pps: clients: parport: Switch to use module_parport_driver()
PATCH v2 1/1 pps: clients: parport: Switch to use module_parport_driver()
Switch to use module_parport_driver() to reduce boilerplate code.
Signed-off-by Andy Shevchenko <[email protected]>
Acked-by Rodolfo Giometti <[email protected]>
---
v2: added tag (Rodolfo)
drivers/pps/clients/pps_parport.c | 42 ++++++------------------------- 1 file changed, 8 insertions(+), 34 deletions(-)
drivers/pps/clients/pps_parport.c +8 -34
@@ -22,8 +22,6 @@#include <linux/parport.h> #include <linux/pps_kernel.h> -#define DRVDESC "parallel port PPS client" -/* module parameters */ #define CLEAR_WAIT_MAX 100
@@ -138,6 +136,12 @@ static void parport_attach(struct parport *port) .dev = NULL }; +if (clear_wait >CLEAR_WAIT_MAX ) { +pr_err ("clear_wait value should be not greater then %d\n" , +CLEAR_WAIT_MAX ); +return ; + } + device =kzalloc (sizeof (struct pps_client_pp ),GFP_KERNEL );if (!device) {pr_err ("memory allocation failed, not attaching\n" );
@@ -214,38 +218,8 @@ static struct parport_driver pps_parport_driver = { .detach = parport_detach, .devmodel = true, }; - -/* module staff */ - -static int __init pps_parport_init (void ) -{ -int ret; - -pr_info (DRVDESC "\n" ); - -if (clear_wait >CLEAR_WAIT_MAX ) { -pr_err ("clear_wait value should be not greater" -" then %d\n" ,CLEAR_WAIT_MAX ); -return -EINVAL ; - } - - ret =parport_register_driver (&pps_parport_driver); -if (ret) { -pr_err ("unable to register with parport\n" ); -return ret; - } - -return 0 ; -} - -static void __exit pps_parport_exit(void) -{ -parport_unregister_driver (&pps_parport_driver); -} - -module_init (pps_parport_init); -module_exit (pps_parport_exit); +module_parport_driver (pps_parport_driver);MODULE_AUTHOR ("Alexander Gordeev <[email protected]>" ); -MODULE_DESCRIPTION (DRVDESC ); +MODULE_DESCRIPTION ("parallel port PPS client" );MODULE_LICENSE ("GPL" );
Signature · 1 line
2.30.2
Quoted 6 lines · Andy Shevchenko
Switch to use
module_parport_driver()to reduce boilerplate code.Signed-off-by Andy Shevchenko <[email protected]>Acked-by Rodolfo Giometti <[email protected]>---
v2: added tag (Rodolfo)
Seems missed patch.
Signature · 2 lines
With Best Regards, Andy Shevchenko
Quoted 9 lines · Andy Shevchenko
Quoted 6 lines · Andy Shevchenko
Switch to use
module_parport_driver()to reduce boilerplate code.Signed-off-by Andy Shevchenko <[email protected]>Acked-by Rodolfo Giometti <[email protected]>---
v2: added tag (Rodolfo)Seems missed patch.
Greg, can you pick this up, or should I resend?
Signature · 2 lines
With Best Regards, Andy Shevchenko
Quoted 4 lines · Andy Shevchenko
Quoted 3 lines · Andy Shevchenko
Quoted 2 lines · Andy Shevchenko
Switch to use
module_parport_driver()to reduce boilerplate code.
Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
Signed-off-by Andy Shevchenko <[email protected]>Acked-by Rodolfo Giometti <[email protected]>---
v2: added tag (Rodolfo)Seems missed patch.
Greg, can you pick this up, or should I resend?
I took it now, thanks.
greg k-h