Skip to contentSkip to conversation

irqchip/irq-mst: Use ARCH_MSTARV7 as default value for MST_IRQ

PATCH In review Mark-PK Tsai 2 participants 4 messages Jun 7, 2021 – Jun 8, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 irqchip/irq-mst: Use ARCH_MSTARV7 as default value for MST_IRQ

Only TV SoCs of Mediatek products have this controller which inherit from MStar TV SoCs.
Don't enable it by default if ARCH_MEDIATEK is selected. Instead, use ARCH_MSTARV7 as default value.

---
 drivers/irqchip/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/irqchip/Kconfig +1 -1
index 62543a4eccc0..30f578e18a11 100644
@@ -576,7 +576,7 @@ config LOONGSON_PCH_MSI
 config MST_IRQ
 	bool "MStar Interrupt Controller"
 	depends on ARCH_MEDIATEK || ARCH_MSTARV7 || COMPILE_TEST
-	default ARCH_MEDIATEK
+	default ARCH_MSTARV7
 	select IRQ_DOMAIN
 	select IRQ_DOMAIN_HIERARCHY
 	help
Signature · 5 lines
2.18.0
_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek
#1 lore raw

PATCH 1/1 irqchip/irq-mst: Use ARCH_MSTARV7 as default value for MST_IRQ

+ Daniel

Quoted 25 lines

Only TV SoCs of Mediatek products have this controller which inherit from MStar TV SoCs.
Don't enable it by default if ARCH_MEDIATEK is selected. Instead, use ARCH_MSTARV7 as default value.

---
 drivers/irqchip/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/irqchip/Kconfig +1 -1
index 62543a4eccc0..30f578e18a11 100644
@@ -576,7 +576,7 @@ config LOONGSON_PCH_MSI
 config MST_IRQ
 	bool "MStar Interrupt Controller"
 	depends on ARCH_MEDIATEK || ARCH_MSTARV7 || COMPILE_TEST
-	default ARCH_MEDIATEK
+	default ARCH_MSTARV7
 	select IRQ_DOMAIN
 	select IRQ_DOMAIN_HIERARCHY
 	help
Signature · 1 line
2.18.0
maintainer
#2 lore raw
In reply to Mark-PK Tsai
Quoted 15 lines · Mark-PK Tsai

Only TV SoCs of Mediatek products have this controller which inherit from MStar TV SoCs.
Don't enable it by default if ARCH_MEDIATEK is selected. Instead, use ARCH_MSTARV7 as default value.

---
 drivers/irqchip/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/irqchip/Kconfig +0 -0
index 62543a4eccc0..30f578e18a11 100644

drivers/irqchip/Kconfig config LOONGSON_PCH_MSI · line 578

Quoted 3 lines
drivers/irqchip/Kconfig +0 -0
@@ -576,7 +576,7 @@ config LOONGSON_PCH_MSI
 config MST_IRQ
 	bool "MStar Interrupt Controller"
 	depends on ARCH_MEDIATEK || ARCH_MSTARV7 || COMPILE_TEST

We should also delete ARCH_MEDIATEK dependency.

Regards,
Matthias

drivers/irqchip/Kconfig config LOONGSON_PCH_MSI · line 582

Quoted 6 lines
drivers/irqchip/Kconfig +1 -1
-	default ARCH_MEDIATEK
+	default ARCH_MSTARV7
 	select IRQ_DOMAIN
 	select IRQ_DOMAIN_HIERARCHY
 	help

_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek

#3 lore raw
Quoted 13 lines · Mark-PK Tsai
Quoted 10 lines

Only TV SoCs of Mediatek products have this controller which inherit from MStar TV SoCs.
Don't enable it by default if ARCH_MEDIATEK is selected. Instead, use ARCH_MSTARV7 as default value.

---
 drivers/irqchip/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 10 lines

drivers/irqchip/Kconfig config LOONGSON_PCH_MSI · line 578

Quoted 8 lines
drivers/irqchip/Kconfig +0 -0
index 62543a4eccc0..30f578e18a11 100644
@@ -576,7 +576,7 @@ config LOONGSON_PCH_MSI
 config MST_IRQ
 	bool "MStar Interrupt Controller"
 	depends on ARCH_MEDIATEK || ARCH_MSTARV7 || COMPILE_TEST

We should also delete ARCH_MEDIATEK dependency.

Actually what I want to do is decouple the MST_IRQ from ARCH_MEDIATEK, because there are only TV SoCs have this. But if I remove the ARCH_MEDIATEK dependency, then all the Mediatek TV SoCs kernel have to select ARCH_MSTARV7 too. It's kind of weird.

Though it may ask some Mediatek users about MST_IRQ, I just change the default config to prevent that all the Mediatek kernel include this driver by default.

What would you suggest for this?

Quoted 11 lines

Regards,
Matthias

Quoted 6 lines
drivers/irqchip/Kconfig +1 -1
-	default ARCH_MEDIATEK
+	default ARCH_MSTARV7
 	select IRQ_DOMAIN
 	select IRQ_DOMAIN_HIERARCHY
 	help