RDMA/irdma: Use list_move instead of list_del/list_add
Subsystems (3)
PATCH 1/1 RDMA/irdma: Use list_move instead of list_del/list_add
Using list_move() instead of list_del() + list_add().
Reported-by Hulk Robot <[email protected]>
Signed-off-by Baokun Li <[email protected]>
--- drivers/infiniband/hw/irdma/puda.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/infiniband/hw/irdma/puda.c +1 -2
@@ -1420,8 +1420,7 @@ irdma_ieq_handle_partial(struct irdma_puda_rsrc *ieq, struct irdma_pfpdu *pfpdu, error:while (!list_empty (&pbufl)) { buf = (struct irdma_puda_buf *)(pbufl.prev); -list_del (&buf->list); -list_add (&buf->list, rxlist); +list_move (&buf->list, rxlist); }if (txbuf)irdma_puda_ret_bufpool (ieq, txbuf);
Quoted 13 lines · Baokun Li
Using
list_move()instead oflist_del()+list_add().Reported-by Hulk Robot <[email protected]>Signed-off-by Baokun Li <[email protected]>--- drivers/infiniband/hw/irdma/puda.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)drivers/infiniband/hw/irdma/puda.c +0
-0
drivers/infiniband/hw/irdma/puda.c irdma_ieq_handle_partial(struct irdma_puda_rsrc *ieq, struct irdma_pfpdu *pfpdu, · line 1422
Quoted 3 lines
drivers/infiniband/hw/irdma/puda.c +0
-0@@ -1420,8 +1420,7 @@ irdma_ieq_handle_partial(struct irdma_puda_rsrc *ieq, struct irdma_pfpdu *pfpdu, error:while (!list_empty (&pbufl)) { buf = (struct irdma_puda_buf *)(pbufl.prev);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Not related to your patch but this would be nicer as:
buf = list_last_entry(&pbufl, struct irdma_puda_buf, list);
drivers/infiniband/hw/irdma/puda.c irdma_ieq_handle_partial(struct irdma_puda_rsrc *ieq, struct irdma_pfpdu *pfpdu, · line 1423
Quoted 3 lines
drivers/infiniband/hw/irdma/puda.c +1
-2-list_del (&buf->list); -list_add (&buf->list, rxlist); +list_move (&buf->list, rxlist);
regards,
dan carpenter
Quoted 7 lines
Subject: [PATCH -next] RDMA/irdma: Use
list_moveinstead of list_del/list_addUsing
list_move()instead oflist_del()+list_add().Reported-by Hulk Robot <[email protected]>Signed-off-by Baokun Li <[email protected]>---
Acked-by Shiraz Saleem <[email protected]>
Quoted 8 lines · Baokun Li
Using
list_move()instead oflist_del()+list_add().Reported-by Hulk Robot <[email protected]>Signed-off-by Baokun Li <[email protected]>Acked-by Shiraz Saleem <[email protected]>--- drivers/infiniband/hw/irdma/puda.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
Applied to for-next, thanks
Jason