Skip to contentSkip to conversation

RDMA/irdma: Use list_move instead of list_del/list_add

PATCH Applied Baokun Li 4 participants 4 messages Jun 8, 2021

Subsystems (3)
lore
Share & tools
lore

Baokun Li

author
#0 lore raw

PATCH 1/1 RDMA/irdma: Use list_move instead of list_del/list_add

Using list_move() instead of list_del() + list_add().

---
 drivers/infiniband/hw/irdma/puda.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/infiniband/hw/irdma/puda.c +1 -2
index 18057139817d..c0be6e37d425 100644
@@ -1420,8 +1420,7 @@ irdma_ieq_handle_partial(struct irdma_puda_rsrc *ieq, struct irdma_pfpdu *pfpdu,
 error:
 	while (!list_empty(&pbufl)) {
 		buf = (struct irdma_puda_buf *)(pbufl.prev);
-		list_del(&buf->list);
-		list_add(&buf->list, rxlist);
+		list_move(&buf->list, rxlist);
 	}
 	if (txbuf)
 		irdma_puda_ret_bufpool(ieq, txbuf);
#1 lore raw
Quoted 13 lines · Baokun Li

Using list_move() instead of list_del() + list_add().

---
 drivers/infiniband/hw/irdma/puda.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/infiniband/hw/irdma/puda.c +0 -0
index 18057139817d..c0be6e37d425 100644

drivers/infiniband/hw/irdma/puda.c irdma_ieq_handle_partial(struct irdma_puda_rsrc *ieq, struct irdma_pfpdu *pfpdu, · line 1422

Quoted 3 lines
drivers/infiniband/hw/irdma/puda.c +0 -0
@@ -1420,8 +1420,7 @@ irdma_ieq_handle_partial(struct irdma_puda_rsrc *ieq, struct irdma_pfpdu *pfpdu,
 error:
 	while (!list_empty(&pbufl)) {
 		buf = (struct irdma_puda_buf *)(pbufl.prev);
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Not related to your patch but this would be nicer as:

		buf = list_last_entry(&pbufl, struct irdma_puda_buf, list);

drivers/infiniband/hw/irdma/puda.c irdma_ieq_handle_partial(struct irdma_puda_rsrc *ieq, struct irdma_pfpdu *pfpdu, · line 1423

Quoted 3 lines
drivers/infiniband/hw/irdma/puda.c +1 -2
-		list_del(&buf->list);
-		list_add(&buf->list, rxlist);
+		list_move(&buf->list, rxlist);

regards,
dan carpenter