iommu/amd: Fix section mismatch warning for detect_ivrs()
Subsystems (2)
Joerg Roedel
maintainerPATCH 1/1 iommu/amd: Fix section mismatch warning for detect_ivrs()
From: Joerg Roedel <[email protected]>
A recent commit introduced this section mismatch warning:
WARNING: modpost: vmlinux.o(.text.unlikely+0x22a1f): Section mismatch in reference from the function detect_ivrs() to the variable .init.data:amd_iommu_force_enable
The reason is that detect_ivrs() is not marked __init while it should be, because it is only called from another __init function. Mark detect_ivrs() __init to get rid of the warning.
--- drivers/iommu/amd/init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iommu/amd/init.c +1 -1
@@ -2817,7 +2817,7 @@ static int amd_iommu_enable_interrupts(void)return ret; } -static bool detect_ivrs (void ) +static bool __init detect_ivrs (void ) {struct acpi_table_header *ivrs_base;acpi_status status;
Signature · 1 line
2.31.1
[AMD Public Use]
Quoted 18 lines
-----Original Message-----
From: Joerg Roedel <[email protected]>
Sent: Tuesday, June 8, 2021 8:29 AM
To: Joerg Roedel <[email protected]>; Will Deacon <[email protected]>
Cc: Deucher, Alexander <[email protected]>; [email protected]; [email protected]; Joerg Roedel <[email protected]>
Subject: [PATCH] iommu/amd: Fix section mismatch warning fordetect_ivrs()From: Joerg Roedel <[email protected]>
A recent commit introduced this section mismatch warning:
WARNING: modpost: vmlinux.o(.text.unlikely+0x22a1f): Sectionmismatch in reference from the function
detect_ivrs()to the variable .init.data:amd_iommu_force_enable
Quoted 7 lines
The reason is that
detect_ivrs()is not marked__initwhile it should be, because it is only called from another__initfunction. Markdetect_ivrs()__initto get rid of the warning.Fixes b1e650db2cc4 ("iommu/amd: Add amd_iommu=force_enableoption")
Signed-off-by Joerg Roedel <[email protected]>
Quoted 19 lines
--- drivers/iommu/amd/init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/iommu/amd/init.c index renamed from drivers/iommu/amd/init.c +0
-0
4e4fb0f4e412..46280e6e1535100644drivers/iommu/amd/init.c +1
-2@@ -2817,7 +2817,7 @@ static int amd_iommu_enable_interrupts(void)return ret; } -static bool detect_ivrs (void ) +static bool __init detect_ivrs (void ) {struct acpi_table_header *ivrs_base;acpi_status status; --2.31.1