drm/bridge: ti-sn65dsi83: Fix sparse warnings
Subsystems (3)
PATCH 1/1 drm/bridge: ti-sn65dsi83: Fix sparse warnings
Fix the following sparse warnings generated by "make C=1":
drivers/gpu/drm/bridge/ti-sn65dsi83.c:429:13: warning: incorrect type in assignment (different base types)drivers/gpu/drm/bridge/ti-sn65dsi83.c:429:13: expected unsigned short [assigned] [usertype] valdrivers/gpu/drm/bridge/ti-sn65dsi83.c:429:13: got restricted __le16 [usertype]drivers/gpu/drm/bridge/ti-sn65dsi83.c:432:13: warning: incorrect type in assignment (different base types)drivers/gpu/drm/bridge/ti-sn65dsi83.c:432:13: expected unsigned short [addressable] [assigned] [usertype] valdrivers/gpu/drm/bridge/ti-sn65dsi83.c:432:13: got restricted __le16 [usertype]drivers/gpu/drm/bridge/ti-sn65dsi83.c:436:13: warning: incorrect type in assignment (different base types)drivers/gpu/drm/bridge/ti-sn65dsi83.c:436:13: expected unsigned short [addressable] [assigned] [usertype] valdrivers/gpu/drm/bridge/ti-sn65dsi83.c:436:13: got restricted __le16 [usertype]drivers/gpu/drm/bridge/ti-sn65dsi83.c:438:13: warning: incorrect type in assignment (different base types)drivers/gpu/drm/bridge/ti-sn65dsi83.c:438:13: expected unsigned short [addressable] [assigned] [usertype] valdrivers/gpu/drm/bridge/ti-sn65dsi83.c:438:13: got restricted __le16 [usertype]drivers/gpu/drm/bridge/ti-sn65dsi83.c:441:13: warning: incorrect type in assignment (different base types)drivers/gpu/drm/bridge/ti-sn65dsi83.c:441:13: expected unsigned short [addressable] [assigned] [usertype] valdrivers/gpu/drm/bridge/ti-sn65dsi83.c:441:13: got restricted __le16 [usertype]
--- drivers/gpu/drm/bridge/ti-sn65dsi83.c | 21 +++++++++++---------- 1 file changed, 11 insertions(+), 10 deletions(-)
drivers/gpu/drm/bridge/ti-sn65dsi83.c +11 -10
@@ -368,6 +368,7 @@ static void sn65dsi83_enable(struct drm_bridge *bridge) {struct sn65dsi83 *ctx =bridge_to_sn65dsi83 (bridge);unsigned int pval; +__le16 le16val;u16 val;int ret;
@@ -426,21 +427,21 @@ static void sn65dsi83_enable(struct drm_bridge *bridge) REG_LVDS_LANE_CHB_LVDS_TERM);regmap_write (ctx->regmap,REG_LVDS_CM ,0x00 ); - val =cpu_to_le16 (ctx->mode.hdisplay); + le16val =cpu_to_le16 (ctx->mode.hdisplay);regmap_bulk_write (ctx->regmap,REG_VID_CHA_ACTIVE_LINE_LENGTH_LOW , - &val,2 ); - val =cpu_to_le16 (ctx->mode.vdisplay); + &le16val,2 ); + le16val =cpu_to_le16 (ctx->mode.vdisplay);regmap_bulk_write (ctx->regmap,REG_VID_CHA_VERTICAL_DISPLAY_SIZE_LOW , - &val,2 ); + &le16val,2 );/* 32 + 1 pixel clock to ensure proper operation */ - val =cpu_to_le16 (32 +1 ); -regmap_bulk_write (ctx->regmap,REG_VID_CHA_SYNC_DELAY_LOW , &val,2 ); - val =cpu_to_le16 (ctx->mode.hsync_end - ctx->mode.hsync_start); + le16val =cpu_to_le16 (32 +1 ); +regmap_bulk_write (ctx->regmap,REG_VID_CHA_SYNC_DELAY_LOW , &le16val,2 ); + le16val =cpu_to_le16 (ctx->mode.hsync_end - ctx->mode.hsync_start);regmap_bulk_write (ctx->regmap,REG_VID_CHA_HSYNC_PULSE_WIDTH_LOW , - &val,2 ); - val =cpu_to_le16 (ctx->mode.vsync_end - ctx->mode.vsync_start); + &le16val,2 ); + le16val =cpu_to_le16 (ctx->mode.vsync_end - ctx->mode.vsync_start);regmap_bulk_write (ctx->regmap,REG_VID_CHA_VSYNC_PULSE_WIDTH_LOW , - &val,2 ); + &le16val,2 );regmap_write (ctx->regmap,REG_VID_CHA_HORIZONTAL_BACK_PORCH , ctx->mode.htotal - ctx->mode.hsync_end); regmap_write(ctx->regmap, REG_VID_CHA_VERTICAL_BACK_PORCH,
Signature · 1 line
2.30.2
Hey Marek,
Thanks for submitting this.
Quoted 72 lines · Marek Vasut
Fix the following sparse warnings generated by "make C=1":
drivers/gpu/drm/bridge/ti-sn65dsi83.c:429:13: warning: incorrect type in assignment (different base types)drivers/gpu/drm/bridge/ti-sn65dsi83.c:429:13: expected unsigned short [assigned] [usertype] valdrivers/gpu/drm/bridge/ti-sn65dsi83.c:429:13: got restricted__le16[usertype]drivers/gpu/drm/bridge/ti-sn65dsi83.c:432:13: warning: incorrect type in assignment (different base types)drivers/gpu/drm/bridge/ti-sn65dsi83.c:432:13: expected unsigned short [addressable] [assigned] [usertype] valdrivers/gpu/drm/bridge/ti-sn65dsi83.c:432:13: got restricted__le16[usertype]drivers/gpu/drm/bridge/ti-sn65dsi83.c:436:13: warning: incorrect type in assignment (different base types)drivers/gpu/drm/bridge/ti-sn65dsi83.c:436:13: expected unsigned short [addressable] [assigned] [usertype] valdrivers/gpu/drm/bridge/ti-sn65dsi83.c:436:13: got restricted__le16[usertype]drivers/gpu/drm/bridge/ti-sn65dsi83.c:438:13: warning: incorrect type in assignment (different base types)drivers/gpu/drm/bridge/ti-sn65dsi83.c:438:13: expected unsigned short [addressable] [assigned] [usertype] valdrivers/gpu/drm/bridge/ti-sn65dsi83.c:438:13: got restricted__le16[usertype]drivers/gpu/drm/bridge/ti-sn65dsi83.c:441:13: warning: incorrect type in assignment (different base types)drivers/gpu/drm/bridge/ti-sn65dsi83.c:441:13: expected unsigned short [addressable] [assigned] [usertype] valdrivers/gpu/drm/bridge/ti-sn65dsi83.c:441:13: got restricted__le16[usertype]Signed-off-by Marek Vasut <[email protected]>Cc Adam Ford <[email protected]>Cc Douglas Anderson <[email protected]>Cc Frieder Schrempf <[email protected]>Cc Jagan Teki <[email protected]>Cc Laurent Pinchart <[email protected]>Cc Linus Walleij <[email protected]>Cc Loic Poulain <[email protected]>Cc Marek Vasut <[email protected]>Cc Philippe Schenker <[email protected]>Cc Robert Foss <[email protected]>Cc Sam Ravnborg <[email protected]>Cc Stephen Boyd <[email protected]>Cc Valentin Raevsky <[email protected]>--- drivers/gpu/drm/bridge/ti-sn65dsi83.c | 21 +++++++++++---------- 1 file changed, 11 insertions(+), 10 deletions(-)drivers/gpu/drm/bridge/ti-sn65dsi83.c +8
-7@@ -368,6 +368,7 @@ static void sn65dsi83_enable(struct drm_bridge *bridge) {struct sn65dsi83 *ctx =bridge_to_sn65dsi83 (bridge);unsigned int pval; +__le16 le16val;u16 val;int ret;@@ -426,21 +427,21 @@ static void sn65dsi83_enable(struct drm_bridge *bridge) REG_LVDS_LANE_CHB_LVDS_TERM);regmap_write (ctx->regmap,REG_LVDS_CM ,0x00 ); - val =cpu_to_le16 (ctx->mode.hdisplay); + le16val =cpu_to_le16 (ctx->mode.hdisplay);regmap_bulk_write (ctx->regmap,REG_VID_CHA_ACTIVE_LINE_LENGTH_LOW , - &val,2 ); - val =cpu_to_le16 (ctx->mode.vdisplay); + &le16val,2 ); + le16val =cpu_to_le16 (ctx->mode.vdisplay);regmap_bulk_write (ctx->regmap,REG_VID_CHA_VERTICAL_DISPLAY_SIZE_LOW , - &val,2 ); + &le16val,2 );/* 32 + 1 pixel clock to ensure proper operation */ - val =cpu_to_le16 (32 +1 ); -regmap_bulk_write (ctx->regmap,REG_VID_CHA_SYNC_DELAY_LOW , &val,2 ); - val =cpu_to_le16 (ctx->mode.hsync_end - ctx->mode.hsync_start); + le16val =cpu_to_le16 (32 +1 ); +regmap_bulk_write (ctx->regmap,REG_VID_CHA_SYNC_DELAY_LOW , &le16val,2 ); + le16val =cpu_to_le16 (ctx->mode.hsync_end - ctx->mode.hsync_start); regmap_bulk_write(ctx->regmap, REG_VID_CHA_HSYNC_PULSE_WIDTH_LOW,
drivers/gpu/drm/bridge/ti-sn65dsi83.c static void sn65dsi83_enable(struct drm_bridge *bridge) · line 447
Quoted 10 lines
drivers/gpu/drm/bridge/ti-sn65dsi83.c +3
-3- &val, 2); - val =cpu_to_le16 (ctx->mode.vsync_end - ctx->mode.vsync_start); + &le16val, 2); + le16val =cpu_to_le16 (ctx->mode.vsync_end - ctx->mode.vsync_start);regmap_bulk_write (ctx->regmap,REG_VID_CHA_VSYNC_PULSE_WIDTH_LOW , - &val,2 ); + &le16val,2 );regmap_write (ctx->regmap,REG_VID_CHA_HORIZONTAL_BACK_PORCH , ctx->mode.htotal - ctx->mode.hsync_end); regmap_write(ctx->regmap, REG_VID_CHA_VERTICAL_BACK_PORCH,
Reviewed and pulled into drm-misc-next.
https://cgit.freedesktop.org/drm/drm-misc/commit/?id=241a9e233e7cf1001d09426c9fc520768f8961bf