nvmet/fc: do not check for invalid target port in nvmet_fc_handle_fcp_rqst()
Subsystems (3)
PATCH 1/1 nvmet/fc: do not check for invalid target port in nvmet_fc_handle_fcp_rqst()
When parsing a request in nvmet_fc_handle_fcp_rqst() we should not check for invalid target ports; if we do the command is aborted from the fcp layer, causing the host to assume a transport error. Rather we should still forward this request to the nvmet layer, which will then correctly fail the command with an appropriate error status.
--- drivers/nvme/target/fc.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-)
drivers/nvme/target/fc.c +2 -8
@@ -2510,13 +2510,6 @@ nvmet_fc_handle_fcp_rqst(struct nvmet_fc_tgtport *tgtport,u32 xfrlen =be32_to_cpu (cmdiu->data_len);int ret; -/* -* if there is no nvmet mapping to the targetport there -* shouldn't be requests. just terminate them. -*/ -if (!tgtport->pe) - goto transport_error; -/* * Fused commands are currently not supported in the linux * implementation.
@@ -2544,7 +2537,8 @@ nvmet_fc_handle_fcp_rqst(struct nvmet_fc_tgtport *tgtport, fod->req.cmd = &fod->cmdiubuf.sqe; fod->req.cqe = &fod->rspiubuf.cqe; - fod->req.port = tgtport->pe->port; +if (tgtport->pe) + fod->req.port = tgtport->pe->port;/* clear any response payload */ memset (&fod->rspiubuf,0 ,sizeof (fod->rspiubuf));
Signature · 7 lines
2.26.2 _______________________________________________ Linux-nvme mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-nvme
Quoted 7 lines · Hannes Reinecke
When parsing a request in
nvmet_fc_handle_fcp_rqst()we should not check for invalid target ports; if we do the command is aborted from the fcp layer, causing the host to assume a transport error. Rather we should still forward this request to the nvmet layer, which will then correctly fail the command with an appropriate error status.Signed-off-by Hannes Reinecke <[email protected]>
Well, correct behavior either way as I to would think it is a transport error if the port hasn't been tied to any subsystem yet. But, I guess it's fine to let nvmet_find_get_subsys() see the null port pointer and fail Connect with INVALID_PARAM|DNR as well.
so - ok
-- james
_______________________________________________
Linux-nvme mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-nvme
Thanks,
applied to nvme-5.14.
_______________________________________________
Linux-nvme mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-nvme