fpga: change FPGA indirect article to an
Subsystems (8)
[email protected]
reviewercover fpga: change FPGA indirect article to an
From: Tom Rix <[email protected]>
A treewide followup of
https://lore.kernel.org/linux-fpga/[email protected]/
Change the use of 'a fpga' to 'an fpga'
Ref usage in wiki
https://en.wikipedia.org/wiki/Field-programmable_gate_array
and Intel's 'FPGAs For Dummies'
https://plan.seek.intel.com/PSG_WW_NC_LPCD_FR_2018_FPGAforDummiesbook
Change was mechanical
!/bin/sh
for f in find . -type f; do
sed -i.bak 's/ a fpga/ an fpga/g' $f
sed -i.bak 's/ A fpga/ An fpga/g' $f
sed -i.bak 's/ a FPGA/ an FPGA/g' $f
sed -i.bak 's/ A FPGA/ An FPGA/g' $f
done
Tom Rix (11):
dt-bindings: fpga: fpga-region: change FPGA indirect article to an
Documentation: fpga: dfl: change FPGA indirect article to an
Documentation: ocxl.rst: change FPGA indirect article to an
crypto: marvell: cesa: change FPGA indirect article to an
fpga: change FPGA indirect article to an
fpga: bridge: change FPGA indirect article to an
fpga-mgr: change FPGA indirect article to an
fpga: region: change FPGA indirect article to an
fpga: of-fpga-region: change FPGA indirect article to an
fpga: stratix10-soc: change FPGA indirect article to an
staging: fpgaboot: change FPGA indirect article to an
.../devicetree/bindings/fpga/fpga-region.txt | 22 +++++++++---------- Documentation/fpga/dfl.rst | 4 ++-- .../userspace-api/accelerators/ocxl.rst | 2 +- drivers/crypto/marvell/cesa/cesa.h | 2 +- drivers/fpga/Kconfig | 4 ++-- drivers/fpga/fpga-bridge.c | 22 +++++++++---------- drivers/fpga/fpga-mgr.c | 22 +++++++++---------- drivers/fpga/fpga-region.c | 14 ++++++------ drivers/fpga/of-fpga-region.c | 8 +++---- drivers/fpga/stratix10-soc.c | 2 +- drivers/staging/gs_fpgaboot/README | 2 +- include/linux/fpga/fpga-bridge.h | 2 +- include/linux/fpga/fpga-mgr.h | 2 +- 13 files changed, 54 insertions(+), 54 deletions(-)
Signature · 1 line
2.26.3
[email protected]
reviewercover fpga: change FPGA indirect article to an
From: Tom Rix <[email protected]>
A treewide followup of
https://lore.kernel.org/linux-fpga/[email protected]/
Change the use of 'a fpga' to 'an fpga'
Ref usage in wiki
https://en.wikipedia.org/wiki/Field-programmable_gate_array
and Intel's 'FPGAs For Dummies'
https://plan.seek.intel.com/PSG_WW_NC_LPCD_FR_2018_FPGAforDummiesbook
Change was mechanical
!/bin/sh
for f in find . -type f; do
sed -i.bak 's/ a fpga/ an fpga/g' $f
sed -i.bak 's/ A fpga/ An fpga/g' $f
sed -i.bak 's/ a FPGA/ an FPGA/g' $f
sed -i.bak 's/ A FPGA/ An FPGA/g' $f
done
Tom Rix (11):
dt-bindings: fpga: fpga-region: change FPGA indirect article to an
Documentation: fpga: dfl: change FPGA indirect article to an
Documentation: ocxl.rst: change FPGA indirect article to an
crypto: marvell: cesa: change FPGA indirect article to an
fpga: change FPGA indirect article to an
fpga: bridge: change FPGA indirect article to an
fpga-mgr: change FPGA indirect article to an
fpga: region: change FPGA indirect article to an
fpga: of-fpga-region: change FPGA indirect article to an
fpga: stratix10-soc: change FPGA indirect article to an
staging: fpgaboot: change FPGA indirect article to an
.../devicetree/bindings/fpga/fpga-region.txt | 22 +++++++++---------- Documentation/fpga/dfl.rst | 4 ++-- .../userspace-api/accelerators/ocxl.rst | 2 +- drivers/crypto/marvell/cesa/cesa.h | 2 +- drivers/fpga/Kconfig | 4 ++-- drivers/fpga/fpga-bridge.c | 22 +++++++++---------- drivers/fpga/fpga-mgr.c | 22 +++++++++---------- drivers/fpga/fpga-region.c | 14 ++++++------ drivers/fpga/of-fpga-region.c | 8 +++---- drivers/fpga/stratix10-soc.c | 2 +- drivers/staging/gs_fpgaboot/README | 2 +- include/linux/fpga/fpga-bridge.h | 2 +- include/linux/fpga/fpga-mgr.h | 2 +- 13 files changed, 54 insertions(+), 54 deletions(-)
Signature · 1 line
2.26.3
[email protected]
reviewerPATCH 1/11 dt-bindings: fpga: fpga-region: change FPGA indirect article to an
In reply to [email protected]From: Tom Rix <[email protected]>
Change use of 'a fpga' to 'an fpga'
--- .../devicetree/bindings/fpga/fpga-region.txt | 22 +++++++++---------- 1 file changed, 11 insertions(+), 11 deletions(-)
Documentation/devicetree/bindings/fpga/fpga-region.txt +11 -11
@@ -38,7 +38,7 @@ Partial Reconfiguration (PR) Partial Reconfiguration Region (PRR) * Also called a "reconfigurable partition" - * A PRR is a specific section of a FPGA reserved for reconfiguration. + * A PRR is a specific section of an FPGA reserved for reconfiguration. * A base (or static) FPGA image may create a set of PRR's that later may be independently reprogrammed many times. * The size and specific location of each PRR is fixed.
@@ -105,7 +105,7 @@ reprogrammed independently while the rest of the system continues to function. Sequence ======== -When a DT overlay that targets a FPGA Region is applied, the FPGA Region will +When a DT overlay that targets an FPGA Region is applied, the FPGA Region will do the following: 1. Disable appropriate FPGA bridges.
@@ -134,8 +134,8 @@ The intended use is that a Device Tree overlay (DTO) can be used to reprogram an FPGA while an operating system is running. An FPGA Region that exists in the live Device Tree reflects the current state. -If the live tree shows a "firmware-name" property or child nodes under a FPGA -Region, the FPGA already has been programmed. A DTO that targets a FPGA Region +If the live tree shows a "firmware-name" property or child nodes under an FPGA +Region, the FPGA already has been programmed. A DTO that targets an FPGA Region and adds the "firmware-name" property is taken as a request to reprogram the FPGA. After reprogramming is successful, the overlay is accepted into the live tree.
@@ -152,9 +152,9 @@ These FPGA regions are children of FPGA bridges which are then children of the base FPGA region. The "Full Reconfiguration to add PRR's" example below shows this. -If an FPGA Region does not specify a FPGA Manager, it will inherit the FPGA +If an FPGA Region does not specify an FPGA Manager, it will inherit the FPGA Manager specified by its ancestor FPGA Region. This supports both the case -where the same FPGA Manager is used for all of a FPGA as well the case where +where the same FPGA Manager is used for all of an FPGA as well the case where a different FPGA Manager is used for each region. FPGA Regions do not inherit their ancestor FPGA regions' bridges. This prevents
@@ -166,7 +166,7 @@ within the static image of the FPGA. Required properties: - compatible : should contain "fpga-region" - fpga-mgr : should contain a phandle to an FPGA Manager. Child FPGA Regions - inherit this property from their ancestor regions. A fpga-mgr property + inherit this property from their ancestor regions. An fpga-mgr property in a region will override any inherited FPGA manager. - #address-cells, #size-cells, ranges : must be present to handle address space mapping for child nodes.
@@ -175,12 +175,12 @@ Optional properties: - firmware-name : should contain the name of an FPGA image file located on the firmware search path. If this property shows up in a live device tree it indicates that the FPGA has already been programmed with this image. - If this property is in an overlay targeting a FPGA region, it is a + If this property is in an overlay targeting an FPGA region, it is a request to program the FPGA with that image. - fpga-bridges : should contain a list of phandles to FPGA Bridges that must be controlled during FPGA programming along with the parent FPGA bridge. This property is optional if the FPGA Manager handles the bridges. - If the fpga-region is the child of a fpga-bridge, the list should not + If the fpga-region is the child of an fpga-bridge, the list should not contain the parent bridge. - partial-fpga-config : boolean, set if partial reconfiguration is to be done, otherwise full reconfiguration is done.
@@ -279,7 +279,7 @@ Supported Use Models In all cases the live DT must have the FPGA Manager, FPGA Bridges (if any), and a FPGA Region. The target of the Device Tree Overlay is the FPGA Region. Some -uses are specific to a FPGA device. +uses are specific to an FPGA device. * No FPGA Bridges In this case, the FPGA Manager which programs the FPGA also handles the
@@ -300,7 +300,7 @@ uses are specific to a FPGA device. bridges need to exist in the FPGA that can gate the buses going to each FPGA region while the buses are enabled for other sections. Before any partial reconfiguration can be done, a base FPGA image must be loaded which includes - PRR's with FPGA bridges. The device tree should have a FPGA region for each + PRR's with FPGA bridges. The device tree should have an FPGA region for each PRR. Device Tree Examples
Signature · 1 line
2.26.3
[email protected]
reviewerPATCH 2/11 Documentation: fpga: dfl: change FPGA indirect article to an
In reply to [email protected]From: Tom Rix <[email protected]>
Change use of 'a fpga' to 'an fpga'
--- Documentation/fpga/dfl.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Documentation/fpga/dfl.rst +2 -2
@@ -57,7 +57,7 @@ FPGA Interface Unit (FIU) represents a standalone functional unit for the interface to FPGA, e.g. the FPGA Management Engine (FME) and Port (more descriptions on FME and Port in later sections). -Accelerated Function Unit (AFU) represents a FPGA programmable region and +Accelerated Function Unit (AFU) represents an FPGA programmable region and always connects to a FIU (e.g. a Port) as its child as illustrated above. Private Features represent sub features of the FIU and AFU. They could be
@@ -311,7 +311,7 @@ The driver organization in virtualization case is illustrated below: | PCI PF Device | | | PCI VF Device | +---------------+ | +---------------+ -FPGA PCIe device driver is always loaded first once a FPGA PCIe PF or VF device +FPGA PCIe device driver is always loaded first once an FPGA PCIe PF or VF device is detected. It: * Finishes enumeration on both FPGA PCIe PF and VF device using common
Signature · 1 line
2.26.3
[email protected]
reviewerPATCH 3/11 Documentation: ocxl.rst: change FPGA indirect article to an
In reply to [email protected]From: Tom Rix <[email protected]>
Change use of 'a fpga' to 'an fpga'
--- Documentation/userspace-api/accelerators/ocxl.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/userspace-api/accelerators/ocxl.rst +1 -1
@@ -6,7 +6,7 @@ OpenCAPI is an interface between processors and accelerators. It aims at being low-latency and high-bandwidth. The specification is developed by the `OpenCAPI Consortium <http://opencapi.org/>`_. -It allows an accelerator (which could be a FPGA, ASICs, ...) to access +It allows an accelerator (which could be an FPGA, ASICs, ...) to access the host memory coherently, using virtual addresses. An OpenCAPI device can also host its own memory, that can be accessed from the host.
Signature · 1 line
2.26.3
Re: [PATCH 03/11] Documentation: ocxl.rst: change FPGA indirect article to an
Quoted 5 lines · On 9/6/21 7:23 am, [email protected] wrote:
From: Tom Rix <[email protected]>
Change use of 'a fpga' to 'an fpga'
Signed-off-by Tom Rix <[email protected]>
Signature · 2 lines
Andrew Donnellan OzLabs, ADL Canberra [email protected] IBM Australia Limited
[email protected]
reviewerPATCH 4/11 crypto: marvell: cesa: change FPGA indirect article to an
In reply to [email protected]From: Tom Rix <[email protected]>
Change use of 'a fpga' to 'an fpga'
--- drivers/crypto/marvell/cesa/cesa.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/crypto/marvell/cesa/cesa.h +1 -1
@@ -66,7 +66,7 @@#define CESA_SA_ST_ACT_1 BIT(1)/* -* CESA_SA_FPGA_INT_STATUS looks like a FPGA leftover and is documented only +* CESA_SA_FPGA_INT_STATUS looks like an FPGA leftover and is documented only * in Errata 4.12. It looks like that it was part of an IRQ-controller in FPGA * and someone forgot to remove it while switching to the core and moving to * CESA_SA_INT_STATUS.
Signature · 1 line
2.26.3
Herbert Xu
maintainerRe: [PATCH 04/11] crypto: marvell: cesa: change FPGA indirect article to an
Quoted 8 lines · On Tue, Jun 08, 2021 at 02:23:43PM -0700, [email protected] wrote:
From: Tom Rix <[email protected]>
Change use of 'a fpga' to 'an fpga'
Signed-off-by Tom Rix <[email protected]>--- drivers/crypto/marvell/cesa/cesa.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Patch applied. Thanks.
Signature · 3 lines
Email: Herbert Xu <[email protected]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
[email protected]
reviewerPATCH 5/11 fpga: change FPGA indirect article to an
In reply to [email protected]From: Tom Rix <[email protected]>
Change use of 'a fpga' to 'an fpga'
--- drivers/fpga/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/fpga/Kconfig +2 -2
@@ -7,7 +7,7 @@ menuconfig FPGA tristate "FPGA Configuration Framework" help Say Y here if you want support for configuring FPGAs from the - kernel. The FPGA framework adds a FPGA manager class and FPGA + kernel. The FPGA framework adds an FPGA manager class and FPGA manager drivers. if FPGA
@@ -134,7 +134,7 @@ config FPGA_REGION tristate "FPGA Region" depends on FPGA_BRIDGE help - FPGA Region common code. A FPGA Region controls a FPGA Manager + FPGA Region common code. An FPGA Region controls an FPGA Manager and the FPGA Bridges associated with either a reconfigurable region of an FPGA or a whole FPGA.
Signature · 1 line
2.26.3
[email protected]
reviewerPATCH 6/11 fpga: bridge: change FPGA indirect article to an
In reply to [email protected]From: Tom Rix <[email protected]>
Change use of 'a fpga' to 'an fpga'
--- drivers/fpga/fpga-bridge.c | 22 +++++++++++----------- include/linux/fpga/fpga-bridge.h | 2 +- 2 files changed, 12 insertions(+), 12 deletions(-)
drivers/fpga/fpga-bridge.c +11 -11
@@ -85,14 +85,14 @@ static struct fpga_bridge *__fpga_bridge_get(struct device *dev, }/** -* of_fpga_bridge_get - get an exclusive reference to a fpga bridge +* of_fpga_bridge_get - get an exclusive reference to an fpga bridge * -* @np: node pointer of a FPGA bridge +* @np: node pointer of an FPGA bridge * @info: fpga image specific information * * Return fpga_bridge struct if successful. * Return -EBUSY if someone already has a reference to the bridge. -* Return -ENODEV if @np is not a FPGA Bridge. +* Return -ENODEV if @np is not an FPGA Bridge. */ struct fpga_bridge *of_fpga_bridge_get (struct device_node *np,struct fpga_image_info *info)
@@ -113,11 +113,11 @@ static int fpga_bridge_dev_match(struct device *dev, const void *data) }/** -* fpga_bridge_get - get an exclusive reference to a fpga bridge +* fpga_bridge_get - get an exclusive reference to an fpga bridge * @dev: parent device that fpga bridge was registered with * @info: fpga manager info * -* Given a device, get an exclusive reference to a fpga bridge. +* Given a device, get an exclusive reference to an fpga bridge. * * Return: fpga bridge struct or IS_ERR() condition containing error code. */
@@ -224,7 +224,7 @@ EXPORT_SYMBOL_GPL(fpga_bridges_put);/** * of_fpga_bridge_get_to_list - get a bridge, add it to a list * -* @np: node pointer of a FPGA bridge +* @np: node pointer of an FPGA bridge * @info: fpga image specific information * @bridge_list: list of FPGA bridges *
@@ -373,7 +373,7 @@ struct fpga_bridge *fpga_bridge_create(struct device *dev, const char *name,EXPORT_SYMBOL_GPL (fpga_bridge_create);/** -* fpga_bridge_free - free a fpga bridge created by fpga_bridge_create() +* fpga_bridge_free - free an fpga bridge created by fpga_bridge_create() * @bridge: FPGA bridge struct */ void fpga_bridge_free (struct fpga_bridge *bridge)
@@ -397,7 +397,7 @@ static void devm_fpga_bridge_release(struct device *dev, void *res)* @br_ops: pointer to structure of fpga bridge ops * @priv: FPGA bridge private data * -* This function is intended for use in a FPGA bridge driver's probe function. +* This function is intended for use in an FPGA bridge driver's probe function. * After the bridge driver creates the struct with devm_fpga_bridge_create(), it * should register the bridge with fpga_bridge_register(). The bridge driver's * remove function should call fpga_bridge_unregister(). The bridge struct
@@ -430,7 +430,7 @@ struct fpga_bridgeEXPORT_SYMBOL_GPL (devm_fpga_bridge_create);/** -* fpga_bridge_register - register a FPGA bridge +* fpga_bridge_register - register an FPGA bridge * * @bridge: FPGA bridge struct *
@@ -454,11 +454,11 @@ int fpga_bridge_register(struct fpga_bridge *bridge)EXPORT_SYMBOL_GPL (fpga_bridge_register);/** -* fpga_bridge_unregister - unregister a FPGA bridge +* fpga_bridge_unregister - unregister an FPGA bridge * * @bridge: FPGA bridge struct * -* This function is intended for use in a FPGA bridge driver's remove function. +* This function is intended for use in an FPGA bridge driver's remove function. */ void fpga_bridge_unregister (struct fpga_bridge *bridge) {
include/linux/fpga/fpga-bridge.h +1 -1
@@ -11,7 +11,7 @@ struct fpga_bridge;/** * struct fpga_bridge_ops - ops for low level FPGA bridge drivers * @enable_show: returns the FPGA bridge's status -* @enable_set: set a FPGA bridge as enabled or disabled +* @enable_set: set an FPGA bridge as enabled or disabled * @fpga_bridge_remove: set FPGA into a specific state during driver remove * @groups: optional attribute groups. */
Signature · 1 line
2.26.3
[email protected]
reviewerPATCH 7/11 fpga-mgr: change FPGA indirect article to an
In reply to [email protected]From: Tom Rix <[email protected]>
Change use of 'a fpga' to 'an fpga'
--- drivers/fpga/fpga-mgr.c | 22 +++++++++++----------- include/linux/fpga/fpga-mgr.h | 2 +- 2 files changed, 12 insertions(+), 12 deletions(-)
drivers/fpga/fpga-mgr.c +11 -11
@@ -26,7 +26,7 @@ struct fpga_mgr_devres { };/** -* fpga_image_info_alloc - Allocate a FPGA image info struct +* fpga_image_info_alloc - Allocate an FPGA image info struct * @dev: owning device * * Return: struct fpga_image_info or NULL
@@ -50,7 +50,7 @@ struct fpga_image_info *fpga_image_info_alloc(struct device *dev)EXPORT_SYMBOL_GPL (fpga_image_info_alloc);/** -* fpga_image_info_free - Free a FPGA image info struct +* fpga_image_info_free - Free an FPGA image info struct * @info: FPGA image info struct to free */ void fpga_image_info_free (struct fpga_image_info *info)
@@ -470,7 +470,7 @@ static int fpga_mgr_dev_match(struct device *dev, const void *data) }/** -* fpga_mgr_get - Given a device, get a reference to a fpga mgr. +* fpga_mgr_get - Given a device, get a reference to an fpga mgr. * @dev: parent device that fpga mgr was registered with * * Return: fpga manager struct or IS_ERR() condition containing error code.
@@ -487,7 +487,7 @@ struct fpga_manager *fpga_mgr_get(struct device *dev)EXPORT_SYMBOL_GPL (fpga_mgr_get);/** -* of_fpga_mgr_get - Given a device node, get a reference to a fpga mgr. +* of_fpga_mgr_get - Given a device node, get a reference to an fpga mgr. * * @node: device node *
@@ -506,7 +506,7 @@ struct fpga_manager *of_fpga_mgr_get(struct device_node *node)EXPORT_SYMBOL_GPL (of_fpga_mgr_get);/** -* fpga_mgr_put - release a reference to a fpga manager +* fpga_mgr_put - release a reference to an fpga manager * @mgr: fpga manager structure */ void fpga_mgr_put (struct fpga_manager *mgr)
@@ -550,7 +550,7 @@ void fpga_mgr_unlock(struct fpga_manager *mgr)EXPORT_SYMBOL_GPL (fpga_mgr_unlock);/** -* fpga_mgr_create - create and initialize a FPGA manager struct +* fpga_mgr_create - create and initialize an FPGA manager struct * @dev: fpga manager device from pdev * @name: fpga manager name * @mops: pointer to structure of fpga manager ops
@@ -617,7 +617,7 @@ struct fpga_manager *fpga_mgr_create(struct device *dev, const char *name,EXPORT_SYMBOL_GPL (fpga_mgr_create);/** -* fpga_mgr_free - free a FPGA manager created with fpga_mgr_create() +* fpga_mgr_free - free an FPGA manager created with fpga_mgr_create() * @mgr: fpga manager struct */ void fpga_mgr_free (struct fpga_manager *mgr)
@@ -641,7 +641,7 @@ static void devm_fpga_mgr_release(struct device *dev, void *res)* @mops: pointer to structure of fpga manager ops * @priv: fpga manager private data * -* This function is intended for use in a FPGA manager driver's probe function. +* This function is intended for use in an FPGA manager driver's probe function. * After the manager driver creates the manager struct with * devm_fpga_mgr_create(), it should register it with fpga_mgr_register(). The * manager driver's remove function should call fpga_mgr_unregister(). The
@@ -674,7 +674,7 @@ struct fpga_manager *devm_fpga_mgr_create(struct device *dev, const char *name,EXPORT_SYMBOL_GPL (devm_fpga_mgr_create);/** -* fpga_mgr_register - register a FPGA manager +* fpga_mgr_register - register an FPGA manager * @mgr: fpga manager struct * * Return: 0 on success, negative error code otherwise.
@@ -706,10 +706,10 @@ int fpga_mgr_register(struct fpga_manager *mgr)EXPORT_SYMBOL_GPL (fpga_mgr_register);/** -* fpga_mgr_unregister - unregister a FPGA manager +* fpga_mgr_unregister - unregister an FPGA manager * @mgr: fpga manager struct * -* This function is intended for use in a FPGA manager driver's remove function. +* This function is intended for use in an FPGA manager driver's remove function. */ void fpga_mgr_unregister (struct fpga_manager *mgr) {
include/linux/fpga/fpga-mgr.h +1 -1
@@ -75,7 +75,7 @@ enum fpga_mgr_states {#define FPGA_MGR_COMPRESSED_BITSTREAM BIT(4)/** -* struct fpga_image_info - information specific to a FPGA image +* struct fpga_image_info - information specific to an FPGA image * @flags: boolean flags as defined above * @enable_timeout_us: maximum time to enable traffic through bridge (uSec) * @disable_timeout_us: maximum time to disable traffic through bridge (uSec)
Signature · 1 line
2.26.3
[email protected]
reviewerPATCH 8/11 fpga: region: change FPGA indirect article to an
In reply to [email protected]From: Tom Rix <[email protected]>
Change use of 'a fpga' to 'an fpga'
--- drivers/fpga/fpga-region.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)
drivers/fpga/fpga-region.c +7 -7
@@ -33,14 +33,14 @@ struct fpga_region *fpga_region_class_find(EXPORT_SYMBOL_GPL (fpga_region_class_find);/** -* fpga_region_get - get an exclusive reference to a fpga region +* fpga_region_get - get an exclusive reference to an fpga region * @region: FPGA Region struct * * Caller should call fpga_region_put() when done with region. * * Return fpga_region struct if successful. * Return -EBUSY if someone already has a reference to the region. -* Return -ENODEV if @np is not a FPGA Region. +* Return -ENODEV if @np is not an FPGA Region. */ static struct fpga_region *fpga_region_get (struct fpga_region *region) {
@@ -234,7 +234,7 @@ struct fpga_regionEXPORT_SYMBOL_GPL (fpga_region_create);/** -* fpga_region_free - free a FPGA region created by fpga_region_create() +* fpga_region_free - free an FPGA region created by fpga_region_create() * @region: FPGA region */ void fpga_region_free (struct fpga_region *region)
@@ -257,7 +257,7 @@ static void devm_fpga_region_release(struct device *dev, void *res)* @mgr: manager that programs this region * @get_bridges: optional function to get bridges to a list * -* This function is intended for use in a FPGA region driver's probe function. +* This function is intended for use in an FPGA region driver's probe function. * After the region driver creates the region struct with * devm_fpga_region_create(), it should register it with fpga_region_register(). * The region driver's remove function should call fpga_region_unregister().
@@ -291,7 +291,7 @@ struct fpga_regionEXPORT_SYMBOL_GPL (devm_fpga_region_create);/** -* fpga_region_register - register a FPGA region +* fpga_region_register - register an FPGA region * @region: FPGA region * * Return: 0 or -errno
@@ -303,10 +303,10 @@ int fpga_region_register(struct fpga_region *region)EXPORT_SYMBOL_GPL (fpga_region_register);/** -* fpga_region_unregister - unregister a FPGA region +* fpga_region_unregister - unregister an FPGA region * @region: FPGA region * -* This function is intended for use in a FPGA region driver's remove function. +* This function is intended for use in an FPGA region driver's remove function. */ void fpga_region_unregister (struct fpga_region *region) {
Signature · 1 line
2.26.3
[email protected]
reviewerPATCH 9/11 fpga: of-fpga-region: change FPGA indirect article to an
In reply to [email protected]From: Tom Rix <[email protected]>
Change use of 'a fpga' to 'an fpga'
--- drivers/fpga/of-fpga-region.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/fpga/of-fpga-region.c +4 -4
@@ -181,7 +181,7 @@ static int child_regions_with_firmware(struct device_node *overlay)* @region: FPGA region * @overlay: overlay applied to the FPGA region * -* Given an overlay applied to a FPGA region, parse the FPGA image specific +* Given an overlay applied to an FPGA region, parse the FPGA image specific * info in the overlay and do some checking. * * Returns:
@@ -273,7 +273,7 @@ static struct fpga_image_info *of_fpga_region_parse_ov(* @region: FPGA region that the overlay was applied to * @nd: overlay notification data * -* Called when an overlay targeted to a FPGA Region is about to be applied. +* Called when an overlay targeted to an FPGA Region is about to be applied. * Parses the overlay for properties that influence how the FPGA will be * programmed and does some checking. If the checks pass, programs the FPGA. * If the checks fail, overlay is rejected and does not get added to the
@@ -336,8 +336,8 @@ static void of_fpga_region_notify_post_remove(struct fpga_region *region,* @action: notifier action * @arg: reconfig data * -* This notifier handles programming a FPGA when a "firmware-name" property is -* added to a fpga-region. +* This notifier handles programming an FPGA when a "firmware-name" property is +* added to an fpga-region. * * Returns NOTIFY_OK or error if FPGA programming fails. */
Signature · 1 line
2.26.3
[email protected]
reviewerPATCH 10/11 fpga: stratix10-soc: change FPGA indirect article to an
In reply to [email protected]From: Tom Rix <[email protected]>
Change use of 'a fpga' to 'an fpga'
--- drivers/fpga/stratix10-soc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/fpga/stratix10-soc.c +1 -1
@@ -271,7 +271,7 @@ static int s10_send_buf(struct fpga_manager *mgr, const char *buf, size_t count) }/* -* Send a FPGA image to privileged layers to write to the FPGA. When done +* Send an FPGA image to privileged layers to write to the FPGA. When done * sending, free all service layer buffers we allocated in write_init. */ static int s10_ops_write(struct fpga_manager *mgr, const char *buf,
Signature · 1 line
2.26.3
[email protected]
reviewerPATCH 11/11 staging: fpgaboot: change FPGA indirect article to an
In reply to [email protected]From: Tom Rix <[email protected]>
Change use of 'a fpga' to 'an fpga'
--- drivers/staging/gs_fpgaboot/README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/gs_fpgaboot/README +1 -1
@@ -39,7 +39,7 @@ TABLE OF CONTENTS. 5. USE CASE (from a mailing list discussion with Greg) - a. As a FPGA development support tool, + a. As an FPGA development support tool, During FPGA firmware development, you need to download a new FPGA image frequently. You would do that with a dedicated JTAG, which usually a limited
Signature · 1 line
2.26.3