Skip to contentSkip to conversation

usb: gadget: eem: fix wrong eem header operation

PATCH New Linyu Yuan 1 participant 1 message Jun 8, 2021

Subsystems (2)
Stable branch USB
lore
Share & tools
lore

Linyu Yuan

author
#0 lore raw

PATCH v3 1/1 usb: gadget: eem: fix wrong eem header operation

From: Linyu Yuan <[email protected]>

when skb_clone() or skb_copy_expand() fail,
it should pull skb with lengh indicated by header, or not it will read network data and check it as header.

Cc <[email protected]>
Signed-off-by Linyu Yuan <[email protected]>

---

v3: cc stable kernel
v2: use scripts/get_maintainer.pl to get correct maintainer

 drivers/usb/gadget/function/f_eem.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/usb/gadget/function/f_eem.c +2 -2
index cfcc4e81fb77..28dd5f1fd106 100644
@@ -495,7 +495,7 @@ static int eem_unwrap(struct gether *port,
 			skb2 = skb_clone(skb, GFP_ATOMIC);
 			if (unlikely(!skb2)) {
 				DBG(cdev, "unable to unframe EEM packet\n");
-				continue;
+				goto next;
 			}
 			skb_trim(skb2, len - ETH_FCS_LEN);
 

@@ -505,7 +505,7 @@ static int eem_unwrap(struct gether *port,
 						GFP_ATOMIC);
 			if (unlikely(!skb3)) {
 				dev_kfree_skb_any(skb2);
-				continue;
+				goto next;
 			}
 			dev_kfree_skb_any(skb2);
 			skb_queue_tail(list, skb3);
Signature · 1 line
2.25.1