Skip to contentSkip to conversation

clk: qcom: clk-alpha-pll: fix CAL_L write in alpha_pll_fabia_prepare

PATCH Applied Jonathan Marek 3 participants 3 messages Jun 9, 2021 – Jun 28, 2021

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 clk: qcom: clk-alpha-pll: fix CAL_L write in alpha_pll_fabia_prepare

Caught this when looking at alpha-pll code. Untested but it is clear that this was intended to write to PLL_CAL_L_VAL and not PLL_ALPHA_VAL.

Fixes 691865bad627 ("clk: qcom: clk-alpha-pll: Add support for Fabia PLL calibration")
---
 drivers/clk/qcom/clk-alpha-pll.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clk/qcom/clk-alpha-pll.c +1 -1
index 94b53c7db2f7f..eaedcceb766f9 100644
@@ -1255,7 +1255,7 @@ static int alpha_pll_fabia_prepare(struct clk_hw *hw)
 		return ret;
 
 	/* Setup PLL for calibration frequency */
-	regmap_write(pll->clkr.regmap, PLL_ALPHA_VAL(pll), cal_l);
+	regmap_write(pll->clkr.regmap, PLL_CAL_L_VAL(pll), cal_l);
 
 	/* Bringup the PLL at calibration frequency */
 	ret = clk_alpha_pll_enable(hw);
Signature · 1 line
2.26.1
maintainer Applied
#1 lore raw

Quoting Jonathan Marek (2021-06-08 19:28:52)

Quoted 6 lines

Caught this when looking at alpha-pll code. Untested but it is clear that this was intended to write to PLL_CAL_L_VAL and not PLL_ALPHA_VAL.

Fixes 691865bad627 ("clk: qcom: clk-alpha-pll: Add support for Fabia PLL calibration")

---

Applied to clk-next

Taniya, can you please review?

Reviewed-by on v2 1/1
#2 lore raw
In reply to Jonathan Marek
Quoted 23 lines · Jonathan Marek

Caught this when looking at alpha-pll code. Untested but it is clear that this was intended to write to PLL_CAL_L_VAL and not PLL_ALPHA_VAL.

Fixes 691865bad627 ("clk: qcom: clk-alpha-pll: Add support for Fabia PLL calibration")
---
  drivers/clk/qcom/clk-alpha-pll.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clk/qcom/clk-alpha-pll.c +1 -1
index 94b53c7db2f7f..eaedcceb766f9 100644
@@ -1255,7 +1255,7 @@ static int alpha_pll_fabia_prepare(struct clk_hw *hw)
  		return ret;
 
  	/* Setup PLL for calibration frequency */
-	regmap_write(pll->clkr.regmap, PLL_ALPHA_VAL(pll), cal_l);
+	regmap_write(pll->clkr.regmap, PLL_CAL_L_VAL(pll), cal_l);
 
  	/* Bringup the PLL at calibration frequency */
  	ret = clk_alpha_pll_enable(hw);
Signature · 4 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation.

--