Skip to contentSkip to conversation

usb: gadget: function: printer: use list_move instead of list_del/list_add

PATCH New Baokun Li 1 participant 1 message Jun 9, 2021

Subsystems (2)
lore
Share & tools
lore

Baokun Li

author
#0 lore raw

PATCH v2 1/1 usb: gadget: function: printer: use list_move instead of list_del/list_add

Using list_move() instead of list_del() + list_add().

---
V1->V2:
CC mailist

 drivers/usb/gadget/function/f_printer.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/usb/gadget/function/f_printer.c +1 -2
index f47fdc1fa7f1..b5112f6974f2 100644
@@ -667,8 +667,7 @@ printer_write(struct file *fd, const char __user *buf, size_t len, loff_t *ptr)
 		value = usb_ep_queue(dev->in_ep, req, GFP_ATOMIC);
 		spin_lock(&dev->lock);
 		if (value) {
-			list_del(&req->list);
-			list_add(&req->list, &dev->tx_reqs);
+			list_move(&req->list, &dev->tx_reqs);
 			spin_unlock_irqrestore(&dev->lock, flags);
 			mutex_unlock(&dev->lock_printer_io);
 			return -EAGAIN;