Skip to contentSkip to conversation

net: convert TFTP_TSIZE to proper Kconfig option

PATCH In review Tero Kristo 3 participants 4 messages May 12, 2021 – Jun 9, 2021 Networking

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 net: convert TFTP_TSIZE to proper Kconfig option

TFTP transfer size can be used to re-size the TFTP progress bar on single line based on the server reported file size. The support for this has been around from 2019, but it was never converted to proper Kconfig.

While adding this new Kconfig, enable it by default for OMAP2+ and K3 devices also.

---
v2: convert to proper Kconfig and add defaults for TI platforms

 net/Kconfig | 11 +++++++++++
 1 file changed, 11 insertions(+)
net/Kconfig +11 -0
index c4b4dae064..ba0ca813ce 100644
@@ -74,6 +74,17 @@ config TFTP_WINDOWSIZE
 	  before an ack response is required.
 	  The default TFTP implementation implies a window size of 1.
 
+config TFTP_TSIZE
+	bool "Track TFTP transfers based on file size option"
+	depends on CMD_TFTPBOOT
+	default y if (ARCH_OMAP2PLUS || ARCH_K3)
+	help
+	  By default, TFTP progress bar is increased for each received UDP
+	  frame, which can lead into long time being spent for sending
+	  data over the UART. Enabling this option, TFTP queries the file
+	  size from server, and if supported, limits the progress bar to
+	  50 characters total which fits on single line.
+
 config SERVERIP_FROM_PROXYDHCP
 	bool "Get serverip value from Proxy DHCP response"
 	help
Signature · 1 line
2.17.1
#1 lore raw

PATCH v2 1/1 net: convert TFTP_TSIZE to proper Kconfig option

Quoted 39 lines · Tero Kristo

TFTP transfer size can be used to re-size the TFTP progress bar on single line based on the server reported file size. The support for this has been around from 2019, but it was never converted to proper Kconfig.

While adding this new Kconfig, enable it by default for OMAP2+ and K3 devices also.

---
v2: convert to proper Kconfig and add defaults for TI platforms

 net/Kconfig | 11 +++++++++++
 1 file changed, 11 insertions(+)
net/Kconfig +11 -1
index c4b4dae064..ba0ca813ce 100644
@@ -74,6 +74,17 @@ config TFTP_WINDOWSIZE
          before an ack response is required.
          The default TFTP implementation implies a window size of 1.
 
+config TFTP_TSIZE
+       bool "Track TFTP transfers based on file size option"
+       depends on CMD_TFTPBOOT
+       default y if (ARCH_OMAP2PLUS || ARCH_K3)
+       help
+         By default, TFTP progress bar is increased for each received UDP
+         frame, which can lead into long time being spent for sending
+         data over the UART. Enabling this option, TFTP queries the file
+         size from server, and if supported, limits the progress bar to
+         50 characters total which fits on single line.
+
 config SERVERIP_FROM_PROXYDHCP
        bool "Get serverip value from Proxy DHCP response"
        help
--
Quoted 2 lines

2.17.1

Very good,
Two remarks, please use tools/moveconfig.py in order to automatically move all defconfigs into the configuration you just created. Second, don't add default here for the specific boards. add the option on the board specific Kconfig.

#2 lore raw

PATCH v2 1/1 net: convert TFTP_TSIZE to proper Kconfig option

Quoted 37 lines · Ramon Fried
Quoted 36 lines · Tero Kristo

TFTP transfer size can be used to re-size the TFTP progress bar on single line based on the server reported file size. The support for this has been around from 2019, but it was never converted to proper Kconfig.

While adding this new Kconfig, enable it by default for OMAP2+ and K3 devices also.

---
v2: convert to proper Kconfig and add defaults for TI platforms

 net/Kconfig | 11 +++++++++++
 1 file changed, 11 insertions(+)
net/Kconfig +11 -0
index c4b4dae064..ba0ca813ce 100644
@@ -74,6 +74,17 @@ config TFTP_WINDOWSIZE
          before an ack response is required.
          The default TFTP implementation implies a window size of 1.
 
+config TFTP_TSIZE
+       bool "Track TFTP transfers based on file size option"
+       depends on CMD_TFTPBOOT
+       default y if (ARCH_OMAP2PLUS || ARCH_K3)
+       help
+         By default, TFTP progress bar is increased for each received UDP
+         frame, which can lead into long time being spent for sending
+         data over the UART. Enabling this option, TFTP queries the file
+         size from server, and if supported, limits the progress bar to
+         50 characters total which fits on single line.
+
 config SERVERIP_FROM_PROXYDHCP
Quoted 8 lines
Quoted 5 lines
net/Kconfig +0 -1
        bool "Get serverip value from Proxy DHCP response"
        help
--

2.17.1

Very good,
Two remarks, please use tools/moveconfig.py in order to automatically move all defconfigs into the configuration you just created.

It's nice when that's done, but honestly not a big deal since it also tends to lead to making the patch harder to merge due to merge conflicts.

Quoted 2 lines

Second, don't add default here for the specific boards. add the option on the board specific Kconfig.

I prefer them to be here, rather than in the board Kconfig files as that second option makes more churn in the defconfig files I believe on resyncs.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20210515/9ef4a1a5/attachment.sig>
#3 lore raw
In reply to Tero Kristo
Quoted 9 lines · Tero Kristo

TFTP transfer size can be used to re-size the TFTP progress bar on single line based on the server reported file size. The support for this has been around from 2019, but it was never converted to proper Kconfig.

While adding this new Kconfig, enable it by default for OMAP2+ and K3 devices also.

Applied to u-boot/next, thanks!

Signature · 1 line
Tom