Correct and extend distro boot support for imx8m
cover Correct and extend distro boot support for imx8m
Distro boot support for imx8m family is not completed, with:
(a) imx8mm and imx8mp has facilities enabled to support only boot flow based on the boot scripts;
(b) im8mn has no distro boot support enabled, and still adheres to the customized boot flow using modified environment;
This patch series addresses above points by extending imx8mm and imx8mp derivatives with full support for distro boot, including sysboot flow; and adds a support for distro boot to imx8mn.
Andrey Zhizhikin (3):
imx8mm: configs: enable distro default features
imx8mp: configs: enable distro default features
imx8mn: configs: add support for distro boot commands
configs/imx8mm_evk_defconfig | 3 +- configs/imx8mn_ddr4_evk_defconfig | 1 + configs/imx8mn_evk_defconfig | 1 + configs/imx8mp_evk_defconfig | 3 +- include/configs/imx8mn_evk.h | 64 ++++++------------------------- 5 files changed, 16 insertions(+), 56 deletions(-)
Signature · 1 line
2.25.1
PATCH 1/3 imx8mm: configs: enable distro default features
imx8mm ekv has been switched to use distro boot commands, but had no correct options enabled to support sysboot.
According to the README.distro, sysboot is consindered to be a recommended way of using distro boot commands, it required default distro features to be enabled instead of only those that are relevant to the boot script.
Replace the boot script specific options in the config to a default distro option.
--- configs/imx8mm_evk_defconfig | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
configs/imx8mm_evk_defconfig +1 -2
@@ -18,6 +18,7 @@ CONFIG_SPL_SERIAL_SUPPORT=y CONFIG_SPL_DRIVERS_MISC_SUPPORT=y CONFIG_SPL=y CONFIG_DEFAULT_DEVICE_TREE="imx8mm-evk" +CONFIG_DISTRO_DEFAULTS=y CONFIG_FIT=y CONFIG_FIT_EXTERNAL_OFFSET=0x3000 CONFIG_SPL_LOAD_FIT=y
@@ -40,7 +41,6 @@ CONFIG_CMD_FUSE=y CONFIG_CMD_GPIO=y CONFIG_CMD_I2C=y CONFIG_CMD_MMC=y -CONFIG_CMD_PART=y CONFIG_CMD_DHCP=y CONFIG_CMD_MII=y CONFIG_CMD_PING=y
@@ -50,7 +50,6 @@ CONFIG_CMD_EXT2=y CONFIG_CMD_EXT4=y CONFIG_CMD_EXT4_WRITE=y CONFIG_CMD_FAT=y -CONFIG_CMD_FS_GENERIC=y CONFIG_OF_CONTROL=y CONFIG_SPL_OF_CONTROL=y CONFIG_ENV_OVERWRITE=y
Signature · 1 line
2.25.1
Fabio Estevam
reviewerPATCH 1/3 imx8mm: configs: enable distro default features
Hi Andrey,
Quoted 8 lines · Andrey Zhizhikin
imx8mm ekv has been switched to use distro boot commands, but had no correct options enabled to support sysboot.
According to the README.distro, sysboot is consindered to be a recommended way of using distro boot commands, it required default distro features to be enabled instead of only those that are relevant to the boot script.
Quoted 6 lines
Replace the boot script specific options in the config to a default distro option.
Signed-off-by Andrey Zhizhikin <[email protected]>Cc Peng Fan <[email protected]>Fixes 2df8930bf9 ("imx8mm: configs: add support for distro boot commands")
RE: [PATCH 1/3] imx8mm: configs: enable distro default features
Hello Stefano,
I believe the following patch is missing from the series that I've submitted earlier.
From the entire series named "Correct and extend distro boot support for imx8m" [1], there were 3 patches included, namely:
[2] imx8mm: configs: enable distro default features [3] imx8mp: configs: enable distro default features [4] imx8mn: configs: add support for distro boot commands
I see that only [4] is actually got merged, the rest 2 patches are left in "Superseded" state in Patchwork.
I'm not sure what happened here, I believe that was due to the fact that the patch which targeted "imx8mn" has been updated to V2 which caused the entire series to be dropped.
Should I re-submit the rest of 2 patches from the original series, or perhaps you can take them from the Patchwork directly?
Quoted 22 lines
-----Original Message-----
From: Fabio Estevam <[email protected]>
Sent: Sunday, May 2, 2021 12:00 AM
To: ZHIZHIKIN Andrey <[email protected]>
Cc: U-Boot-Denx <[email protected]>; Peng Fan <[email protected]>
Subject: Re: [PATCH 1/3] imx8mm: configs: enable distro default featuresHi Andrey,
Quoted 11 lines · Andrey Zhizhikin
imx8mm ekv has been switched to use distro boot commands, but had no correct options enabled to support sysboot.
According to the README.distro, sysboot is consindered to be a recommended way of using distro boot commands, it required default distro features to be enabled instead of only those that are relevant to the boot script.Replace the boot script specific options in the config to a default distro option.
Quoted 7 lines
Quoted 5 lines
Signed-off-by: Andrey Zhizhikin
<[email protected]>Cc Peng Fan <[email protected]>Fixes 2df8930bf9 ("imx8mm: configs: add support for distro bootcommands")
Reviewed-by Fabio Estevam <[email protected]>
-- Andrey
Re: [PATCH 1/3] imx8mm: configs: enable distro default features
Hi Andrey,
Quoted 11 lines · ZHIZHIKIN Andrey
Hello Stefano,
I believe the following patch is missing from the series that I've submitted earlier.
From the entire series named "Correct and extend distro boot support for imx8m" [1], there were 3 patches included, namely:
[2] imx8mm: configs: enable distro default features [3] imx8mp: configs: enable distro default features [4] imx8mn: configs: add support for distro boot commandsI see that only [4] is actually got merged, the rest 2 patches are left in "Superseded" state in Patchwork.
..and then discharged...
Quoted 1 line
I'm not sure what happened here,
I have no idea, too.
Quoted 3 lines
I believe that was due to the fact that the patch which targeted "imx8mn" has been updated to V2 which caused the entire series to be dropped.
Should I re-submit the rest of 2 patches from the original series, or perhaps you can take them from the Patchwork directly?
I check myself, thanks for pointing out.
Best regards,
Stefano
Quoted 38 lines
Quoted 23 lines
-----Original Message-----
From: Fabio Estevam <[email protected]>
Sent: Sunday, May 2, 2021 12:00 AM
To: ZHIZHIKIN Andrey <[email protected]>
Cc: U-Boot-Denx <[email protected]>; Peng Fan <[email protected]>
Subject: Re: [PATCH 1/3] imx8mm: configs: enable distro default featuresHi Andrey,
Quoted 11 lines · Andrey Zhizhikin
imx8mm ekv has been switched to use distro boot commands, but had no correct options enabled to support sysboot.
According to the README.distro, sysboot is consindered to be a recommended way of using distro boot commands, it required default distro features to be enabled instead of only those that are relevant to the boot script.Replace the boot script specific options in the config to a default distro option.
Quoted 7 lines
Quoted 5 lines
Signed-off-by: Andrey Zhizhikin
<[email protected]>Cc Peng Fan <[email protected]>Fixes 2df8930bf9 ("imx8mm: configs: add support for distro bootcommands")
Reviewed-by Fabio Estevam <[email protected]>-- Andrey
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: [email protected] =====================================================================
Re: [PATCH 1/3] imx8mm: configs: enable distro default features
In reply to ZHIZHIKIN AndreyQuoted 9 lines · ZHIZHIKIN Andrey
Hello Stefano,
I believe the following patch is missing from the series that I've submitted earlier.
From the entire series named "Correct and extend distro boot support for imx8m" [1], there were 3 patches included, namely:
[2] imx8mm: configs: enable distro default features [3] imx8mp: configs: enable distro default features [4] imx8mn: configs: add support for distro boot commands
Quoted 6 lines
I see that only [4] is actually got merged, the rest 2 patches are left in "Superseded" state in Patchwork.
I'm not sure what happened here, I believe that was due to the fact that the patch which targeted "imx8mn" has been updated to V2 which caused the entire series to be dropped.
Should I re-submit the rest of 2 patches from the original series, or perhaps you can take them from the Patchwork directly?
I picked up the two missing patches, just take a look at u-boot-imx, -master.
Best regards,
Stefano
Quoted 37 lines
Quoted 22 lines
-----Original Message-----
From: Fabio Estevam <[email protected]>
Sent: Sunday, May 2, 2021 12:00 AM
To: ZHIZHIKIN Andrey <[email protected]>
Cc: U-Boot-Denx <[email protected]>; Peng Fan <[email protected]>
Subject: Re: [PATCH 1/3] imx8mm: configs: enable distro default featuresHi Andrey,
Quoted 11 lines · Andrey Zhizhikin
imx8mm ekv has been switched to use distro boot commands, but had no correct options enabled to support sysboot.
According to the README.distro, sysboot is consindered to be a recommended way of using distro boot commands, it required default distro features to be enabled instead of only those that are relevant to the boot script.Replace the boot script specific options in the config to a default distro option.
Quoted 7 lines
Quoted 5 lines
Signed-off-by: Andrey Zhizhikin
<[email protected]>Cc Peng Fan <[email protected]>Fixes 2df8930bf9 ("imx8mm: configs: add support for distro bootcommands")
Reviewed-by Fabio Estevam <[email protected]>-- Andrey
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: [email protected] =====================================================================
RE: [PATCH 1/3] imx8mm: configs: enable distro default features
Hello Stefano,
Quoted 25 lines
-----Original Message-----
From: Stefano Babic <[email protected]>
Sent: Monday, June 21, 2021 1:36 PM
To: ZHIZHIKIN Andrey <[email protected]>; [email protected]
Cc: U-Boot-Denx <[email protected]>; Peng Fan <[email protected]>; Fabio Estevam <[email protected]>
Subject: Re: [PATCH 1/3] imx8mm: configs: enable distro default featuresQuoted 3 lines · ZHIZHIKIN Andrey
Hello Stefano,
I believe the following patch is missing from the series that I've submitted
earlier.
Quoted 2 lines
From the entire series named "Correct and extend distro boot support for
imx8m" [1], there were 3 patches included, namely:
Quoted 5 lines
[2] imx8mm: configs: enable distro default features [3] imx8mp:
configs: enable distro default features [4] imx8mn: configs: add support for distro boot commandsI see that only [4] is actually got merged, the rest 2 patches are left in
"Superseded" state in Patchwork.
Quoted 2 lines
I'm not sure what happened here, I believe that was due to the fact that the
Quoted 8 lines
patch which targeted "imx8mn" has been updated to V2 which caused the entire series to be dropped.
Quoted 2 lines
Should I re-submit the rest of 2 patches from the original series, or perhaps you
can take them from the Patchwork directly?
Quoted 1 line
I picked up the two missing patches, just take a look at u-boot-imx, -master.
I've checked the [master] branch of u-boot-imx and I can see those two missing patches in it.
This now completed the original series, thanks for taking care of this.
Quoted 4 lines
Best regards,
Stefano
Quoted 8 lines
--
==============================================================
=======
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: [email protected]
==============================================================
=======
-- andrey
PATCH 2/3 imx8mp: configs: enable distro default features
In reply to Andrey Zhizhikinimx8mp ekv has been switched to use distro boot commands, but had no correct options enabled to support sysboot.
According to the README.distro, sysboot is consindered to be a recommended way of using distro boot commands, it required default distro features to be enabled instead of only those that are relevant to the boot script.
Replace the boot script specific options in the config to a default distro option.
--- configs/imx8mp_evk_defconfig | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
configs/imx8mp_evk_defconfig +1 -2
@@ -19,6 +19,7 @@ CONFIG_SPL_DRIVERS_MISC_SUPPORT=y CONFIG_SPL=y CONFIG_SPL_IMX_ROMAPI_LOADADDR=0x48000000 CONFIG_DEFAULT_DEVICE_TREE="imx8mp-evk" +CONFIG_DISTRO_DEFAULTS=y CONFIG_FIT=y CONFIG_FIT_EXTERNAL_OFFSET=0x3000 CONFIG_SPL_LOAD_FIT=y
@@ -45,7 +46,6 @@ CONFIG_CMD_FUSE=y CONFIG_CMD_GPIO=y CONFIG_CMD_I2C=y CONFIG_CMD_MMC=y -CONFIG_CMD_PART=y CONFIG_CMD_DHCP=y CONFIG_CMD_MII=y CONFIG_CMD_PING=y
@@ -55,7 +55,6 @@ CONFIG_CMD_EXT2=y CONFIG_CMD_EXT4=y CONFIG_CMD_EXT4_WRITE=y CONFIG_CMD_FAT=y -CONFIG_CMD_FS_GENERIC=y CONFIG_OF_CONTROL=y CONFIG_SPL_OF_CONTROL=y CONFIG_ENV_OVERWRITE=y
Signature · 1 line
2.25.1
Fabio Estevam
reviewerPATCH 2/3 imx8mp: configs: enable distro default features
Quoted 8 lines · Andrey Zhizhikin
imx8mp ekv has been switched to use distro boot commands, but had no correct options enabled to support sysboot.
According to the README.distro, sysboot is consindered to be a recommended way of using distro boot commands, it required default distro features to be enabled instead of only those that are relevant to the boot script.
Quoted 6 lines
Replace the boot script specific options in the config to a default distro option.
Signed-off-by Andrey Zhizhikin <[email protected]>Cc Peng Fan <[email protected]>Fixes 9b162b1d1f ("imx8mp: configs: add support for distro boot commands")
PATCH 3/3 imx8mn: configs: add support for distro boot commands
In reply to Andrey ZhizhikinSupported boot device types in iMX8MN: MMC, DHCP.
Add DISTRO_DEFAULTS config option and include the distro boot command header file to enable full support of distro boot on i.MX8M Nano EVK (both DDR and LPDDR derivatives).
Drop previous environment, which was targeting customized boot commands and boot order.
--- configs/imx8mn_ddr4_evk_defconfig | 1 + configs/imx8mn_evk_defconfig | 1 + include/configs/imx8mn_evk.h | 64 ++++++------------------------- 3 files changed, 14 insertions(+), 52 deletions(-)
configs/imx8mn_ddr4_evk_defconfig +1 -0
@@ -19,6 +19,7 @@ CONFIG_SPL_DRIVERS_MISC_SUPPORT=y CONFIG_SPL=y CONFIG_SPL_IMX_ROMAPI_LOADADDR=0x48000000 CONFIG_DEFAULT_DEVICE_TREE="imx8mn-ddr4-evk" +CONFIG_DISTRO_DEFAULTS=y CONFIG_FIT=y CONFIG_FIT_EXTERNAL_OFFSET=0x3000 CONFIG_SPL_LOAD_FIT=y
configs/imx8mn_evk_defconfig +1 -0
@@ -20,6 +20,7 @@ CONFIG_SPL_DRIVERS_MISC_SUPPORT=y CONFIG_SPL=y CONFIG_SPL_IMX_ROMAPI_LOADADDR=0x48000000 CONFIG_DEFAULT_DEVICE_TREE="imx8mn-evk" +CONFIG_DISTRO_DEFAULTS=y CONFIG_FIT=y CONFIG_FIT_EXTERNAL_OFFSET=0x3000 CONFIG_SPL_LOAD_FIT=y
include/configs/imx8mn_evk.h +12 -52
81 lines not on this page · raw message
Signature · 1 line
2.25.1
Fabio Estevam
reviewerPATCH 3/3 imx8mn: configs: add support for distro boot commands
Quoted 7 lines · Andrey Zhizhikin
Supported boot device types in iMX8MN: MMC, DHCP.
Add
DISTRO_DEFAULTSconfig option and include the distro boot command header file to enable full support of distro boot on i.MX8M Nano EVK (both DDR and LPDDR derivatives).
Quoted 5 lines
Drop previous environment, which was targeting customized boot commands and boot order.
Signed-off-by Andrey Zhizhikin <[email protected]>Cc Peng Fan <[email protected]>
PATCH v2 1/1 imx8mn: configs: add support for distro boot commands
In reply to Andrey ZhizhikinSupported boot device types in iMX8MN: MMC, DHCP.
Add DISTRO_DEFAULTS config option and include the distro boot command header file to enable full support of distro boot on i.MX8M Nano EVK (both DDR and LPDDR derivatives).
Drop previous environment, which was targeting customized boot commands and boot order.
---
Changes in v2:
- Correct fdt parameters: "fdt_file" -> "fdtfile", "fdt_addr" -> "fdt_addr_r"
- Set "kernel_addr_r" and "scriptaddr" from config
configs/imx8mn_ddr4_evk_defconfig | 1 + configs/imx8mn_evk_defconfig | 1 + include/configs/imx8mn_evk.h | 68 +++++++------------------------ 3 files changed, 16 insertions(+), 54 deletions(-)
configs/imx8mn_ddr4_evk_defconfig +1 -0
@@ -19,6 +19,7 @@ CONFIG_SPL_DRIVERS_MISC_SUPPORT=y CONFIG_SPL=y CONFIG_SPL_IMX_ROMAPI_LOADADDR=0x48000000 CONFIG_DEFAULT_DEVICE_TREE="imx8mn-ddr4-evk" +CONFIG_DISTRO_DEFAULTS=y CONFIG_FIT=y CONFIG_FIT_EXTERNAL_OFFSET=0x3000 CONFIG_SPL_LOAD_FIT=y
configs/imx8mn_evk_defconfig +1 -0
@@ -22,6 +22,7 @@ CONFIG_SPL_DRIVERS_MISC_SUPPORT=y CONFIG_SPL=y CONFIG_SPL_IMX_ROMAPI_LOADADDR=0x48000000 CONFIG_DEFAULT_DEVICE_TREE="imx8mn-evk" +CONFIG_DISTRO_DEFAULTS=y CONFIG_FIT=y CONFIG_FIT_EXTERNAL_OFFSET=0x3000 CONFIG_SPL_LOAD_FIT=y
include/configs/imx8mn_evk.h +14 -54
83 lines not on this page · raw message
Signature · 1 line
2.25.1
Fabio Estevam
reviewerPATCH v2 1/1 imx8mn: configs: add support for distro boot commands
Hi Andrey,
Quoted 7 lines · Andrey Zhizhikin
Supported boot device types in iMX8MN: MMC, DHCP.
Add
DISTRO_DEFAULTSconfig option and include the distro boot command header file to enable full support of distro boot on i.MX8M Nano EVK (both DDR and LPDDR derivatives).
Quoted 8 lines
Drop previous environment, which was targeting customized boot commands and boot order.
Signed-off-by Andrey Zhizhikin <[email protected]>Cc Peng Fan <[email protected]>---
Changes in v2:
- Correct fdt parameters: "fdt_file" -> "fdtfile", "fdt_addr" -> "fdt_addr_r"
Yes, these are the preferred names according to the README file, thanks:
PATCH v2 1/1 imx8mn: configs: add support for distro boot commands
In reply to Andrey ZhizhikinQuoted 9 lines
Supported boot device types in iMX8MN: MMC, DHCP.
AddDISTRO_DEFAULTSconfig option and include the distro boot command header file to enable full support of distro boot on i.MX8M Nano EVK (both DDR and LPDDR derivatives).
Drop previous environment, which was targeting customized boot commands and boot order.Signed-off-by Andrey Zhizhikin <[email protected]>Cc Peng Fan <[email protected]>Reviewed-by Fabio Estevam <[email protected]>
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: [email protected] =====================================================================