Skip to contentSkip to conversation

arm: imx: imx8mm: clock: make debug output more descriptive

PATCH New Andrey Zhizhikin 3 participants 3 messages May 3, 2021 – Jun 9, 2021

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm: imx: imx8mm: clock: make debug output more descriptive

Clock initialization functionality has ambitious debug messages, which are printed out when failures are triggered during execution:
- Separate frequency table lookup functions have the the same output that makes it impossible to understand which function failed and produced the output
- PLL decoding routine has a generic debug statement printed, which does not state the actual value failed to be found

Extend the output for both cases with prefixing table lookup functions output with function name, and report the failed value in PLL decoding routine.

Cc Stefano Babic <[email protected]>
Cc Fabio Estevam <[email protected]>
Cc "NXP i.MX U-Boot Team" <[email protected]>
Cc Peng Fan <[email protected]>
Cc Simon Glass <[email protected]>
---
 arch/arm/mach-imx/imx8m/clock_imx8mm.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
arch/arm/mach-imx/imx8m/clock_imx8mm.c +3 -3
index 7d0f564a24..8b0c19cec8 100644
@@ -72,7 +72,7 @@ static int fracpll_configure(enum pll_clocks pll, u32 freq)
 	}
 
 	if (i == ARRAY_SIZE(imx8mm_fracpll_tbl)) {
-		printf("No matched freq table %u\n", freq);
+		printf("%s: No matched freq table %u\n", __func__, freq);
 		return -EINVAL;
 	}
 
@@ -148,7 +148,7 @@ void dram_enable_bypass(ulong clk_val)
 	}
 
 	if (i == ARRAY_SIZE(imx8mm_dram_bypass_tbl)) {
-		printf("No matched freq table %lu\n", clk_val);
+		printf("%s: No matched freq table %lu\n", __func__, clk_val);
 		return;
 	}
 
@@ -646,7 +646,7 @@ static u32 decode_fracpll(enum clk_root_src frac_pll)
 		pll_fdiv_ctl1 = readl(&ana_pll->video_pll1_fdiv_ctl1);
 		break;
 	default:
-		printf("Not supported\n");
+		printf("Unsupported clk_root_src %d\n", frac_pll);
 		return 0;
 	}
 
Signature · 1 line
2.25.1
reviewer
#1 lore raw

PATCH 1/1 arm: imx: imx8mm: clock: make debug output more descriptive

Hi Andrey,

Quoted 13 lines · Andrey Zhizhikin

Clock initialization functionality has ambitious debug messages, which are printed out when failures are triggered during execution:
- Separate frequency table lookup functions have the the same output that makes it impossible to understand which function failed and produced the output
- PLL decoding routine has a generic debug statement printed, which does not state the actual value failed to be found

Extend the output for both cases with prefixing table lookup functions output with function name, and report the failed value in PLL decoding routine.

Quoted 7 lines
Cc Stefano Babic <[email protected]>
Cc Fabio Estevam <[email protected]>
Cc "NXP i.MX U-Boot Team" <[email protected]>
Cc Peng Fan <[email protected]>
Cc Simon Glass <[email protected]>

Thanks for doing the split:

#2 lore raw

PATCH 1/1 arm: imx: imx8mm: clock: make debug output more descriptive

In reply to Andrey Zhizhikin
Quoted 10 lines

Clock initialization functionality has ambitious debug messages, which are printed out when failures are triggered during execution:
- Separate frequency table lookup functions have the the same output that makes it impossible to understand which function failed and produced the output
- PLL decoding routine has a generic debug statement printed, which does not state the actual value failed to be found
Extend the output for both cases with prefixing table lookup functions output with function name, and report the failed value in PLL decoding routine.

Quoted 8 lines
Cc Stefano Babic <[email protected]>
Cc Fabio Estevam <[email protected]>
Cc "NXP i.MX U-Boot Team" <[email protected]>
Cc Peng Fan <[email protected]>
Cc Simon Glass <[email protected]>

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: [email protected]
=====================================================================