fpga: reorganize to subdirs
Subsystems (3)
[email protected]
reviewerv2 cover fpga: reorganize to subdirs
From: Tom Rix <[email protected]>
The incoming xrt patchset has a toplevel subdir xrt/
The current fpga/ uses a single dir with filename prefixes to subdivide owners For consistency, there should be only one way to organize the fpga/ dir. Because the subdir model scales better, refactor to use it.
The discussion wrt xrt is here:
https://lore.kernel.org/linux-fpga/[email protected]/
Follow drivers/net/ethernet/ which has control configs NET_VENDOR_BLA that map to drivers/net/ethernet/bla Since fpgas do not have many vendors, drop the 'VENDOR' and use FPGA_BLA.
There are several new subdirs
altera/
dfl/
lattice/
xilinx/
Each subdir has a Kconfig that has a new/reused
if FPGA_BLA
... existing configs ...
endif FPGA_BLA
Which is sourced into the main fpga/Kconfig
Each subdir has a Makefile whose transversal is controlled in the fpga/Makefile by
obj-$(CONFIG_FPGA_BLA) += bla/
Some cleanup to arrange thing alphabetically and make fpga/Makefile's whitespace look more like net/'s
Changes from
v1
Drop renaming files
Cleanup makefiles
Tom Rix (4):
fpga: dfl: reorganize to subdir layout
fpga: xilinx: reorganize to subdir layout
fpga: altera: reorganize to subdir layout
fpga: lattice: reorganize to subdir layout
MAINTAINERS | 2 +-
drivers/fpga/Kconfig | 204 +-----------------
drivers/fpga/Makefile | 47 +---
drivers/fpga/altera/Kconfig | 78 +++++++
drivers/fpga/altera/Makefile | 12 ++
drivers/fpga/{ => altera}/altera-cvp.c | 0
drivers/fpga/{ => altera}/altera-fpga2sdram.c | 0
.../fpga/{ => altera}/altera-freeze-bridge.c | 0
drivers/fpga/{ => altera}/altera-hps2fpga.c | 0
.../{ => altera}/altera-pr-ip-core-plat.c | 0
drivers/fpga/{ => altera}/altera-pr-ip-core.c | 0
drivers/fpga/{ => altera}/altera-ps-spi.c | 0
drivers/fpga/{ => altera}/socfpga-a10.c | 0
drivers/fpga/{ => altera}/socfpga.c | 0
drivers/fpga/{ => altera}/stratix10-soc.c | 0
drivers/fpga/{ => altera}/ts73xx-fpga.c | 0
drivers/fpga/dfl/Kconfig | 81 +++++++
drivers/fpga/dfl/Makefile | 16 ++
drivers/fpga/{ => dfl}/dfl-afu-dma-region.c | 0
drivers/fpga/{ => dfl}/dfl-afu-error.c | 0
drivers/fpga/{ => dfl}/dfl-afu-main.c | 0
drivers/fpga/{ => dfl}/dfl-afu-region.c | 0
drivers/fpga/{ => dfl}/dfl-afu.h | 0
drivers/fpga/{ => dfl}/dfl-fme-br.c | 0
drivers/fpga/{ => dfl}/dfl-fme-error.c | 0
drivers/fpga/{ => dfl}/dfl-fme-main.c | 0
drivers/fpga/{ => dfl}/dfl-fme-mgr.c | 0
drivers/fpga/{ => dfl}/dfl-fme-perf.c | 0
drivers/fpga/{ => dfl}/dfl-fme-pr.c | 0
drivers/fpga/{ => dfl}/dfl-fme-pr.h | 0
drivers/fpga/{ => dfl}/dfl-fme-region.c | 0
drivers/fpga/{ => dfl}/dfl-fme.h | 0
drivers/fpga/{ => dfl}/dfl-n3000-nios.c | 0
drivers/fpga/{ => dfl}/dfl-pci.c | 0
drivers/fpga/{ => dfl}/dfl.c | 0
drivers/fpga/{ => dfl}/dfl.h | 0
drivers/fpga/lattice/Kconfig | 22 ++
drivers/fpga/lattice/Makefile | 4 +
drivers/fpga/{ => lattice}/ice40-spi.c | 0
drivers/fpga/{ => lattice}/machxo2-spi.c | 0
drivers/fpga/xilinx/Kconfig | 48 +++++
drivers/fpga/xilinx/Makefile | 6 +
.../fpga/{ => xilinx}/xilinx-pr-decoupler.c | 0
drivers/fpga/{ => xilinx}/xilinx-spi.c | 0
drivers/fpga/{ => xilinx}/zynq-fpga.c | 0
drivers/fpga/{ => xilinx}/zynqmp-fpga.c | 0
46 files changed, 280 insertions(+), 240 deletions(-)
create mode 100644 drivers/fpga/altera/Kconfig
create mode 100644 drivers/fpga/altera/Makefile
rename drivers/fpga/{ => altera}/altera-cvp.c (100%)
rename drivers/fpga/{ => altera}/altera-fpga2sdram.c (100%)
rename drivers/fpga/{ => altera}/altera-freeze-bridge.c (100%)
rename drivers/fpga/{ => altera}/altera-hps2fpga.c (100%)
rename drivers/fpga/{ => altera}/altera-pr-ip-core-plat.c (100%)
rename drivers/fpga/{ => altera}/altera-pr-ip-core.c (100%)
rename drivers/fpga/{ => altera}/altera-ps-spi.c (100%)
rename drivers/fpga/{ => altera}/socfpga-a10.c (100%)
rename drivers/fpga/{ => altera}/socfpga.c (100%)
rename drivers/fpga/{ => altera}/stratix10-soc.c (100%)
rename drivers/fpga/{ => altera}/ts73xx-fpga.c (100%)
create mode 100644 drivers/fpga/dfl/Kconfig
create mode 100644 drivers/fpga/dfl/Makefile
rename drivers/fpga/{ => dfl}/dfl-afu-dma-region.c (100%)
rename drivers/fpga/{ => dfl}/dfl-afu-error.c (100%)
rename drivers/fpga/{ => dfl}/dfl-afu-main.c (100%)
rename drivers/fpga/{ => dfl}/dfl-afu-region.c (100%)
rename drivers/fpga/{ => dfl}/dfl-afu.h (100%)
rename drivers/fpga/{ => dfl}/dfl-fme-br.c (100%)
rename drivers/fpga/{ => dfl}/dfl-fme-error.c (100%)
rename drivers/fpga/{ => dfl}/dfl-fme-main.c (100%)
rename drivers/fpga/{ => dfl}/dfl-fme-mgr.c (100%)
rename drivers/fpga/{ => dfl}/dfl-fme-perf.c (100%)
rename drivers/fpga/{ => dfl}/dfl-fme-pr.c (100%)
rename drivers/fpga/{ => dfl}/dfl-fme-pr.h (100%)
rename drivers/fpga/{ => dfl}/dfl-fme-region.c (100%)
rename drivers/fpga/{ => dfl}/dfl-fme.h (100%)
rename drivers/fpga/{ => dfl}/dfl-n3000-nios.c (100%)
rename drivers/fpga/{ => dfl}/dfl-pci.c (100%)
rename drivers/fpga/{ => dfl}/dfl.c (100%)
rename drivers/fpga/{ => dfl}/dfl.h (100%)
create mode 100644 drivers/fpga/lattice/Kconfig
create mode 100644 drivers/fpga/lattice/Makefile
rename drivers/fpga/{ => lattice}/ice40-spi.c (100%)
rename drivers/fpga/{ => lattice}/machxo2-spi.c (100%)
create mode 100644 drivers/fpga/xilinx/Kconfig
create mode 100644 drivers/fpga/xilinx/Makefile
rename drivers/fpga/{ => xilinx}/xilinx-pr-decoupler.c (100%)
rename drivers/fpga/{ => xilinx}/xilinx-spi.c (100%)
rename drivers/fpga/{ => xilinx}/zynq-fpga.c (100%)
rename drivers/fpga/{ => xilinx}/zynqmp-fpga.c (100%)Signature · 1 line
2.26.3
[email protected]
reviewerv2 cover fpga: reorganize to subdirs
From: Tom Rix <[email protected]>
The incoming xrt patchset has a toplevel subdir xrt/
The current fpga/ uses a single dir with filename prefixes to subdivide owners For consistency, there should be only one way to organize the fpga/ dir. Because the subdir model scales better, refactor to use it.
The discussion wrt xrt is here:
https://lore.kernel.org/linux-fpga/[email protected]/
Follow drivers/net/ethernet/ which has control configs NET_VENDOR_BLA that map to drivers/net/ethernet/bla Since fpgas do not have many vendors, drop the 'VENDOR' and use FPGA_BLA.
There are several new subdirs
altera/
dfl/
lattice/
xilinx/
Each subdir has a Kconfig that has a new/reused
if FPGA_BLA
... existing configs ...
endif FPGA_BLA
Which is sourced into the main fpga/Kconfig
Each subdir has a Makefile whose transversal is controlled in the fpga/Makefile by
obj-$(CONFIG_FPGA_BLA) += bla/
Some cleanup to arrange thing alphabetically and make fpga/Makefile's whitespace look more like net/'s
Changes from
v1
Drop renaming files
Cleanup makefiles
Tom Rix (4):
fpga: dfl: reorganize to subdir layout
fpga: xilinx: reorganize to subdir layout
fpga: altera: reorganize to subdir layout
fpga: lattice: reorganize to subdir layout
MAINTAINERS | 2 +-
drivers/fpga/Kconfig | 204 +-----------------
drivers/fpga/Makefile | 47 +---
drivers/fpga/altera/Kconfig | 78 +++++++
drivers/fpga/altera/Makefile | 12 ++
drivers/fpga/{ => altera}/altera-cvp.c | 0
drivers/fpga/{ => altera}/altera-fpga2sdram.c | 0
.../fpga/{ => altera}/altera-freeze-bridge.c | 0
drivers/fpga/{ => altera}/altera-hps2fpga.c | 0
.../{ => altera}/altera-pr-ip-core-plat.c | 0
drivers/fpga/{ => altera}/altera-pr-ip-core.c | 0
drivers/fpga/{ => altera}/altera-ps-spi.c | 0
drivers/fpga/{ => altera}/socfpga-a10.c | 0
drivers/fpga/{ => altera}/socfpga.c | 0
drivers/fpga/{ => altera}/stratix10-soc.c | 0
drivers/fpga/{ => altera}/ts73xx-fpga.c | 0
drivers/fpga/dfl/Kconfig | 81 +++++++
drivers/fpga/dfl/Makefile | 16 ++
drivers/fpga/{ => dfl}/dfl-afu-dma-region.c | 0
drivers/fpga/{ => dfl}/dfl-afu-error.c | 0
drivers/fpga/{ => dfl}/dfl-afu-main.c | 0
drivers/fpga/{ => dfl}/dfl-afu-region.c | 0
drivers/fpga/{ => dfl}/dfl-afu.h | 0
drivers/fpga/{ => dfl}/dfl-fme-br.c | 0
drivers/fpga/{ => dfl}/dfl-fme-error.c | 0
drivers/fpga/{ => dfl}/dfl-fme-main.c | 0
drivers/fpga/{ => dfl}/dfl-fme-mgr.c | 0
drivers/fpga/{ => dfl}/dfl-fme-perf.c | 0
drivers/fpga/{ => dfl}/dfl-fme-pr.c | 0
drivers/fpga/{ => dfl}/dfl-fme-pr.h | 0
drivers/fpga/{ => dfl}/dfl-fme-region.c | 0
drivers/fpga/{ => dfl}/dfl-fme.h | 0
drivers/fpga/{ => dfl}/dfl-n3000-nios.c | 0
drivers/fpga/{ => dfl}/dfl-pci.c | 0
drivers/fpga/{ => dfl}/dfl.c | 0
drivers/fpga/{ => dfl}/dfl.h | 0
drivers/fpga/lattice/Kconfig | 22 ++
drivers/fpga/lattice/Makefile | 4 +
drivers/fpga/{ => lattice}/ice40-spi.c | 0
drivers/fpga/{ => lattice}/machxo2-spi.c | 0
drivers/fpga/xilinx/Kconfig | 48 +++++
drivers/fpga/xilinx/Makefile | 6 +
.../fpga/{ => xilinx}/xilinx-pr-decoupler.c | 0
drivers/fpga/{ => xilinx}/xilinx-spi.c | 0
drivers/fpga/{ => xilinx}/zynq-fpga.c | 0
drivers/fpga/{ => xilinx}/zynqmp-fpga.c | 0
46 files changed, 280 insertions(+), 240 deletions(-)
create mode 100644 drivers/fpga/altera/Kconfig
create mode 100644 drivers/fpga/altera/Makefile
rename drivers/fpga/{ => altera}/altera-cvp.c (100%)
rename drivers/fpga/{ => altera}/altera-fpga2sdram.c (100%)
rename drivers/fpga/{ => altera}/altera-freeze-bridge.c (100%)
rename drivers/fpga/{ => altera}/altera-hps2fpga.c (100%)
rename drivers/fpga/{ => altera}/altera-pr-ip-core-plat.c (100%)
rename drivers/fpga/{ => altera}/altera-pr-ip-core.c (100%)
rename drivers/fpga/{ => altera}/altera-ps-spi.c (100%)
rename drivers/fpga/{ => altera}/socfpga-a10.c (100%)
rename drivers/fpga/{ => altera}/socfpga.c (100%)
rename drivers/fpga/{ => altera}/stratix10-soc.c (100%)
rename drivers/fpga/{ => altera}/ts73xx-fpga.c (100%)
create mode 100644 drivers/fpga/dfl/Kconfig
create mode 100644 drivers/fpga/dfl/Makefile
rename drivers/fpga/{ => dfl}/dfl-afu-dma-region.c (100%)
rename drivers/fpga/{ => dfl}/dfl-afu-error.c (100%)
rename drivers/fpga/{ => dfl}/dfl-afu-main.c (100%)
rename drivers/fpga/{ => dfl}/dfl-afu-region.c (100%)
rename drivers/fpga/{ => dfl}/dfl-afu.h (100%)
rename drivers/fpga/{ => dfl}/dfl-fme-br.c (100%)
rename drivers/fpga/{ => dfl}/dfl-fme-error.c (100%)
rename drivers/fpga/{ => dfl}/dfl-fme-main.c (100%)
rename drivers/fpga/{ => dfl}/dfl-fme-mgr.c (100%)
rename drivers/fpga/{ => dfl}/dfl-fme-perf.c (100%)
rename drivers/fpga/{ => dfl}/dfl-fme-pr.c (100%)
rename drivers/fpga/{ => dfl}/dfl-fme-pr.h (100%)
rename drivers/fpga/{ => dfl}/dfl-fme-region.c (100%)
rename drivers/fpga/{ => dfl}/dfl-fme.h (100%)
rename drivers/fpga/{ => dfl}/dfl-n3000-nios.c (100%)
rename drivers/fpga/{ => dfl}/dfl-pci.c (100%)
rename drivers/fpga/{ => dfl}/dfl.c (100%)
rename drivers/fpga/{ => dfl}/dfl.h (100%)
create mode 100644 drivers/fpga/lattice/Kconfig
create mode 100644 drivers/fpga/lattice/Makefile
rename drivers/fpga/{ => lattice}/ice40-spi.c (100%)
rename drivers/fpga/{ => lattice}/machxo2-spi.c (100%)
create mode 100644 drivers/fpga/xilinx/Kconfig
create mode 100644 drivers/fpga/xilinx/Makefile
rename drivers/fpga/{ => xilinx}/xilinx-pr-decoupler.c (100%)
rename drivers/fpga/{ => xilinx}/xilinx-spi.c (100%)
rename drivers/fpga/{ => xilinx}/zynq-fpga.c (100%)
rename drivers/fpga/{ => xilinx}/zynqmp-fpga.c (100%)Signature · 1 line
2.26.3
[email protected]
reviewerPATCH v2 1/4 fpga: dfl: reorganize to subdir layout
In reply to [email protected]From: Tom Rix <[email protected]>
Create a dfl/ subdir
Move dfl-* files to it.
Add a Kconfig and Makefile
Because FPGA_DFL is now used in dfl/Kconfig in a if/endif block, all the other configs in dfl/Kconfig implicitly depend on FPGA_DFL. So the explict dependence can be removed. Also since FPGA_DFL depends on HAS_IOMEM, it can be removed from the other configs.
---
MAINTAINERS | 2 +-
drivers/fpga/Kconfig | 80 +-------------------
drivers/fpga/Makefile | 18 +----
drivers/fpga/dfl/Kconfig | 81 +++++++++++++++++++++
drivers/fpga/dfl/Makefile | 16 ++++
drivers/fpga/{ => dfl}/dfl-afu-dma-region.c | 0
drivers/fpga/{ => dfl}/dfl-afu-error.c | 0
drivers/fpga/{ => dfl}/dfl-afu-main.c | 0
drivers/fpga/{ => dfl}/dfl-afu-region.c | 0
drivers/fpga/{ => dfl}/dfl-afu.h | 0
drivers/fpga/{ => dfl}/dfl-fme-br.c | 0
drivers/fpga/{ => dfl}/dfl-fme-error.c | 0
drivers/fpga/{ => dfl}/dfl-fme-main.c | 0
drivers/fpga/{ => dfl}/dfl-fme-mgr.c | 0
drivers/fpga/{ => dfl}/dfl-fme-perf.c | 0
drivers/fpga/{ => dfl}/dfl-fme-pr.c | 0
drivers/fpga/{ => dfl}/dfl-fme-pr.h | 0
drivers/fpga/{ => dfl}/dfl-fme-region.c | 0
drivers/fpga/{ => dfl}/dfl-fme.h | 0
drivers/fpga/{ => dfl}/dfl-n3000-nios.c | 0
drivers/fpga/{ => dfl}/dfl-pci.c | 0
drivers/fpga/{ => dfl}/dfl.c | 0
drivers/fpga/{ => dfl}/dfl.h | 0
23 files changed, 100 insertions(+), 97 deletions(-)
create mode 100644 drivers/fpga/dfl/Kconfig
create mode 100644 drivers/fpga/dfl/Makefile
rename drivers/fpga/{ => dfl}/dfl-afu-dma-region.c (100%)
rename drivers/fpga/{ => dfl}/dfl-afu-error.c (100%)
rename drivers/fpga/{ => dfl}/dfl-afu-main.c (100%)
rename drivers/fpga/{ => dfl}/dfl-afu-region.c (100%)
rename drivers/fpga/{ => dfl}/dfl-afu.h (100%)
rename drivers/fpga/{ => dfl}/dfl-fme-br.c (100%)
rename drivers/fpga/{ => dfl}/dfl-fme-error.c (100%)
rename drivers/fpga/{ => dfl}/dfl-fme-main.c (100%)
rename drivers/fpga/{ => dfl}/dfl-fme-mgr.c (100%)
rename drivers/fpga/{ => dfl}/dfl-fme-perf.c (100%)
rename drivers/fpga/{ => dfl}/dfl-fme-pr.c (100%)
rename drivers/fpga/{ => dfl}/dfl-fme-pr.h (100%)
rename drivers/fpga/{ => dfl}/dfl-fme-region.c (100%)
rename drivers/fpga/{ => dfl}/dfl-fme.h (100%)
rename drivers/fpga/{ => dfl}/dfl-n3000-nios.c (100%)
rename drivers/fpga/{ => dfl}/dfl-pci.c (100%)
rename drivers/fpga/{ => dfl}/dfl.c (100%)
rename drivers/fpga/{ => dfl}/dfl.h (100%)MAINTAINERS +1 -1
@@ -7207,7 +7207,7 @@ L: [email protected] S: Maintained F: Documentation/ABI/testing/sysfs-bus-dfl* F: Documentation/fpga/dfl.rst -F: drivers/fpga/dfl* +F: drivers/fpga/dfl/ F: drivers/uio/uio_dfl.c F: include/linux/dfl.h F: include/uapi/linux/fpga-dfl.h
drivers/fpga/Kconfig +1 -79
86 lines not on this page · raw message
drivers/fpga/Makefile +1 -17
@@ -31,20 +31,4 @@ obj-$(CONFIG_XILINX_PR_DECOUPLER) += xilinx-pr-decoupler.o obj-$(CONFIG_FPGA_REGION) += fpga-region.o obj-$(CONFIG_OF_FPGA_REGION) += of-fpga-region.o -# FPGA Device Feature List Support -obj-$(CONFIG_FPGA_DFL) += dfl.o -obj-$(CONFIG_FPGA_DFL_FME) += dfl-fme.o -obj-$(CONFIG_FPGA_DFL_FME_MGR) += dfl-fme-mgr.o -obj-$(CONFIG_FPGA_DFL_FME_BRIDGE) += dfl-fme-br.o -obj-$(CONFIG_FPGA_DFL_FME_REGION) += dfl-fme-region.o -obj-$(CONFIG_FPGA_DFL_AFU) += dfl-afu.o - -dfl-fme-objs := dfl-fme-main.o dfl-fme-pr.o dfl-fme-error.o -dfl-fme-objs += dfl-fme-perf.o -dfl-afu-objs := dfl-afu-main.o dfl-afu-region.o dfl-afu-dma-region.o -dfl-afu-objs += dfl-afu-error.o - -obj-$(CONFIG_FPGA_DFL_NIOS_INTEL_PAC_N3000) += dfl-n3000-nios.o - -# Drivers for FPGAs which implement DFL -obj-$(CONFIG_FPGA_DFL_PCI) += dfl-pci.o +obj-$(CONFIG_FPGA_DFL) += dfl/
drivers/fpga/dfl/Kconfig new file +81 -0
81 lines not on this page · raw message
drivers/fpga/dfl/Makefile new file +16 -0
@@ -0,0 +1,16 @@ +# SPDX-License-Identifier: GPL-2.0-only +# +# FPGA Device Feature List (DFL) Support +obj-$(CONFIG_FPGA_DFL) += dfl.o +obj-$(CONFIG_FPGA_DFL_AFU) += dfl-afu.o +obj-$(CONFIG_FPGA_DFL_FME) += dfl-fme.o +obj-$(CONFIG_FPGA_DFL_FME_BRIDGE) += dfl-fme-br.o +obj-$(CONFIG_FPGA_DFL_FME_MGR) += dfl-fme-mgr.o +obj-$(CONFIG_FPGA_DFL_FME_REGION) += dfl-fme-region.o +obj-$(CONFIG_FPGA_DFL_NIOS_INTEL_PAC_N3000) += dfl-n3000-nios.o +obj-$(CONFIG_FPGA_DFL_PCI) += dfl-pci.o + +dfl-fme-objs := dfl-fme-main.o dfl-fme-pr.o dfl-fme-error.o \ + dfl-fme-perf.o +dfl-afu-objs := dfl-afu-main.o dfl-afu-region.o dfl-afu-dma-region.o \ + dfl-afu-error.o
drivers/fpga/dfl/dfl-afu-dma-region.c renamed from drivers/fpga/dfl-afu-dma-region.c +0 -0
drivers/fpga/dfl/dfl-afu-error.c renamed from drivers/fpga/dfl-afu-error.c +0 -0
drivers/fpga/dfl/dfl-afu-main.c renamed from drivers/fpga/dfl-afu-main.c +0 -0
drivers/fpga/dfl/dfl-afu-region.c renamed from drivers/fpga/dfl-afu-region.c +0 -0
drivers/fpga/dfl/dfl-afu.h renamed from drivers/fpga/dfl-afu.h +0 -0
drivers/fpga/dfl/dfl-fme-br.c renamed from drivers/fpga/dfl-fme-br.c +0 -0
drivers/fpga/dfl/dfl-fme-error.c renamed from drivers/fpga/dfl-fme-error.c +0 -0
drivers/fpga/dfl/dfl-fme-main.c renamed from drivers/fpga/dfl-fme-main.c +0 -0
drivers/fpga/dfl/dfl-fme-mgr.c renamed from drivers/fpga/dfl-fme-mgr.c +0 -0
drivers/fpga/dfl/dfl-fme-perf.c renamed from drivers/fpga/dfl-fme-perf.c +0 -0
drivers/fpga/dfl/dfl-fme-pr.c renamed from drivers/fpga/dfl-fme-pr.c +0 -0
drivers/fpga/dfl/dfl-fme-pr.h renamed from drivers/fpga/dfl-fme-pr.h +0 -0
drivers/fpga/dfl/dfl-fme-region.c renamed from drivers/fpga/dfl-fme-region.c +0 -0
drivers/fpga/dfl/dfl-fme.h renamed from drivers/fpga/dfl-fme.h +0 -0
drivers/fpga/dfl/dfl-n3000-nios.c renamed from drivers/fpga/dfl-n3000-nios.c +0 -0
drivers/fpga/dfl/dfl-pci.c renamed from drivers/fpga/dfl-pci.c +0 -0
drivers/fpga/dfl/dfl.c renamed from drivers/fpga/dfl.c +0 -0
drivers/fpga/dfl/dfl.h renamed from drivers/fpga/dfl.h +0 -0
Signature · 1 line
2.26.3
[email protected]
reviewerPATCH v2 2/4 fpga: xilinx: reorganize to subdir layout
In reply to [email protected]From: Tom Rix <[email protected]>
Create a xilinx/ subdir
Move xilinx-* and zynq* files to it.
Add a Kconfig and Makefile
---
drivers/fpga/Kconfig | 40 +---------------
drivers/fpga/Makefile | 5 +-
drivers/fpga/xilinx/Kconfig | 48 +++++++++++++++++++
drivers/fpga/xilinx/Makefile | 6 +++
.../fpga/{ => xilinx}/xilinx-pr-decoupler.c | 0
drivers/fpga/{ => xilinx}/xilinx-spi.c | 0
drivers/fpga/{ => xilinx}/zynq-fpga.c | 0
drivers/fpga/{ => xilinx}/zynqmp-fpga.c | 0
8 files changed, 56 insertions(+), 43 deletions(-)
create mode 100644 drivers/fpga/xilinx/Kconfig
create mode 100644 drivers/fpga/xilinx/Makefile
rename drivers/fpga/{ => xilinx}/xilinx-pr-decoupler.c (100%)
rename drivers/fpga/{ => xilinx}/xilinx-spi.c (100%)
rename drivers/fpga/{ => xilinx}/zynq-fpga.c (100%)
rename drivers/fpga/{ => xilinx}/zynqmp-fpga.c (100%)drivers/fpga/Kconfig +1 -39
@@ -52,25 +52,12 @@ config FPGA_MGR_ALTERA_CVP FPGA manager driver support for Arria-V, Cyclone-V, Stratix-V, Arria 10 and Stratix10 Altera FPGAs using the CvP interface over PCIe. -config FPGA_MGR_ZYNQ_FPGA - tristate "Xilinx Zynq FPGA" - depends on ARCH_ZYNQ || COMPILE_TEST - help - FPGA manager driver support for Xilinx Zynq FPGAs. - config FPGA_MGR_STRATIX10_SOC tristate "Intel Stratix10 SoC FPGA Manager" depends on (ARCH_INTEL_SOCFPGA && INTEL_STRATIX10_SERVICE) help FPGA manager driver support for the Intel Stratix10 SoC. -config FPGA_MGR_XILINX_SPI - tristate "Xilinx Configuration over Slave Serial (SPI)" - depends on SPI - help - FPGA manager driver support for Xilinx FPGA configuration - over slave serial interface. - config FPGA_MGR_ICE40_SPI tristate "Lattice iCE40 SPI" depends on OF && SPI
@@ -113,23 +100,6 @@ config ALTERA_FREEZE_BRIDGE isolate one region of the FPGA from the busses while that region is being reprogrammed. -config XILINX_PR_DECOUPLER - tristate "Xilinx LogiCORE PR Decoupler" - depends on FPGA_BRIDGE - depends on HAS_IOMEM - help - Say Y to enable drivers for Xilinx LogiCORE PR Decoupler - or Xilinx Dynamic Function eXchnage AIX Shutdown Manager. - The PR Decoupler exists in the FPGA fabric to isolate one - region of the FPGA from the busses while that region is - being reprogrammed during partial reconfig. - The Dynamic Function eXchange AXI shutdown manager prevents - AXI traffic from passing through the bridge. The controller - safely handles AXI4MM and AXI4-Lite interfaces on a - Reconfigurable Partition when it is undergoing dynamic - reconfiguration, preventing the system deadlock that can - occur if AXI transactions are interrupted by DFX. - config FPGA_REGION tristate "FPGA Region" depends on FPGA_BRIDGE
@@ -146,14 +116,6 @@ config OF_FPGA_REGION overlay. source "drivers/fpga/dfl/Kconfig" - -config FPGA_MGR_ZYNQMP_FPGA - tristate "Xilinx ZynqMP FPGA" - depends on ZYNQMP_FIRMWARE || (!ZYNQMP_FIRMWARE && COMPILE_TEST) - help - FPGA manager driver support for Xilinx ZynqMP FPGAs. - This driver uses the processor configuration port(PCAP) - to configure the programmable logic(PL) through PS - on ZynqMP SoC. +source "drivers/fpga/xilinx/Kconfig" endif # FPGA
drivers/fpga/Makefile +1 -4
@@ -15,9 +15,6 @@ obj-$(CONFIG_FPGA_MGR_SOCFPGA) += socfpga.o obj-$(CONFIG_FPGA_MGR_SOCFPGA_A10) += socfpga-a10.o obj-$(CONFIG_FPGA_MGR_STRATIX10_SOC) += stratix10-soc.o obj-$(CONFIG_FPGA_MGR_TS73XX) += ts73xx-fpga.o -obj-$(CONFIG_FPGA_MGR_XILINX_SPI) += xilinx-spi.o -obj-$(CONFIG_FPGA_MGR_ZYNQ_FPGA) += zynq-fpga.o -obj-$(CONFIG_FPGA_MGR_ZYNQMP_FPGA) += zynqmp-fpga.o obj-$(CONFIG_ALTERA_PR_IP_CORE) += altera-pr-ip-core.o obj-$(CONFIG_ALTERA_PR_IP_CORE_PLAT) += altera-pr-ip-core-plat.o
@@ -25,10 +22,10 @@ obj-$(CONFIG_ALTERA_PR_IP_CORE_PLAT) += altera-pr-ip-core-plat.o obj-$(CONFIG_FPGA_BRIDGE) += fpga-bridge.o obj-$(CONFIG_SOCFPGA_FPGA_BRIDGE) += altera-hps2fpga.o altera-fpga2sdram.o obj-$(CONFIG_ALTERA_FREEZE_BRIDGE) += altera-freeze-bridge.o -obj-$(CONFIG_XILINX_PR_DECOUPLER) += xilinx-pr-decoupler.o # High Level Interfaces obj-$(CONFIG_FPGA_REGION) += fpga-region.o obj-$(CONFIG_OF_FPGA_REGION) += of-fpga-region.o obj-$(CONFIG_FPGA_DFL) += dfl/ +obj-$(CONFIG_FPGA_XILINX) += xilinx/
drivers/fpga/xilinx/Kconfig new file +48 -0
48 lines not on this page · raw message
drivers/fpga/xilinx/Makefile new file +6 -0
@@ -0,0 +1,6 @@ +# SPDX-License-Identifier: GPL-2.0-only + +obj-$(CONFIG_XILINX_PR_DECOUPLER) += xilinx-pr-decoupler.o +obj-$(CONFIG_FPGA_MGR_XILINX_SPI) += xilinx-spi.o +obj-$(CONFIG_FPGA_MGR_ZYNQ_FPGA) += zynq-fpga.o +obj-$(CONFIG_FPGA_MGR_ZYNQMP_FPGA) += zynqmp-fpga.o
drivers/fpga/xilinx/xilinx-pr-decoupler.c renamed from drivers/fpga/xilinx-pr-decoupler.c +0 -0
drivers/fpga/xilinx/xilinx-spi.c renamed from drivers/fpga/xilinx-spi.c +0 -0
drivers/fpga/xilinx/zynq-fpga.c renamed from drivers/fpga/zynq-fpga.c +0 -0
drivers/fpga/xilinx/zynqmp-fpga.c renamed from drivers/fpga/zynqmp-fpga.c +0 -0
Signature · 1 line
2.26.3
Re: [PATCH v2 2/4] fpga: xilinx: reorganize to subdir layout
Quoted 7 lines · On Wed, Jun 09, 2021 at 07:22:06AM -0700, [email protected] wrote:
From: Tom Rix <[email protected]>
Create a xilinx/ subdir
Move xilinx-* and zynq* files to it.
Add aKconfigandMakefileSigned-off-by Tom Rix <[email protected]>
Any specific reason why you did not add a SPDX line to the new file you created here?
{sigh}
greg k-h
kernel test robot
build botRe: [PATCH v2 2/4] fpga: xilinx: reorganize to subdir layout
In reply to [email protected]I love your patch! Perhaps something to improve:
Hi,
I love your patch! Perhaps something to improve:
[auto build test WARNING on linus/master]
[also build test WARNING on v5.13-rc6 next-20210617]
[cannot apply to xlnx/master]
[If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/trix-redhat-com/fpga-reorganize-to-subdirs/20210616-231900 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 94f0b2d4a1d0c52035aef425da5e022bd2cb1c71 config: arm-randconfig-r011-20210618 (attached as .config) compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 64720f57bea6a6bf033feef4a5751ab9c0c3b401)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
# install arm cross compiling tool for clang build
# apt-get install binutils-arm-linux-gnueabi
# https://github.com/0day-ci/linux/commit/0bd65980328487e0974bffd1493b183e2e413fbd
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review trix-redhat-com/fpga-reorganize-to-subdirs/20210616-231900 git checkout 0bd65980328487e0974bffd1493b183e2e413fbd
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm
If you fix the issue, kindly add following tag as appropriate
All warnings (new ones prefixed by >>):
drivers/fpga/xilinx/xilinx-pr-decoupler.c:37:19: warning: unused function 'xlnx_pr_decouple_read' [-Wunused-function] static inline u32 xlnx_pr_decouple_read(const struct xlnx_pr_decoupler_data *d,
^
>> drivers/fpga/xilinx/xilinx-pr-decoupler.c:92:34: warning: unused variable 'xlnx_pr_decoupler_of_match' [-Wunused-const-variable]
static const struct of_device_id xlnx_pr_decoupler_of_match[] = {
^
2 warnings generated.
--
>> drivers/fpga/xilinx/xilinx-spi.c:259:34: warning: unused variable 'xlnx_spi_of_match' [-Wunused-const-variable]
static const struct of_device_id xlnx_spi_of_match[] = {
^1 warning generated.
vim +/xlnx_pr_decoupler_of_match +92 drivers/fpga/xilinx/xilinx-pr-decoupler.c
30a2ac9a8bb5fc drivers/fpga/xilinx-pr-decoupler.c Nava kishore Manne 2021-02-11 91
7e961c12be424c drivers/fpga/xilinx-pr-decoupler.c Moritz Fischer 2017-03-24 @92 static const struct of_device_id xlnx_pr_decoupler_of_match[] = {
30a2ac9a8bb5fc drivers/fpga/xilinx-pr-decoupler.c Nava kishore Manne 2021-02-11 93 { .compatible = "xlnx,pr-decoupler-1.00", .data = &decoupler_config },
30a2ac9a8bb5fc drivers/fpga/xilinx-pr-decoupler.c Nava kishore Manne 2021-02-11 94 { .compatible = "xlnx,pr-decoupler", .data = &decoupler_config },
30a2ac9a8bb5fc drivers/fpga/xilinx-pr-decoupler.c Nava kishore Manne 2021-02-11 95 { .compatible = "xlnx,dfx-axi-shutdown-manager-1.00",
30a2ac9a8bb5fc drivers/fpga/xilinx-pr-decoupler.c Nava kishore Manne 2021-02-11 96 .data = &shutdown_config },
30a2ac9a8bb5fc drivers/fpga/xilinx-pr-decoupler.c Nava kishore Manne 2021-02-11 97 { .compatible = "xlnx,dfx-axi-shutdown-manager",
30a2ac9a8bb5fc drivers/fpga/xilinx-pr-decoupler.c Nava kishore Manne 2021-02-11 98 .data = &shutdown_config },
7e961c12be424c drivers/fpga/xilinx-pr-decoupler.c Moritz Fischer 2017-03-24 99 {},
7e961c12be424c drivers/fpga/xilinx-pr-decoupler.c Moritz Fischer 2017-03-24 100 };
7e961c12be424c drivers/fpga/xilinx-pr-decoupler.c Moritz Fischer 2017-03-24 101 MODULE_DEVICE_TABLE(of, xlnx_pr_decoupler_of_match);7e961c12be424c drivers/fpga/xilinx-pr-decoupler.c Moritz Fischer 2017-03-24 102
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
kernel test robot
build botRe: [PATCH v2 2/4] fpga: xilinx: reorganize to subdir layout
In reply to [email protected]I love your patch! Perhaps something to improve:
Hi,
I love your patch! Perhaps something to improve:
[auto build test WARNING on linus/master]
[also build test WARNING on v5.13-rc7 next-20210621]
[cannot apply to xlnx/master]
[If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/trix-redhat-com/fpga-reorganize-to-subdirs/20210616-231900 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 94f0b2d4a1d0c52035aef425da5e022bd2cb1c71 config: x86_64-randconfig-a014-20210621 (attached as .config) compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project e1adf90826a57b674eee79b071fb46c1f5683cd0)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
# https://github.com/0day-ci/linux/commit/0bd65980328487e0974bffd1493b183e2e413fbd
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review trix-redhat-com/fpga-reorganize-to-subdirs/20210616-231900 git checkout 0bd65980328487e0974bffd1493b183e2e413fbd
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
All warnings (new ones prefixed by >>):
>> drivers/fpga/xilinx/zynqmp-fpga.c:113:34: warning: unused variable 'zynqmp_fpga_of_match' [-Wunused-const-variable]
static const struct of_device_id zynqmp_fpga_of_match[] = {
^1 warning generated.
vim +/zynqmp_fpga_of_match +113 drivers/fpga/xilinx/zynqmp-fpga.c
c09f7471127e9d drivers/fpga/zynqmp-fpga.c Nava kishore Manne 2019-04-15 112
c09f7471127e9d drivers/fpga/zynqmp-fpga.c Nava kishore Manne 2019-04-15 @113 static const struct of_device_id zynqmp_fpga_of_match[] = {
c09f7471127e9d drivers/fpga/zynqmp-fpga.c Nava kishore Manne 2019-04-15 114 { .compatible = "xlnx,zynqmp-pcap-fpga", },
c09f7471127e9d drivers/fpga/zynqmp-fpga.c Nava kishore Manne 2019-04-15 115 {},
c09f7471127e9d drivers/fpga/zynqmp-fpga.c Nava kishore Manne 2019-04-15 116 };c09f7471127e9d drivers/fpga/zynqmp-fpga.c Nava kishore Manne 2019-04-15 117
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[email protected]
reviewerPATCH v2 3/4 fpga: altera: reorganize to subdir layout
In reply to [email protected]From: Tom Rix <[email protected]>
Create a altera/ subdir
Move altera-* and soc* ts73xx* files to it.
Add a Kconfig and Makefile
---
drivers/fpga/Kconfig | 70 +----------------
drivers/fpga/Makefile | 11 +--
drivers/fpga/altera/Kconfig | 78 +++++++++++++++++++
drivers/fpga/altera/Makefile | 12 +++
drivers/fpga/{ => altera}/altera-cvp.c | 0
drivers/fpga/{ => altera}/altera-fpga2sdram.c | 0
.../fpga/{ => altera}/altera-freeze-bridge.c | 0
drivers/fpga/{ => altera}/altera-hps2fpga.c | 0
.../{ => altera}/altera-pr-ip-core-plat.c | 0
drivers/fpga/{ => altera}/altera-pr-ip-core.c | 0
drivers/fpga/{ => altera}/altera-ps-spi.c | 0
drivers/fpga/{ => altera}/socfpga-a10.c | 0
drivers/fpga/{ => altera}/socfpga.c | 0
drivers/fpga/{ => altera}/stratix10-soc.c | 0
drivers/fpga/{ => altera}/ts73xx-fpga.c | 0
15 files changed, 92 insertions(+), 79 deletions(-)
create mode 100644 drivers/fpga/altera/Kconfig
create mode 100644 drivers/fpga/altera/Makefile
rename drivers/fpga/{ => altera}/altera-cvp.c (100%)
rename drivers/fpga/{ => altera}/altera-fpga2sdram.c (100%)
rename drivers/fpga/{ => altera}/altera-freeze-bridge.c (100%)
rename drivers/fpga/{ => altera}/altera-hps2fpga.c (100%)
rename drivers/fpga/{ => altera}/altera-pr-ip-core-plat.c (100%)
rename drivers/fpga/{ => altera}/altera-pr-ip-core.c (100%)
rename drivers/fpga/{ => altera}/altera-ps-spi.c (100%)
rename drivers/fpga/{ => altera}/socfpga-a10.c (100%)
rename drivers/fpga/{ => altera}/socfpga.c (100%)
rename drivers/fpga/{ => altera}/stratix10-soc.c (100%)
rename drivers/fpga/{ => altera}/ts73xx-fpga.c (100%)drivers/fpga/Kconfig +1 -69
@@ -12,52 +12,6 @@ menuconfig FPGA if FPGA -config FPGA_MGR_SOCFPGA - tristate "Altera SOCFPGA FPGA Manager" - depends on ARCH_INTEL_SOCFPGA || COMPILE_TEST - help - FPGA manager driver support for Altera SOCFPGA. - -config FPGA_MGR_SOCFPGA_A10 - tristate "Altera SoCFPGA Arria10" - depends on ARCH_INTEL_SOCFPGA || COMPILE_TEST - select REGMAP_MMIO - help - FPGA manager driver support for Altera Arria10 SoCFPGA. - -config ALTERA_PR_IP_CORE - tristate "Altera Partial Reconfiguration IP Core" - help - Core driver support for Altera Partial Reconfiguration IP component - -config ALTERA_PR_IP_CORE_PLAT - tristate "Platform support of Altera Partial Reconfiguration IP Core" - depends on ALTERA_PR_IP_CORE && OF && HAS_IOMEM - help - Platform driver support for Altera Partial Reconfiguration IP - component - -config FPGA_MGR_ALTERA_PS_SPI - tristate "Altera FPGA Passive Serial over SPI" - depends on SPI - select BITREVERSE - help - FPGA manager driver support for Altera Arria/Cyclone/Stratix - using the passive serial interface over SPI. - -config FPGA_MGR_ALTERA_CVP - tristate "Altera CvP FPGA Manager" - depends on PCI - help - FPGA manager driver support for Arria-V, Cyclone-V, Stratix-V, - Arria 10 and Stratix10 Altera FPGAs using the CvP interface over PCIe. - -config FPGA_MGR_STRATIX10_SOC - tristate "Intel Stratix10 SoC FPGA Manager" - depends on (ARCH_INTEL_SOCFPGA && INTEL_STRATIX10_SERVICE) - help - FPGA manager driver support for the Intel Stratix10 SoC. - config FPGA_MGR_ICE40_SPI tristate "Lattice iCE40 SPI" depends on OF && SPI
@@ -71,35 +25,12 @@ config FPGA_MGR_MACHXO2_SPI FPGA manager driver support for Lattice MachXO2 configuration over slave SPI interface. -config FPGA_MGR_TS73XX - tristate "Technologic Systems TS-73xx SBC FPGA Manager" - depends on ARCH_EP93XX && MACH_TS72XX - help - FPGA manager driver support for the Altera Cyclone II FPGA - present on the TS-73xx SBC boards. - config FPGA_BRIDGE tristate "FPGA Bridge Framework" help Say Y here if you want to support bridges connected between host processors and FPGAs or between FPGAs. -config SOCFPGA_FPGA_BRIDGE - tristate "Altera SoCFPGA FPGA Bridges" - depends on ARCH_INTEL_SOCFPGA && FPGA_BRIDGE - help - Say Y to enable drivers for FPGA bridges for Altera SOCFPGA - devices. - -config ALTERA_FREEZE_BRIDGE - tristate "Altera FPGA Freeze Bridge" - depends on FPGA_BRIDGE && HAS_IOMEM - help - Say Y to enable drivers for Altera FPGA Freeze bridges. A - freeze bridge is a bridge that exists in the FPGA fabric to - isolate one region of the FPGA from the busses while that - region is being reprogrammed. - config FPGA_REGION tristate "FPGA Region" depends on FPGA_BRIDGE
@@ -115,6 +46,7 @@ config OF_FPGA_REGION Support for loading FPGA images by applying a Device Tree overlay. +source "drivers/fpga/altera/Kconfig" source "drivers/fpga/dfl/Kconfig" source "drivers/fpga/xilinx/Kconfig"
drivers/fpga/Makefile +1 -10
@@ -7,25 +7,16 @@ obj-$(CONFIG_FPGA) += fpga-mgr.o # FPGA Manager Drivers -obj-$(CONFIG_FPGA_MGR_ALTERA_CVP) += altera-cvp.o -obj-$(CONFIG_FPGA_MGR_ALTERA_PS_SPI) += altera-ps-spi.o obj-$(CONFIG_FPGA_MGR_ICE40_SPI) += ice40-spi.o obj-$(CONFIG_FPGA_MGR_MACHXO2_SPI) += machxo2-spi.o -obj-$(CONFIG_FPGA_MGR_SOCFPGA) += socfpga.o -obj-$(CONFIG_FPGA_MGR_SOCFPGA_A10) += socfpga-a10.o -obj-$(CONFIG_FPGA_MGR_STRATIX10_SOC) += stratix10-soc.o -obj-$(CONFIG_FPGA_MGR_TS73XX) += ts73xx-fpga.o -obj-$(CONFIG_ALTERA_PR_IP_CORE) += altera-pr-ip-core.o -obj-$(CONFIG_ALTERA_PR_IP_CORE_PLAT) += altera-pr-ip-core-plat.o # FPGA Bridge Drivers obj-$(CONFIG_FPGA_BRIDGE) += fpga-bridge.o -obj-$(CONFIG_SOCFPGA_FPGA_BRIDGE) += altera-hps2fpga.o altera-fpga2sdram.o -obj-$(CONFIG_ALTERA_FREEZE_BRIDGE) += altera-freeze-bridge.o # High Level Interfaces obj-$(CONFIG_FPGA_REGION) += fpga-region.o obj-$(CONFIG_OF_FPGA_REGION) += of-fpga-region.o +obj-$(CONFIG_FPGA_ALTERA) += altera/ obj-$(CONFIG_FPGA_DFL) += dfl/ obj-$(CONFIG_FPGA_XILINX) += xilinx/
drivers/fpga/altera/Kconfig new file +78 -0
78 lines not on this page · raw message
drivers/fpga/altera/Makefile new file +12 -0
@@ -0,0 +1,12 @@ +# SPDX-License-Identifier: GPL-2.0-only + +obj-$(CONFIG_ALTERA_FREEZE_BRIDGE) += altera-freeze-bridge.o +obj-$(CONFIG_ALTERA_PR_IP_CORE) += altera-pr-ip-core.o +obj-$(CONFIG_ALTERA_PR_IP_CORE_PLAT) += altera-pr-ip-core-plat.o +obj-$(CONFIG_FPGA_MGR_ALTERA_CVP) += altera-cvp.o +obj-$(CONFIG_FPGA_MGR_ALTERA_PS_SPI) += altera-ps-spi.o +obj-$(CONFIG_FPGA_MGR_SOCFPGA) += socfpga.o +obj-$(CONFIG_FPGA_MGR_SOCFPGA_A10) += socfpga-a10.o +obj-$(CONFIG_FPGA_MGR_STRATIX10_SOC) += stratix10-soc.o +obj-$(CONFIG_FPGA_MGR_TS73XX) += ts73xx-fpga.o +obj-$(CONFIG_SOCFPGA_FPGA_BRIDGE) += altera-hps2fpga.o altera-fpga2sdram.o
drivers/fpga/altera/altera-cvp.c renamed from drivers/fpga/altera-cvp.c +0 -0
drivers/fpga/altera/altera-fpga2sdram.c renamed from drivers/fpga/altera-fpga2sdram.c +0 -0
drivers/fpga/altera/altera-freeze-bridge.c renamed from drivers/fpga/altera-freeze-bridge.c +0 -0
drivers/fpga/altera/altera-hps2fpga.c renamed from drivers/fpga/altera-hps2fpga.c +0 -0
drivers/fpga/altera/altera-pr-ip-core-plat.c renamed from drivers/fpga/altera-pr-ip-core-plat.c +0 -0
drivers/fpga/altera/altera-pr-ip-core.c renamed from drivers/fpga/altera-pr-ip-core.c +0 -0
drivers/fpga/altera/altera-ps-spi.c renamed from drivers/fpga/altera-ps-spi.c +0 -0
drivers/fpga/altera/socfpga-a10.c renamed from drivers/fpga/socfpga-a10.c +0 -0
drivers/fpga/altera/socfpga.c renamed from drivers/fpga/socfpga.c +0 -0
drivers/fpga/altera/stratix10-soc.c renamed from drivers/fpga/stratix10-soc.c +0 -0
drivers/fpga/altera/ts73xx-fpga.c renamed from drivers/fpga/ts73xx-fpga.c +0 -0
Signature · 1 line
2.26.3
Re: [PATCH v2 3/4] fpga: altera: reorganize to subdir layout
Quoted 5 lines · On Wed, Jun 09, 2021 at 07:22:07AM -0700, [email protected] wrote:
From: Tom Rix <[email protected]>
Create a altera/ subdir
Move altera-* and soc* ts73xx* files to it.
Add aKconfigandMakefile
Again no SPDX line?
[email protected]
reviewerPATCH v2 4/4 fpga: lattice: reorganize to subdir layout
In reply to [email protected]From: Tom Rix <[email protected]>
Create a lattice/ subdir
Move ice40* and machxo2* files to it.
Add a Kconfig and Makefile
---
drivers/fpga/Kconfig | 14 +-------------
drivers/fpga/Makefile | 13 +++++--------
drivers/fpga/lattice/Kconfig | 22 ++++++++++++++++++++++
drivers/fpga/lattice/Makefile | 4 ++++
drivers/fpga/{ => lattice}/ice40-spi.c | 0
drivers/fpga/{ => lattice}/machxo2-spi.c | 0
6 files changed, 32 insertions(+), 21 deletions(-)
create mode 100644 drivers/fpga/lattice/Kconfig
create mode 100644 drivers/fpga/lattice/Makefile
rename drivers/fpga/{ => lattice}/ice40-spi.c (100%)
rename drivers/fpga/{ => lattice}/machxo2-spi.c (100%)drivers/fpga/Kconfig +1 -13
@@ -12,19 +12,6 @@ menuconfig FPGA if FPGA -config FPGA_MGR_ICE40_SPI - tristate "Lattice iCE40 SPI" - depends on OF && SPI - help - FPGA manager driver support for Lattice iCE40 FPGAs over SPI. - -config FPGA_MGR_MACHXO2_SPI - tristate "Lattice MachXO2 SPI" - depends on SPI - help - FPGA manager driver support for Lattice MachXO2 configuration - over slave SPI interface. - config FPGA_BRIDGE tristate "FPGA Bridge Framework" help
@@ -47,6 +34,7 @@ config OF_FPGA_REGION overlay. source "drivers/fpga/altera/Kconfig" +source "drivers/fpga/lattice/Kconfig" source "drivers/fpga/dfl/Kconfig" source "drivers/fpga/xilinx/Kconfig"
drivers/fpga/Makefile +5 -8
@@ -4,19 +4,16 @@ # # Core FPGA Manager Framework -obj-$(CONFIG_FPGA) += fpga-mgr.o - -# FPGA Manager Drivers -obj-$(CONFIG_FPGA_MGR_ICE40_SPI) += ice40-spi.o -obj-$(CONFIG_FPGA_MGR_MACHXO2_SPI) += machxo2-spi.o +obj-$(CONFIG_FPGA) += fpga-mgr.o # FPGA Bridge Drivers -obj-$(CONFIG_FPGA_BRIDGE) += fpga-bridge.o +obj-$(CONFIG_FPGA_BRIDGE) += fpga-bridge.o # High Level Interfaces -obj-$(CONFIG_FPGA_REGION) += fpga-region.o -obj-$(CONFIG_OF_FPGA_REGION) += of-fpga-region.o +obj-$(CONFIG_FPGA_REGION) += fpga-region.o +obj-$(CONFIG_OF_FPGA_REGION) += of-fpga-region.o obj-$(CONFIG_FPGA_ALTERA) += altera/ obj-$(CONFIG_FPGA_DFL) += dfl/ +obj-$(CONFIG_FPGA_LATTICE) += lattice/ obj-$(CONFIG_FPGA_XILINX) += xilinx/
drivers/fpga/lattice/Kconfig new file +22 -0
@@ -0,0 +1,22 @@ +config FPGA_LATTICE + bool "Lattice Devices" + default y + help + If you have a lattice fpga, say Y. + +if FPGA_LATTICE + +config FPGA_MGR_ICE40_SPI + tristate "Lattice iCE40 SPI" + depends on OF && SPI + help + FPGA manager driver support for Lattice iCE40 FPGAs over SPI. + +config FPGA_MGR_MACHXO2_SPI + tristate "Lattice MachXO2 SPI" + depends on SPI + help + FPGA manager driver support for Lattice MachXO2 configuration + over slave SPI interface. + +endif #FPGA_LATTICE
drivers/fpga/lattice/Makefile new file +4 -0
@@ -0,0 +1,4 @@ +# SPDX-License-Identifier: GPL-2.0-only + +obj-$(CONFIG_FPGA_MGR_ICE40_SPI) += ice40-spi.o +obj-$(CONFIG_FPGA_MGR_MACHXO2_SPI) += machxo2-spi.o
drivers/fpga/lattice/ice40-spi.c renamed from drivers/fpga/ice40-spi.c +0 -0
drivers/fpga/lattice/machxo2-spi.c renamed from drivers/fpga/machxo2-spi.c +0 -0
Signature · 1 line
2.26.3
Re: [PATCH v2 4/4] fpga: lattice: reorganize to subdir layout
Quoted 7 lines · On Wed, Jun 09, 2021 at 07:22:08AM -0700, [email protected] wrote:
From: Tom Rix <[email protected]>
Create a lattice/ subdir
Move ice40* and machxo2* files to it.
Add aKconfigandMakefileSigned-off-by Tom Rix <[email protected]>
And again, no SPDX line :(
kernel test robot
build botRe: [PATCH v2 4/4] fpga: lattice: reorganize to subdir layout
In reply to [email protected]I love your patch! Perhaps something to improve:
Hi,
I love your patch! Perhaps something to improve:
[auto build test WARNING on linus/master]
[also build test WARNING on v5.13-rc6 next-20210617]
[cannot apply to xlnx/master]
[If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/trix-redhat-com/fpga-reorganize-to-subdirs/20210616-231900 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 94f0b2d4a1d0c52035aef425da5e022bd2cb1c71 config: arm-randconfig-r011-20210618 (attached as .config) compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 64720f57bea6a6bf033feef4a5751ab9c0c3b401)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
# install arm cross compiling tool for clang build
# apt-get install binutils-arm-linux-gnueabi
# https://github.com/0day-ci/linux/commit/e5f1603deb6348c4e1e0f5efe8dc8cde603279ea
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review trix-redhat-com/fpga-reorganize-to-subdirs/20210616-231900 git checkout e5f1603deb6348c4e1e0f5efe8dc8cde603279ea
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm
If you fix the issue, kindly add following tag as appropriate
All warnings (new ones prefixed by >>):
>> drivers/fpga/lattice/machxo2-spi.c:377:34: warning: unused variable 'of_match' [-Wunused-const-variable]
static const struct of_device_id of_match[] = {
^1 warning generated.
vim +/of_match +377 drivers/fpga/lattice/machxo2-spi.c
88fb3a00233073 drivers/fpga/machxo2-spi.c Paolo Pisati 2018-04-16 376
88fb3a00233073 drivers/fpga/machxo2-spi.c Paolo Pisati 2018-04-16 @377 static const struct of_device_id of_match[] = {
88fb3a00233073 drivers/fpga/machxo2-spi.c Paolo Pisati 2018-04-16 378 { .compatible = "lattice,machxo2-slave-spi", },
88fb3a00233073 drivers/fpga/machxo2-spi.c Paolo Pisati 2018-04-16 379 {}
88fb3a00233073 drivers/fpga/machxo2-spi.c Paolo Pisati 2018-04-16 380 };
88fb3a00233073 drivers/fpga/machxo2-spi.c Paolo Pisati 2018-04-16 381 MODULE_DEVICE_TABLE(of, of_match);88fb3a00233073 drivers/fpga/machxo2-spi.c Paolo Pisati 2018-04-16 382
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
Re: [PATCH v2 4/4] fpga: lattice: reorganize to subdir layout
Quoted 7 lines · kernel test robot
All warnings (new ones prefixed by >>):
Quoted 1 line
Quoted 1 line
drivers/fpga/lattice/machxo2-spi.c:377:34: warning: unused variable 'of_match' [-Wunused-const-variable]static const struct of_device_id of_match[] = { ^1 warning generated.
This is almost always the result of an 'of_match_ptr()' that should be removed, I have not
checked this instance.
Arnd
Moritz Fischer
maintainerRe: [PATCH v2 4/4] fpga: lattice: reorganize to subdir layout
Quoted 9 lines · Arnd Bergmann
Quoted 7 lines · kernel test robot
All warnings (new ones prefixed by >>):
Quoted 1 line
Quoted 1 line
drivers/fpga/lattice/machxo2-spi.c:377:34: warning: unused variable 'of_match' [-Wunused-const-variable]static const struct of_device_id of_match[] = { ^1 warning generated.
Quoted 5 lines
This is almost always the result of an '
of_match_ptr()' that should be removed, I have not
checked this instance.Arnd
I think the of_device id is missing a #CONFIG_OF
@@ -374,11 +374,13 @@ static int machxo2_spi_probe(struct spi_device *spi)
return devm_fpga_mgr_register(dev, mgr);
}
+#ifdef CONFIG_OF
static const struct of_device_id of_match[] = {
{ .compatible = "lattice,machxo2-slave-spi", },
{} };
MODULE_DEVICE_TABLE(of, of_match);
+#endif
- Moritz
Moritz Fischer
maintainerRe: [PATCH v2 4/4] fpga: lattice: reorganize to subdir layout
Quoted 21 lines · Moritz Fischer
Quoted 9 lines · Arnd Bergmann
Quoted 7 lines · kernel test robot
All warnings (new ones prefixed by >>):
Quoted 1 line
Quoted 1 line
drivers/fpga/lattice/machxo2-spi.c:377:34: warning: unused variable 'of_match' [-Wunused-const-variable]static const struct of_device_id of_match[] = { ^1 warning generated.
Quoted 5 lines
This is almost always the result of an '
of_match_ptr()' that should be removed, I have not
checked this instance.Arnd
I think the
of_deviceid is missing a #CONFIG_OF(quoted diff) +0
-0@@ -374,11 +374,13 @@ static int machxo2_spi_probe(struct spi_device *spi) return devm_fpga_mgr_register(dev, mgr); }
Review static int machxo2_spi_probe(struct spi_device *spi) · line 383
Quoted 10 lines
(quoted diff) +2
-1+#ifdef CONFIG_OF static const struct of_device_id of_match[] = { { .compatible = "lattice,machxo2-slave-spi", }, {} }; MODULE_DEVICE_TABLE(of, of_match); +#endif - Moritz
Scratch that, you're right. Sorry for the noise.
- Moritz
Quoted 8 lines · On Wed, Jun 09, 2021 at 07:22:03AM -0700, [email protected] wrote:
From: Tom Rix <[email protected]>
The incoming xrt patchset has a toplevel subdir xrt/
The current fpga/ uses a single dir with filename prefixes to subdivide owners For consistency, there should be only one way to organize the fpga/ dir. Because the subdir model scales better, refactor to use it.
The discussion wrt xrt is here:
https://lore.kernel.org/linux-fpga/[email protected]/
Why am I getting 2 copies of 0/4?
Please fix your email client...
Quoted 33 lines · On Wed, Jun 09, 2021 at 07:22:03AM -0700, [email protected] wrote:
From: Tom Rix <[email protected]>
The incoming xrt patchset has a toplevel subdir xrt/
The current fpga/ uses a single dir with filename prefixes to subdivide owners For consistency, there should be only one way to organize the fpga/ dir. Because the subdir model scales better, refactor to use it.
The discussion wrt xrt is here:
https://lore.kernel.org/linux-fpga/[email protected]/Follow
drivers/net/ethernet/which has control configsNET_VENDOR_BLAthat map todrivers/net/ethernet/blaSince fpgas do not have many vendors, drop the 'VENDOR' and useFPGA_BLA.There are several new subdirs
altera/
dfl/
lattice/
xilinx/Each subdir has a
Kconfigthat has a new/reusedif
FPGA_BLA
... existing configs ...
endifFPGA_BLAWhich is sourced into the main fpga/Kconfig
Each subdir has a
Makefilewhose transversal is controlled in the fpga/Makefile byobj-$(CONFIG_FPGA_BLA) += bla/
Quoted 7 lines
Some cleanup to arrange thing alphabetically and make fpga/Makefile's whitespace look more like net/'s
Changes from
v1
Drop renaming files
Cleanup makefiles
You can rename the files, you just can not rename the .ko objects without everyone knowing what you are doing and you trying to bury it in the middle of a differently described patch.
If you want to do that, do you? I don't really understand why you want to move things around right now other than "we have 40 files in one directory, ick!".
greg k-h
Tom Rix
reviewerQuoted 41 lines · Greg KH
Quoted 33 lines · On Wed, Jun 09, 2021 at 07:22:03AM -0700, [email protected] wrote:
From: Tom Rix <[email protected]>
The incoming xrt patchset has a toplevel subdir xrt/
The current fpga/ uses a single dir with filename prefixes to subdivide owners For consistency, there should be only one way to organize the fpga/ dir. Because the subdir model scales better, refactor to use it.
The discussion wrt xrt is here:
https://lore.kernel.org/linux-fpga/[email protected]/Follow
drivers/net/ethernet/which has control configsNET_VENDOR_BLAthat map todrivers/net/ethernet/blaSince fpgas do not have many vendors, drop the 'VENDOR' and useFPGA_BLA.There are several new subdirs
altera/
dfl/
lattice/
xilinx/Each subdir has a
Kconfigthat has a new/reusedif
FPGA_BLA
... existing configs ...
endifFPGA_BLAWhich is sourced into the main fpga/Kconfig
Each subdir has a
Makefilewhose transversal is controlled in the fpga/Makefile byobj-$(CONFIG_FPGA_BLA) += bla/
Quoted 7 lines
Some cleanup to arrange thing alphabetically and make fpga/Makefile's whitespace look more like net/'s
Changes from
v1
Drop renaming files
Cleanup makefiles
Quoted 7 lines
You can rename the files, you just can not rename the .ko objects without everyone knowing what you are doing and you trying to bury it in the middle of a differently described patch.
If you want to do that, do you? I don't really understand why you want to move things around right now other than "we have 40 files in one directory, ick!".
I am trying to resolve the layout inconsistency between what we have and what the xrt patchset does.
The big issue is the files vs dirs.
Over specified filenames is secondary, so I dropped them.
40 files in one dir is itself not a problem.
having 40 files and an xrt/ is.
fpga/ layout should be consistent so the Makefile and Kconfig are easier to maintain.
My preference is for subdir's.
Tom
Quoted 3 lines
greg k-h
Quoted 47 lines · Tom Rix
Quoted 45 lines · Greg KH
Quoted 33 lines · On Wed, Jun 09, 2021 at 07:22:03AM -0700, [email protected] wrote:
From: Tom Rix <[email protected]>
The incoming xrt patchset has a toplevel subdir xrt/
The current fpga/ uses a single dir with filename prefixes to subdivide owners For consistency, there should be only one way to organize the fpga/ dir. Because the subdir model scales better, refactor to use it.
The discussion wrt xrt is here:
https://lore.kernel.org/linux-fpga/[email protected]/Follow
drivers/net/ethernet/which has control configsNET_VENDOR_BLAthat map todrivers/net/ethernet/blaSince fpgas do not have many vendors, drop the 'VENDOR' and useFPGA_BLA.There are several new subdirs
altera/
dfl/
lattice/
xilinx/Each subdir has a
Kconfigthat has a new/reusedif
FPGA_BLA
... existing configs ...
endifFPGA_BLAWhich is sourced into the main fpga/Kconfig
Each subdir has a
Makefilewhose transversal is controlled in the fpga/Makefile byobj-$(CONFIG_FPGA_BLA) += bla/
Quoted 7 lines
Some cleanup to arrange thing alphabetically and make fpga/Makefile's whitespace look more like net/'s
Changes from
v1
Drop renaming files
Cleanup makefilesYou can rename the files, you just can not rename the .ko objects without everyone knowing what you are doing and you trying to bury it in the middle of a differently described patch.
Quoted 6 lines
Quoted 3 lines
If you want to do that, do you? I don't really understand why you want to move things around right now other than "we have 40 files in one directory, ick!".
I am trying to resolve the layout inconsistency between what we have and what the xrt patchset does.
Why does it matter? New stuff can be added to a new dir, why worry about old stuff? What does it hurt?
Quoted 7 lines
The big issue is the files vs dirs.
Over specified filenames is secondary, so I dropped them.
40 files in one dir is itself not a problem.
having 40 files and an xrt/ is.
Why is that a "problem"?
Quoted 2 lines
fpga/ layout should be consistent so the
MakefileandKconfigare easier to maintain.
Is it somehow hard to maintain today? Seems pretty trivial to me...
thanks,
greg k-h
Tom Rix
reviewerQuoted 59 lines · Greg KH
Quoted 46 lines · Tom Rix
Quoted 45 lines · Greg KH
Quoted 33 lines · On Wed, Jun 09, 2021 at 07:22:03AM -0700, [email protected] wrote:
From: Tom Rix <[email protected]>
The incoming xrt patchset has a toplevel subdir xrt/
The current fpga/ uses a single dir with filename prefixes to subdivide owners For consistency, there should be only one way to organize the fpga/ dir. Because the subdir model scales better, refactor to use it.
The discussion wrt xrt is here:
https://lore.kernel.org/linux-fpga/[email protected]/Follow
drivers/net/ethernet/which has control configsNET_VENDOR_BLAthat map todrivers/net/ethernet/blaSince fpgas do not have many vendors, drop the 'VENDOR' and useFPGA_BLA.There are several new subdirs
altera/
dfl/
lattice/
xilinx/Each subdir has a
Kconfigthat has a new/reusedif
FPGA_BLA
... existing configs ...
endifFPGA_BLAWhich is sourced into the main fpga/Kconfig
Each subdir has a
Makefilewhose transversal is controlled in the fpga/Makefile byobj-$(CONFIG_FPGA_BLA) += bla/
Quoted 7 lines
Some cleanup to arrange thing alphabetically and make fpga/Makefile's whitespace look more like net/'s
Changes from
v1
Drop renaming files
Cleanup makefilesYou can rename the files, you just can not rename the .ko objects without everyone knowing what you are doing and you trying to bury it in the middle of a differently described patch.
Quoted 5 lines
Quoted 3 lines
If you want to do that, do you? I don't really understand why you want to move things around right now other than "we have 40 files in one directory, ick!".
I am trying to resolve the layout inconsistency between what we have and what the xrt patchset does.
Why does it matter? New stuff can be added to a new dir, why worry about old stuff? What does it hurt?
Quoted 4 lines
The big issue is the files vs dirs.
Over specified filenames is secondary, so I dropped them.
Quoted 8 lines
Quoted 3 lines
40 files in one dir is itself not a problem.
having 40 files and an xrt/ is.
Why is that a "problem"?
Quoted 2 lines
fpga/ layout should be consistent so the
MakefileandKconfigare easier to maintain.Is it somehow hard to maintain today? Seems pretty trivial to me...
This change was to help move xrt along.
If you are fine with xrt/, I will drop this patchset.
Tom
Quoted 5 lines
thanks,
greg k-h
Quoted 66 lines · Tom Rix
Quoted 64 lines · Greg KH
Quoted 46 lines · Tom Rix
Quoted 45 lines · Greg KH
Quoted 33 lines · On Wed, Jun 09, 2021 at 07:22:03AM -0700, [email protected] wrote:
From: Tom Rix <[email protected]>
The incoming xrt patchset has a toplevel subdir xrt/
The current fpga/ uses a single dir with filename prefixes to subdivide owners For consistency, there should be only one way to organize the fpga/ dir. Because the subdir model scales better, refactor to use it.
The discussion wrt xrt is here:
https://lore.kernel.org/linux-fpga/[email protected]/Follow
drivers/net/ethernet/which has control configsNET_VENDOR_BLAthat map todrivers/net/ethernet/blaSince fpgas do not have many vendors, drop the 'VENDOR' and useFPGA_BLA.There are several new subdirs
altera/
dfl/
lattice/
xilinx/Each subdir has a
Kconfigthat has a new/reusedif
FPGA_BLA
... existing configs ...
endifFPGA_BLAWhich is sourced into the main fpga/Kconfig
Each subdir has a
Makefilewhose transversal is controlled in the fpga/Makefile byobj-$(CONFIG_FPGA_BLA) += bla/
Quoted 7 lines
Some cleanup to arrange thing alphabetically and make fpga/Makefile's whitespace look more like net/'s
Changes from
v1
Drop renaming files
Cleanup makefilesYou can rename the files, you just can not rename the .ko objects without everyone knowing what you are doing and you trying to bury it in the middle of a differently described patch.
Quoted 5 lines
Quoted 3 lines
If you want to do that, do you? I don't really understand why you want to move things around right now other than "we have 40 files in one directory, ick!".
I am trying to resolve the layout inconsistency between what we have and what the xrt patchset does.
Why does it matter? New stuff can be added to a new dir, why worry about old stuff? What does it hurt?
Quoted 7 lines
The big issue is the files vs dirs.
Over specified filenames is secondary, so I dropped them.
40 files in one dir is itself not a problem.
having 40 files and an xrt/ is.
Why is that a "problem"?
Quoted 7 lines
Quoted 3 lines
Quoted 2 lines
fpga/ layout should be consistent so the
MakefileandKconfigare easier to maintain.Is it somehow hard to maintain today? Seems pretty trivial to me...
This change was to help move xrt along.
If you are fine with xrt/, I will drop this patchset.
Who has objected to xrt/ being the only new subdirectory?
My main complaints here are:
- these patches were not tested
- you renamed kernel modules "accidentally"
- you forgot SPDX lines
- lack of description of why these files being moved was necessary in the changelog where you moved the files
Remember, patch 0/X never shows up in changelogs...
You can do better :)
greg k-h
Tom Rix
reviewerQuoted 66 lines · Greg KH
Quoted 65 lines · Tom Rix
Quoted 64 lines · Greg KH
Quoted 46 lines · Tom Rix
Quoted 45 lines · Greg KH
Quoted 33 lines · On Wed, Jun 09, 2021 at 07:22:03AM -0700, [email protected] wrote:
From: Tom Rix <[email protected]>
The incoming xrt patchset has a toplevel subdir xrt/
The current fpga/ uses a single dir with filename prefixes to subdivide owners For consistency, there should be only one way to organize the fpga/ dir. Because the subdir model scales better, refactor to use it.
The discussion wrt xrt is here:
https://lore.kernel.org/linux-fpga/[email protected]/Follow
drivers/net/ethernet/which has control configsNET_VENDOR_BLAthat map todrivers/net/ethernet/blaSince fpgas do not have many vendors, drop the 'VENDOR' and useFPGA_BLA.There are several new subdirs
altera/
dfl/
lattice/
xilinx/Each subdir has a
Kconfigthat has a new/reusedif
FPGA_BLA
... existing configs ...
endifFPGA_BLAWhich is sourced into the main fpga/Kconfig
Each subdir has a
Makefilewhose transversal is controlled in the fpga/Makefile byobj-$(CONFIG_FPGA_BLA) += bla/
Quoted 7 lines
Some cleanup to arrange thing alphabetically and make fpga/Makefile's whitespace look more like net/'s
Changes from
v1
Drop renaming files
Cleanup makefilesYou can rename the files, you just can not rename the .ko objects without everyone knowing what you are doing and you trying to bury it in the middle of a differently described patch.
Quoted 5 lines
Quoted 3 lines
If you want to do that, do you? I don't really understand why you want to move things around right now other than "we have 40 files in one directory, ick!".
I am trying to resolve the layout inconsistency between what we have and what the xrt patchset does.
Why does it matter? New stuff can be added to a new dir, why worry about old stuff? What does it hurt?
Quoted 7 lines
The big issue is the files vs dirs.
Over specified filenames is secondary, so I dropped them.
40 files in one dir is itself not a problem.
having 40 files and an xrt/ is.
Why is that a "problem"?
Quoted 7 lines
Quoted 6 lines
Quoted 3 lines
Quoted 2 lines
fpga/ layout should be consistent so the
MakefileandKconfigare easier to maintain.Is it somehow hard to maintain today? Seems pretty trivial to me...
This change was to help move xrt along.
If you are fine with xrt/, I will drop this patchset.
Who has objected to xrt/ being the only new subdirectory?
Maybe just me, but it has been mostly me doing the review.
all of my easy comments have been nearly resolved.
now I am looking at bigger issues like this, should subdev's move out of fpga/ etc.
Quoted 9 lines
My main complaints here are:
- these patches were not tested
- you renamed kernel modules "accidentally"
- you forgot SPDX lines
- lack of description of why these files being moved was necessary in the changelog where you moved the filesRemember, patch 0/X never shows up in changelogs...
I will respin and collapse the patches to a single patch with a better commit log.
They aren't really useful except as a full change.
Testing will be done for dfl.
Tom
Quoted 5 lines
You can do better :)
greg k-h
Quoted 11 lines · Tom Rix
Quoted 8 lines
My main complaints here are:
- these patches were not tested
- you renamed kernel modules "accidentally"
- you forgot SPDX lines
- lack of description of why these files being moved was necessary in the changelog where you moved the filesRemember, patch 0/X never shows up in changelogs...
I will respin and collapse the patches to a single patch with a better commit log.
They should not be a single patch, I never said that at all :(
Please read what I wrote above, did I ever mention there was too many patches in the series here?
{sigh}
greg k-h