Skip to contentSkip to conversation

ipwireless: remove unused ipw_tty::closing

PATCH In review Jiri Slaby 2 participants 2 messages Jun 10, 2021 TTY layer and serial drivers

lore
Share & tools
lore

Jiri Slaby

author
#0 lore raw

PATCH 1/1 ipwireless: remove unused ipw_tty::closing

It's only set, but never read.

Cc Jiri Kosina <[email protected]>
Cc David Sterba <[email protected]>
---
 drivers/tty/ipwireless/tty.c | 2 --
 1 file changed, 2 deletions(-)
drivers/tty/ipwireless/tty.c +0 -2
index e01ca68f24f4..e3a5a5ba752c 100644
@@ -54,7 +54,6 @@ struct ipw_tty {
 	unsigned int control_lines;
 	struct mutex ipw_tty_mutex;
 	int tx_bytes_queued;
-	int closing;
 };
 
 static struct ipw_tty *ttys[IPWIRELESS_PCMCIA_MINORS];
@@ -525,7 +524,6 @@ void ipwireless_tty_free(struct ipw_tty *tty)
 				printk(KERN_INFO IPWIRELESS_PCCARD_NAME
 				       ": deregistering %s device ttyIPWp%d\n",
 				       tty_type_name(ttyj->tty_type), j);
-			ttyj->closing = 1;
 			if (ttyj->port.tty != NULL) {
 				mutex_unlock(&ttyj->ipw_tty_mutex);
 				tty_vhangup(ttyj->port.tty);
Signature · 1 line
2.32.0
#1 lore raw
Quoted 1 line · Jiri Slaby

It's only set, but never read.

Thanks. Please update the changelog with:

Commit 01261cb94318 ("tty: ipwireless: Remove tty->closing abort from ipw_open()") removed last use of tty::closing.