Skip to contentSkip to conversation

Add support for querying hw info that UMDs need

PATCH In review [email protected] 8 participants 20 messages Jun 10, 2021 – Jul 20, 2021

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

cover Add support for querying hw info that UMDs need

From: John Harrison <[email protected]>

Various UMDs require hardware configuration information about the current platform. A bunch of static information is available in a fixed table that can be retrieved from the GuC. Further information can be calculated dynamically from fuse registers.

John Harrison (2):
drm/i915/guc: Add fetch of hwconfig table
drm/i915/uapi: Add query for L3 bank count

Rodrigo Vivi (1):
drm/i915/uapi: Add query for hwconfig table

 drivers/gpu/drm/i915/Makefile                 |   1 +
 drivers/gpu/drm/i915/gt/intel_gt.c            |  15 ++
 drivers/gpu/drm/i915/gt/intel_gt.h            |   1 +
 .../gpu/drm/i915/gt/intel_hwconfig_types.h    | 102 +++++++++++
 .../gpu/drm/i915/gt/uc/abi/guc_actions_abi.h  |   1 +
 .../gpu/drm/i915/gt/uc/abi/guc_errors_abi.h   |   4 +
 drivers/gpu/drm/i915/gt/uc/intel_guc.c        |   3 +-
 drivers/gpu/drm/i915/gt/uc/intel_guc.h        |   2 +
 .../gpu/drm/i915/gt/uc/intel_guc_hwconfig.c   | 167 ++++++++++++++++++
 .../gpu/drm/i915/gt/uc/intel_guc_hwconfig.h   |  19 ++
 drivers/gpu/drm/i915/gt/uc/intel_uc.c         |   6 +
 drivers/gpu/drm/i915/i915_query.c             |  45 +++++
 drivers/gpu/drm/i915/i915_reg.h               |   1 +
 include/uapi/drm/i915_drm.h                   |   2 +
 14 files changed, 368 insertions(+), 1 deletion(-)
 create mode 100644 drivers/gpu/drm/i915/gt/intel_hwconfig_types.h
 create mode 100644 drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c
 create mode 100644 drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.h
Signature · 1 line
2.25.1
#1 lore raw

PATCH 1/3 drm/i915/guc: Add fetch of hwconfig table

From: John Harrison <[email protected]>

Implement support for fetching the hardware description table from the GuC. The call is made twice - once without a destination buffer to query the size and then a second time to fill in the buffer.

This patch also adds a header file which lists all the attribute values currently defined for the table. This is included for reference as these are not currently used by the i915 driver itself.

Note that the table is only available on ADL-P and later platforms.

---
 drivers/gpu/drm/i915/Makefile                 |   1 +
 .../gpu/drm/i915/gt/intel_hwconfig_types.h    | 102 +++++++++++
 .../gpu/drm/i915/gt/uc/abi/guc_actions_abi.h  |   1 +
 .../gpu/drm/i915/gt/uc/abi/guc_errors_abi.h   |   4 +
 drivers/gpu/drm/i915/gt/uc/intel_guc.c        |   3 +-
 drivers/gpu/drm/i915/gt/uc/intel_guc.h        |   2 +
 .../gpu/drm/i915/gt/uc/intel_guc_hwconfig.c   | 167 ++++++++++++++++++
 .../gpu/drm/i915/gt/uc/intel_guc_hwconfig.h   |  19 ++
 drivers/gpu/drm/i915/gt/uc/intel_uc.c         |   6 +
 9 files changed, 304 insertions(+), 1 deletion(-)
 create mode 100644 drivers/gpu/drm/i915/gt/intel_hwconfig_types.h
 create mode 100644 drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c
 create mode 100644 drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.h
drivers/gpu/drm/i915/Makefile +1 -0
index 2adb6b420c7c..8e957ca7c9f1 100644
@@ -187,6 +187,7 @@ i915-y += gt/uc/intel_uc.o \
 	  gt/uc/intel_guc_log.o \
 	  gt/uc/intel_guc_log_debugfs.o \
 	  gt/uc/intel_guc_submission.o \
+	  gt/uc/intel_guc_hwconfig.o \
 	  gt/uc/intel_huc.o \
 	  gt/uc/intel_huc_debugfs.o \
 	  gt/uc/intel_huc_fw.o
drivers/gpu/drm/i915/gt/intel_hwconfig_types.h new file +102 -0

102 lines not on this page · raw message

drivers/gpu/drm/i915/gt/uc/abi/guc_actions_abi.h +1 -0
index 90efef8a73e4..075f56a040b7 100644
@@ -19,6 +19,7 @@ enum intel_guc_action {
 	INTEL_GUC_ACTION_EXIT_S_STATE = 0x502,
 	INTEL_GUC_ACTION_SLPC_REQUEST = 0x3003,
 	INTEL_GUC_ACTION_AUTHENTICATE_HUC = 0x4000,
+	INTEL_GUC_ACTION_GET_HWCONFIG = 0x4100,
 	INTEL_GUC_ACTION_REGISTER_COMMAND_TRANSPORT_BUFFER = 0x4505,
 	INTEL_GUC_ACTION_DEREGISTER_COMMAND_TRANSPORT_BUFFER = 0x4506,
 	INTEL_GUC_ACTION_LIMIT
drivers/gpu/drm/i915/gt/uc/abi/guc_errors_abi.h +4 -0
index 488b6061ee89..f9e2a6aaef4a 100644
@@ -8,6 +8,10 @@
 
 enum intel_guc_response_status {
 	INTEL_GUC_RESPONSE_STATUS_SUCCESS = 0x0,
+	INTEL_GUC_RESPONSE_NOT_SUPPORTED = 0x20,
+	INTEL_GUC_RESPONSE_NO_ATTRIBUTE_TABLE = 0x201,
+	INTEL_GUC_RESPONSE_NO_DECRYPTION_KEY = 0x202,
+	INTEL_GUC_RESPONSE_DECRYPTION_FAILED = 0x204,
 	INTEL_GUC_RESPONSE_STATUS_GENERIC_FAIL = 0xF000,
 };
 
drivers/gpu/drm/i915/gt/uc/intel_guc.c +2 -1
index f147cb389a20..01839d5eb130 100644
@@ -407,13 +407,14 @@ int intel_guc_send_mmio(struct intel_guc *guc, const u32 *action, u32 len,
 	/*
 	 * No GuC command should ever take longer than 10ms.
 	 * Fast commands should still complete in 10us.
+	 * Except for the hwconfig table query, which takes ~50ms.
 	 */
 	ret = __intel_wait_for_register_fw(uncore,
 					   guc_send_reg(guc, 0),
 					   INTEL_GUC_MSG_TYPE_MASK,
 					   INTEL_GUC_MSG_TYPE_RESPONSE <<
 					   INTEL_GUC_MSG_TYPE_SHIFT,
-					   10, 10, &status);
+					   10, 100, &status);
 	/* If GuC explicitly returned an error, convert it to -EIO */
 	if (!ret && !INTEL_GUC_MSG_IS_RESPONSE_SUCCESS(status))
 		ret = -EIO;
drivers/gpu/drm/i915/gt/uc/intel_guc.h +2 -0
index 4abc59f6f3cd..8307de463af0 100644
@@ -12,6 +12,7 @@
 #include "intel_guc_ct.h"
 #include "intel_guc_log.h"
 #include "intel_guc_reg.h"
+#include "intel_guc_hwconfig.h"
 #include "intel_uc_fw.h"
 #include "i915_utils.h"
 #include "i915_vma.h"
@@ -27,6 +28,7 @@ struct intel_guc {
 	struct intel_uc_fw fw;
 	struct intel_guc_log log;
 	struct intel_guc_ct ct;
+	struct intel_guc_hwconfig hwconfig;
 
 	/* intel_guc_recv interrupt related state */
 	spinlock_t irq_lock;
drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c new file +167 -0

167 lines not on this page · raw message

drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.h new file +19 -0
new file mode 100644
index 000000000000..91e96d88d713
@@ -0,0 +1,19 @@
+/* SPDX-License-Identifier: MIT */
+/*
+ * Copyright © 2020 Intel Corporation
+ */
+
+#ifndef _INTEL_GUC_HWCONFIG_H_
+#define _INTEL_GUC_HWCONFIG_H_
+
+#include <linux/types.h>
+
+struct intel_guc_hwconfig {
+	u32 size;
+	void *ptr;
+};
+
+int intel_guc_hwconfig_init(struct intel_guc_hwconfig *hwconfig);
+void intel_guc_hwconfig_fini(struct intel_guc_hwconfig *hwconfig);
+
+#endif /* _INTEL_GUC_HWCONFIG_H_ */
drivers/gpu/drm/i915/gt/uc/intel_uc.c +6 -0
index 6d8b9233214e..b289693f9767 100644
@@ -502,6 +502,10 @@ static int __uc_init_hw(struct intel_uc *uc)
 
 	intel_huc_auth(huc);
 
+	ret = intel_guc_hwconfig_init(&guc->hwconfig);
+	if (ret)
+		goto err_log_capture;
+
 	if (intel_uc_uses_guc_submission(uc))
 		intel_guc_submission_enable(guc);
 
@@ -552,6 +556,8 @@ static void __uc_fini_hw(struct intel_uc *uc)
 	if (intel_uc_uses_guc_submission(uc))
 		intel_guc_submission_disable(guc);
 
+	intel_guc_hwconfig_fini(&guc->hwconfig);
+
 	__uc_sanitize(uc);
 }
 
Signature · 6 lines
2.25.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#2 lore raw

Re: [PATCH 1/3] drm/i915/guc: Add fetch of hwconfig table

Quoted 420 lines · On Thu, Jun 10, 2021 at 01:46:24PM -0700, [email protected] wrote:

From: John Harrison <[email protected]>

Implement support for fetching the hardware description table from the GuC. The call is made twice - once without a destination buffer to query the size and then a second time to fill in the buffer.

This patch also adds a header file which lists all the attribute values currently defined for the table. This is included for reference as these are not currently used by the i915 driver itself.

Note that the table is only available on ADL-P and later platforms.

---
 drivers/gpu/drm/i915/Makefile                 |   1 +
 .../gpu/drm/i915/gt/intel_hwconfig_types.h    | 102 +++++++++++
 .../gpu/drm/i915/gt/uc/abi/guc_actions_abi.h  |   1 +
 .../gpu/drm/i915/gt/uc/abi/guc_errors_abi.h   |   4 +
 drivers/gpu/drm/i915/gt/uc/intel_guc.c        |   3 +-
 drivers/gpu/drm/i915/gt/uc/intel_guc.h        |   2 +
 .../gpu/drm/i915/gt/uc/intel_guc_hwconfig.c   | 167 ++++++++++++++++++
 .../gpu/drm/i915/gt/uc/intel_guc_hwconfig.h   |  19 ++
 drivers/gpu/drm/i915/gt/uc/intel_uc.c         |   6 +
 9 files changed, 304 insertions(+), 1 deletion(-)
 create mode 100644 drivers/gpu/drm/i915/gt/intel_hwconfig_types.h
 create mode 100644 drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c
 create mode 100644 drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.h
drivers/gpu/drm/i915/Makefile +1 -0
index 2adb6b420c7c..8e957ca7c9f1 100644
@@ -187,6 +187,7 @@ i915-y += gt/uc/intel_uc.o \
 	  gt/uc/intel_guc_log.o \
 	  gt/uc/intel_guc_log_debugfs.o \
 	  gt/uc/intel_guc_submission.o \
+	  gt/uc/intel_guc_hwconfig.o \
 	  gt/uc/intel_huc.o \
 	  gt/uc/intel_huc_debugfs.o \
 	  gt/uc/intel_huc_fw.o
drivers/gpu/drm/i915/gt/intel_hwconfig_types.h new file +102 -0
new file mode 100644
index 000000000000..b09c0f65b93a
@@ -0,0 +1,102 @@
+/* SPDX-License-Identifier: MIT */
+/*
+ * Copyright © 2020 Intel Corporation
+ */
+
+#ifndef _INTEL_HWCONFIG_TYPES_H_
+#define _INTEL_HWCONFIG_TYPES_H_
+
+/**
+ * enum intel_hwconfig - Global definition of hwconfig table attributes
+ *
+ * Intel devices provide a KLV (Key/Length/Value) table containing
+ * the static hardware configuration for that platform.
+ * This header defines the current attribute keys for this KLV.
+ */
+enum intel_hwconfig {
+	INTEL_HWCONFIG_MAX_SLICES_SUPPORTED = 1,
+	INTEL_HWCONFIG_MAX_DUAL_SUBSLICES_SUPPORTED,		/* 2 */
+	INTEL_HWCONFIG_MAX_NUM_EU_PER_DSS,			/* 3 */
+	INTEL_HWCONFIG_NUM_PIXEL_PIPES,				/* 4 */
+	INTEL_HWCONFIG_DEPRECATED_MAX_NUM_GEOMETRY_PIPES,	/* 5 */
+	INTEL_HWCONFIG_DEPRECATED_L3_CACHE_SIZE_IN_KB,		/* 6 */
+	INTEL_HWCONFIG_DEPRECATED_L3_BANK_COUNT,		/* 7 */
+	INTEL_HWCONFIG_L3_CACHE_WAYS_SIZE_IN_BYTES,		/* 8 */
+	INTEL_HWCONFIG_L3_CACHE_WAYS_PER_SECTOR,		/* 9 */
+	INTEL_HWCONFIG_MAX_MEMORY_CHANNELS,			/* 10 */
+	INTEL_HWCONFIG_MEMORY_TYPE,				/* 11 */
+	INTEL_HWCONFIG_CACHE_TYPES,                             /* 12 */
+	INTEL_HWCONFIG_LOCAL_MEMORY_PAGE_SIZES_SUPPORTED,	/* 13 */
+	INTEL_HWCONFIG_DEPRECATED_SLM_SIZE_IN_KB,		/* 14 */
+	INTEL_HWCONFIG_NUM_THREADS_PER_EU,			/* 15 */
+	INTEL_HWCONFIG_TOTAL_VS_THREADS,			/* 16 */
+	INTEL_HWCONFIG_TOTAL_GS_THREADS,			/* 17 */
+	INTEL_HWCONFIG_TOTAL_HS_THREADS,			/* 18 */
+	INTEL_HWCONFIG_TOTAL_DS_THREADS,			/* 19 */
+	INTEL_HWCONFIG_TOTAL_VS_THREADS_POCS,			/* 20 */
+	INTEL_HWCONFIG_TOTAL_PS_THREADS,			/* 21 */
+	INTEL_HWCONFIG_DEPRECATED_MAX_FILL_RATE,		/* 22 */
+	INTEL_HWCONFIG_MAX_RCS,					/* 23 */
+	INTEL_HWCONFIG_MAX_CCS,					/* 24 */
+	INTEL_HWCONFIG_MAX_VCS,					/* 25 */
+	INTEL_HWCONFIG_MAX_VECS,				/* 26 */
+	INTEL_HWCONFIG_MAX_COPY_CS,				/* 27 */
+	INTEL_HWCONFIG_DEPRECATED_URB_SIZE_IN_KB,		/* 28 */
+	INTEL_HWCONFIG_MIN_VS_URB_ENTRIES,			/* 29 */
+	INTEL_HWCONFIG_MAX_VS_URB_ENTRIES,			/* 30 */
+	INTEL_HWCONFIG_MIN_PCS_URB_ENTRIES,			/* 31 */
+	INTEL_HWCONFIG_MAX_PCS_URB_ENTRIES,			/* 32 */
+	INTEL_HWCONFIG_MIN_HS_URB_ENTRIES,			/* 33 */
+	INTEL_HWCONFIG_MAX_HS_URB_ENTRIES,			/* 34 */
+	INTEL_HWCONFIG_MIN_GS_URB_ENTRIES,			/* 35 */
+	INTEL_HWCONFIG_MAX_GS_URB_ENTRIES,			/* 36 */
+	INTEL_HWCONFIG_MIN_DS_URB_ENTRIES,			/* 37 */
+	INTEL_HWCONFIG_MAX_DS_URB_ENTRIES,			/* 38 */
+	INTEL_HWCONFIG_PUSH_CONSTANT_URB_RESERVED_SIZE,		/* 39 */
+	INTEL_HWCONFIG_POCS_PUSH_CONSTANT_URB_RESERVED_SIZE,	/* 40 */
+	INTEL_HWCONFIG_URB_REGION_ALIGNMENT_SIZE_IN_BYTES,	/* 41 */
+	INTEL_HWCONFIG_URB_ALLOCATION_SIZE_UNITS_IN_BYTES,	/* 42 */
+	INTEL_HWCONFIG_MAX_URB_SIZE_CCS_IN_BYTES,		/* 43 */
+	INTEL_HWCONFIG_VS_MIN_DEREF_BLOCK_SIZE_HANDLE_COUNT,	/* 44 */
+	INTEL_HWCONFIG_DS_MIN_DEREF_BLOCK_SIZE_HANDLE_COUNT,	/* 45 */
+	INTEL_HWCONFIG_NUM_RT_STACKS_PER_DSS,			/* 46 */
+	INTEL_HWCONFIG_MAX_URB_STARTING_ADDRESS,		/* 47 */
+	INTEL_HWCONFIG_MIN_CS_URB_ENTRIES,			/* 48 */
+	INTEL_HWCONFIG_MAX_CS_URB_ENTRIES,			/* 49 */
+	INTEL_HWCONFIG_L3_ALLOC_PER_BANK_URB,			/* 50 */
+	INTEL_HWCONFIG_L3_ALLOC_PER_BANK_REST,			/* 51 */
+	INTEL_HWCONFIG_L3_ALLOC_PER_BANK_DC,			/* 52 */
+	INTEL_HWCONFIG_L3_ALLOC_PER_BANK_RO,			/* 53 */
+	INTEL_HWCONFIG_L3_ALLOC_PER_BANK_Z,			/* 54 */
+	INTEL_HWCONFIG_L3_ALLOC_PER_BANK_COLOR,			/* 55 */
+	INTEL_HWCONFIG_L3_ALLOC_PER_BANK_UNIFIED_TILE_CACHE,	/* 56 */
+	INTEL_HWCONFIG_L3_ALLOC_PER_BANK_COMMAND_BUFFER,	/* 57 */
+	INTEL_HWCONFIG_L3_ALLOC_PER_BANK_RW,			/* 58 */
+	INTEL_HWCONFIG_MAX_NUM_L3_CONFIGS,			/* 59 */
+	INTEL_HWCONFIG_BINDLESS_SURFACE_OFFSET_BIT_COUNT,	/* 60 */
+	INTEL_HWCONFIG_RESERVED_CCS_WAYS,			/* 61 */
+	INTEL_HWCONFIG_CSR_SIZE_IN_MB,				/* 62 */
+	INTEL_HWCONFIG_GEOMETRY_PIPES_PER_SLICE,		/* 63 */
+	INTEL_HWCONFIG_L3_BANK_SIZE_IN_KB,			/* 64 */
+	INTEL_HWCONFIG_SLM_SIZE_PER_DSS,			/* 65 */
+	INTEL_HWCONFIG_MAX_PIXEL_FILL_RATE_PER_SLICE,		/* 66 */
+	INTEL_HWCONFIG_MAX_PIXEL_FILL_RATE_PER_DSS,		/* 67 */
+	INTEL_HWCONFIG_URB_SIZE_PER_SLICE_IN_KB,		/* 68 */
+	INTEL_HWCONFIG_URB_SIZE_PER_L3_BANK_COUNT_IN_KB,	/* 69 */
+	INTEL_HWCONFIG_MAX_SUBSLICE,				/* 70 */
+	INTEL_HWCONFIG_MAX_EU_PER_SUBSLICE,			/* 71 */
+	INTEL_HWCONFIG_RAMBO_L3_BANK_SIZE_IN_KB,		/* 72 */
+	INTEL_HWCONFIG_SLM_SIZE_PER_SS_IN_KB,			/* 73 */
+	__INTEL_HWCONFIG_LIMIT
+};
+
+enum {
+	INTEL_HWCONFIG_MEMORY_TYPE_LPDDR4 = 0,
+	INTEL_HWCONFIG_MEMORY_TYPE_LPDDR5,
+};
+
+#define INTEL_HWCONFIG_CACHE_TYPE_L3	BIT(0)
+#define INTEL_HWCONFIG_CACHE_TYPE_LLC	BIT(1)
+#define INTEL_HWCONFIG_CACHE_TYPE_EDRAM	BIT(2)
+
+#endif /* _INTEL_HWCONFIG_TYPES_H_ */
drivers/gpu/drm/i915/gt/uc/abi/guc_actions_abi.h +1 -0
index 90efef8a73e4..075f56a040b7 100644
@@ -19,6 +19,7 @@ enum intel_guc_action {
 	INTEL_GUC_ACTION_EXIT_S_STATE = 0x502,
 	INTEL_GUC_ACTION_SLPC_REQUEST = 0x3003,
 	INTEL_GUC_ACTION_AUTHENTICATE_HUC = 0x4000,
+	INTEL_GUC_ACTION_GET_HWCONFIG = 0x4100,
 	INTEL_GUC_ACTION_REGISTER_COMMAND_TRANSPORT_BUFFER = 0x4505,
 	INTEL_GUC_ACTION_DEREGISTER_COMMAND_TRANSPORT_BUFFER = 0x4506,
 	INTEL_GUC_ACTION_LIMIT
drivers/gpu/drm/i915/gt/uc/abi/guc_errors_abi.h +4 -0
index 488b6061ee89..f9e2a6aaef4a 100644
@@ -8,6 +8,10 @@
 
 enum intel_guc_response_status {
 	INTEL_GUC_RESPONSE_STATUS_SUCCESS = 0x0,
+	INTEL_GUC_RESPONSE_NOT_SUPPORTED = 0x20,
+	INTEL_GUC_RESPONSE_NO_ATTRIBUTE_TABLE = 0x201,
+	INTEL_GUC_RESPONSE_NO_DECRYPTION_KEY = 0x202,
+	INTEL_GUC_RESPONSE_DECRYPTION_FAILED = 0x204,
 	INTEL_GUC_RESPONSE_STATUS_GENERIC_FAIL = 0xF000,
 };
 
drivers/gpu/drm/i915/gt/uc/intel_guc.c +2 -1
index f147cb389a20..01839d5eb130 100644
@@ -407,13 +407,14 @@ int intel_guc_send_mmio(struct intel_guc *guc, const u32 *action, u32 len,
 	/*
 	 * No GuC command should ever take longer than 10ms.
 	 * Fast commands should still complete in 10us.
+	 * Except for the hwconfig table query, which takes ~50ms.
 	 */
 	ret = __intel_wait_for_register_fw(uncore,
 					   guc_send_reg(guc, 0),
 					   INTEL_GUC_MSG_TYPE_MASK,
 					   INTEL_GUC_MSG_TYPE_RESPONSE <<
 					   INTEL_GUC_MSG_TYPE_SHIFT,
-					   10, 10, &status);
+					   10, 100, &status);
 	/* If GuC explicitly returned an error, convert it to -EIO */
 	if (!ret && !INTEL_GUC_MSG_IS_RESPONSE_SUCCESS(status))
 		ret = -EIO;
drivers/gpu/drm/i915/gt/uc/intel_guc.h +2 -0
index 4abc59f6f3cd..8307de463af0 100644
@@ -12,6 +12,7 @@
 #include "intel_guc_ct.h"
 #include "intel_guc_log.h"
 #include "intel_guc_reg.h"
+#include "intel_guc_hwconfig.h"
 #include "intel_uc_fw.h"
 #include "i915_utils.h"
 #include "i915_vma.h"
@@ -27,6 +28,7 @@ struct intel_guc {
 	struct intel_uc_fw fw;
 	struct intel_guc_log log;
 	struct intel_guc_ct ct;
+	struct intel_guc_hwconfig hwconfig;
 
 	/* intel_guc_recv interrupt related state */
 	spinlock_t irq_lock;
drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c new file +167 -0
new file mode 100644
index 000000000000..938b1edb7209
@@ -0,0 +1,167 @@
+// SPDX-License-Identifier: MIT
+/*
+ * Copyright © 2020 Intel Corporation
+ */
+
+#include "gt/intel_gt.h"
+#include "gt/intel_hwconfig_types.h"
+#include "i915_drv.h"
+#include "i915_memcpy.h"
+#include "intel_guc_hwconfig.h"
+
+static
+inline struct intel_guc *hwconfig_to_guc(struct intel_guc_hwconfig *hwconfig)
+{
+	return container_of(hwconfig, struct intel_guc, hwconfig);
+}
+
+/**
+ * GuC has a blob containing hardware configuration information (hwconfig).
+ * This is formatted as a simple and flexible KLV (Key/Length/Value) table.
+ *
+ * For example, a minimal version could be:
+ *   enum device_attr {
+ *     ATTR_SOME_VALUE = 0,
+ *     ATTR_SOME_MASK  = 1,
+ *   };
+ *
+ *   static const u32 hwconfig[] = {
+ *     ATTR_SOME_VALUE,
+ *     1,		// Value Length in DWords
+ *     8,		// Value
+ *
+ *     ATTR_SOME_MASK,
+ *     3,
+ *     0x00FFFFFFFF, 0xFFFFFFFF, 0xFF000000,
+ *   };
+ *
+ * The attribute ids are defined in a hardware spec. The current list as
+ * known to the i915 driver can be found in i915/gt/intel_guc_hwconfig_types.h
+ */
+
+static int __guc_action_get_hwconfig(struct intel_guc_hwconfig *hwconfig,
+				     u32 ggtt_offset, u32 ggtt_size)
+{
+	struct intel_guc *guc = hwconfig_to_guc(hwconfig);
+	struct drm_i915_private *i915 = guc_to_gt(guc)->i915;
+	u32 action[] = {
+		INTEL_GUC_ACTION_GET_HWCONFIG,
+		ggtt_offset,
+		ggtt_size,
+		(INTEL_DEVID(i915) << 16) | INTEL_REVID(i915),
+	};
+	int ret;
+
+	ret = intel_guc_send_mmio(guc, action, ARRAY_SIZE(action), NULL, 0);
+	if (ret == -ENXIO)
+		return -ENOENT;
+
+	if (!ggtt_size && !ret)
+		ret = -EINVAL;
+
+	return ret;
+}
+
+static int guc_hwconfig_discover_size(struct intel_guc_hwconfig *hwconfig)
+{
+	int ret;
+
+	/* Sending a query with too small a table will return the size of the table */
+	ret = __guc_action_get_hwconfig(hwconfig, 0, 0);
+	if (ret < 0)
+		return ret;
+
+	hwconfig->size = ret;
+	return 0;
+}
+
+static int guc_hwconfig_fill_buffer(struct intel_guc_hwconfig *hwconfig)
+{
+	struct intel_guc *guc = hwconfig_to_guc(hwconfig);
+	struct drm_i915_private *i915 = guc_to_gt(guc)->i915;
+	u32 ggtt_offset;
+	int ret;
+	struct i915_vma *vma;
+	void *vaddr;
+
+	GEM_BUG_ON(!hwconfig->size);
+
+	ret = intel_guc_allocate_and_map_vma(guc, hwconfig->size, &vma, &vaddr);
+	if (ret) {
+		drm_err(&i915->drm, "HWConfig: Failed to allocate buffer: %d!\n", ret);
+		return ret;
+	}
+
+	ggtt_offset = intel_guc_ggtt_offset(guc, vma);
+
+	ret = __guc_action_get_hwconfig(hwconfig, ggtt_offset, hwconfig->size);
+	if (ret >= 0)
+		memcpy(hwconfig->ptr, vaddr, hwconfig->size);
+
+	i915_vma_unpin_and_release(&vma, I915_VMA_RELEASE_MAP);
+
+	return ret;
+}
+
+static bool has_table(struct drm_i915_private *i915)
+{
+	if (IS_ALDERLAKE_P(i915)) {
+		if (IS_ADLP_GT_STEP(i915, STEP_A0, STEP_A0))
+			return 0;
+
+		return 1;
+	}
+
+	return 0;
+}
+
+/**
+ * intel_guc_hwconfig_init - Initialize the HWConfig
+ *
+ * Retrieve the HWConfig table from the GuC and save it away in a local memory
+ * allocation. It can then be queried on demand by other users later on.
+ */
+int intel_guc_hwconfig_init(struct intel_guc_hwconfig *hwconfig)
+{
+	struct intel_guc *guc = hwconfig_to_guc(hwconfig);
+	struct drm_i915_private *i915 = guc_to_gt(guc)->i915;
+	int ret;
+
+	if (!has_table(i915))
+		return 0;
+
+	ret = guc_hwconfig_discover_size(hwconfig);
+	if (ret)
+		return ret;
+
+	hwconfig->ptr = kmalloc(hwconfig->size, GFP_KERNEL);
+	if (!hwconfig->ptr) {
+		hwconfig->size = 0;
+		return -ENOMEM;
+	}
+
+	ret = guc_hwconfig_fill_buffer(hwconfig);
+	if (ret < 0) {
+		kfree(hwconfig->ptr);
+		hwconfig->size = 0;
+		hwconfig->ptr = NULL;
+		return ret;
+	}
+
+	return 0;
+}
+
+/**
+ * intel_guc_hwconfig_fini - Finalize the HWConfig
+ *
+ * Free up the memory allocation holding the table.
+ */
+void intel_guc_hwconfig_fini(struct intel_guc_hwconfig *hwconfig)
+{
+	if (!hwconfig->size)
+		return;
+
+	kfree(hwconfig->ptr);
+	hwconfig->size = 0;
+	hwconfig->ptr = NULL;
+}
drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.h new file +19 -0
new file mode 100644
index 000000000000..91e96d88d713
@@ -0,0 +1,19 @@
+/* SPDX-License-Identifier: MIT */
+/*
+ * Copyright © 2020 Intel Corporation
+ */
+
+#ifndef _INTEL_GUC_HWCONFIG_H_
+#define _INTEL_GUC_HWCONFIG_H_
+
+#include <linux/types.h>
+
+struct intel_guc_hwconfig {
+	u32 size;
+	void *ptr;
+};
+
+int intel_guc_hwconfig_init(struct intel_guc_hwconfig *hwconfig);
+void intel_guc_hwconfig_fini(struct intel_guc_hwconfig *hwconfig);
+
+#endif /* _INTEL_GUC_HWCONFIG_H_ */
drivers/gpu/drm/i915/gt/uc/intel_uc.c +0 -0
index 6d8b9233214e..b289693f9767 100644

drivers/gpu/drm/i915/gt/uc/intel_uc.c static int __uc_init_hw(struct intel_uc *uc) · line 505

Quoted 4 lines
drivers/gpu/drm/i915/gt/uc/intel_uc.c +1 -0
@@ -502,6 +502,10 @@ static int __uc_init_hw(struct intel_uc *uc)
 
 	intel_huc_auth(huc);
 
+	ret = intel_guc_hwconfig_init(&guc->hwconfig);

As discussed on another thread, shouldn't we move this above guc_enable_communication() to not mix MMIO and CTB communication?

Matt

Quoted 18 lines
drivers/gpu/drm/i915/gt/uc/intel_uc.c +5 -0
+	if (ret)
+		goto err_log_capture;
+
 	if (intel_uc_uses_guc_submission(uc))
 		intel_guc_submission_enable(guc);
 
@@ -552,6 +556,8 @@ static void __uc_fini_hw(struct intel_uc *uc)
 	if (intel_uc_uses_guc_submission(uc))
 		intel_guc_submission_disable(guc);
 
+	intel_guc_hwconfig_fini(&guc->hwconfig);
+
 	__uc_sanitize(uc);
 }
 
Signature · 1 line
2.25.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#3 lore raw

Re: [PATCH 1/3] drm/i915/guc: Add fetch of hwconfig table

In reply to [email protected]
Quoted 48 lines · On 10.06.2021 22:46, [email protected] wrote:

From: John Harrison <[email protected]>

Implement support for fetching the hardware description table from the GuC. The call is made twice - once without a destination buffer to query the size and then a second time to fill in the buffer.

This patch also adds a header file which lists all the attribute values currently defined for the table. This is included for reference as these are not currently used by the i915 driver itself.

Note that the table is only available on ADL-P and later platforms.

---
 drivers/gpu/drm/i915/Makefile                 |   1 +
 .../gpu/drm/i915/gt/intel_hwconfig_types.h    | 102 +++++++++++
 .../gpu/drm/i915/gt/uc/abi/guc_actions_abi.h  |   1 +
 .../gpu/drm/i915/gt/uc/abi/guc_errors_abi.h   |   4 +
 drivers/gpu/drm/i915/gt/uc/intel_guc.c        |   3 +-
 drivers/gpu/drm/i915/gt/uc/intel_guc.h        |   2 +
 .../gpu/drm/i915/gt/uc/intel_guc_hwconfig.c   | 167 ++++++++++++++++++
 .../gpu/drm/i915/gt/uc/intel_guc_hwconfig.h   |  19 ++
 drivers/gpu/drm/i915/gt/uc/intel_uc.c         |   6 +
 9 files changed, 304 insertions(+), 1 deletion(-)
 create mode 100644 drivers/gpu/drm/i915/gt/intel_hwconfig_types.h
 create mode 100644 drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c
 create mode 100644 drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.h
drivers/gpu/drm/i915/Makefile +1 -0
index 2adb6b420c7c..8e957ca7c9f1 100644
@@ -187,6 +187,7 @@ i915-y += gt/uc/intel_uc.o \
 	  gt/uc/intel_guc_log.o \
 	  gt/uc/intel_guc_log_debugfs.o \
 	  gt/uc/intel_guc_submission.o \
+	  gt/uc/intel_guc_hwconfig.o \
 	  gt/uc/intel_huc.o \
 	  gt/uc/intel_huc_debugfs.o \
 	  gt/uc/intel_huc_fw.o
drivers/gpu/drm/i915/gt/intel_hwconfig_types.h new file +0 -0
new file mode 100644
index 000000000000..b09c0f65b93a

drivers/gpu/drm/i915/gt/intel_hwconfig_types.h line 3

Quoted 3 lines
drivers/gpu/drm/i915/gt/intel_hwconfig_types.h new file +3 -0
@@ -0,0 +1,102 @@
+/* SPDX-License-Identifier: MIT */
+/*
+ * Copyright © 2020 Intel Corporation

it's already June'21

drivers/gpu/drm/i915/gt/intel_hwconfig_types.h line 14

Quoted 11 lines
drivers/gpu/drm/i915/gt/intel_hwconfig_types.h new file +11 -0
+ */
+
+#ifndef _INTEL_HWCONFIG_TYPES_H_
+#define _INTEL_HWCONFIG_TYPES_H_
+
+/**
+ * enum intel_hwconfig - Global definition of hwconfig table attributes
+ *
+ * Intel devices provide a KLV (Key/Length/Value) table containing
+ * the static hardware configuration for that platform.
+ * This header defines the current attribute keys for this KLV.

s/header/enum

as this is enum documentation

likely separate DOC: section with explanation of the whole HW KLV concept could be helpful if plugged into i915 rst

drivers/gpu/drm/i915/gt/intel_hwconfig_types.h line 18

Quoted 4 lines
drivers/gpu/drm/i915/gt/intel_hwconfig_types.h new file +4 -0
+ */
+enum intel_hwconfig {
+	INTEL_HWCONFIG_MAX_SLICES_SUPPORTED = 1,
+	INTEL_HWCONFIG_MAX_DUAL_SUBSLICES_SUPPORTED,		/* 2 */

putting estimated enum values in comments could be misleading, as if someone accidentally add some enum in the middle then all values in comments will be stale

if you really want stable definitions, without risking accidental breakage, then better to define enums with explicit value, like you did for the first one:

INTEL_HWCONFIG_MAX_SLICES_SUPPORTED = 1, INTEL_HWCONFIG_MAX_DUAL_SUBSLICES_SUPPORTED = 2, INTEL_HWCONFIG_MAX_NUM_EU_PER_DSS = 3,
...

drivers/gpu/drm/i915/gt/intel_hwconfig_types.h line 23

Quoted 5 lines
drivers/gpu/drm/i915/gt/intel_hwconfig_types.h new file +5 -0
+	INTEL_HWCONFIG_MAX_NUM_EU_PER_DSS,			/* 3 */
+	INTEL_HWCONFIG_NUM_PIXEL_PIPES,				/* 4 */
+	INTEL_HWCONFIG_DEPRECATED_MAX_NUM_GEOMETRY_PIPES,	/* 5 */
+	INTEL_HWCONFIG_DEPRECATED_L3_CACHE_SIZE_IN_KB,		/* 6 */
+	INTEL_HWCONFIG_DEPRECATED_L3_BANK_COUNT,		/* 7 */

what's the meaning of the 'deprecated' here ?

if not used in ADLP and beyond, then I guess no reason to define them. just skip these numbers:

INTEL_HWCONFIG_NUM_PIXEL_PIPES = 4,
/* 5-7 not used/reserved/deprecated */ INTEL_HWCONFIG_L3_CACHE_WAYS_SIZE_IN_BYTES = 8,

Quoted 57 lines
drivers/gpu/drm/i915/gt/intel_hwconfig_types.h new file +57 -0
+	INTEL_HWCONFIG_L3_CACHE_WAYS_SIZE_IN_BYTES,		/* 8 */
+	INTEL_HWCONFIG_L3_CACHE_WAYS_PER_SECTOR,		/* 9 */
+	INTEL_HWCONFIG_MAX_MEMORY_CHANNELS,			/* 10 */
+	INTEL_HWCONFIG_MEMORY_TYPE,				/* 11 */
+	INTEL_HWCONFIG_CACHE_TYPES,                             /* 12 */
+	INTEL_HWCONFIG_LOCAL_MEMORY_PAGE_SIZES_SUPPORTED,	/* 13 */
+	INTEL_HWCONFIG_DEPRECATED_SLM_SIZE_IN_KB,		/* 14 */
+	INTEL_HWCONFIG_NUM_THREADS_PER_EU,			/* 15 */
+	INTEL_HWCONFIG_TOTAL_VS_THREADS,			/* 16 */
+	INTEL_HWCONFIG_TOTAL_GS_THREADS,			/* 17 */
+	INTEL_HWCONFIG_TOTAL_HS_THREADS,			/* 18 */
+	INTEL_HWCONFIG_TOTAL_DS_THREADS,			/* 19 */
+	INTEL_HWCONFIG_TOTAL_VS_THREADS_POCS,			/* 20 */
+	INTEL_HWCONFIG_TOTAL_PS_THREADS,			/* 21 */
+	INTEL_HWCONFIG_DEPRECATED_MAX_FILL_RATE,		/* 22 */
+	INTEL_HWCONFIG_MAX_RCS,					/* 23 */
+	INTEL_HWCONFIG_MAX_CCS,					/* 24 */
+	INTEL_HWCONFIG_MAX_VCS,					/* 25 */
+	INTEL_HWCONFIG_MAX_VECS,				/* 26 */
+	INTEL_HWCONFIG_MAX_COPY_CS,				/* 27 */
+	INTEL_HWCONFIG_DEPRECATED_URB_SIZE_IN_KB,		/* 28 */
+	INTEL_HWCONFIG_MIN_VS_URB_ENTRIES,			/* 29 */
+	INTEL_HWCONFIG_MAX_VS_URB_ENTRIES,			/* 30 */
+	INTEL_HWCONFIG_MIN_PCS_URB_ENTRIES,			/* 31 */
+	INTEL_HWCONFIG_MAX_PCS_URB_ENTRIES,			/* 32 */
+	INTEL_HWCONFIG_MIN_HS_URB_ENTRIES,			/* 33 */
+	INTEL_HWCONFIG_MAX_HS_URB_ENTRIES,			/* 34 */
+	INTEL_HWCONFIG_MIN_GS_URB_ENTRIES,			/* 35 */
+	INTEL_HWCONFIG_MAX_GS_URB_ENTRIES,			/* 36 */
+	INTEL_HWCONFIG_MIN_DS_URB_ENTRIES,			/* 37 */
+	INTEL_HWCONFIG_MAX_DS_URB_ENTRIES,			/* 38 */
+	INTEL_HWCONFIG_PUSH_CONSTANT_URB_RESERVED_SIZE,		/* 39 */
+	INTEL_HWCONFIG_POCS_PUSH_CONSTANT_URB_RESERVED_SIZE,	/* 40 */
+	INTEL_HWCONFIG_URB_REGION_ALIGNMENT_SIZE_IN_BYTES,	/* 41 */
+	INTEL_HWCONFIG_URB_ALLOCATION_SIZE_UNITS_IN_BYTES,	/* 42 */
+	INTEL_HWCONFIG_MAX_URB_SIZE_CCS_IN_BYTES,		/* 43 */
+	INTEL_HWCONFIG_VS_MIN_DEREF_BLOCK_SIZE_HANDLE_COUNT,	/* 44 */
+	INTEL_HWCONFIG_DS_MIN_DEREF_BLOCK_SIZE_HANDLE_COUNT,	/* 45 */
+	INTEL_HWCONFIG_NUM_RT_STACKS_PER_DSS,			/* 46 */
+	INTEL_HWCONFIG_MAX_URB_STARTING_ADDRESS,		/* 47 */
+	INTEL_HWCONFIG_MIN_CS_URB_ENTRIES,			/* 48 */
+	INTEL_HWCONFIG_MAX_CS_URB_ENTRIES,			/* 49 */
+	INTEL_HWCONFIG_L3_ALLOC_PER_BANK_URB,			/* 50 */
+	INTEL_HWCONFIG_L3_ALLOC_PER_BANK_REST,			/* 51 */
+	INTEL_HWCONFIG_L3_ALLOC_PER_BANK_DC,			/* 52 */
+	INTEL_HWCONFIG_L3_ALLOC_PER_BANK_RO,			/* 53 */
+	INTEL_HWCONFIG_L3_ALLOC_PER_BANK_Z,			/* 54 */
+	INTEL_HWCONFIG_L3_ALLOC_PER_BANK_COLOR,			/* 55 */
+	INTEL_HWCONFIG_L3_ALLOC_PER_BANK_UNIFIED_TILE_CACHE,	/* 56 */
+	INTEL_HWCONFIG_L3_ALLOC_PER_BANK_COMMAND_BUFFER,	/* 57 */
+	INTEL_HWCONFIG_L3_ALLOC_PER_BANK_RW,			/* 58 */
+	INTEL_HWCONFIG_MAX_NUM_L3_CONFIGS,			/* 59 */
+	INTEL_HWCONFIG_BINDLESS_SURFACE_OFFSET_BIT_COUNT,	/* 60 */
+	INTEL_HWCONFIG_RESERVED_CCS_WAYS,			/* 61 */
+	INTEL_HWCONFIG_CSR_SIZE_IN_MB,				/* 62 */
+	INTEL_HWCONFIG_GEOMETRY_PIPES_PER_SLICE,		/* 63 */
+	INTEL_HWCONFIG_L3_BANK_SIZE_IN_KB,			/* 64 */

drivers/gpu/drm/i915/gt/intel_hwconfig_types.h line 90

Quoted 10 lines
drivers/gpu/drm/i915/gt/intel_hwconfig_types.h new file +10 -0
+	INTEL_HWCONFIG_SLM_SIZE_PER_DSS,			/* 65 */
+	INTEL_HWCONFIG_MAX_PIXEL_FILL_RATE_PER_SLICE,		/* 66 */
+	INTEL_HWCONFIG_MAX_PIXEL_FILL_RATE_PER_DSS,		/* 67 */
+	INTEL_HWCONFIG_URB_SIZE_PER_SLICE_IN_KB,		/* 68 */
+	INTEL_HWCONFIG_URB_SIZE_PER_L3_BANK_COUNT_IN_KB,	/* 69 */
+	INTEL_HWCONFIG_MAX_SUBSLICE,				/* 70 */
+	INTEL_HWCONFIG_MAX_EU_PER_SUBSLICE,			/* 71 */
+	INTEL_HWCONFIG_RAMBO_L3_BANK_SIZE_IN_KB,		/* 72 */
+	INTEL_HWCONFIG_SLM_SIZE_PER_SS_IN_KB,			/* 73 */
+	__INTEL_HWCONFIG_LIMIT

what's the purpose of this 'limit' ?

drivers/gpu/drm/i915/gt/intel_hwconfig_types.h line 92

Quoted 2 lines
drivers/gpu/drm/i915/gt/intel_hwconfig_types.h new file +2 -0
+};
+

below are values definitions just for two keys, what about others like MAX_PIXEL_FILL_RATE ? either add them all or introduce by one while adding support

drivers/gpu/drm/i915/gt/intel_hwconfig_types.h line 100

Quoted 8 lines
drivers/gpu/drm/i915/gt/intel_hwconfig_types.h new file +8 -0
+enum {
+	INTEL_HWCONFIG_MEMORY_TYPE_LPDDR4 = 0,
+	INTEL_HWCONFIG_MEMORY_TYPE_LPDDR5,
+};
+
+#define INTEL_HWCONFIG_CACHE_TYPE_L3	BIT(0)
+#define INTEL_HWCONFIG_CACHE_TYPE_LLC	BIT(1)
+#define INTEL_HWCONFIG_CACHE_TYPE_EDRAM	BIT(2)

why mixing style for KLV values ? you can still use enum:

enum {
INTEL_HWCONFIG_CACHE_TYPE_L3 = BIT(0),
INTEL_HWCONFIG_CACHE_TYPE_LLC = BIT(1),
INTEL_HWCONFIG_CACHE_TYPE_EDRAM = BIT(2),
};

and as you're using BIT macro then likely you should earlier add:

#include <linux/bits.h>

Quoted 34 lines
drivers/gpu/drm/i915/gt/intel_hwconfig_types.h new file +2 -0
+
+#endif /* _INTEL_HWCONFIG_TYPES_H_ */
drivers/gpu/drm/i915/gt/uc/abi/guc_actions_abi.h +1 -0
index 90efef8a73e4..075f56a040b7 100644
@@ -19,6 +19,7 @@ enum intel_guc_action {
 	INTEL_GUC_ACTION_EXIT_S_STATE = 0x502,
 	INTEL_GUC_ACTION_SLPC_REQUEST = 0x3003,
 	INTEL_GUC_ACTION_AUTHENTICATE_HUC = 0x4000,
+	INTEL_GUC_ACTION_GET_HWCONFIG = 0x4100,
 	INTEL_GUC_ACTION_REGISTER_COMMAND_TRANSPORT_BUFFER = 0x4505,
 	INTEL_GUC_ACTION_DEREGISTER_COMMAND_TRANSPORT_BUFFER = 0x4506,
 	INTEL_GUC_ACTION_LIMIT
drivers/gpu/drm/i915/gt/uc/abi/guc_errors_abi.h +4 -0
index 488b6061ee89..f9e2a6aaef4a 100644
@@ -8,6 +8,10 @@
 
 enum intel_guc_response_status {
 	INTEL_GUC_RESPONSE_STATUS_SUCCESS = 0x0,
+	INTEL_GUC_RESPONSE_NOT_SUPPORTED = 0x20,
+	INTEL_GUC_RESPONSE_NO_ATTRIBUTE_TABLE = 0x201,
+	INTEL_GUC_RESPONSE_NO_DECRYPTION_KEY = 0x202,
+	INTEL_GUC_RESPONSE_DECRYPTION_FAILED = 0x204,
 	INTEL_GUC_RESPONSE_STATUS_GENERIC_FAIL = 0xF000,
 };
 
drivers/gpu/drm/i915/gt/uc/intel_guc.c +0 -0
index f147cb389a20..01839d5eb130 100644

drivers/gpu/drm/i915/gt/uc/intel_guc.c int intel_guc_send_mmio(struct intel_guc *guc, const u32 *action, u32 len, · line 410

Quoted 4 lines
drivers/gpu/drm/i915/gt/uc/intel_guc.c +1 -0
@@ -407,13 +407,14 @@ int intel_guc_send_mmio(struct intel_guc *guc, const u32 *action, u32 len,
 	/*
 	 * No GuC command should ever take longer than 10ms.
 	 * Fast commands should still complete in 10us.
+	 * Except for the hwconfig table query, which takes ~50ms.

I assume this is a limitation of the specific fw release and will be fixed in next releases, so maybe worth to add some FIXME to don't forget to drop this hack once fw is fixed ?

Quoted 37 lines
drivers/gpu/drm/i915/gt/uc/intel_guc.c +1 -1
 	 */
 	ret = __intel_wait_for_register_fw(uncore,
 					   guc_send_reg(guc, 0),
 					   INTEL_GUC_MSG_TYPE_MASK,
 					   INTEL_GUC_MSG_TYPE_RESPONSE <<
 					   INTEL_GUC_MSG_TYPE_SHIFT,
-					   10, 10, &status);
+					   10, 100, &status);
 	/* If GuC explicitly returned an error, convert it to -EIO */
 	if (!ret && !INTEL_GUC_MSG_IS_RESPONSE_SUCCESS(status))
 		ret = -EIO;
drivers/gpu/drm/i915/gt/uc/intel_guc.h +2 -0
index 4abc59f6f3cd..8307de463af0 100644
@@ -12,6 +12,7 @@
 #include "intel_guc_ct.h"
 #include "intel_guc_log.h"
 #include "intel_guc_reg.h"
+#include "intel_guc_hwconfig.h"
 #include "intel_uc_fw.h"
 #include "i915_utils.h"
 #include "i915_vma.h"
@@ -27,6 +28,7 @@ struct intel_guc {
 	struct intel_uc_fw fw;
 	struct intel_guc_log log;
 	struct intel_guc_ct ct;
+	struct intel_guc_hwconfig hwconfig;
 
 	/* intel_guc_recv interrupt related state */
 	spinlock_t irq_lock;
drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c new file +0 -0
new file mode 100644
index 000000000000..938b1edb7209

drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c line 3

Quoted 3 lines
drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c new file +3 -0
@@ -0,0 +1,167 @@
+// SPDX-License-Identifier: MIT
+/*
+ * Copyright © 2020 Intel Corporation

2021

drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c line 13

Quoted 10 lines
drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c new file +10 -0
+ */
+
+#include "gt/intel_gt.h"
+#include "gt/intel_hwconfig_types.h"
+#include "i915_drv.h"
+#include "i915_memcpy.h"
+#include "intel_guc_hwconfig.h"
+
+static
+inline struct intel_guc *hwconfig_to_guc(struct intel_guc_hwconfig *hwconfig)

no need to (badly) split lines, column limit is 100

drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c line 18

Quoted 5 lines
drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c new file +5 -0
+{
+	return container_of(hwconfig, struct intel_guc, hwconfig);
+}
+
+/**

this doesn't looks like kernel doc

drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c line 19

Quoted 1 line
drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c new file +1 -0
+ * GuC has a blob containing hardware configuration information (hwconfig).

later you are using "HWConfig" name

drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c line 20

Quoted 1 line
drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c new file +1 -0
+ * This is formatted as a simple and flexible KLV (Key/Length/Value) table.

in file intel_hwconfig_types.h there was statement
"Intel devices provide a KLV ..."
so maybe we don't have to repeat that here and also just move example below to .h where whole concept could be explained in one place.

Quoted 12 lines
drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c new file +12 -0
+ *
+ * For example, a minimal version could be:
+ *   enum device_attr {
+ *     ATTR_SOME_VALUE = 0,
+ *     ATTR_SOME_MASK  = 1,
+ *   };
+ *
+ *   static const u32 hwconfig[] = {
+ *     ATTR_SOME_VALUE,
+ *     1,		// Value Length in DWords
+ *     8,		// Value
+ *

drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c line 42

Quoted 10 lines
drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c new file +10 -0
+ *     ATTR_SOME_MASK,
+ *     3,
+ *     0x00FFFFFFFF, 0xFFFFFFFF, 0xFF000000,
+ *   };
+ *
+ * The attribute ids are defined in a hardware spec. The current list as
+ * known to the i915 driver can be found in i915/gt/intel_guc_hwconfig_types.h
+ */
+
+static int __guc_action_get_hwconfig(struct intel_guc_hwconfig *hwconfig,

all other "guc_action" functions take directly "guc" as param

drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c line 55

Quoted 13 lines
drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c new file +13 -0
+				     u32 ggtt_offset, u32 ggtt_size)
+{
+	struct intel_guc *guc = hwconfig_to_guc(hwconfig);
+	struct drm_i915_private *i915 = guc_to_gt(guc)->i915;
+	u32 action[] = {
+		INTEL_GUC_ACTION_GET_HWCONFIG,
+		ggtt_offset,
+		ggtt_size,
+		(INTEL_DEVID(i915) << 16) | INTEL_REVID(i915),
+	};
+	int ret;
+
+	ret = intel_guc_send_mmio(guc, action, ARRAY_SIZE(action), NULL, 0);

why this is over MMIO?
as you need to pass GGTT then CTB is also already available...

Quoted 4 lines
drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c new file +4 -0
+	if (ret == -ENXIO)
+		return -ENOENT;
+
+	if (!ggtt_size && !ret)

drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c line 69

Quoted 10 lines
drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c new file +10 -0
+		ret = -EINVAL;
+
+	return ret;
+}
+
+static int guc_hwconfig_discover_size(struct intel_guc_hwconfig *hwconfig)
+{
+	int ret;
+
+	/* Sending a query with too small a table will return the size of the table */

likely: "Sending a query with zero buffer size will return .."

Quoted 6 lines
drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c new file +6 -0
+	ret = __guc_action_get_hwconfig(hwconfig, 0, 0);
+	if (ret < 0)
+		return ret;
+
+	hwconfig->size = ret;
+	return 0;

drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c line 85

Quoted 10 lines
drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c new file +10 -0
+}
+
+static int guc_hwconfig_fill_buffer(struct intel_guc_hwconfig *hwconfig)
+{
+	struct intel_guc *guc = hwconfig_to_guc(hwconfig);
+	struct drm_i915_private *i915 = guc_to_gt(guc)->i915;
+	u32 ggtt_offset;
+	int ret;
+	struct i915_vma *vma;
+	void *vaddr;

nit: some would prefer this order:

	struct i915_vma *vma;
	u32 ggtt_offset;
	void *vaddr;
	int ret;

drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c line 91

Quoted 6 lines
drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c new file +6 -0
+
+	GEM_BUG_ON(!hwconfig->size);
+
+	ret = intel_guc_allocate_and_map_vma(guc, hwconfig->size, &vma, &vaddr);
+	if (ret) {
+		drm_err(&i915->drm, "HWConfig: Failed to allocate buffer: %d!\n", ret);

we can fail in many different ways, also in other places, why only this case has dedicated error message ?

nit: to be more friendly we can print error code with %pe

drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c line 99

Quoted 8 lines
drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c new file +8 -0
+		return ret;
+	}
+
+	ggtt_offset = intel_guc_ggtt_offset(guc, vma);
+
+	ret = __guc_action_get_hwconfig(hwconfig, ggtt_offset, hwconfig->size);
+	if (ret >= 0)
+		memcpy(hwconfig->ptr, vaddr, hwconfig->size);

do you plan to add some validation of the received klvs ? like if last one is not truncated ?

and to (debug) print it anywhere ?

and maybe to add to error capture?

drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c line 112

Quoted 13 lines
drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c new file +13 -0
+
+	i915_vma_unpin_and_release(&vma, I915_VMA_RELEASE_MAP);
+
+	return ret;
+}
+
+static bool has_table(struct drm_i915_private *i915)
+{
+	if (IS_ALDERLAKE_P(i915)) {
+		if (IS_ADLP_GT_STEP(i915, STEP_A0, STEP_A0))
+			return 0;
+
+		return 1;

nit: this could be single line:

	return !IS_ADLP_GT_STEP(i915, STEP_A0, STEP_A0);

and maybe add few words as in commit message you said all ADP-P have it

drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c line 75

Quoted 3 lines
drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c new file +3 -0
+	}
+
+	return 0;

since you defined function as returning bool, then use true/false

Quoted 23 lines
drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c new file +23 -0
+}
+
+/**
+ * intel_guc_hwconfig_init - Initialize the HWConfig
+ *
+ * Retrieve the HWConfig table from the GuC and save it away in a local memory
+ * allocation. It can then be queried on demand by other users later on.
+ */
+int intel_guc_hwconfig_init(struct intel_guc_hwconfig *hwconfig)
+{
+	struct intel_guc *guc = hwconfig_to_guc(hwconfig);
+	struct drm_i915_private *i915 = guc_to_gt(guc)->i915;
+	int ret;
+
+	if (!has_table(i915))
+		return 0;
+
+	ret = guc_hwconfig_discover_size(hwconfig);
+	if (ret)
+		return ret;
+
+	hwconfig->ptr = kmalloc(hwconfig->size, GFP_KERNEL);
+	if (!hwconfig->ptr) {

drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c line 148

Quoted 10 lines
drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c new file +10 -0
+		hwconfig->size = 0;
+		return -ENOMEM;
+	}
+
+	ret = guc_hwconfig_fill_buffer(hwconfig);
+	if (ret < 0) {
+		kfree(hwconfig->ptr);
+		hwconfig->size = 0;
+		hwconfig->ptr = NULL;
+		return ret;

maybe use onion cleanup ?

Quoted 4 lines
drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c new file +4 -0
+	}
+
+	return 0;
+}

drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c line 162

Quoted 10 lines
drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c new file +10 -0
+
+/**
+ * intel_guc_hwconfig_fini - Finalize the HWConfig
+ *
+ * Free up the memory allocation holding the table.
+ */
+void intel_guc_hwconfig_fini(struct intel_guc_hwconfig *hwconfig)
+{
+	if (!hwconfig->size)
+		return;

not needed, kfree will work with null

Quoted 11 lines
drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c new file +5 -0
+
+	kfree(hwconfig->ptr);
+	hwconfig->size = 0;
+	hwconfig->ptr = NULL;
+}
drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.h new file +0 -0
new file mode 100644
index 000000000000..91e96d88d713

drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.h line 3

Quoted 3 lines
drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.h new file +3 -0
@@ -0,0 +1,19 @@
+/* SPDX-License-Identifier: MIT */
+/*
+ * Copyright © 2020 Intel Corporation

2021

drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.h line 12

Quoted 9 lines
drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.h new file +9 -0
+ */
+
+#ifndef _INTEL_GUC_HWCONFIG_H_
+#define _INTEL_GUC_HWCONFIG_H_
+
+#include <linux/types.h>
+
+struct intel_guc_hwconfig {
+	u32 size;

size in bytes or dwords ?

drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.h line 13

Quoted 1 line
drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.h new file +1 -0
+	void *ptr;

nit: as this is ptr to klv dwords, maybe:

	u32 *kls;
Quoted 23 lines
drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.h new file +6 -0
+};
+
+int intel_guc_hwconfig_init(struct intel_guc_hwconfig *hwconfig);
+void intel_guc_hwconfig_fini(struct intel_guc_hwconfig *hwconfig);
+
+#endif /* _INTEL_GUC_HWCONFIG_H_ */
drivers/gpu/drm/i915/gt/uc/intel_uc.c +4 -0
index 6d8b9233214e..b289693f9767 100644
@@ -502,6 +502,10 @@ static int __uc_init_hw(struct intel_uc *uc)
 
 	intel_huc_auth(huc);
 
+	ret = intel_guc_hwconfig_init(&guc->hwconfig);
+	if (ret)
+		goto err_log_capture;
+
 	if (intel_uc_uses_guc_submission(uc))
 		intel_guc_submission_enable(guc);
 

drivers/gpu/drm/i915/gt/uc/intel_uc.c static void __uc_fini_hw(struct intel_uc *uc) · line 563

Quoted 8 lines
drivers/gpu/drm/i915/gt/uc/intel_uc.c +2 -0
@@ -552,6 +556,8 @@ static void __uc_fini_hw(struct intel_uc *uc)
 	if (intel_uc_uses_guc_submission(uc))
 		intel_guc_submission_disable(guc);
 
+	intel_guc_hwconfig_fini(&guc->hwconfig);
+
 	__uc_sanitize(uc);
 }
 

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#4 lore raw

Re: [PATCH 1/3] drm/i915/guc: Add fetch of hwconfig table

In reply to [email protected]
Thank you for the patch! Perhaps something to improve:

Hi,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on drm-intel/for-linux-next]
[also build test WARNING on next-20210615]
[cannot apply to v5.13-rc6]
[If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/John-C-Harrison-Intel-com/Add-support-for-querying-hw-info-that-UMDs-need/20210616-141805
base:   git://anongit.freedesktop.org/drm-intel for-linux-next
config: i386-defconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/0006532f8f4a6f0ff36af11df58e8705af452e3c
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review John-C-Harrison-Intel-com/Add-support-for-querying-hw-info-that-UMDs-need/20210616-141805
        git checkout 0006532f8f4a6f0ff36af11df58e8705af452e3c
        # save the attached .config to linux build tree
        make W=1 ARCH=i386 

If you fix the issue, kindly add following tag as appropriate

All warnings (new ones prefixed by >>):

>> drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c:19: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst

* GuC has a blob containing hardware configuration information (hwconfig).
drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c:125: warning: Function parameter or member 'hwconfig' not described in 'intel_guc_hwconfig_init' drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c:160: warning: Function parameter or member 'hwconfig' not described in 'intel_guc_hwconfig_fini'

vim +19 drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c

    17	
    18	/**
  > 19	 * GuC has a blob containing hardware configuration information (hwconfig).
    20	 * This is formatted as a simple and flexible KLV (Key/Length/Value) table.
    21	 *
    22	 * For example, a minimal version could be:
    23	 *   enum device_attr {
    24	 *     ATTR_SOME_VALUE = 0,
    25	 *     ATTR_SOME_MASK  = 1,
    26	 *   };
    27	 *
    28	 *   static const u32 hwconfig[] = {
    29	 *     ATTR_SOME_VALUE,
    30	 *     1,		// Value Length in DWords
    31	 *     8,		// Value
    32	 *
    33	 *     ATTR_SOME_MASK,
    34	 *     3,
    35	 *     0x00FFFFFFFF, 0xFFFFFFFF, 0xFF000000,
    36	 *   };
    37	 *
    38	 * The attribute ids are defined in a hardware spec. The current list as
    39	 * known to the i915 driver can be found in i915/gt/intel_guc_hwconfig_types.h
    40	 */
    41	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

#5 lore raw

Re: [PATCH 1/3] drm/i915/guc: Add fetch of hwconfig table

In reply to [email protected]
Thank you for the patch! Perhaps something to improve:

Hi,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on drm-intel/for-linux-next]
[also build test WARNING on next-20210615]
[cannot apply to v5.13-rc6]
[If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/John-C-Harrison-Intel-com/Add-support-for-querying-hw-info-that-UMDs-need/20210616-141805
base:   git://anongit.freedesktop.org/drm-intel for-linux-next
config: x86_64-randconfig-a002-20210616 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 64720f57bea6a6bf033feef4a5751ab9c0c3b401)

reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
# https://github.com/0day-ci/linux/commit/0006532f8f4a6f0ff36af11df58e8705af452e3c
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review John-C-Harrison-Intel-com/Add-support-for-querying-hw-info-that-UMDs-need/20210616-141805 git checkout 0006532f8f4a6f0ff36af11df58e8705af452e3c
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64

If you fix the issue, kindly add following tag as appropriate

All warnings (new ones prefixed by >>):

>> drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c:19: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst

* GuC has a blob containing hardware configuration information (hwconfig).
drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c:125: warning: Function parameter or member 'hwconfig' not described in 'intel_guc_hwconfig_init' drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c:160: warning: Function parameter or member 'hwconfig' not described in 'intel_guc_hwconfig_fini'

vim +19 drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c

    17	
    18	/**
  > 19	 * GuC has a blob containing hardware configuration information (hwconfig).
    20	 * This is formatted as a simple and flexible KLV (Key/Length/Value) table.
    21	 *
    22	 * For example, a minimal version could be:
    23	 *   enum device_attr {
    24	 *     ATTR_SOME_VALUE = 0,
    25	 *     ATTR_SOME_MASK  = 1,
    26	 *   };
    27	 *
    28	 *   static const u32 hwconfig[] = {
    29	 *     ATTR_SOME_VALUE,
    30	 *     1,		// Value Length in DWords
    31	 *     8,		// Value
    32	 *
    33	 *     ATTR_SOME_MASK,
    34	 *     3,
    35	 *     0x00FFFFFFFF, 0xFFFFFFFF, 0xFF000000,
    36	 *   };
    37	 *
    38	 * The attribute ids are defined in a hardware spec. The current list as
    39	 * known to the i915 driver can be found in i915/gt/intel_guc_hwconfig_types.h
    40	 */
    41	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

#6 lore raw

PATCH 2/3 drm/i915/uapi: Add query for hwconfig table

In reply to [email protected]

From: Rodrigo Vivi <[email protected]>

GuC contains a consolidated table with a bunch of information about the current device.

Previously, this information was spread and hardcoded to all the components including GuC, i915 and various UMDs. The goal here is to consolidate the data into GuC in a way that all interested components can grab the very latest and synchronized information using a simple query.

As per most of the other queries, this one can be called twice. Once with item.length=0 to determine the exact buffer size, then allocate the user memory and call it again for to retrieve the table data. For example:

  struct drm_i915_query_item item = {
    .query_id = DRM_I915_QUERY_HWCONCFIG_TABLE;

};
query.items_ptr = (int64_t) &item;
query.num_items = 1;

  ioctl(fd, DRM_IOCTL_I915_QUERY, query, sizeof(query));

if (item.length <= 0)

    return -ENOENT;
  data = malloc(item.length);
  item.data_ptr = (int64_t) &data;
  ioctl(fd, DRM_IOCTL_I915_QUERY, query, sizeof(query));

// Parse the data as appropriate...

The returned array is a simple and flexible KLV (Key/Length/Value) formatted table. For example, it could be just:
enum device_attr {
ATTR_SOME_VALUE = 0,
ATTR_SOME_MASK = 1,
};

  static const u32 hwconfig[] = {
      ATTR_SOME_VALUE,
      1,             // Value Length in DWords
      8,             // Value
      ATTR_SOME_MASK,
      3,
      0x00FFFFFFFF, 0xFFFFFFFF, 0xFF000000,

};

The attribute ids are defined in a hardware spec. The current list as known to the i915 driver can be found in i915/gt/intel_guc_hwconfig_types.h

Cc Tvrtko Ursulin <[email protected]>
Cc Kenneth Graunke <[email protected]>
Cc Michal Wajdeczko <[email protected]>
Cc Slawomir Milczarek <[email protected]>
---
 drivers/gpu/drm/i915/i915_query.c | 23 +++++++++++++++++++++++
 include/uapi/drm/i915_drm.h       |  1 +
 2 files changed, 24 insertions(+)
drivers/gpu/drm/i915/i915_query.c +23 -0
index e49da36c62fb..96bd8fb3e895 100644
@@ -480,12 +480,35 @@ static int query_memregion_info(struct drm_i915_private *i915,
 	return total_length;
 }
 
+static int query_hwconfig_table(struct drm_i915_private *i915,
+				struct drm_i915_query_item *query_item)
+{
+	struct intel_gt *gt = &i915->gt;
+	struct intel_guc_hwconfig *hwconfig = &gt->uc.guc.hwconfig;
+
+	if (!hwconfig->size || !hwconfig->ptr)
+		return -ENODEV;
+
+	if (query_item->length == 0)
+		return hwconfig->size;
+
+	if (query_item->length < hwconfig->size)
+		return -EINVAL;
+
+	if (copy_to_user(u64_to_user_ptr(query_item->data_ptr),
+			 hwconfig->ptr, hwconfig->size))
+		return -EFAULT;
+
+	return hwconfig->size;
+}
+
 static int (* const i915_query_funcs[])(struct drm_i915_private *dev_priv,
 					struct drm_i915_query_item *query_item) = {
 	query_topology_info,
 	query_engine_info,
 	query_perf_config,
 	query_memregion_info,
+	query_hwconfig_table,
 };
 
 int i915_query_ioctl(struct drm_device *dev, void *data, struct drm_file *file)
include/uapi/drm/i915_drm.h +1 -0
index c2c7759b7d2e..87d369cae22a 100644
@@ -2233,6 +2233,7 @@ struct drm_i915_query_item {
 #define DRM_I915_QUERY_ENGINE_INFO	2
 #define DRM_I915_QUERY_PERF_CONFIG      3
 #define DRM_I915_QUERY_MEMORY_REGIONS   4
+#define DRM_I915_QUERY_HWCONFIG_TABLE   5
 /* Must be kept compact -- no holes and well documented */
 
 	/**
Signature · 6 lines
2.25.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Reviewed-by on v1 2/3
#7 lore raw

Re: [PATCH 2/3] drm/i915/uapi: Add query for hwconfig table

Quoted 51 lines · On Thu, Jun 10, 2021 at 01:46:25PM -0700, [email protected] wrote:

From: Rodrigo Vivi <[email protected]>

GuC contains a consolidated table with a bunch of information about the current device.

Previously, this information was spread and hardcoded to all the components including GuC, i915 and various UMDs. The goal here is to consolidate the data into GuC in a way that all interested components can grab the very latest and synchronized information using a simple query.

As per most of the other queries, this one can be called twice. Once with item.length=0 to determine the exact buffer size, then allocate the user memory and call it again for to retrieve the table data. For example:

  struct drm_i915_query_item item = {
    .query_id = DRM_I915_QUERY_HWCONCFIG_TABLE;

};
query.items_ptr = (int64_t) &item;
query.num_items = 1;

  ioctl(fd, DRM_IOCTL_I915_QUERY, query, sizeof(query));

if (item.length <= 0)

    return -ENOENT;
  data = malloc(item.length);
  item.data_ptr = (int64_t) &data;
  ioctl(fd, DRM_IOCTL_I915_QUERY, query, sizeof(query));

// Parse the data as appropriate...

The returned array is a simple and flexible KLV (Key/Length/Value) formatted table. For example, it could be just:
enum device_attr {
ATTR_SOME_VALUE = 0,
ATTR_SOME_MASK = 1,
};

  static const u32 hwconfig[] = {
      ATTR_SOME_VALUE,
      1,             // Value Length in DWords
      8,             // Value
      ATTR_SOME_MASK,
      3,
      0x00FFFFFFFF, 0xFFFFFFFF, 0xFF000000,

};

The attribute ids are defined in a hardware spec. The current list as known to the i915 driver can be found in i915/gt/intel_guc_hwconfig_types.h

Quoted 6 lines
Cc Tvrtko Ursulin <[email protected]>
Cc Kenneth Graunke <[email protected]>
Cc Michal Wajdeczko <[email protected]>
Cc Slawomir Milczarek <[email protected]>
Quoted 60 lines
---
 drivers/gpu/drm/i915/i915_query.c | 23 +++++++++++++++++++++++
 include/uapi/drm/i915_drm.h       |  1 +
 2 files changed, 24 insertions(+)
drivers/gpu/drm/i915/i915_query.c +23 -0
index e49da36c62fb..96bd8fb3e895 100644
@@ -480,12 +480,35 @@ static int query_memregion_info(struct drm_i915_private *i915,
 	return total_length;
 }
 
+static int query_hwconfig_table(struct drm_i915_private *i915,
+				struct drm_i915_query_item *query_item)
+{
+	struct intel_gt *gt = &i915->gt;
+	struct intel_guc_hwconfig *hwconfig = &gt->uc.guc.hwconfig;
+
+	if (!hwconfig->size || !hwconfig->ptr)
+		return -ENODEV;
+
+	if (query_item->length == 0)
+		return hwconfig->size;
+
+	if (query_item->length < hwconfig->size)
+		return -EINVAL;
+
+	if (copy_to_user(u64_to_user_ptr(query_item->data_ptr),
+			 hwconfig->ptr, hwconfig->size))
+		return -EFAULT;
+
+	return hwconfig->size;
+}
+
 static int (* const i915_query_funcs[])(struct drm_i915_private *dev_priv,
 					struct drm_i915_query_item *query_item) = {
 	query_topology_info,
 	query_engine_info,
 	query_perf_config,
 	query_memregion_info,
+	query_hwconfig_table,
 };
 
 int i915_query_ioctl(struct drm_device *dev, void *data, struct drm_file *file)
include/uapi/drm/i915_drm.h +1 -0
index c2c7759b7d2e..87d369cae22a 100644
@@ -2233,6 +2233,7 @@ struct drm_i915_query_item {
 #define DRM_I915_QUERY_ENGINE_INFO	2
 #define DRM_I915_QUERY_PERF_CONFIG      3
 #define DRM_I915_QUERY_MEMORY_REGIONS   4
+#define DRM_I915_QUERY_HWCONFIG_TABLE   5
 /* Must be kept compact -- no holes and well documented */
 
 	/**
Signature · 1 line
2.25.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#8 lore raw

Re: [PATCH 2/3] drm/i915/uapi: Add query for hwconfig table

In reply to [email protected]
Quoted 43 lines · On 10.06.2021 22:46, [email protected] wrote:

From: Rodrigo Vivi <[email protected]>

GuC contains a consolidated table with a bunch of information about the current device.

Previously, this information was spread and hardcoded to all the components including GuC, i915 and various UMDs. The goal here is to consolidate the data into GuC in a way that all interested components can grab the very latest and synchronized information using a simple query.

As per most of the other queries, this one can be called twice. Once with item.length=0 to determine the exact buffer size, then allocate the user memory and call it again for to retrieve the table data. For example:

  struct drm_i915_query_item item = {
    .query_id = DRM_I915_QUERY_HWCONCFIG_TABLE;

};
query.items_ptr = (int64_t) &item;
query.num_items = 1;

  ioctl(fd, DRM_IOCTL_I915_QUERY, query, sizeof(query));

if (item.length <= 0)

    return -ENOENT;
  data = malloc(item.length);
  item.data_ptr = (int64_t) &data;
  ioctl(fd, DRM_IOCTL_I915_QUERY, query, sizeof(query));

// Parse the data as appropriate...

The returned array is a simple and flexible KLV (Key/Length/Value) formatted table. For example, it could be just:
enum device_attr {
ATTR_SOME_VALUE = 0,
ATTR_SOME_MASK = 1,
};

  static const u32 hwconfig[] = {
      ATTR_SOME_VALUE,
      1,             // Value Length in DWords
      8,             // Value
Quoted 4 lines
      ATTR_SOME_MASK,
      3,
      0x00FFFFFFFF, 0xFFFFFFFF, 0xFF000000,

};

same example was already added to code in previous patch maybe just refer to that documentation ?

Quoted 3 lines

The attribute ids are defined in a hardware spec. The current list as known to the i915 driver can be found in i915/gt/intel_guc_hwconfig_types.h

previous patch introduced i915/gt/intel_hwconfig_types.h

also, i915 seems to be not using any/many of them directly, so it could happen that GuC will return new/updated klvs, so shouldn't we make this klv list more external and maybe even define as uabi header?

Quoted 18 lines
Cc Tvrtko Ursulin <[email protected]>
Cc Kenneth Graunke <[email protected]>
Cc Michal Wajdeczko <[email protected]>
Cc Slawomir Milczarek <[email protected]>
---
 drivers/gpu/drm/i915/i915_query.c | 23 +++++++++++++++++++++++
 include/uapi/drm/i915_drm.h       |  1 +
 2 files changed, 24 insertions(+)
drivers/gpu/drm/i915/i915_query.c +0 -0
index e49da36c62fb..96bd8fb3e895 100644
@@ -480,12 +480,35 @@ static int query_memregion_info(struct drm_i915_private *i915,
 	return total_length;

drivers/gpu/drm/i915/i915_query.c static int query_memregion_info(struct drm_i915_private *i915, · line 490

Quoted 10 lines
drivers/gpu/drm/i915/i915_query.c +8 -0
 }
 
+static int query_hwconfig_table(struct drm_i915_private *i915,
+				struct drm_i915_query_item *query_item)
+{
+	struct intel_gt *gt = &i915->gt;
+	struct intel_guc_hwconfig *hwconfig = &gt->uc.guc.hwconfig;
+
+	if (!hwconfig->size || !hwconfig->ptr)
+		return -ENODEV;

shouldn't we also have:

	if (query_item->flags != 0)
		return -EINVAL;
Quoted 29 lines
drivers/gpu/drm/i915/i915_query.c +15 -0
+
+	if (query_item->length == 0)
+		return hwconfig->size;
+
+	if (query_item->length < hwconfig->size)
+		return -EINVAL;
+
+	if (copy_to_user(u64_to_user_ptr(query_item->data_ptr),
+			 hwconfig->ptr, hwconfig->size))
+		return -EFAULT;
+
+	return hwconfig->size;
+}
+
 static int (* const i915_query_funcs[])(struct drm_i915_private *dev_priv,
 					struct drm_i915_query_item *query_item) = {
 	query_topology_info,
 	query_engine_info,
 	query_perf_config,
 	query_memregion_info,
+	query_hwconfig_table,
 };
 
 int i915_query_ioctl(struct drm_device *dev, void *data, struct drm_file *file)
include/uapi/drm/i915_drm.h +0 -0
index c2c7759b7d2e..87d369cae22a 100644

include/uapi/drm/i915_drm.h struct drm_i915_query_item { · line 2236

Quoted 4 lines
include/uapi/drm/i915_drm.h +1 -0
@@ -2233,6 +2233,7 @@ struct drm_i915_query_item {
 #define DRM_I915_QUERY_ENGINE_INFO	2
 #define DRM_I915_QUERY_PERF_CONFIG      3
 #define DRM_I915_QUERY_MEMORY_REGIONS   4
+#define DRM_I915_QUERY_HWCONFIG_TABLE   5

hmm, not sure is this single line satisfies below "well documented" requirement ;)

Quoted 4 lines
include/uapi/drm/i915_drm.h +0 -0
 /* Must be kept compact -- no holes and well documented */
 
 	/**
#9 lore raw

PATCH 3/3 drm/i915/uapi: Add query for L3 bank count

In reply to [email protected]

From: John Harrison <[email protected]>

Various UMDs need to know the L3 bank count. So add a query API for it.

---
 drivers/gpu/drm/i915/gt/intel_gt.c | 15 +++++++++++++++
 drivers/gpu/drm/i915/gt/intel_gt.h |  1 +
 drivers/gpu/drm/i915/i915_query.c  | 22 ++++++++++++++++++++++
 drivers/gpu/drm/i915/i915_reg.h    |  1 +
 include/uapi/drm/i915_drm.h        |  1 +
 5 files changed, 40 insertions(+)
drivers/gpu/drm/i915/gt/intel_gt.c +15 -0
index 2161bf01ef8b..708bb3581d83 100644
@@ -704,3 +704,18 @@ void intel_gt_info_print(const struct intel_gt_info *info,
 
 	intel_sseu_dump(&info->sseu, p);
 }
+
+int intel_gt_get_l3bank_count(struct intel_gt *gt)
+{
+	struct drm_i915_private *i915 = gt->i915;
+	intel_wakeref_t wakeref;
+	u32 fuse3;
+
+	if (GRAPHICS_VER(i915) < 12)
+		return -ENODEV;
+
+	with_intel_runtime_pm(gt->uncore->rpm, wakeref)
+		fuse3 = intel_uncore_read(gt->uncore, GEN10_MIRROR_FUSE3);
+
+	return hweight32(REG_FIELD_GET(GEN12_GT_L3_MODE_MASK, ~fuse3));
+}
drivers/gpu/drm/i915/gt/intel_gt.h +1 -0
index 7ec395cace69..46aa1cf4cf30 100644
@@ -77,6 +77,7 @@ static inline bool intel_gt_is_wedged(const struct intel_gt *gt)
 
 void intel_gt_info_print(const struct intel_gt_info *info,
 			 struct drm_printer *p);
+int intel_gt_get_l3bank_count(struct intel_gt *gt);
 
 void intel_gt_watchdog_work(struct work_struct *work);
 
drivers/gpu/drm/i915/i915_query.c +22 -0
index 96bd8fb3e895..0e92bb2d21b2 100644
@@ -10,6 +10,7 @@
 #include "i915_perf.h"
 #include "i915_query.h"
 #include <uapi/drm/i915_drm.h>
+#include "gt/intel_gt.h"
 
 static int copy_query_item(void *query_hdr, size_t query_sz,
 			   u32 total_length,
@@ -502,6 +503,26 @@ static int query_hwconfig_table(struct drm_i915_private *i915,
 	return hwconfig->size;
 }
 
+static int query_l3banks(struct drm_i915_private *i915,
+			 struct drm_i915_query_item *query_item)
+{
+	u32 banks;
+
+	if (query_item->length == 0)
+		return sizeof(banks);
+
+	if (query_item->length < sizeof(banks))
+		return -EINVAL;
+
+	banks = intel_gt_get_l3bank_count(&i915->gt);
+
+	if (copy_to_user(u64_to_user_ptr(query_item->data_ptr),
+			 &banks, sizeof(banks)))
+		return -EFAULT;
+
+	return sizeof(banks);
+}
+
 static int (* const i915_query_funcs[])(struct drm_i915_private *dev_priv,
 					struct drm_i915_query_item *query_item) = {
 	query_topology_info,
@@ -509,6 +530,7 @@ static int (* const i915_query_funcs[])(struct drm_i915_private *dev_priv,
 	query_perf_config,
 	query_memregion_info,
 	query_hwconfig_table,
+	query_l3banks,
 };
 
 int i915_query_ioctl(struct drm_device *dev, void *data, struct drm_file *file)
drivers/gpu/drm/i915/i915_reg.h +1 -0
index eb13c601d680..e9ba88fe3db7 100644
@@ -3099,6 +3099,7 @@ static inline bool i915_mmio_reg_valid(i915_reg_t reg)
 #define	GEN10_MIRROR_FUSE3		_MMIO(0x9118)
 #define GEN10_L3BANK_PAIR_COUNT     4
 #define GEN10_L3BANK_MASK   0x0F
+#define GEN12_GT_L3_MODE_MASK 0xFF
 
 #define GEN8_EU_DISABLE0		_MMIO(0x9134)
 #define   GEN8_EU_DIS0_S0_MASK		0xffffff
include/uapi/drm/i915_drm.h +1 -0
index 87d369cae22a..20d18cca5066 100644
@@ -2234,6 +2234,7 @@ struct drm_i915_query_item {
 #define DRM_I915_QUERY_PERF_CONFIG      3
 #define DRM_I915_QUERY_MEMORY_REGIONS   4
 #define DRM_I915_QUERY_HWCONFIG_TABLE   5
+#define DRM_I915_QUERY_L3_BANK_COUNT    6
 /* Must be kept compact -- no holes and well documented */
 
 	/**
Signature · 6 lines
2.25.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Reviewed-by on v1 3/3
#10 lore raw

Re: [Intel-gfx] [PATCH 3/3] drm/i915/uapi: Add query for L3 bank count

Quoted 18 lines · On Thu, Jun 10, 2021 at 01:46:26PM -0700, [email protected] wrote:

From: John Harrison <[email protected]>

Various UMDs need to know the L3 bank count. So add a query API for it.

---
 drivers/gpu/drm/i915/gt/intel_gt.c | 15 +++++++++++++++
 drivers/gpu/drm/i915/gt/intel_gt.h |  1 +
 drivers/gpu/drm/i915/i915_query.c  | 22 ++++++++++++++++++++++
 drivers/gpu/drm/i915/i915_reg.h    |  1 +
 include/uapi/drm/i915_drm.h        |  1 +
 5 files changed, 40 insertions(+)
drivers/gpu/drm/i915/gt/intel_gt.c +0 -0
index 2161bf01ef8b..708bb3581d83 100644

drivers/gpu/drm/i915/gt/intel_gt.c void intel_gt_info_print(const struct intel_gt_info *info, · line 708

Quoted 5 lines
drivers/gpu/drm/i915/gt/intel_gt.c +2 -0
@@ -704,3 +704,18 @@ void intel_gt_info_print(const struct intel_gt_info *info,
 
 	intel_sseu_dump(&info->sseu, p);
 }
+
+int intel_gt_get_l3bank_count(struct intel_gt *gt)

Small nit, this function is ..'l3bank_count' while the define for query is ..'L3_BANK_COUNT'. I'm thinking this function should have a space between l3 & bank for consistency.

Quoted 65 lines
drivers/gpu/drm/i915/gt/intel_gt.c +13 -0
+{
+	struct drm_i915_private *i915 = gt->i915;
+	intel_wakeref_t wakeref;
+	u32 fuse3;
+
+	if (GRAPHICS_VER(i915) < 12)
+		return -ENODEV;
+
+	with_intel_runtime_pm(gt->uncore->rpm, wakeref)
+		fuse3 = intel_uncore_read(gt->uncore, GEN10_MIRROR_FUSE3);
+
+	return hweight32(REG_FIELD_GET(GEN12_GT_L3_MODE_MASK, ~fuse3));
+}
drivers/gpu/drm/i915/gt/intel_gt.h +1 -0
index 7ec395cace69..46aa1cf4cf30 100644
@@ -77,6 +77,7 @@ static inline bool intel_gt_is_wedged(const struct intel_gt *gt)
 
 void intel_gt_info_print(const struct intel_gt_info *info,
 			 struct drm_printer *p);
+int intel_gt_get_l3bank_count(struct intel_gt *gt);
 
 void intel_gt_watchdog_work(struct work_struct *work);
 
drivers/gpu/drm/i915/i915_query.c +21 -0
index 96bd8fb3e895..0e92bb2d21b2 100644
@@ -10,6 +10,7 @@
 #include "i915_perf.h"
 #include "i915_query.h"
 #include <uapi/drm/i915_drm.h>
+#include "gt/intel_gt.h"
 
 static int copy_query_item(void *query_hdr, size_t query_sz,
 			   u32 total_length,
@@ -502,6 +503,26 @@ static int query_hwconfig_table(struct drm_i915_private *i915,
 	return hwconfig->size;
 }
 
+static int query_l3banks(struct drm_i915_private *i915,
+			 struct drm_i915_query_item *query_item)
+{
+	u32 banks;
+
+	if (query_item->length == 0)
+		return sizeof(banks);
+
+	if (query_item->length < sizeof(banks))
+		return -EINVAL;
+
+	banks = intel_gt_get_l3bank_count(&i915->gt);
+
+	if (copy_to_user(u64_to_user_ptr(query_item->data_ptr),
+			 &banks, sizeof(banks)))
+		return -EFAULT;
+
+	return sizeof(banks);
+}
+
 static int (* const i915_query_funcs[])(struct drm_i915_private *dev_priv,
 					struct drm_i915_query_item *query_item) = {
 	query_topology_info,

drivers/gpu/drm/i915/i915_query.c static int (* const i915_query_funcs[])(struct drm_i915_private *dev_priv, · line 533

Quoted 4 lines
drivers/gpu/drm/i915/i915_query.c +1 -0
@@ -509,6 +530,7 @@ static int (* const i915_query_funcs[])(struct drm_i915_private *dev_priv,
 	query_perf_config,
 	query_memregion_info,
 	query_hwconfig_table,
+	query_l3banks,

Another nit, for consistency query_l3banks -> query_l3_bank_count.

With these nits fixed:

Quoted 34 lines
drivers/gpu/drm/i915/i915_query.c +0 -0
 };
 
 int i915_query_ioctl(struct drm_device *dev, void *data, struct drm_file *file)
drivers/gpu/drm/i915/i915_reg.h +1 -0
index eb13c601d680..e9ba88fe3db7 100644
@@ -3099,6 +3099,7 @@ static inline bool i915_mmio_reg_valid(i915_reg_t reg)
 #define	GEN10_MIRROR_FUSE3		_MMIO(0x9118)
 #define GEN10_L3BANK_PAIR_COUNT     4
 #define GEN10_L3BANK_MASK   0x0F
+#define GEN12_GT_L3_MODE_MASK 0xFF
 
 #define GEN8_EU_DISABLE0		_MMIO(0x9134)
 #define   GEN8_EU_DIS0_S0_MASK		0xffffff
include/uapi/drm/i915_drm.h +1 -0
index 87d369cae22a..20d18cca5066 100644
@@ -2234,6 +2234,7 @@ struct drm_i915_query_item {
 #define DRM_I915_QUERY_PERF_CONFIG      3
 #define DRM_I915_QUERY_MEMORY_REGIONS   4
 #define DRM_I915_QUERY_HWCONFIG_TABLE   5
+#define DRM_I915_QUERY_L3_BANK_COUNT    6
 /* Must be kept compact -- no holes and well documented */
 
 	/**
Signature · 6 lines
2.25.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#11 lore raw

Re: [Intel-gfx] [PATCH 3/3] drm/i915/uapi: Add query for L3 bank count

In reply to [email protected]
Quoted 61 lines · On 10.06.2021 22:46, [email protected] wrote:

From: John Harrison <[email protected]>

Various UMDs need to know the L3 bank count. So add a query API for it.

---
 drivers/gpu/drm/i915/gt/intel_gt.c | 15 +++++++++++++++
 drivers/gpu/drm/i915/gt/intel_gt.h |  1 +
 drivers/gpu/drm/i915/i915_query.c  | 22 ++++++++++++++++++++++
 drivers/gpu/drm/i915/i915_reg.h    |  1 +
 include/uapi/drm/i915_drm.h        |  1 +
 5 files changed, 40 insertions(+)
drivers/gpu/drm/i915/gt/intel_gt.c +15 -0
index 2161bf01ef8b..708bb3581d83 100644
@@ -704,3 +704,18 @@ void intel_gt_info_print(const struct intel_gt_info *info,
 
 	intel_sseu_dump(&info->sseu, p);
 }
+
+int intel_gt_get_l3bank_count(struct intel_gt *gt)
+{
+	struct drm_i915_private *i915 = gt->i915;
+	intel_wakeref_t wakeref;
+	u32 fuse3;
+
+	if (GRAPHICS_VER(i915) < 12)
+		return -ENODEV;
+
+	with_intel_runtime_pm(gt->uncore->rpm, wakeref)
+		fuse3 = intel_uncore_read(gt->uncore, GEN10_MIRROR_FUSE3);
+
+	return hweight32(REG_FIELD_GET(GEN12_GT_L3_MODE_MASK, ~fuse3));
+}
drivers/gpu/drm/i915/gt/intel_gt.h +1 -0
index 7ec395cace69..46aa1cf4cf30 100644
@@ -77,6 +77,7 @@ static inline bool intel_gt_is_wedged(const struct intel_gt *gt)
 
 void intel_gt_info_print(const struct intel_gt_info *info,
 			 struct drm_printer *p);
+int intel_gt_get_l3bank_count(struct intel_gt *gt);
 
 void intel_gt_watchdog_work(struct work_struct *work);
 
drivers/gpu/drm/i915/i915_query.c +1 -0
index 96bd8fb3e895..0e92bb2d21b2 100644
@@ -10,6 +10,7 @@
 #include "i915_perf.h"
 #include "i915_query.h"
 #include <uapi/drm/i915_drm.h>
+#include "gt/intel_gt.h"
 
 static int copy_query_item(void *query_hdr, size_t query_sz,
 			   u32 total_length,

drivers/gpu/drm/i915/i915_query.c static int query_hwconfig_table(struct drm_i915_private *i915, · line 509

Quoted 7 lines
drivers/gpu/drm/i915/i915_query.c +4 -0
@@ -502,6 +503,26 @@ static int query_hwconfig_table(struct drm_i915_private *i915,
 	return hwconfig->size;
 }
 
+static int query_l3banks(struct drm_i915_private *i915,
+			 struct drm_i915_query_item *query_item)
+{
+	u32 banks;

likely we also need to check:

	if (query_item->flags != 0)
		return -EINVAL;
Quoted 52 lines
drivers/gpu/drm/i915/i915_query.c +17 -0
+
+	if (query_item->length == 0)
+		return sizeof(banks);
+
+	if (query_item->length < sizeof(banks))
+		return -EINVAL;
+
+	banks = intel_gt_get_l3bank_count(&i915->gt);
+
+	if (copy_to_user(u64_to_user_ptr(query_item->data_ptr),
+			 &banks, sizeof(banks)))
+		return -EFAULT;
+
+	return sizeof(banks);
+}
+
 static int (* const i915_query_funcs[])(struct drm_i915_private *dev_priv,
 					struct drm_i915_query_item *query_item) = {
 	query_topology_info,
@@ -509,6 +530,7 @@ static int (* const i915_query_funcs[])(struct drm_i915_private *dev_priv,
 	query_perf_config,
 	query_memregion_info,
 	query_hwconfig_table,
+	query_l3banks,
 };
 
 int i915_query_ioctl(struct drm_device *dev, void *data, struct drm_file *file)
drivers/gpu/drm/i915/i915_reg.h +1 -0
index eb13c601d680..e9ba88fe3db7 100644
@@ -3099,6 +3099,7 @@ static inline bool i915_mmio_reg_valid(i915_reg_t reg)
 #define	GEN10_MIRROR_FUSE3		_MMIO(0x9118)
 #define GEN10_L3BANK_PAIR_COUNT     4
 #define GEN10_L3BANK_MASK   0x0F
+#define GEN12_GT_L3_MODE_MASK 0xFF
 
 #define GEN8_EU_DISABLE0		_MMIO(0x9134)
 #define   GEN8_EU_DIS0_S0_MASK		0xffffff
include/uapi/drm/i915_drm.h +1 -0
index 87d369cae22a..20d18cca5066 100644
@@ -2234,6 +2234,7 @@ struct drm_i915_query_item {
 #define DRM_I915_QUERY_PERF_CONFIG      3
 #define DRM_I915_QUERY_MEMORY_REGIONS   4
 #define DRM_I915_QUERY_HWCONFIG_TABLE   5
+#define DRM_I915_QUERY_L3_BANK_COUNT    6
 /* Must be kept compact -- no holes and well documented */
 
 	/**
#12 lore raw

Re: [Intel-gfx] [PATCH 3/3] drm/i915/uapi: Add query for L3 bank count

In reply to [email protected]
Quoted 112 lines · On 10/06/2021 23:46, [email protected] wrote:

From: John Harrison <[email protected]>

Various UMDs need to know the L3 bank count. So add a query API for it.

---
  drivers/gpu/drm/i915/gt/intel_gt.c | 15 +++++++++++++++
  drivers/gpu/drm/i915/gt/intel_gt.h |  1 +
  drivers/gpu/drm/i915/i915_query.c  | 22 ++++++++++++++++++++++
  drivers/gpu/drm/i915/i915_reg.h    |  1 +
  include/uapi/drm/i915_drm.h        |  1 +
  5 files changed, 40 insertions(+)
drivers/gpu/drm/i915/gt/intel_gt.c +15 -0
index 2161bf01ef8b..708bb3581d83 100644
@@ -704,3 +704,18 @@ void intel_gt_info_print(const struct intel_gt_info *info,
 
  	intel_sseu_dump(&info->sseu, p);
  }
+
+int intel_gt_get_l3bank_count(struct intel_gt *gt)
+{
+	struct drm_i915_private *i915 = gt->i915;
+	intel_wakeref_t wakeref;
+	u32 fuse3;
+
+	if (GRAPHICS_VER(i915) < 12)
+		return -ENODEV;
+
+	with_intel_runtime_pm(gt->uncore->rpm, wakeref)
+		fuse3 = intel_uncore_read(gt->uncore, GEN10_MIRROR_FUSE3);
+
+	return hweight32(REG_FIELD_GET(GEN12_GT_L3_MODE_MASK, ~fuse3));
+}
drivers/gpu/drm/i915/gt/intel_gt.h +1 -0
index 7ec395cace69..46aa1cf4cf30 100644
@@ -77,6 +77,7 @@ static inline bool intel_gt_is_wedged(const struct intel_gt *gt)
 
  void intel_gt_info_print(const struct intel_gt_info *info,
  			 struct drm_printer *p);
+int intel_gt_get_l3bank_count(struct intel_gt *gt);
 
  void intel_gt_watchdog_work(struct work_struct *work);
 
drivers/gpu/drm/i915/i915_query.c +22 -0
index 96bd8fb3e895..0e92bb2d21b2 100644
@@ -10,6 +10,7 @@
  #include "i915_perf.h"
  #include "i915_query.h"
  #include <uapi/drm/i915_drm.h>
+#include "gt/intel_gt.h"
 
  static int copy_query_item(void *query_hdr, size_t query_sz,
  			   u32 total_length,
@@ -502,6 +503,26 @@ static int query_hwconfig_table(struct drm_i915_private *i915,
  	return hwconfig->size;
  }
 
+static int query_l3banks(struct drm_i915_private *i915,
+			 struct drm_i915_query_item *query_item)
+{
+	u32 banks;
+
+	if (query_item->length == 0)
+		return sizeof(banks);
+
+	if (query_item->length < sizeof(banks))
+		return -EINVAL;
+
+	banks = intel_gt_get_l3bank_count(&i915->gt);
+
+	if (copy_to_user(u64_to_user_ptr(query_item->data_ptr),
+			 &banks, sizeof(banks)))
+		return -EFAULT;
+
+	return sizeof(banks);
+}
+
  static int (* const i915_query_funcs[])(struct drm_i915_private *dev_priv,
  					struct drm_i915_query_item *query_item) = {
  	query_topology_info,
@@ -509,6 +530,7 @@ static int (* const i915_query_funcs[])(struct drm_i915_private *dev_priv,
  	query_perf_config,
  	query_memregion_info,
  	query_hwconfig_table,
+	query_l3banks,
  };
 
  int i915_query_ioctl(struct drm_device *dev, void *data, struct drm_file *file)
drivers/gpu/drm/i915/i915_reg.h +1 -0
index eb13c601d680..e9ba88fe3db7 100644
@@ -3099,6 +3099,7 @@ static inline bool i915_mmio_reg_valid(i915_reg_t reg)
  #define	GEN10_MIRROR_FUSE3		_MMIO(0x9118)
  #define GEN10_L3BANK_PAIR_COUNT     4
  #define GEN10_L3BANK_MASK   0x0F
+#define GEN12_GT_L3_MODE_MASK 0xFF
 
  #define GEN8_EU_DISABLE0		_MMIO(0x9134)
  #define   GEN8_EU_DIS0_S0_MASK		0xffffff
include/uapi/drm/i915_drm.h +0 -0
index 87d369cae22a..20d18cca5066 100644

include/uapi/drm/i915_drm.h struct drm_i915_query_item { · line 2237

Quoted 4 lines
include/uapi/drm/i915_drm.h +1 -0
@@ -2234,6 +2234,7 @@ struct drm_i915_query_item {
  #define DRM_I915_QUERY_PERF_CONFIG      3
  #define DRM_I915_QUERY_MEMORY_REGIONS   4
  #define DRM_I915_QUERY_HWCONFIG_TABLE   5
+#define DRM_I915_QUERY_L3_BANK_COUNT    6

A little bit of documentation about the format of the return data would be nice :)

-Lionel

include/uapi/drm/i915_drm.h struct drm_i915_query_item { · line 2240

Quoted 3 lines
include/uapi/drm/i915_drm.h +0 -0
  /* Must be kept compact -- no holes and well documented */
 
  	/**

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#13 lore raw

Re: [Intel-gfx] [PATCH 3/3] drm/i915/uapi: Add query for L3 bank count

In reply to [email protected]
Quoted 66 lines · On 10/06/2021 21:46, [email protected] wrote:

From: John Harrison <[email protected]>

Various UMDs need to know the L3 bank count. So add a query API for it.

---
  drivers/gpu/drm/i915/gt/intel_gt.c | 15 +++++++++++++++
  drivers/gpu/drm/i915/gt/intel_gt.h |  1 +
  drivers/gpu/drm/i915/i915_query.c  | 22 ++++++++++++++++++++++
  drivers/gpu/drm/i915/i915_reg.h    |  1 +
  include/uapi/drm/i915_drm.h        |  1 +
  5 files changed, 40 insertions(+)
drivers/gpu/drm/i915/gt/intel_gt.c +15 -0
index 2161bf01ef8b..708bb3581d83 100644
@@ -704,3 +704,18 @@ void intel_gt_info_print(const struct intel_gt_info *info,
 
  	intel_sseu_dump(&info->sseu, p);
  }
+
+int intel_gt_get_l3bank_count(struct intel_gt *gt)
+{
+	struct drm_i915_private *i915 = gt->i915;
+	intel_wakeref_t wakeref;
+	u32 fuse3;
+
+	if (GRAPHICS_VER(i915) < 12)
+		return -ENODEV;
+
+	with_intel_runtime_pm(gt->uncore->rpm, wakeref)
+		fuse3 = intel_uncore_read(gt->uncore, GEN10_MIRROR_FUSE3);
+
+	return hweight32(REG_FIELD_GET(GEN12_GT_L3_MODE_MASK, ~fuse3));
+}
drivers/gpu/drm/i915/gt/intel_gt.h +1 -0
index 7ec395cace69..46aa1cf4cf30 100644
@@ -77,6 +77,7 @@ static inline bool intel_gt_is_wedged(const struct intel_gt *gt)
 
  void intel_gt_info_print(const struct intel_gt_info *info,
  			 struct drm_printer *p);
+int intel_gt_get_l3bank_count(struct intel_gt *gt);
 
  void intel_gt_watchdog_work(struct work_struct *work);
 
drivers/gpu/drm/i915/i915_query.c +3 -0
index 96bd8fb3e895..0e92bb2d21b2 100644
@@ -10,6 +10,7 @@
  #include "i915_perf.h"
  #include "i915_query.h"
  #include <uapi/drm/i915_drm.h>
+#include "gt/intel_gt.h"
 
  static int copy_query_item(void *query_hdr, size_t query_sz,
  			   u32 total_length,
@@ -502,6 +503,26 @@ static int query_hwconfig_table(struct drm_i915_private *i915,
  	return hwconfig->size;
  }
 
+static int query_l3banks(struct drm_i915_private *i915,
+			 struct drm_i915_query_item *query_item)

drivers/gpu/drm/i915/i915_query.c static int query_hwconfig_table(struct drm_i915_private *i915, · line 517

Quoted 10 lines
drivers/gpu/drm/i915/i915_query.c +10 -0
+{
+	u32 banks;
+
+	if (query_item->length == 0)
+		return sizeof(banks);
+
+	if (query_item->length < sizeof(banks))
+		return -EINVAL;
+
+	banks = intel_gt_get_l3bank_count(&i915->gt);

Having spotted i915->gt I am thinking whether this should be future proofed to take, say, struct i915_engine_class_instance as input. If one need different GTs will have different L3 config. Alternative is adding a new query at that point. No strong opinion either way.

Otherwise yes, I agree with adding flags mbz check and documenting the uapi as other people have suggested.

Regards,

Tvrtko

Quoted 44 lines
drivers/gpu/drm/i915/i915_query.c +9 -0
+
+	if (copy_to_user(u64_to_user_ptr(query_item->data_ptr),
+			 &banks, sizeof(banks)))
+		return -EFAULT;
+
+	return sizeof(banks);
+}
+
  static int (* const i915_query_funcs[])(struct drm_i915_private *dev_priv,
  					struct drm_i915_query_item *query_item) = {
  	query_topology_info,
@@ -509,6 +530,7 @@ static int (* const i915_query_funcs[])(struct drm_i915_private *dev_priv,
  	query_perf_config,
  	query_memregion_info,
  	query_hwconfig_table,
+	query_l3banks,
  };
 
  int i915_query_ioctl(struct drm_device *dev, void *data, struct drm_file *file)
drivers/gpu/drm/i915/i915_reg.h +1 -0
index eb13c601d680..e9ba88fe3db7 100644
@@ -3099,6 +3099,7 @@ static inline bool i915_mmio_reg_valid(i915_reg_t reg)
  #define	GEN10_MIRROR_FUSE3		_MMIO(0x9118)
  #define GEN10_L3BANK_PAIR_COUNT     4
  #define GEN10_L3BANK_MASK   0x0F
+#define GEN12_GT_L3_MODE_MASK 0xFF
 
  #define GEN8_EU_DISABLE0		_MMIO(0x9134)
  #define   GEN8_EU_DIS0_S0_MASK		0xffffff
include/uapi/drm/i915_drm.h +1 -0
index 87d369cae22a..20d18cca5066 100644
@@ -2234,6 +2234,7 @@ struct drm_i915_query_item {
  #define DRM_I915_QUERY_PERF_CONFIG      3
  #define DRM_I915_QUERY_MEMORY_REGIONS   4
  #define DRM_I915_QUERY_HWCONFIG_TABLE   5
+#define DRM_I915_QUERY_L3_BANK_COUNT    6
  /* Must be kept compact -- no holes and well documented */
 
  	/**
#14 lore raw

Re: [Intel-gfx] [PATCH 3/3] drm/i915/uapi: Add query for L3 bank count

In reply to [email protected]
Quoted 4 lines · On Thu, Jun 10, 2021 at 10:46 PM <[email protected]> wrote:

From: John Harrison <[email protected]>

Various UMDs need to know the L3 bank count. So add a query API for it.

Please link to both the igt test submission for this (there's not even a Test-with: on the cover letter) and the merge requests for the various UMD which uses new uapi. Also as other mentioned, full uapi kerneldoc is needed too. Please fill in any gaps in the existing docs that relate to your addition directly (like we've e.g. done for the extension chaining when adding lmem support).

Thanks, Daniel

Quoted 123 lines
---
 drivers/gpu/drm/i915/gt/intel_gt.c | 15 +++++++++++++++
 drivers/gpu/drm/i915/gt/intel_gt.h |  1 +
 drivers/gpu/drm/i915/i915_query.c  | 22 ++++++++++++++++++++++
 drivers/gpu/drm/i915/i915_reg.h    |  1 +
 include/uapi/drm/i915_drm.h        |  1 +
 5 files changed, 40 insertions(+)
drivers/gpu/drm/i915/gt/intel_gt.c +15 -0
index 2161bf01ef8b..708bb3581d83 100644
@@ -704,3 +704,18 @@ void intel_gt_info_print(const struct intel_gt_info *info,
 
        intel_sseu_dump(&info->sseu, p);
 }
+
+int intel_gt_get_l3bank_count(struct intel_gt *gt)
+{
+       struct drm_i915_private *i915 = gt->i915;
+       intel_wakeref_t wakeref;
+       u32 fuse3;
+
+       if (GRAPHICS_VER(i915) < 12)
+               return -ENODEV;
+
+       with_intel_runtime_pm(gt->uncore->rpm, wakeref)
+               fuse3 = intel_uncore_read(gt->uncore, GEN10_MIRROR_FUSE3);
+
+       return hweight32(REG_FIELD_GET(GEN12_GT_L3_MODE_MASK, ~fuse3));
+}
drivers/gpu/drm/i915/gt/intel_gt.h +1 -0
index 7ec395cace69..46aa1cf4cf30 100644
@@ -77,6 +77,7 @@ static inline bool intel_gt_is_wedged(const struct intel_gt *gt)
 
 void intel_gt_info_print(const struct intel_gt_info *info,
                         struct drm_printer *p);
+int intel_gt_get_l3bank_count(struct intel_gt *gt);
 
 void intel_gt_watchdog_work(struct work_struct *work);
 
drivers/gpu/drm/i915/i915_query.c +22 -0
index 96bd8fb3e895..0e92bb2d21b2 100644
@@ -10,6 +10,7 @@
 #include "i915_perf.h"
 #include "i915_query.h"
 #include <uapi/drm/i915_drm.h>
+#include "gt/intel_gt.h"
 
 static int copy_query_item(void *query_hdr, size_t query_sz,
                           u32 total_length,
@@ -502,6 +503,26 @@ static int query_hwconfig_table(struct drm_i915_private *i915,
        return hwconfig->size;
 }
 
+static int query_l3banks(struct drm_i915_private *i915,
+                        struct drm_i915_query_item *query_item)
+{
+       u32 banks;
+
+       if (query_item->length == 0)
+               return sizeof(banks);
+
+       if (query_item->length < sizeof(banks))
+               return -EINVAL;
+
+       banks = intel_gt_get_l3bank_count(&i915->gt);
+
+       if (copy_to_user(u64_to_user_ptr(query_item->data_ptr),
+                        &banks, sizeof(banks)))
+               return -EFAULT;
+
+       return sizeof(banks);
+}
+
 static int (* const i915_query_funcs[])(struct drm_i915_private *dev_priv,
                                        struct drm_i915_query_item *query_item) = {
        query_topology_info,
@@ -509,6 +530,7 @@ static int (* const i915_query_funcs[])(struct drm_i915_private *dev_priv,
        query_perf_config,
        query_memregion_info,
        query_hwconfig_table,
+       query_l3banks,
 };
 
 int i915_query_ioctl(struct drm_device *dev, void *data, struct drm_file *file)
drivers/gpu/drm/i915/i915_reg.h +1 -0
index eb13c601d680..e9ba88fe3db7 100644
@@ -3099,6 +3099,7 @@ static inline bool i915_mmio_reg_valid(i915_reg_t reg)
 #define        GEN10_MIRROR_FUSE3              _MMIO(0x9118)
 #define GEN10_L3BANK_PAIR_COUNT     4
 #define GEN10_L3BANK_MASK   0x0F
+#define GEN12_GT_L3_MODE_MASK 0xFF
 
 #define GEN8_EU_DISABLE0               _MMIO(0x9134)
 #define   GEN8_EU_DIS0_S0_MASK         0xffffff
include/uapi/drm/i915_drm.h +1 -1
index 87d369cae22a..20d18cca5066 100644
@@ -2234,6 +2234,7 @@ struct drm_i915_query_item {
 #define DRM_I915_QUERY_PERF_CONFIG      3
 #define DRM_I915_QUERY_MEMORY_REGIONS   4
 #define DRM_I915_QUERY_HWCONFIG_TABLE   5
+#define DRM_I915_QUERY_L3_BANK_COUNT    6
 /* Must be kept compact -- no holes and well documented */
 
        /**
--

2.25.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Signature · 3 lines
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
#15 lore raw

Re: [Intel-gfx] [PATCH 3/3] drm/i915/uapi: Add query for L3 bank count

Quoted 6 lines · Daniel Vetter
Quoted 3 lines · On Thu, Jun 10, 2021 at 10:46 PM <[email protected]> wrote:

From: John Harrison <[email protected]>

Various UMDs need to know the L3 bank count. So add a query API for it.

Please link to both the igt test submission for this (there's not even a Test-with: on the cover letter)

Is there a wiki page that describes all such tags? That is not one I was aware of and I can't find anything in the Kernel patch submission wiki or DRM maintainers wiki that mentions it.

Quoted 2 lines

and the merge requests for the
various UMD which uses new uapi.

Is there a particular tag to use for this?

John.

Quoted 121 lines

Also as other mentioned, full uapi
kerneldoc is needed too. Please fill in any gaps in the existing docs that relate to your addition directly (like we've e.g. done for the extension chaining when adding lmem support).

Thanks, Daniel

Quoted 114 lines
---
  drivers/gpu/drm/i915/gt/intel_gt.c | 15 +++++++++++++++
  drivers/gpu/drm/i915/gt/intel_gt.h |  1 +
  drivers/gpu/drm/i915/i915_query.c  | 22 ++++++++++++++++++++++
  drivers/gpu/drm/i915/i915_reg.h    |  1 +
  include/uapi/drm/i915_drm.h        |  1 +
  5 files changed, 40 insertions(+)
drivers/gpu/drm/i915/gt/intel_gt.c +15 -0
index 2161bf01ef8b..708bb3581d83 100644
@@ -704,3 +704,18 @@ void intel_gt_info_print(const struct intel_gt_info *info,
 
         intel_sseu_dump(&info->sseu, p);
  }
+
+int intel_gt_get_l3bank_count(struct intel_gt *gt)
+{
+       struct drm_i915_private *i915 = gt->i915;
+       intel_wakeref_t wakeref;
+       u32 fuse3;
+
+       if (GRAPHICS_VER(i915) < 12)
+               return -ENODEV;
+
+       with_intel_runtime_pm(gt->uncore->rpm, wakeref)
+               fuse3 = intel_uncore_read(gt->uncore, GEN10_MIRROR_FUSE3);
+
+       return hweight32(REG_FIELD_GET(GEN12_GT_L3_MODE_MASK, ~fuse3));
+}
drivers/gpu/drm/i915/gt/intel_gt.h +1 -0
index 7ec395cace69..46aa1cf4cf30 100644
@@ -77,6 +77,7 @@ static inline bool intel_gt_is_wedged(const struct intel_gt *gt)
 
  void intel_gt_info_print(const struct intel_gt_info *info,
                          struct drm_printer *p);
+int intel_gt_get_l3bank_count(struct intel_gt *gt);
 
  void intel_gt_watchdog_work(struct work_struct *work);
 
drivers/gpu/drm/i915/i915_query.c +22 -0
index 96bd8fb3e895..0e92bb2d21b2 100644
@@ -10,6 +10,7 @@
  #include "i915_perf.h"
  #include "i915_query.h"
  #include <uapi/drm/i915_drm.h>
+#include "gt/intel_gt.h"
 
  static int copy_query_item(void *query_hdr, size_t query_sz,
                            u32 total_length,
@@ -502,6 +503,26 @@ static int query_hwconfig_table(struct drm_i915_private *i915,
         return hwconfig->size;
  }
 
+static int query_l3banks(struct drm_i915_private *i915,
+                        struct drm_i915_query_item *query_item)
+{
+       u32 banks;
+
+       if (query_item->length == 0)
+               return sizeof(banks);
+
+       if (query_item->length < sizeof(banks))
+               return -EINVAL;
+
+       banks = intel_gt_get_l3bank_count(&i915->gt);
+
+       if (copy_to_user(u64_to_user_ptr(query_item->data_ptr),
+                        &banks, sizeof(banks)))
+               return -EFAULT;
+
+       return sizeof(banks);
+}
+
  static int (* const i915_query_funcs[])(struct drm_i915_private *dev_priv,
                                         struct drm_i915_query_item *query_item) = {
         query_topology_info,
@@ -509,6 +530,7 @@ static int (* const i915_query_funcs[])(struct drm_i915_private *dev_priv,
         query_perf_config,
         query_memregion_info,
         query_hwconfig_table,
+       query_l3banks,
  };
 
  int i915_query_ioctl(struct drm_device *dev, void *data, struct drm_file *file)
drivers/gpu/drm/i915/i915_reg.h +1 -0
index eb13c601d680..e9ba88fe3db7 100644
@@ -3099,6 +3099,7 @@ static inline bool i915_mmio_reg_valid(i915_reg_t reg)
  #define        GEN10_MIRROR_FUSE3              _MMIO(0x9118)
  #define GEN10_L3BANK_PAIR_COUNT     4
  #define GEN10_L3BANK_MASK   0x0F
+#define GEN12_GT_L3_MODE_MASK 0xFF
 
  #define GEN8_EU_DISABLE0               _MMIO(0x9134)
  #define   GEN8_EU_DIS0_S0_MASK         0xffffff
include/uapi/drm/i915_drm.h +1 -0
index 87d369cae22a..20d18cca5066 100644
@@ -2234,6 +2234,7 @@ struct drm_i915_query_item {
  #define DRM_I915_QUERY_PERF_CONFIG      3
  #define DRM_I915_QUERY_MEMORY_REGIONS   4
  #define DRM_I915_QUERY_HWCONFIG_TABLE   5
+#define DRM_I915_QUERY_L3_BANK_COUNT    6
  /* Must be kept compact -- no holes and well documented */
 
Quoted 10 lines
Quoted 8 lines
include/uapi/drm/i915_drm.h +0 -1
         /**
--

2.25.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#16 lore raw

Re: [Intel-gfx] [PATCH 3/3] drm/i915/uapi: Add query for L3 bank count

Quoted 10 lines · John Harrison
Quoted 6 lines · Daniel Vetter
Quoted 3 lines · On Thu, Jun 10, 2021 at 10:46 PM <[email protected]> wrote:

From: John Harrison <[email protected]>

Various UMDs need to know the L3 bank count. So add a query API for it.

Please link to both the igt test submission for this (there's not even a Test-with: on the cover letter)

Is there a wiki page that describes all such tags? That is not one I was aware of and I can't find anything in the Kernel patch submission wiki or DRM maintainers wiki that mentions it.

It's in the CI docs (linked from the main page too)

https://intel-gfx-ci.01.org/test-with.html

Quoted 3 lines
Quoted 2 lines

and the merge requests for the
various UMD which uses new uapi.

Is there a particular tag to use for this?

I think often just a link to the merge request in the cover letter. Sometimes people also put the link in the uapi patch itself in the commit message. Which I think would be best.
-Daniel

Quoted 135 lines

John.

Quoted 131 lines

Also as other mentioned, full uapi
kerneldoc is needed too. Please fill in any gaps in the existing docs that relate to your addition directly (like we've e.g. done for the extension chaining when adding lmem support).

Thanks, Daniel

Quoted 122 lines
---
  drivers/gpu/drm/i915/gt/intel_gt.c | 15 +++++++++++++++
  drivers/gpu/drm/i915/gt/intel_gt.h |  1 +
  drivers/gpu/drm/i915/i915_query.c  | 22 ++++++++++++++++++++++
  drivers/gpu/drm/i915/i915_reg.h    |  1 +
  include/uapi/drm/i915_drm.h        |  1 +
  5 files changed, 40 insertions(+)
drivers/gpu/drm/i915/gt/intel_gt.c +15 -0
index 2161bf01ef8b..708bb3581d83 100644
@@ -704,3 +704,18 @@ void intel_gt_info_print(const struct intel_gt_info *info,
 
         intel_sseu_dump(&info->sseu, p);
  }
+
+int intel_gt_get_l3bank_count(struct intel_gt *gt)
+{
+       struct drm_i915_private *i915 = gt->i915;
+       intel_wakeref_t wakeref;
+       u32 fuse3;
+
+       if (GRAPHICS_VER(i915) < 12)
+               return -ENODEV;
+
+       with_intel_runtime_pm(gt->uncore->rpm, wakeref)
+               fuse3 = intel_uncore_read(gt->uncore, GEN10_MIRROR_FUSE3);
+
+       return hweight32(REG_FIELD_GET(GEN12_GT_L3_MODE_MASK, ~fuse3));
+}
drivers/gpu/drm/i915/gt/intel_gt.h +1 -0
index 7ec395cace69..46aa1cf4cf30 100644
@@ -77,6 +77,7 @@ static inline bool intel_gt_is_wedged(const struct intel_gt *gt)
 
  void intel_gt_info_print(const struct intel_gt_info *info,
                          struct drm_printer *p);
+int intel_gt_get_l3bank_count(struct intel_gt *gt);
 
  void intel_gt_watchdog_work(struct work_struct *work);
 
drivers/gpu/drm/i915/i915_query.c +22 -0
index 96bd8fb3e895..0e92bb2d21b2 100644
@@ -10,6 +10,7 @@
  #include "i915_perf.h"
  #include "i915_query.h"
  #include <uapi/drm/i915_drm.h>
+#include "gt/intel_gt.h"
 
  static int copy_query_item(void *query_hdr, size_t query_sz,
                            u32 total_length,
@@ -502,6 +503,26 @@ static int query_hwconfig_table(struct drm_i915_private *i915,
         return hwconfig->size;
  }
 
+static int query_l3banks(struct drm_i915_private *i915,
+                        struct drm_i915_query_item *query_item)
+{
+       u32 banks;
+
+       if (query_item->length == 0)
+               return sizeof(banks);
+
+       if (query_item->length < sizeof(banks))
+               return -EINVAL;
+
+       banks = intel_gt_get_l3bank_count(&i915->gt);
+
+       if (copy_to_user(u64_to_user_ptr(query_item->data_ptr),
+                        &banks, sizeof(banks)))
+               return -EFAULT;
+
+       return sizeof(banks);
+}
+
  static int (* const i915_query_funcs[])(struct drm_i915_private *dev_priv,
                                         struct drm_i915_query_item *query_item) = {
         query_topology_info,
@@ -509,6 +530,7 @@ static int (* const i915_query_funcs[])(struct drm_i915_private *dev_priv,
         query_perf_config,
         query_memregion_info,
         query_hwconfig_table,
+       query_l3banks,
  };
 
  int i915_query_ioctl(struct drm_device *dev, void *data, struct drm_file *file)
drivers/gpu/drm/i915/i915_reg.h +1 -0
index eb13c601d680..e9ba88fe3db7 100644
@@ -3099,6 +3099,7 @@ static inline bool i915_mmio_reg_valid(i915_reg_t reg)
  #define        GEN10_MIRROR_FUSE3              _MMIO(0x9118)
  #define GEN10_L3BANK_PAIR_COUNT     4
  #define GEN10_L3BANK_MASK   0x0F
+#define GEN12_GT_L3_MODE_MASK 0xFF
 
  #define GEN8_EU_DISABLE0               _MMIO(0x9134)
  #define   GEN8_EU_DIS0_S0_MASK         0xffffff
include/uapi/drm/i915_drm.h +1 -1
index 87d369cae22a..20d18cca5066 100644
@@ -2234,6 +2234,7 @@ struct drm_i915_query_item {
  #define DRM_I915_QUERY_PERF_CONFIG      3
  #define DRM_I915_QUERY_MEMORY_REGIONS   4
  #define DRM_I915_QUERY_HWCONFIG_TABLE   5
+#define DRM_I915_QUERY_L3_BANK_COUNT    6
  /* Must be kept compact -- no holes and well documented */
 
         /**
--

2.25.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Signature · 3 lines
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
#17 lore raw

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Add support for querying hw info that UMDs need

In reply to [email protected]
== Series Details ==

== Series Details ==

Series: Add support for querying hw info that UMDs need
URL : https://patchwork.freedesktop.org/series/91353/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
aec94293496a drm/i915/guc: Add fetch of hwconfig table
-:33: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#33: 
new file mode 100644

total: 0 errors, 1 warnings, 0 checks, 359 lines checked d2f683792bb5 drm/i915/uapi: Add query for hwconfig table 57f8dceec930 drm/i915/uapi: Add query for L3 bank count

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#18 lore raw

[Intel-gfx] ✓ Fi.CI.BAT: success for Add support for querying hw info that UMDs need

In reply to [email protected]
== Series Details ==

== Series Details ==

Series: Add support for querying hw info that UMDs need
URL : https://patchwork.freedesktop.org/series/91353/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_10205 -> Patchwork_20338
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/index.html

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_20338:

### IGT changes ###

#### Suppressed ####

The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.

* igt@runner@aborted:
- {fi-jsl-1}: [FAIL][1] ([i915#1222]) -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/fi-jsl-1/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/fi-jsl-1/igt@[email protected]
- {fi-ehl-2}: [FAIL][3] ([i915#1222]) -> [FAIL][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/fi-ehl-2/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/fi-ehl-2/igt@[email protected]

Known issues
------------

Here are the changes found in Patchwork_20338 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@kms_chamelium@dp-crc-fast:
- fi-kbl-7500u: [PASS][5] -> [FAIL][6] ([i915#1372])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/fi-kbl-7500u/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/fi-kbl-7500u/igt@[email protected]

#### Warnings ####

* igt@i915_selftest@live@execlists:
- fi-bsw-nick: [DMESG-FAIL][7] ([i915#3462]) -> [INCOMPLETE][8] ([i915#2782] / [i915#2940] / [i915#3462])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/fi-bsw-nick/igt@i915_selftest@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/fi-bsw-nick/igt@i915_selftest@[email protected]
- fi-bsw-kefka: [DMESG-FAIL][9] ([i915#3462]) -> [INCOMPLETE][10] ([i915#2782] / [i915#2940] / [i915#3462])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/fi-bsw-kefka/igt@i915_selftest@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/fi-bsw-kefka/igt@i915_selftest@[email protected]

* igt@runner@aborted:
- fi-kbl-7567u: [FAIL][11] ([i915#1436] / [i915#2426] / [i915#3363]) -> [FAIL][12] ([i915#1436] / [i915#3363])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/fi-kbl-7567u/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/fi-kbl-7567u/igt@[email protected]
- fi-skl-6700k2: [FAIL][13] ([i915#1436] / [i915#2426] / [i915#3363]) -> [FAIL][14] ([i915#1436] / [i915#3363])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/fi-skl-6700k2/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/fi-skl-6700k2/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1222]: https://gitlab.freedesktop.org/drm/intel/issues/1222
[i915#1372]: https://gitlab.freedesktop.org/drm/intel/issues/1372
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2426]: https://gitlab.freedesktop.org/drm/intel/issues/2426
[i915#2782]: https://gitlab.freedesktop.org/drm/intel/issues/2782
[i915#2940]: https://gitlab.freedesktop.org/drm/intel/issues/2940
[i915#3012]: https://gitlab.freedesktop.org/drm/intel/issues/3012
[i915#3276]: https://gitlab.freedesktop.org/drm/intel/issues/3276
[i915#3277]: https://gitlab.freedesktop.org/drm/intel/issues/3277
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3283]: https://gitlab.freedesktop.org/drm/intel/issues/3283
[i915#3363]: https://gitlab.freedesktop.org/drm/intel/issues/3363
[i915#3462]: https://gitlab.freedesktop.org/drm/intel/issues/3462
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3542]: https://gitlab.freedesktop.org/drm/intel/issues/3542
[i915#3544]: https://gitlab.freedesktop.org/drm/intel/issues/3544
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533

Participating hosts (46 -> 38)
------------------------------

Additional (1): fi-rkl-11500t
Missing (9): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-glk-dsi fi-bsw-cyan bat-adlp-4 bat-adls-4 fi-bdw-samus bat-jsl-1

Build changes
-------------

* Linux: CI_DRM_10205 -> Patchwork_20338

CI-20190529: 20190529
CI_DRM_10205: e3375fd2aeeb2416a8e8c8b59d106adf9c0dd938 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6103: 3aa79e55e73d4a49a5222e5dfde486b800a29fe7 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_20338: 57f8dceec930c4f27987c779cbe71dc0688ceebc @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

57f8dceec930 drm/i915/uapi: Add query for L3 bank count d2f683792bb5 drm/i915/uapi: Add query for hwconfig table aec94293496a drm/i915/guc: Add fetch of hwconfig table

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/index.html

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#19 lore raw

[Intel-gfx] ✓ Fi.CI.IGT: success for Add support for querying hw info that UMDs need

In reply to [email protected]
== Series Details ==

== Series Details ==

Series: Add support for querying hw info that UMDs need
URL : https://patchwork.freedesktop.org/series/91353/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_10205_full -> Patchwork_20338_full
====================================================

Summary
-------

**SUCCESS**

No regressions found.

Known issues
------------

Here are the changes found in Patchwork_20338_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_ctx_persistence@clone:
- shard-snb: NOTRUN -> [SKIP][1] ([fdo#109271] / [i915#1099]) +4 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/shard-snb7/igt@[email protected]

* igt@gem_eio@unwedge-stress:
- shard-snb: NOTRUN -> [FAIL][2] ([i915#3354])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/shard-snb6/igt@[email protected]

* igt@gem_exec_fair@basic-flow@rcs0:
- shard-skl: NOTRUN -> [SKIP][3] ([fdo#109271]) +51 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/shard-skl3/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-tglb: [PASS][4] -> [FAIL][5] ([i915#2842])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-tglb8/igt@gem_exec_fair@[email protected]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/shard-tglb6/igt@gem_exec_fair@[email protected]

* igt@gem_huc_copy@huc-copy:
- shard-skl: NOTRUN -> [SKIP][6] ([fdo#109271] / [i915#2190])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/shard-skl3/igt@[email protected]

* igt@gem_mmap_gtt@big-copy-xy:
- shard-skl: [PASS][7] -> [FAIL][8] ([i915#307])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-skl3/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/shard-skl8/igt@[email protected]

* igt@gem_userptr_blits@dmabuf-sync:
- shard-apl: NOTRUN -> [SKIP][9] ([fdo#109271] / [i915#3323])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/shard-apl2/igt@[email protected]

* igt@gem_userptr_blits@input-checking:
- shard-skl: NOTRUN -> [DMESG-WARN][10] ([i915#3002])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/shard-skl5/igt@[email protected]

* igt@gem_vm_create@destroy-race:
- shard-tglb: [PASS][11] -> [TIMEOUT][12] ([i915#2795])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-tglb8/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/shard-tglb6/igt@[email protected]

* igt@gen7_exec_parse@cmd-crossing-page:
- shard-tglb: NOTRUN -> [SKIP][13] ([fdo#109289])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/shard-tglb2/igt@[email protected]

* igt@gen9_exec_parse@bb-large:
- shard-apl: NOTRUN -> [FAIL][14] ([i915#3296])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/shard-apl3/igt@[email protected]

* igt@i915_module_load@reload-with-fault-injection:
- shard-skl: [PASS][15] -> [DMESG-WARN][16] ([i915#1982]) +1 similar issue
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-skl9/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/shard-skl8/igt@[email protected]

* igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp:
- shard-apl: NOTRUN -> [SKIP][17] ([fdo#109271] / [i915#1937])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/shard-apl3/igt@i915_pm_lpsp@[email protected]

* igt@kms_big_fb@yf-tiled-16bpp-rotate-270:
- shard-tglb: NOTRUN -> [SKIP][18] ([fdo#111615]) +1 similar issue
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/shard-tglb2/igt@[email protected]

* igt@kms_ccs@pipe-a-ccs-on-another-bo:
- shard-snb: NOTRUN -> [SKIP][19] ([fdo#109271]) +465 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/shard-snb2/igt@[email protected]

* igt@kms_ccs@pipe-c-ccs-on-another-bo:
- shard-skl: NOTRUN -> [SKIP][20] ([fdo#109271] / [fdo#111304])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/shard-skl7/igt@[email protected]

* igt@kms_chamelium@hdmi-audio:
- shard-skl: NOTRUN -> [SKIP][21] ([fdo#109271] / [fdo#111827]) +3 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/shard-skl3/igt@[email protected]

* igt@kms_chamelium@vga-edid-read:
- shard-apl: NOTRUN -> [SKIP][22] ([fdo#109271] / [fdo#111827]) +18 similar issues
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/shard-apl6/igt@[email protected]
- shard-kbl: NOTRUN -> [SKIP][23] ([fdo#109271] / [fdo#111827]) +1 similar issue
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/shard-kbl4/igt@[email protected]

* igt@kms_color_chamelium@pipe-a-ctm-limited-range:
- shard-tglb: NOTRUN -> [SKIP][24] ([fdo#109284] / [fdo#111827]) +2 similar issues
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/shard-tglb2/igt@[email protected]

* igt@kms_color_chamelium@pipe-invalid-ctm-matrix-sizes:
- shard-snb: NOTRUN -> [SKIP][25] ([fdo#109271] / [fdo#111827]) +25 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/shard-snb5/igt@[email protected]

* igt@kms_content_protection@srm:
- shard-apl: NOTRUN -> [TIMEOUT][26] ([i915#1319])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/shard-apl2/igt@[email protected]

* igt@kms_cursor_crc@pipe-b-cursor-suspend:
- shard-kbl: NOTRUN -> [DMESG-WARN][27] ([i915#180])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/shard-kbl7/igt@[email protected]

* igt@kms_cursor_crc@pipe-c-cursor-suspend:
- shard-kbl: [PASS][28] -> [DMESG-WARN][29] ([i915#180]) +3 similar issues
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-kbl4/igt@[email protected]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/shard-kbl6/igt@[email protected]

* igt@kms_cursor_crc@pipe-d-cursor-512x512-sliding:
- shard-tglb: NOTRUN -> [SKIP][30] ([fdo#109279] / [i915#3359]) +1 similar issue
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/shard-tglb2/igt@[email protected]

* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-skl: [PASS][31] -> [FAIL][32] ([i915#2346])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-skl8/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/shard-skl9/igt@[email protected]

* igt@kms_fbcon_fbt@fbc-suspend:
- shard-apl: NOTRUN -> [INCOMPLETE][33] ([i915#180] / [i915#1982])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/shard-apl6/igt@[email protected]

* igt@kms_flip@flip-vs-expired-vblank-interruptible@a-hdmi-a1:
- shard-glk: [PASS][34] -> [FAIL][35] ([i915#79])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-glk9/igt@kms_flip@[email protected]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/shard-glk6/igt@kms_flip@[email protected]

* igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile:
- shard-skl: NOTRUN -> [SKIP][36] ([fdo#109271] / [i915#2642])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/shard-skl3/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-blt:
- shard-kbl: NOTRUN -> [SKIP][37] ([fdo#109271]) +39 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/shard-kbl2/igt@[email protected]

* igt@kms_frontbuffer_tracking@psr-1p-pri-indfb-multidraw:
- shard-skl: [PASS][38] -> [FAIL][39] ([i915#49])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-skl9/igt@[email protected]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/shard-skl4/igt@[email protected]

* igt@kms_frontbuffer_tracking@psr-2p-scndscrn-pri-indfb-draw-pwrite:
- shard-tglb: NOTRUN -> [SKIP][40] ([fdo#111825]) +5 similar issues
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/shard-tglb2/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-pri-indfb-draw-pwrite.html

* igt@kms_hdr@bpc-switch:
- shard-skl: [PASS][41] -> [FAIL][42] ([i915#1188])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-skl7/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/shard-skl1/igt@[email protected]

* igt@kms_pipe_crc_basic@disable-crc-after-crtc-pipe-d:
- shard-apl: NOTRUN -> [SKIP][43] ([fdo#109271] / [i915#533])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/shard-apl2/igt@[email protected]

* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
- shard-apl: [PASS][44] -> [DMESG-WARN][45] ([i915#180]) +1 similar issue
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-apl6/igt@[email protected]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/shard-apl1/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-b-alpha-transparent-fb:
- shard-kbl: NOTRUN -> [FAIL][46] ([i915#265])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/shard-kbl2/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-c-alpha-opaque-fb:
- shard-apl: NOTRUN -> [FAIL][47] ([fdo#108145] / [i915#265]) +1 similar issue
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/shard-apl2/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min:
- shard-kbl: [PASS][48] -> [FAIL][49] ([fdo#108145] / [i915#265])
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-kbl4/igt@[email protected]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/shard-kbl6/igt@[email protected]

* igt@kms_plane_lowres@pipe-c-tiling-none:
- shard-tglb: NOTRUN -> [SKIP][50] ([i915#3536])
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/shard-tglb2/igt@[email protected]

* igt@kms_psr2_sf@plane-move-sf-dmg-area-1:
- shard-kbl: NOTRUN -> [SKIP][51] ([fdo#109271] / [i915#658])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/shard-kbl2/igt@[email protected]

* igt@kms_psr2_sf@plane-move-sf-dmg-area-2:
- shard-apl: NOTRUN -> [SKIP][52] ([fdo#109271] / [i915#658]) +4 similar issues
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/shard-apl2/igt@[email protected]

* igt@kms_psr@psr2_cursor_plane_move:
- shard-iclb: [PASS][53] -> [SKIP][54] ([fdo#109441]) +2 similar issues
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-iclb2/igt@kms_psr@psr2_cursor_plane_move.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/shard-iclb3/igt@kms_psr@psr2_cursor_plane_move.html

* igt@kms_psr@psr2_primary_mmap_gtt:
- shard-tglb: NOTRUN -> [FAIL][55] ([i915#132] / [i915#3467])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/shard-tglb2/igt@kms_psr@psr2_primary_mmap_gtt.html

* igt@kms_setmode@basic:
- shard-snb: NOTRUN -> [FAIL][56] ([i915#31])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/shard-snb2/igt@[email protected]

* igt@kms_vrr@flip-basic:
- shard-tglb: NOTRUN -> [SKIP][57] ([fdo#109502])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/shard-tglb2/igt@[email protected]

* igt@kms_writeback@writeback-fb-id:
- shard-kbl: NOTRUN -> [SKIP][58] ([fdo#109271] / [i915#2437])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/shard-kbl4/igt@[email protected]

* igt@kms_writeback@writeback-pixel-formats:
- shard-apl: NOTRUN -> [SKIP][59] ([fdo#109271] / [i915#2437])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/shard-apl6/igt@[email protected]

* igt@prime_nv_api@i915_nv_reimport_twice_check_flink_name:
- shard-apl: NOTRUN -> [SKIP][60] ([fdo#109271]) +185 similar issues
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/shard-apl3/igt@prime_nv_api@i915_nv_reimport_twice_check_flink_name.html

* igt@prime_nv_pcopy@test3_2:
- shard-tglb: NOTRUN -> [SKIP][61] ([fdo#109291])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/shard-tglb2/igt@prime_nv_pcopy@test3_2.html

* igt@sysfs_clients@fair-7:
- shard-skl: NOTRUN -> [SKIP][62] ([fdo#109271] / [i915#2994]) +1 similar issue
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/shard-skl7/igt@[email protected]

#### Possible fixes ####

* igt@gem_exec_fair@basic-flow@rcs0:
- shard-tglb: [FAIL][63] ([i915#2842]) -> [PASS][64] +1 similar issue
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-tglb1/igt@gem_exec_fair@[email protected]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/shard-tglb7/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-none@vcs0:
- shard-kbl: [FAIL][65] ([i915#2842]) -> [PASS][66] +2 similar issues
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-kbl2/igt@gem_exec_fair@[email protected]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/shard-kbl3/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace@rcs0:
- shard-glk: [FAIL][67] ([i915#2842]) -> [PASS][68]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-glk2/igt@gem_exec_fair@[email protected]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/shard-glk4/igt@gem_exec_fair@[email protected]

* igt@gem_exec_whisper@basic-fds-forked-all:
- shard-glk: [DMESG-WARN][69] ([i915#118] / [i915#95]) -> [PASS][70] +1 similar issue
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-glk7/igt@[email protected]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/shard-glk5/igt@[email protected]

* igt@gem_mmap_gtt@big-copy:
- shard-glk: [FAIL][71] ([i915#307]) -> [PASS][72]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-glk2/igt@[email protected]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/shard-glk3/igt@[email protected]

* igt@gem_mmap_gtt@cpuset-big-copy-xy:
- shard-iclb: [FAIL][73] ([i915#2428]) -> [PASS][74]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-iclb1/igt@[email protected]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/shard-iclb1/igt@[email protected]

* igt@gem_mmap_offset@clear:
- shard-skl: [FAIL][75] ([i915#3160]) -> [PASS][76]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-skl8/igt@[email protected]
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/shard-skl9/igt@[email protected]
- shard-iclb: [FAIL][77] ([i915#3160]) -> [PASS][78]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-iclb8/igt@[email protected]
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/shard-iclb4/igt@[email protected]

* igt@gem_spin_batch@engines@bcs0:
- shard-apl: [FAIL][79] ([i915#2898]) -> [PASS][80]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-apl3/igt@gem_spin_batch@[email protected]
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/shard-apl8/igt@gem_spin_batch@[email protected]

* igt@kms_color@pipe-c-ctm-0-5:
- shard-skl: [DMESG-WARN][81] ([i915#1982]) -> [PASS][82]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-skl8/igt@[email protected]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/shard-skl4/igt@[email protected]

* igt@kms_flip@flip-vs-expired-vblank-interruptible@a-hdmi-a2:
- shard-glk: [FAIL][83] ([i915#79]) -> [PASS][84]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-glk9/igt@kms_flip@[email protected]
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/shard-glk6/igt@kms_flip@[email protected]

* igt@kms_flip@flip-vs-suspend-interruptible@b-dp1:
- shard-apl: [DMESG-WARN][85] ([i915#180]) -> [PASS][86]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-apl8/igt@kms_flip@[email protected]
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/shard-apl2/igt@kms_flip@[email protected]

* igt@kms_hdr@bpc-switch-suspend:
- shard-kbl: [DMESG-WARN][87] ([i915#180]) -> [PASS][88] +5 similar issues
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-kbl3/igt@[email protected]
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/shard-kbl4/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [FAIL][89] ([fdo#108145] / [i915#265]) -> [PASS][90]
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-skl4/igt@[email protected]
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/shard-skl9/igt@[email protected]

* igt@kms_psr@psr2_primary_mmap_cpu:
- shard-iclb: [SKIP][91] ([fdo#109441]) -> [PASS][92] +1 similar issue
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-iclb1/igt@kms_psr@psr2_primary_mmap_cpu.html
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html

* igt@perf@polling-small-buf:
- shard-skl: [FAIL][93] ([i915#1722]) -> [PASS][94]
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-skl1/igt@[email protected]
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/shard-skl3/igt@[email protected]

* igt@prime_vgem@sync@rcs0:
- shard-tglb: [INCOMPLETE][95] ([i915#409]) -> [PASS][96]
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-tglb6/igt@prime_vgem@[email protected]
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/shard-tglb2/igt@prime_vgem@[email protected]

#### Warnings ####

* igt@i915_pm_dc@dc3co-vpb-simulation:
- shard-iclb: [SKIP][97] ([i915#658]) -> [SKIP][98] ([i915#588])
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-iclb4/igt@[email protected]
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/shard-iclb2/igt@[email protected]

* igt@i915_pm_rc6_residency@rc6-idle:
- shard-iclb: [WARN][99] ([i915#2684]) -> [WARN][100] ([i915#1804] / [i915#2684])
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-iclb8/igt@[email protected]
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/shard-iclb4/igt@[email protected]

* igt@i915_selftest@live@execlists:
- shard-tglb: [DMESG-FAIL][101] ([i915#3462]) -> [INCOMPLETE][102] ([i915#3462])
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-tglb2/igt@i915_selftest@[email protected]
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/shard-tglb5/igt@i915_selftest@[email protected]

* igt@kms_psr2_sf@plane-move-sf-dmg-area-0:
- shard-iclb: [SKIP][103] ([i915#658]) -> [SKIP][104] ([i915#2920]) +1 similar issue
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-iclb3/igt@[email protected]
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/shard-iclb2/igt@[email protected]

* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-4:
- shard-iclb: [SKIP][105] ([i915#2920]) -> [SKIP][106] ([i915#658]) +1 similar issue
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-iclb2/igt@[email protected]
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/shard-iclb3/igt@[email protected]

* igt@runner@aborted:
- shard-kbl: ([FAIL][107], [FAIL][108], [FAIL][109], [FAIL][110], [FAIL][111], [FAIL][112], [FAIL][113], [FAIL][114], [FAIL][115], [FAIL][116], [FAIL][117], [FAIL][118], [FAIL][119], [FAIL][120], [FAIL][121]) ([fdo#109271] / [i915#1436] / [i915#180] / [i915#1814] / [i915#2505] / [i915#3002] / [i915#3363] / [i915#602]) -> ([FAIL][122], [FAIL][123], [FAIL][124], [FAIL][125], [FAIL][126], [FAIL][127], [FAIL][128], [FAIL][129], [FAIL][130], [FAIL][131], [FAIL][132], [FAIL][133]) ([i915#1436] / [i915#180] / [i915#1814] / [i915#2505] / [i915#3002] / [i915#3363] / [i915#602])
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-kbl6/igt@[email protected]
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-kbl7/igt@[email protected]
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-kbl3/igt@[email protected]
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-kbl2/igt@[email protected]
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-kbl4/igt@[email protected]
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-kbl6/igt@[email protected]
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-kbl1/igt@[email protected]
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-kbl3/igt@[email protected]
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-kbl6/igt@[email protected]
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-kbl4/igt@[email protected]
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-kbl3/igt@[email protected]
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-kbl3/igt@[email protected]
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-kbl7/igt@[email protected]
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-kbl3/igt@[email protected]
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-kbl3/igt@[email protected]
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/shard-kbl4/igt@[email protected]
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/shard-kbl6/igt@[email protected]
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/shard-kbl6/igt@[email protected]
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/shard-kbl7/igt@[email protected]
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/shard-kbl7/igt@[email protected]
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/shard-kbl7/igt@[email protected]
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/shard-kbl3/igt@[email protected]
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/shard-kbl1/igt@[email protected]
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/shard-kbl1/igt@[email protected]
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/shard-kbl1/igt@[email protected]
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/shard-kbl3/igt@[email protected]
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/shard-kbl4/igt@[email protected]
- shard-iclb: ([FAIL][134], [FAIL][135], [FAIL][136]) ([i915#2426] / [i915#2782] / [i915#3002]) -> ([FAIL][137], [FAIL][138], [FAIL][139]) ([i915#2782] / [i915#3002])
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-iclb2/igt@[email protected]
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-iclb8/igt@[email protected]
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-iclb7/igt@[email protected]
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/shard-iclb3/igt@[email protected]
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/shard-iclb4/igt@[email protected]
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/shard-iclb7/igt@[email protected]
- shard-apl: ([FAIL][140], [FAIL][141], [FAIL][142], [FAIL][143]) ([fdo#109271] / [i915#180] / [i915#2426] / [i915#3002] / [i915#3363]) -> ([FAIL][144], [FAIL][145], [FAIL][146], [FAIL][147], [FAIL][148], [FAIL][149]) ([fdo#109271] / [i915#180] / [i915#1814] / [i915#3002] / [i915#3363])
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-apl8/igt@[email protected]
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-apl8/igt@[email protected]
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-apl1/igt@[email protected]
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-apl3/igt@[email protected]
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/shard-apl1/igt@[email protected]
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/shard-apl8/igt@[email protected]
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/shard-apl6/igt@[email protected]
[147]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/shard-apl6/igt@[email protected]
[148]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/shard-apl6/igt@[email protected]
[149]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/shard-apl7/igt@[email protected]
- shard-tglb: ([FAIL][150], [FAIL][151], [FAIL][152], [FAIL][153]) ([i915#1436] / [i915#2426] / [i915#2966] / [i915#3002] / [i915#409]) -> ([FAIL][154], [FAIL][155], [FAIL][156]) ([i915#1436] / [i915#2966] / [i915#3002])
[150]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-tglb8/igt@[email protected]
[151]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-tglb2/igt@[email protected]
[152]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-tglb3/igt@[email protected]
[153]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-tglb6/igt@[email protected]
[154]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/shard-tglb8/igt@[email protected]
[155]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/shard-tglb8/igt@[email protected]
[156]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/shard-tglb5/igt@[email protected]
- shard-skl: ([FAIL][157], [FAIL][158]) ([i915#1436] / [i915#3002] / [i915#3363]) -> ([FAIL][159], [FAIL][160], [FAIL][161]) ([i915#1436] / [i915#2426] / [i915#3002] / [i915#3363])
[157]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-skl2/igt@[email protected]
[158]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-skl5/igt@[email protected]
[159]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/shard-skl8/igt@[email protected]
[160]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/shard-skl5/igt@[email protected]
[161]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/shard-skl10/igt@[email protected]

### Piglit changes ###

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109502]: https://bugs.freedesktop.org/show_bug.cgi?id=109502
[fdo#111304]: https://bugs.freedesktop.org/show_bug.cgi?id=111304
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1188]: https://gi

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20338/index.html

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx