Skip to contentSkip to conversation

PCI: endpoint: Fix use after free in pci_epf_remove_cfs()

PATCH New Shunsuke Mie 1 participant 1 message Jun 11, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 PCI: endpoint: Fix use after free in pci_epf_remove_cfs()

All of entries are freed in a loop, however, the freed entry is accessed by list_del() after the loop.

Fixes ef1433f ("PCI: endpoint: Create configfs entry for each pci_epf_device_id table entry")
---
 drivers/pci/endpoint/pci-epf-core.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/pci/endpoint/pci-epf-core.c +3 -1
index e9289d10f822..538e902b0ba6 100644
@@ -202,8 +202,10 @@ static void pci_epf_remove_cfs(struct pci_epf_driver *driver)
 		return;
 
 	mutex_lock(&pci_epf_mutex);
-	list_for_each_entry_safe(group, tmp, &driver->epf_group, group_entry)
+	list_for_each_entry_safe(group, tmp, &driver->epf_group, group_entry) {
+		list_del(&group->group_entry);
 		pci_ep_cfs_remove_epf_group(group);
+	}
 	list_del(&driver->epf_group);
 	mutex_unlock(&pci_epf_mutex);
 }
Signature · 1 line
2.17.1