Skip to contentSkip to conversation

sload.f2fs: Reword "IMMUTABLE" in strings/comments

PATCH In review Robin Hsu 3 participants 3 messages Jun 11, 2021 – Jun 22, 2021

lore
Share & tools
lore

Robin Hsu

author
#0 lore raw

PATCH 1/1 sload.f2fs: Reword "IMMUTABLE" in strings/comments

From: Robin Hsu <[email protected]>

Since the IMMUTABLE flag for compression is now changed
to F2FS_COMPRESS_RELEASED, some 'IMMUTABLE' words should be changed too:
1. sload help page
2. inline comments

---
 fsck/main.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
fsck/main.c +3 -2
index c07be1e..c0b871b 100644
@@ -149,7 +149,8 @@ void sload_usage()
 	MSG(0, "    * -i or -x: use it many times for multiple extensions.\n");
 	MSG(0, "    * -i and -x cannot be used together..\n");
 	MSG(0, "    -m <num> min compressed blocks per cluster\n");
-	MSG(0, "    -r readonly (IMMUTABLE) for compressed files\n");
+	MSG(0, "    -r read only (to release unused blocks) for compressed "
+			"files\n");
 	MSG(0, "    ------------------------------------------------------\n");
 	MSG(0, "  -d debug level [default:0]\n");
 	MSG(0, "  -V print the version number and exit\n");
@@ -650,7 +651,7 @@ void f2fs_parse_options(int argc, char *argv[])
 				}
 				c.compress.min_blocks = val;
 				break;
-			case 'r': /* compress file to set IMMUTABLE */
+			case 'r': /* for setting F2FS_COMOPRESS_RELEASE */
 				c.compress.required = true;
 				c.compress.readonly = true;
 				break;
Signature · 1 line
2.32.0.272.g935e593368-goog
#1 lore raw

Hi!

fsck/main.c void f2fs_parse_options(int argc, char *argv[]) · line 654

Quoted 13 lines

Since the IMMUTABLE flag for compression is now changed
to F2FS_COMPRESS_RELEASED, some 'IMMUTABLE' words should be changed too:
1. sload help page
2. inline comments

fsck/main.c +1 -1
@@ -650,7 +651,7 @@ void f2fs_parse_options(int argc, char *argv[])
 				}
 				c.compress.min_blocks = val;
 				break;
-			case 'r': /* compress file to set IMMUTABLE */
+			case 'r': /* for setting F2FS_COMOPRESS_RELEASE */

Typo.

Best regards,
Pavel

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
#2 lore raw
Quoted 9 lines · Pavel Machek

Hi!

Quoted 6 lines

Since the IMMUTABLE flag for compression is now changed
to F2FS_COMPRESS_RELEASED, some 'IMMUTABLE' words should be changed too:
1. sload help page
2. inline comments

Quoted 8 lines

fsck/main.c void f2fs_parse_options(int argc, char *argv[]) · line 654

Quoted 6 lines
fsck/main.c +1 -1
@@ -650,7 +651,7 @@ void f2fs_parse_options(int argc, char *argv[])
 				}
 				c.compress.min_blocks = val;
 				break;
-			case 'r': /* compress file to set IMMUTABLE */
+			case 'r': /* for setting F2FS_COMOPRESS_RELEASE */

Typo.

Ah, fixed. Thank you~

Quoted 7 lines

Best regards,
Pavel

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html