Skip to contentSkip to conversation

soc: mediatek: pwarp: delete confusing comments

PATCH In review [email protected] 2 participants 2 messages Jun 11, 2021 – Jun 14, 2021 Arm MediaTek

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 soc: mediatek: pwarp: delete confusing comments

From: Matthias Brugger <[email protected]>

Comments sugguest that MT8195 arb_en_all and int_en_all values need to be confirmed. But actually these values are correct.

---

 drivers/soc/mediatek/mtk-pmic-wrap.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/soc/mediatek/mtk-pmic-wrap.c +2 -2
index 952bc554f443..118eb4acdeb6 100644
@@ -2047,8 +2047,8 @@ static const struct pmic_wrapper_type pwrap_mt8183 = {
 static struct pmic_wrapper_type pwrap_mt8195 = {
 	.regs = mt8195_regs,
 	.type = PWRAP_MT8195,
-	.arb_en_all = 0x777f, /* NEED CONFIRM */
-	.int_en_all = 0x180000, /* NEED CONFIRM */
+	.arb_en_all = 0x777f,
+	.int_en_all = 0x180000,
 	.int1_en_all = 0,
 	.spi_w = PWRAP_MAN_CMD_SPI_WRITE,
 	.wdt_src = PWRAP_WDT_SRC_MASK_ALL,
Signature · 1 line
2.31.1
#1 lore raw

Thank you for your kind assistance.

Many thanks
James Lo

Quoted 31 lines · On Fri, 2021-06-11 at 13:13 +0200, [email protected] wrote:

From: Matthias Brugger <[email protected]>

Comments sugguest that MT8195 arb_en_all and int_en_all values need to
be confirmed. But actually these values are correct.

---

 drivers/soc/mediatek/mtk-pmic-wrap.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/soc/mediatek/mtk-pmic-wrap.c +2 -2
index 952bc554f443..118eb4acdeb6 100644
@@ -2047,8 +2047,8 @@ static const struct pmic_wrapper_type
 pwrap_mt8183 = {
 static struct pmic_wrapper_type pwrap_mt8195 = {
 	.regs = mt8195_regs,
 	.type = PWRAP_MT8195,
-	.arb_en_all = 0x777f, /* NEED CONFIRM */
-	.int_en_all = 0x180000, /* NEED CONFIRM */
+	.arb_en_all = 0x777f,
+	.int_en_all = 0x180000,
 	.int1_en_all = 0,
 	.spi_w = PWRAP_MAN_CMD_SPI_WRITE,

.wdt_src = PWRAP_WDT_SRC_MASK_ALL,