Skip to contentSkip to conversation

Test comment for git-publish

PATCH Superseded Mauro Matteo Cascella 2 participants 3 messages Jun 11, 2021 – Jun 14, 2021

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Test comment for git-publish

---
 hw/rdma/vmw/pvrdma_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
hw/rdma/vmw/pvrdma_main.c +1 -1
index 84ae8024fc..e229c19564 100644
@@ -427,7 +427,7 @@ static void pvrdma_regs_write(void *opaque, hwaddr addr, uint64_t val,
     case PVRDMA_REG_REQUEST:
         if (val == 0) {
             trace_pvrdma_regs_write(addr, val, "REQUEST", "");
-            pvrdma_exec_cmd(dev);
+            pvrdma_exec_cmd(dev); // this is a test comment
         }
         break;
     default:
Signature · 1 line
2.31.1
#1 lore raw
Quoted 19 lines · Mauro Matteo Cascella
---
 hw/rdma/vmw/pvrdma_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
hw/rdma/vmw/pvrdma_main.c +1 -2
index 84ae8024fc..e229c19564 100644
@@ -427,7 +427,7 @@ static void pvrdma_regs_write(void *opaque, hwaddr addr, uint64_t val,
     case PVRDMA_REG_REQUEST:
         if (val == 0) {
             trace_pvrdma_regs_write(addr, val, "REQUEST", "");
-            pvrdma_exec_cmd(dev);
+            pvrdma_exec_cmd(dev); // this is a test comment
         }
         break;
     default:
--
Quoted 2 lines

2.31.1

Sorry, please disregard this "patch" =)

Signature · 3 lines
Mauro Matteo Cascella
Red Hat Product Security
PGP-Key ID: BB3410B0
#2 lore raw
In reply to Mauro Matteo Cascella
Patchew URL: https://patchew.org/QEMU/[email protected]/

Patchew URL: https://patchew.org/QEMU/[email protected]/

Hi,

This series seems to have some coding style problems. See output below for more information:

Type: series
Message-id: [email protected]
Subject: [PATCH] Test comment for git-publish

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
65950dc Test comment for git-publish

=== OUTPUT BEGIN ===
ERROR: do not use C99 // comments
#21: FILE: hw/rdma/vmw/pvrdma_main.c:430:
+ pvrdma_exec_cmd(dev); // this is a test comment

ERROR: Missing Signed-off-by: line(s)

total: 2 errors, 0 warnings, 8 lines checked

Commit 65950dcea24f (Test comment for git-publish) has style problems, please review. If any of these errors are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1

The full log is available at
http://patchew.org/logs/[email protected]/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to [email protected]