Skip to contentSkip to conversation

arm64: dts: qcom: pmi8998: introduce qpnp haptics

PATCH In review Caleb Connolly 2 participants 3 messages Jun 12, 2021 – Jun 13, 2021

Subsystems (3)
Device tree bindings Arm Qualcomm mailing list Arm Qualcomm support
lore
Share & tools
lore

Caleb Connolly

author
#0 lore raw

PATCH 3/4 arm64: dts: qcom: pmi8998: introduce qpnp haptics

Add bindings for Qualcomm QPNP haptics, setting default values used on most devices.

Signed-off-by Caleb Connolly <[email protected]>
---
 arch/arm64/boot/dts/qcom/pmi8998.dtsi | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
arch/arm64/boot/dts/qcom/pmi8998.dtsi +16 -0
index d230c510d4b7..ccf64c1898d4 100644
@@ -1,4 +1,5 @@
 // SPDX-License-Identifier: GPL-2.0
+#include <dt-bindings/input/qcom,qpnp-haptics.h>
 #include <dt-bindings/interrupt-controller/irq.h>
 #include <dt-bindings/spmi/spmi.h>
 

@@ -41,5 +42,20 @@ lab: lab {
 				interrupt-names = "sc-err", "ocp";
 			};
 		};
+
+		qpnp_haptics: qcom,haptics@c000 {
+			compatible = "qcom,qpnp-haptics";
+			reg = <0xc000 0x100>;
+
+			interrupts = <0x3 0xc0 0x0 IRQ_TYPE_EDGE_BOTH>,
+				     <0x3 0xc0 0x1 IRQ_TYPE_EDGE_BOTH>;
+			interrupt-names = "short", "play";
+
+			qcom,wave-shape = <HAP_WAVE_SINE>;
+			qcom,play-mode = <HAP_PLAY_BUFFER>;
+			qcom,brake-pattern = <0x3 0x3 0x2 0x1>;
+
+			status = "disabled";
+		};
 	};
 };

--
2.31.1

#1 lore raw
Quoted 19 lines · Caleb Connolly

Add bindings for Qualcomm QPNP haptics, setting default values used on most devices.

Signed-off-by Caleb Connolly <[email protected]>
---
 arch/arm64/boot/dts/qcom/pmi8998.dtsi | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
arch/arm64/boot/dts/qcom/pmi8998.dtsi +1 -0
index d230c510d4b7..ccf64c1898d4 100644
@@ -1,4 +1,5 @@
 // SPDX-License-Identifier: GPL-2.0
+#include <dt-bindings/input/qcom,qpnp-haptics.h>
 #include <dt-bindings/interrupt-controller/irq.h>
 #include <dt-bindings/spmi/spmi.h>

arch/arm64/boot/dts/qcom/pmi8998.dtsi lab: lab { · line 46

Quoted 5 lines
arch/arm64/boot/dts/qcom/pmi8998.dtsi +2 -0
@@ -41,5 +42,20 @@ lab: lab {
 				interrupt-names = "sc-err", "ocp";
 			};
 		};
+
+		qpnp_haptics: qcom,haptics@c000 {

No qcom, in node name, please.

arch/arm64/boot/dts/qcom/pmi8998.dtsi lab: lab { · line 48

Quoted 2 lines
arch/arm64/boot/dts/qcom/pmi8998.dtsi +2 -0
+			compatible = "qcom,qpnp-haptics";
+			reg = <0xc000 0x100>;

#size-cells is <0>, so this means 2 addresses. Please drop the "length".

Regards,
Bjorn

Quoted 17 lines
arch/arm64/boot/dts/qcom/pmi8998.dtsi +11 -1
+
+			interrupts = <0x3 0xc0 0x0 IRQ_TYPE_EDGE_BOTH>,
+				     <0x3 0xc0 0x1 IRQ_TYPE_EDGE_BOTH>;
+			interrupt-names = "short", "play";
+
+			qcom,wave-shape = <HAP_WAVE_SINE>;
+			qcom,play-mode = <HAP_PLAY_BUFFER>;
+			qcom,brake-pattern = <0x3 0x3 0x2 0x1>;
+
+			status = "disabled";
+		};
 	};
 };
--

2.31.1

#2 lore raw
In reply to Caleb Connolly
Quoted 19 lines · Caleb Connolly

Add bindings for Qualcomm QPNP haptics, setting default values used on most devices.

Signed-off-by Caleb Connolly <[email protected]>
---
 arch/arm64/boot/dts/qcom/pmi8998.dtsi | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
arch/arm64/boot/dts/qcom/pmi8998.dtsi +1 -0
index d230c510d4b7..ccf64c1898d4 100644
@@ -1,4 +1,5 @@
 // SPDX-License-Identifier: GPL-2.0
+#include <dt-bindings/input/qcom,qpnp-haptics.h>
 #include <dt-bindings/interrupt-controller/irq.h>
 #include <dt-bindings/spmi/spmi.h>

arch/arm64/boot/dts/qcom/pmi8998.dtsi lab: lab { · line 46

Quoted 5 lines
arch/arm64/boot/dts/qcom/pmi8998.dtsi +2 -0
@@ -41,5 +42,20 @@ lab: lab {
 				interrupt-names = "sc-err", "ocp";
 			};
 		};
+
+		qpnp_haptics: qcom,haptics@c000 {

Also, please label this pmi8998_haptics, to make it easier to find where it's defined when looking at the .dts.

Thanks,
Bjorn

Quoted 19 lines
arch/arm64/boot/dts/qcom/pmi8998.dtsi +13 -1
+			compatible = "qcom,qpnp-haptics";
+			reg = <0xc000 0x100>;
+
+			interrupts = <0x3 0xc0 0x0 IRQ_TYPE_EDGE_BOTH>,
+				     <0x3 0xc0 0x1 IRQ_TYPE_EDGE_BOTH>;
+			interrupt-names = "short", "play";
+
+			qcom,wave-shape = <HAP_WAVE_SINE>;
+			qcom,play-mode = <HAP_PLAY_BUFFER>;
+			qcom,brake-pattern = <0x3 0x3 0x2 0x1>;
+
+			status = "disabled";
+		};
 	};
 };
--

2.31.1