Skip to contentSkip to conversation

musl: Set UPSTREAM_CHECK_COMMITS

PATCH In review Khem Raj 3 participants 4 messages Jun 12, 2021 – Jun 14, 2021

lore
Share & tools
lore

Khem Raj

author
#0 lore raw

PATCH 1/1 musl: Set UPSTREAM_CHECK_COMMITS

---
 meta/recipes-core/musl/musl_git.bb | 2 ++
 1 file changed, 2 insertions(+)
meta/recipes-core/musl/musl_git.bb +2 -0
index 6569d1b37b..bd9d5f1d4b 100644
@@ -84,3 +84,5 @@ RPROVIDES_${PN} += "ldd libsegfault rtld(GNU_HASH)"
 LEAD_SONAME = "libc.so"
 INSANE_SKIP_${PN}-dev = "staticdev"
 INSANE_SKIP_${PN} = "libdir"
+
+UPSTREAM_CHECK_COMMITS = "1"
Signature · 1 line
2.32.0
Reviewed-by on v1 1/1
#1 lore raw

Hi Khem

Quoted 10 lines · Khem Raj
---
 meta/recipes-core/musl/musl_git.bb | 2 ++
 1 file changed, 2 insertions(+)
meta/recipes-core/musl/musl_git.bb +0 -0
index 6569d1b37b..bd9d5f1d4b 100644

meta/recipes-core/musl/musl_git.bb RPROVIDES_${PN} += "ldd libsegfault rtld(GNU_HASH)" · line 88

Quoted 5 lines
meta/recipes-core/musl/musl_git.bb +2 -0
@@ -84,3 +84,5 @@ RPROVIDES_${PN} += "ldd libsegfault rtld(GNU_HASH)"
 LEAD_SONAME = "libc.so"
 INSANE_SKIP_${PN}-dev = "staticdev"
 INSANE_SKIP_${PN} = "libdir"
+
+UPSTREAM_CHECK_COMMITS = "1"

Thanks for the patch.

I realize that the UPSTREAM_CHECK_COMMITS variable doesn't appear in the documentation, and it's in relatively frequent use.

Would it make sense to propose to add a description based on the initial commit
(https://git.openembedded.org/openembedded-core/commit/?id=591d57877d3d3e659d78c0ed33f4c515e3f6f8fb)?

Thanks in advance,
Michael.

Signature · 3 lines
Michael Opdenacker, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

That would be very useful, but you should check if the entire nomenclature of UPSTREAM_CHECK_* variables is documented as well
(_COMMITS, _REGEX, _URI, _GITTAGREGEX).

Alex

Quoted 45 lines · Michael Opdenacker

Hi Khem

Review

Quoted 6 lines · Khem Raj
---
 meta/recipes-core/musl/musl_git.bb | 2 ++
 1 file changed, 2 insertions(+)
(quoted diff) +0 -0

b/meta/recipes-core/musl/musl_git.bb

meta/recipes-core/musl/musl_git.bb RPROVIDES_${PN} += "ldd libsegfault rtld(GNU_HASH)" · line 88

Quoted 9 lines

index 6569d1b37b..bd9d5f1d4b 100644

meta/recipes-core/musl/musl_git.bb +2 -0
@@ -84,3 +84,5 @@ RPROVIDES_${PN} += "ldd libsegfault rtld(GNU_HASH)"
 LEAD_SONAME = "libc.so"
 INSANE_SKIP_${PN}-dev = "staticdev"
 INSANE_SKIP_${PN} = "libdir"
+
+UPSTREAM_CHECK_COMMITS = "1"

Thanks for the patch.

I realize that the UPSTREAM_CHECK_COMMITS variable doesn't appear in the documentation, and it's in relatively frequent use.

Would it make sense to propose to add a description based on the initial commit
(
https://git.openembedded.org/openembedded-core/commit/?id=591d57877d3d3e659d78c0ed33f4c515e3f6f8fb
)?

Thanks in advance,
Michael.

--
Michael Opdenacker, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

#3 lore raw

Hi Alex,

Quoted 3 lines · Alexander Kanavin

That would be very useful, but you should check if the entire nomenclature of UPSTREAM_CHECK_* variables is documented as well (_COMMITS, _REGEX, _URI, _GITTAGREGEX).

Great, many thanks for the advise!
I filed a bug to keep track of this need:
https://bugzilla.yoctoproject.org/show_bug.cgi?id=14431

Michael.

Signature · 3 lines
Michael Opdenacker, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com