Skip to contentSkip to conversation

mtd-utils-2.1.2: ubihealthd depends on ubifs support

PATCH New Markus Mayer 3 participants 6 messages Jun 9, 2021 – Jun 13, 2021

lore
Share & tools
lore
#0 lore raw

cover mtd-utils-2.1.2: ubihealthd depends on ubifs support

Hi all,

With the enabling of ubihealthd, we are experiencing a new build failure.

https://git.buildroot.net/buildroot/commit/?id=77a0167155c3

Here is what is happening:

Quoted 1 line
Quoted 1 line
Quoted 1 line

mtd 2.1.2 Installing to target

[...]
/usr/bin/install -D -m 0755
/home/mmayer/Development/br-current/output/arm64/build/mtd-2.1.2/ubiformat /home/mmayer/Development/br-current/output/arm64/target/usr/sbin/ubiformat
/usr/bin/install -D -m 0755
/home/mmayer/Development/br-current/output/arm64/build/mtd-2.1.2/ubihealthd /home/mmayer/Development/br-current/output/arm64/target/usr/sbin/ubihealthd
/usr/bin/install: cannot stat
'/home/mmayer/Development/br-current/output/arm64/build/mtd-2.1.2/ubihealthd':
No such file or directory
make[1]: *** [package/pkg-generic.mk:341:
/home/mmayer/Development/br-current/output/arm64/build/mtd-2.1.2/.stamp_target_installed] Error 1
make: *** [Makefile:27: _all] Error 2

The problem is the following:

1. We are building with BR2_PACKAGE_MTD_UBIFS_UTILS unset and, therefore, with --without-ubifs.

2. Building without ubifs leads to "configure" setting its internal variable need_getrandom="no", which trickles down through the autoconf environment.

3. Without getrandom, ubihealthd is not being built ?
From mtd-2.1.2/ubi-utils/Makemodule.am:

?49 if WITH_GETRANDOM
?50 UBI_BINS += ubihealthd
?51 endif

The mtd-utils package is consistent within itself. Everything works as long as "make install" is being called, because it won't try to install ubihealthd, unless it also built it. However, Buildroot has its own install routine. It thinks ubihealthd is enabled and has been built. Therefore, it tries to install it -- which doesn't work if BR2_PACKAGE_MTD_UBIFS_UTILS is unset.

This patch mirrors the --with-ubifs -> ubihealthd dependency within Buildroot. In my tests, it worked either way. It will built and install ubihealthd (when BR2_PACKAGE_MTD_MKFSUBIFS=y) or it will skip building and installing ubihealthd (when BR2_PACKAGE_MTD_MKFSUBIFS is unset).

Thanks,
-Markus

Markus Mayer (1):
mtd-utils-2.1.2: ubihealthd depends on ubifs support

 package/mtd/Config.in | 1 +
 1 file changed, 1 insertion(+)
Signature · 1 line
2.25.1
#1 lore raw

PATCH 1/1 mtd-utils-2.1.2: ubihealthd depends on ubifs support

ubihealthd is only being built, if mtd-utils are being built --with-ubifs. Reflect that dependency within buildroot.

---
 package/mtd/Config.in | 1 +
 1 file changed, 1 insertion(+)
package/mtd/Config.in +1 -0
index c7ad3b3cdc9c..64a7ae19a7e2 100644
@@ -139,6 +139,7 @@ config BR2_PACKAGE_MTD_UBIFORMAT
 
 config BR2_PACKAGE_MTD_UBIHEALTHD
 	bool "ubihealthd"
+	depends on BR2_PACKAGE_MTD_UBIFS_UTILS
 	default y
 
 config BR2_PACKAGE_MTD_UBIMKVOL
Signature · 1 line
2.25.1
#2 lore raw

PATCH 1/1 mtd-utils-2.1.2: ubihealthd depends on ubifs support

Hallo Markus,

Am Do., 10. Juni 2021 um 01:54 Uhr schrieb Markus Mayer via buildroot <[email protected]>:

Quoted 4 lines

ubihealthd is only being built, if mtd-utils are being built --with-ubifs. Reflect that dependency within buildroot.

This seems to fix the issue reported to the commiter:
http://lists.busybox.net/pipermail/buildroot/2021-June/311951.html

Quoted 10 lines
---
 package/mtd/Config.in | 1 +
 1 file changed, 1 insertion(+)
package/mtd/Config.in +0 -0
index c7ad3b3cdc9c..64a7ae19a7e2 100644

package/mtd/Config.in config BR2_PACKAGE_MTD_UBIFORMAT · line 145

Quoted 7 lines
package/mtd/Config.in +1 -0
@@ -139,6 +139,7 @@ config BR2_PACKAGE_MTD_UBIFORMAT
 
 config BR2_PACKAGE_MTD_UBIHEALTHD
        bool "ubihealthd"
+       depends on BR2_PACKAGE_MTD_UBIFS_UTILS
        default y
 
 config BR2_PACKAGE_MTD_UBIMKVOL

Thanks

Signature · 1 line
Heiko
#3 lore raw

PATCH 1/1 mtd-utils-2.1.2: ubihealthd depends on ubifs support

Quoted 6 lines · Heiko Thiery
Quoted 3 lines

ubihealthd is only being built, if mtd-utils are being built --with-ubifs. Reflect that dependency within buildroot.

This seems to fix the issue reported to the commiter:
http://lists.busybox.net/pipermail/buildroot/2021-June/311951.html

Yes, it does look like it would address this issue. Have you been able to confirm that it addresses the problem? If so, can you reply with a Tested-by?

Thanks,
-Markus

Quoted 21 lines
Quoted 10 lines
---
 package/mtd/Config.in | 1 +
 1 file changed, 1 insertion(+)
package/mtd/Config.in +0 -0
index c7ad3b3cdc9c..64a7ae19a7e2 100644

package/mtd/Config.in config BR2_PACKAGE_MTD_UBIFORMAT · line 145

Quoted 7 lines
package/mtd/Config.in +1 -0
@@ -139,6 +139,7 @@ config BR2_PACKAGE_MTD_UBIFORMAT
 
 config BR2_PACKAGE_MTD_UBIHEALTHD
        bool "ubihealthd"
+       depends on BR2_PACKAGE_MTD_UBIFS_UTILS
        default y
 
 config BR2_PACKAGE_MTD_UBIMKVOL

Thanks
--
Heiko

#4 lore raw

PATCH 1/1 mtd-utils-2.1.2: ubihealthd depends on ubifs support

In reply to Markus Mayer

Hi Markus,

Am Do., 10. Juni 2021 um 01:54 Uhr schrieb Markus Mayer via buildroot <[email protected]>:

Quoted 5 lines

ubihealthd is only being built, if mtd-utils are being built --with-ubifs. Reflect that dependency within buildroot.

Quoted 9 lines
---
 package/mtd/Config.in | 1 +
 1 file changed, 1 insertion(+)
package/mtd/Config.in +0 -0
index c7ad3b3cdc9c..64a7ae19a7e2 100644

package/mtd/Config.in config BR2_PACKAGE_MTD_UBIFORMAT · line 145

Quoted 7 lines
package/mtd/Config.in +1 -0
@@ -139,6 +139,7 @@ config BR2_PACKAGE_MTD_UBIFORMAT
 
 config BR2_PACKAGE_MTD_UBIHEALTHD
        bool "ubihealthd"
+       depends on BR2_PACKAGE_MTD_UBIFS_UTILS
        default y
 
 config BR2_PACKAGE_MTD_UBIMKVOL

Thanks

Signature · 1 line
Heiko
#5 lore raw

PATCH 1/1 mtd-utils-2.1.2: ubihealthd depends on ubifs support

In reply to Markus Mayer

Markus, All,

On 2021-06-09 16:48 -0700, Markus Mayer via buildroot spake thusly:

Quoted 13 lines

ubihealthd is only being built, if mtd-utils are being built --with-ubifs. Reflect that dependency within buildroot.

---
 package/mtd/Config.in | 1 +
 1 file changed, 1 insertion(+)
package/mtd/Config.in +0 -0
index c7ad3b3cdc9c..64a7ae19a7e2 100644

package/mtd/Config.in config BR2_PACKAGE_MTD_UBIFORMAT · line 142

Quoted 4 lines
package/mtd/Config.in +1 -0
@@ -139,6 +139,7 @@ config BR2_PACKAGE_MTD_UBIFORMAT
 
 config BR2_PACKAGE_MTD_UBIHEALTHD
 	bool "ubihealthd"
+	depends on BR2_PACKAGE_MTD_UBIFS_UTILS
    # make check-package
    package/mtd/Config.in:143: attributes order: type, default, depends on, select, help (http://nightly.buildroot.org/#_config_files)

Applied to master with the above fixed, thanks.

Regards,
Yann E. MORIN.

Quoted 10 lines
package/mtd/Config.in +0 -0
 	default y
 
 config BR2_PACKAGE_MTD_UBIMKVOL
Signature · 6 lines
2.25.1

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'