Skip to contentSkip to conversation

gpio: pca953x: Add support for the On Semi pca9655

PATCH Applied Peter Robinson 3 participants 4 messages Jun 13, 2021 – Jun 17, 2021 GPIO

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gpio: pca953x: Add support for the On Semi pca9655

The On Semi pca9655 is a 16 bit variant of the On Semi pca9654 GPIO expander, with 16 GPIOs and interrupt functionality.

---
 drivers/gpio/gpio-pca953x.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpio/gpio-pca953x.c +1 -0
index c91d05651596..348040247b0b 100644
@@ -1241,6 +1241,7 @@ static const struct of_device_id pca953x_dt_ids[] = {
 
 	{ .compatible = "onnn,cat9554", .data = OF_953X( 8, PCA_INT), },
 	{ .compatible = "onnn,pca9654", .data = OF_953X( 8, PCA_INT), },
+	{ .compatible = "onnn,pca9655", .data = OF_953X( 16, PCA_INT), },
 
 	{ .compatible = "exar,xra1202", .data = OF_953X( 8, 0), },
 	{ }
Signature · 1 line
2.31.1
#1 lore raw
Quoted 3 lines · Peter Robinson

The On Semi pca9655 is a 16 bit variant of the On Semi pca9654 GPIO expander, with 16 GPIOs and interrupt functionality.

I don't remember the context...

Quoted 3 lines
        { .compatible = "onnn,cat9554", .data = OF_953X( 8, PCA_INT), },
        { .compatible = "onnn,pca9654", .data = OF_953X( 8, PCA_INT), },

+ { .compatible = "onnn,pca9655", .data = OF_953X( 16, PCA_INT), },

...but the first space (before 16) seems not necessary and the idea as far as I can see from here is to have those columns to be indented nicely.

Quoted 2 lines
        { .compatible = "exar,xra1202", .data = OF_953X( 8, 0), },
        { }
Signature · 2 lines
With Best Regards,
Andy Shevchenko
#2 lore raw
Quoted 16 lines · Andy Shevchenko
Quoted 3 lines · Peter Robinson

The On Semi pca9655 is a 16 bit variant of the On Semi pca9654 GPIO expander, with 16 GPIOs and interrupt functionality.

I don't remember the context...

Quoted 3 lines
        { .compatible = "onnn,cat9554", .data = OF_953X( 8, PCA_INT), },
        { .compatible = "onnn,pca9654", .data = OF_953X( 8, PCA_INT), },

+ { .compatible = "onnn,pca9655", .data = OF_953X( 16, PCA_INT), },

...but the first space (before 16) seems not necessary and the idea as far as I can see from here is to have those columns to be indented nicely.

Quoted 6 lines
Quoted 2 lines
        { .compatible = "exar,xra1202", .data = OF_953X( 8, 0), },
        { }

--
With Best Regards,
Andy Shevchenko

I applied the patch and fixed the indentation problem in my tree. Thanks!

Bart

#3 lore raw
Quoted 19 lines · Bartosz Golaszewski
Quoted 16 lines · Andy Shevchenko
Quoted 3 lines · Peter Robinson

The On Semi pca9655 is a 16 bit variant of the On Semi pca9654 GPIO expander, with 16 GPIOs and interrupt functionality.

I don't remember the context...

Quoted 3 lines
        { .compatible = "onnn,cat9554", .data = OF_953X( 8, PCA_INT), },
        { .compatible = "onnn,pca9654", .data = OF_953X( 8, PCA_INT), },

+ { .compatible = "onnn,pca9655", .data = OF_953X( 16, PCA_INT), },

...but the first space (before 16) seems not necessary and the idea as far as I can see from here is to have those columns to be indented nicely.

Quoted 8 lines
Quoted 6 lines
Quoted 2 lines
        { .compatible = "exar,xra1202", .data = OF_953X( 8, 0), },
        { }

--
With Best Regards,
Andy Shevchenko

I applied the patch and fixed the indentation problem in my tree. Thanks!

Awesome, thanks!