drm/i915: Move system memory to TTM for discrete
Subsystems (2)
v4 cover drm/i915: Move system memory to TTM for discrete
Early implementation of moving system memory for discrete cards over to TTM. We first add the notion of objects being migratable under the object lock to i915 gem, and add some asserts to verify that objects are either locked or pinned when the placement is checked by the gem code.
Patch 2 and 3 deals with updating the i915 gem bookkeeping after a TTM move, Patch 4 moves system over from shmem to TTM for discrete
Note that the mock device doesn't consider itself discrete so the TTM system path is not checked by the mock selftests.
v2:
- Style fixes (reported by Matthew Auld)
- Drop the last patch (migration) It needs selftests and some additional work.
- Unconditionally add VM_IO at mmap time.
v3:
- More style fixes (reported by Matthew Auld)
- Don't overfill the busy placement vector (reported by Matthew Auld)
v4:
- Remove confusion around shrinkable objects (reported by Matthew Auld)
Thomas Hellström (4):
drm/i915: Update object placement flags to be mutable drm/i915/ttm: Adjust gem flags and caching settings after a move drm/i915/ttm: Calculate the object placement at get_pages time drm/i915/ttm: Use TTM for system memory
drivers/gpu/drm/i915/gem/i915_gem_internal.c | 4 +- drivers/gpu/drm/i915/gem/i915_gem_mman.c | 12 +- drivers/gpu/drm/i915/gem/i915_gem_object.c | 38 +++ drivers/gpu/drm/i915/gem/i915_gem_object.h | 14 +- .../gpu/drm/i915/gem/i915_gem_object_types.h | 20 +- drivers/gpu/drm/i915/gem/i915_gem_pages.c | 2 +- drivers/gpu/drm/i915/gem/i915_gem_phys.c | 2 +- drivers/gpu/drm/i915/gem/i915_gem_shmem.c | 10 +- drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 224 ++++++++++++++---- drivers/gpu/drm/i915/gem/i915_gem_userptr.c | 4 +- .../drm/i915/gem/selftests/huge_gem_object.c | 4 +- .../gpu/drm/i915/gem/selftests/huge_pages.c | 5 +- .../drm/i915/gem/selftests/i915_gem_mman.c | 4 +- .../drm/i915/gem/selftests/i915_gem_phys.c | 3 +- drivers/gpu/drm/i915/i915_drv.h | 3 - drivers/gpu/drm/i915/intel_memory_region.c | 7 +- drivers/gpu/drm/i915/intel_memory_region.h | 8 + drivers/gpu/drm/i915/intel_region_ttm.c | 8 +- drivers/gpu/drm/i915/intel_region_ttm.h | 2 + 19 files changed, 278 insertions(+), 96 deletions(-)
Signature · 1 line
2.31.1
PATCH v4 1/4 drm/i915: Update object placement flags to be mutable
The object ops i915_GEM_OBJECT_HAS_IOMEM and the object I915_BO_ALLOC_STRUCT_PAGE flags are considered immutable by much of our code. Introduce a new mem_flags member to hold these and make sure checks for these flags being set are either done under the object lock or with pages properly pinned. The flags will change during migration under the object lock.
---
v2:
- Unconditionally set VM_IO on our VMAs in line with the rest core gem and TTM. Since the bo might be migrated while the VMA is still alive, there is no sense, whether or not it maps iomem might change.
--- drivers/gpu/drm/i915/gem/i915_gem_internal.c | 4 +- drivers/gpu/drm/i915/gem/i915_gem_mman.c | 12 +++--- drivers/gpu/drm/i915/gem/i915_gem_object.c | 38 +++++++++++++++++++ drivers/gpu/drm/i915/gem/i915_gem_object.h | 14 ++----- .../gpu/drm/i915/gem/i915_gem_object_types.h | 20 +++++----- drivers/gpu/drm/i915/gem/i915_gem_pages.c | 2 +- drivers/gpu/drm/i915/gem/i915_gem_phys.c | 2 +- drivers/gpu/drm/i915/gem/i915_gem_shmem.c | 10 +++-- drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 2 +- drivers/gpu/drm/i915/gem/i915_gem_userptr.c | 4 +- .../drm/i915/gem/selftests/huge_gem_object.c | 4 +- .../gpu/drm/i915/gem/selftests/huge_pages.c | 5 +-- .../drm/i915/gem/selftests/i915_gem_mman.c | 4 +- .../drm/i915/gem/selftests/i915_gem_phys.c | 3 +- 14 files changed, 79 insertions(+), 45 deletions(-)
drivers/gpu/drm/i915/gem/i915_gem_internal.c +2 -2
@@ -177,8 +177,8 @@ i915_gem_object_create_internal(struct drm_i915_private *i915,return ERR_PTR (-ENOMEM );drm_gem_private_object_init (&i915->drm, &obj->base, size); -i915_gem_object_init (obj, &i915_gem_object_internal_ops, &lock_class, -I915_BO_ALLOC_STRUCT_PAGE ); +i915_gem_object_init (obj, &i915_gem_object_internal_ops, &lock_class,0 ); + obj->mem_flags |=I915_BO_FLAG_STRUCT_PAGE ;/* * Mark the object as volatile, such that the pages are marked as
drivers/gpu/drm/i915/gem/i915_gem_mman.c +7 -5
@@ -684,7 +684,7 @@ __assign_mmap_offset(struct drm_i915_gem_object *obj,if (mmap_type !=I915_MMAP_TYPE_GTT && !i915_gem_object_has_struct_page (obj) && - !i915_gem_object_type_has (obj,I915_GEM_OBJECT_HAS_IOMEM )) + !i915_gem_object_has_iomem (obj))return -ENODEV ; mmo =mmap_offset_attach (obj, mmap_type, file);
@@ -708,7 +708,12 @@ __assign_mmap_offset_handle(struct drm_file *file,if (!obj)return -ENOENT ; + err =i915_gem_object_lock_interruptible (obj,NULL ); +if (err) + goto out_put; err =__assign_mmap_offset (obj, mmap_type, offset, file); +i915_gem_object_unlock (obj); +out_put:i915_gem_object_put (obj);return err; }
@@ -932,10 +937,7 @@ int i915_gem_mmap(struct file *filp, struct vm_area_struct *vma)return PTR_ERR (anon); } - vma->vm_flags |=VM_PFNMAP |VM_DONTEXPAND |VM_DONTDUMP ; - -if (i915_gem_object_has_iomem (obj)) - vma->vm_flags |=VM_IO ; + vma->vm_flags |=VM_PFNMAP |VM_DONTEXPAND |VM_DONTDUMP |VM_IO ;/* * We keep the ref on mmo->obj, not vm_file, but we require
drivers/gpu/drm/i915/gem/i915_gem_object.c +38 -0
@@ -475,6 +475,44 @@ bool i915_gem_object_migratable(struct drm_i915_gem_object *obj)return obj->mm.n_placements >1 ; } +/** +* i915_gem_object_has_struct_page - Whether the object is page-backed +* @obj: The object to query. +* +* This function should only be called while the object is locked or pinned, +* otherwise the page backing may change under the caller. +* +* Return: True if page-backed, false otherwise. +*/ +bool i915_gem_object_has_struct_page (const struct drm_i915_gem_object *obj) +{ +#ifdef CONFIG_LOCKDEP +if (IS_DGFX (to_i915 (obj->base.dev)) && +i915_gem_object_evictable ((void __force *)obj)) +assert_object_held_shared (obj); +#endif +return obj->mem_flags &I915_BO_FLAG_STRUCT_PAGE ; +} + +/** +* i915_gem_object_has_iomem - Whether the object is iomem-backed +* @obj: The object to query. +* +* This function should only be called while the object is locked or pinned, +* otherwise the iomem backing may change under the caller. +* +* Return: True if iomem-backed, false otherwise. +*/ +bool i915_gem_object_has_iomem (const struct drm_i915_gem_object *obj) +{ +#ifdef CONFIG_LOCKDEP +if (IS_DGFX (to_i915 (obj->base.dev)) && +i915_gem_object_evictable ((void __force *)obj)) +assert_object_held_shared (obj); +#endif +return obj->mem_flags &I915_BO_FLAG_IOMEM ; +} +void i915_gem_init__objects (struct drm_i915_private *i915) {INIT_WORK (&i915->mm.free_work, __i915_gem_free_work);
drivers/gpu/drm/i915/gem/i915_gem_object.h +3 -11
@@ -147,7 +147,7 @@ i915_gem_object_put(struct drm_i915_gem_object *obj)/* * If more than one potential simultaneous locker, assert held. */ -static inline void assert_object_held_shared (struct drm_i915_gem_object *obj) +static inline void assert_object_held_shared (const struct drm_i915_gem_object *obj) {/* * Note mm list lookup is protected by
@@ -261,17 +261,9 @@ i915_gem_object_type_has(const struct drm_i915_gem_object *obj,return obj->ops->flags & flags; } -static inline bool -i915_gem_object_has_struct_page (const struct drm_i915_gem_object *obj) -{ -return obj->flags &I915_BO_ALLOC_STRUCT_PAGE ; -} +bool i915_gem_object_has_struct_page (const struct drm_i915_gem_object *obj); -static inline bool -i915_gem_object_has_iomem (const struct drm_i915_gem_object *obj) -{ -return i915_gem_object_type_has (obj,I915_GEM_OBJECT_HAS_IOMEM ); -} +bool i915_gem_object_has_iomem (const struct drm_i915_gem_object *obj);static inline bool i915_gem_object_is_shrinkable (const struct drm_i915_gem_object *obj)
drivers/gpu/drm/i915/gem/i915_gem_object_types.h +10 -10
@@ -33,10 +33,9 @@ struct i915_lut_handle {struct drm_i915_gem_object_ops {unsigned int flags; -#define I915_GEM_OBJECT_HAS_IOMEM BIT(1) -#define I915_GEM_OBJECT_IS_SHRINKABLE BIT(2) -#define I915_GEM_OBJECT_IS_PROXY BIT(3) -#define I915_GEM_OBJECT_NO_MMAP BIT(4) +#define I915_GEM_OBJECT_IS_SHRINKABLE BIT(1) +#define I915_GEM_OBJECT_IS_PROXY BIT(2) +#define I915_GEM_OBJECT_NO_MMAP BIT(3)/* Interface between the GEM object and its backing storage. * get_pages() is called once prior to the use of the associated set
@@ -201,17 +200,18 @@ struct drm_i915_gem_object {unsigned long flags;#define I915_BO_ALLOC_CONTIGUOUS BIT(0)#define I915_BO_ALLOC_VOLATILE BIT(1) -#define I915_BO_ALLOC_STRUCT_PAGE BIT(2) -#define I915_BO_ALLOC_CPU_CLEAR BIT(3) -#define I915_BO_ALLOC_USER BIT(4) +#define I915_BO_ALLOC_CPU_CLEAR BIT(2) +#define I915_BO_ALLOC_USER BIT(3)#define I915_BO_ALLOC_FLAGS (I915_BO_ALLOC_CONTIGUOUS | \ I915_BO_ALLOC_VOLATILE | \ - I915_BO_ALLOC_STRUCT_PAGE | \ I915_BO_ALLOC_CPU_CLEAR | \ I915_BO_ALLOC_USER) -#define I915_BO_READONLY BIT(5) -#define I915_TILING_QUIRK_BIT 6/* unknown swizzling; do not release! */ +#define I915_BO_READONLY BIT(4) +#define I915_TILING_QUIRK_BIT 5/* unknown swizzling; do not release! */ + unsigned int mem_flags:2; +#define I915_BO_FLAG_STRUCT_PAGE BIT(0) +#define I915_BO_FLAG_IOMEM BIT(1)/* * Is the object to be mapped as read-only to the GPU * Only honoured if hardware has relevant pte bit
drivers/gpu/drm/i915/gem/i915_gem_pages.c +1 -1
@@ -351,7 +351,7 @@ void *i915_gem_object_pin_map(struct drm_i915_gem_object *obj,int err;if (!i915_gem_object_has_struct_page (obj) && - !i915_gem_object_type_has (obj,I915_GEM_OBJECT_HAS_IOMEM )) + !i915_gem_object_has_iomem (obj))return ERR_PTR (-ENXIO );assert_object_held (obj);
drivers/gpu/drm/i915/gem/i915_gem_phys.c +1 -1
@@ -76,7 +76,7 @@ static int i915_gem_object_get_pages_phys(struct drm_i915_gem_object *obj)intel_gt_chipset_flush (&to_i915 (obj->base.dev)->gt);/* We're no longer struct page backed */ - obj->flags &= ~I915_BO_ALLOC_STRUCT_PAGE ; + obj->mem_flags &= ~I915_BO_FLAG_STRUCT_PAGE ;__i915_gem_object_set_pages (obj, st, sg->length);return 0 ;
drivers/gpu/drm/i915/gem/i915_gem_shmem.c +6 -4
@@ -284,6 +284,7 @@ __i915_gem_object_release_shmem(struct drm_i915_gem_object *obj, bool needs_clflush) {GEM_BUG_ON (obj->mm.madv == __I915_MADV_PURGED); +GEM_WARN_ON (IS_DGFX (to_i915 (obj->base.dev)));if (obj->mm.madv ==I915_MADV_DONTNEED ) obj->mm.dirty = false;
@@ -302,6 +303,7 @@ void i915_gem_object_put_pages_shmem(struct drm_i915_gem_object *obj, struct sg_struct pagevec pvec;struct page *page; +GEM_WARN_ON (IS_DGFX (to_i915 (obj->base.dev)));__i915_gem_object_release_shmem (obj, pages, true);i915_gem_gtt_finish_pages (obj, pages);
@@ -444,7 +446,7 @@ shmem_pread(struct drm_i915_gem_object *obj,static void shmem_release (struct drm_i915_gem_object *obj) { -if (obj->flags &I915_BO_ALLOC_STRUCT_PAGE ) +if (i915_gem_object_has_struct_page (obj))i915_gem_object_release_memory_region (obj);fput (obj->base.filp);
@@ -513,9 +515,8 @@ static int shmem_object_init(struct intel_memory_region *mem,mapping_set_gfp_mask (mapping, mask);GEM_BUG_ON (!(mapping_gfp_mask (mapping) & __GFP_RECLAIM)); -i915_gem_object_init (obj, &i915_gem_shmem_ops, &lock_class, -I915_BO_ALLOC_STRUCT_PAGE ); - +i915_gem_object_init (obj, &i915_gem_shmem_ops, &lock_class,0 ); + obj->mem_flags |=I915_BO_FLAG_STRUCT_PAGE ; obj->write_domain =I915_GEM_DOMAIN_CPU ; obj->read_domains =I915_GEM_DOMAIN_CPU ;
@@ -561,6 +562,7 @@ i915_gem_object_create_shmem_from_data(struct drm_i915_private *dev_priv,resource_size_t offset;int err; +GEM_WARN_ON (IS_DGFX (dev_priv)); obj =i915_gem_object_create_shmem (dev_priv,round_up (size,PAGE_SIZE ));if (IS_ERR (obj))return obj;
drivers/gpu/drm/i915/gem/i915_gem_ttm.c +1 -1
@@ -563,7 +563,6 @@ static u64 i915_ttm_mmap_offset(struct drm_i915_gem_object *obj)const struct drm_i915_gem_object_ops i915_gem_ttm_obj_ops = { .name ="i915_gem_object_ttm" , - .flags =I915_GEM_OBJECT_HAS_IOMEM , .get_pages = i915_ttm_get_pages, .put_pages = i915_ttm_put_pages,
@@ -620,6 +619,7 @@ int __i915_gem_ttm_object_init(struct intel_memory_region *mem,i915_gem_object_init_memory_region (obj, mem);i915_gem_object_make_unshrinkable (obj); obj->read_domains =I915_GEM_DOMAIN_WC |I915_GEM_DOMAIN_GTT ; + obj->mem_flags |=I915_BO_FLAG_IOMEM ;i915_gem_object_set_cache_coherency (obj,I915_CACHE_NONE );INIT_RADIX_TREE (&obj->ttm.get_io_page.radix,GFP_KERNEL | __GFP_NOWARN);mutex_init (&obj->ttm.get_io_page.lock);
drivers/gpu/drm/i915/gem/i915_gem_userptr.c +2 -2
@@ -538,8 +538,8 @@ i915_gem_userptr_ioctl(struct drm_device *dev,return -ENOMEM ;drm_gem_private_object_init (dev, &obj->base, args->user_size); -i915_gem_object_init (obj, &i915_gem_userptr_ops, &lock_class, -I915_BO_ALLOC_STRUCT_PAGE ); +i915_gem_object_init (obj, &i915_gem_userptr_ops, &lock_class,0 ); + obj->mem_flags =I915_BO_FLAG_STRUCT_PAGE ; obj->read_domains =I915_GEM_DOMAIN_CPU ; obj->write_domain =I915_GEM_DOMAIN_CPU ;i915_gem_object_set_cache_coherency (obj,I915_CACHE_LLC );
drivers/gpu/drm/i915/gem/selftests/huge_gem_object.c +2 -2
@@ -114,8 +114,8 @@ huge_gem_object(struct drm_i915_private *i915,return ERR_PTR (-ENOMEM );drm_gem_private_object_init (&i915->drm, &obj->base, dma_size); -i915_gem_object_init (obj, &huge_ops, &lock_class, -I915_BO_ALLOC_STRUCT_PAGE ); +i915_gem_object_init (obj, &huge_ops, &lock_class,0 ); + obj->mem_flags |=I915_BO_FLAG_STRUCT_PAGE ; obj->read_domains =I915_GEM_DOMAIN_CPU ; obj->write_domain =I915_GEM_DOMAIN_CPU ;
drivers/gpu/drm/i915/gem/selftests/huge_pages.c +2 -3
@@ -167,9 +167,8 @@ huge_pages_object(struct drm_i915_private *i915,return ERR_PTR (-ENOMEM );drm_gem_private_object_init (&i915->drm, &obj->base, size); -i915_gem_object_init (obj, &huge_page_ops, &lock_class, -I915_BO_ALLOC_STRUCT_PAGE ); - +i915_gem_object_init (obj, &huge_page_ops, &lock_class,0 ); + obj->mem_flags |=I915_BO_FLAG_STRUCT_PAGE ;i915_gem_object_set_volatile (obj); obj->write_domain =I915_GEM_DOMAIN_CPU ;
drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c +2 -2
@@ -837,7 +837,7 @@ static bool can_mmap(struct drm_i915_gem_object *obj, enum i915_mmap_type type)if (type !=I915_MMAP_TYPE_GTT && !i915_gem_object_has_struct_page (obj) && - !i915_gem_object_type_has (obj,I915_GEM_OBJECT_HAS_IOMEM )) + !i915_gem_object_has_iomem (obj))return false;return true;
@@ -991,7 +991,7 @@ static const char *repr_mmap_type(enum i915_mmap_type type)static bool can_access (const struct drm_i915_gem_object *obj) {return i915_gem_object_has_struct_page (obj) || -i915_gem_object_type_has (obj,I915_GEM_OBJECT_HAS_IOMEM ); +i915_gem_object_has_iomem (obj); } static int __igt_mmap_access(struct drm_i915_private *i915,
drivers/gpu/drm/i915/gem/selftests/i915_gem_phys.c +2 -1
@@ -25,13 +25,14 @@ static int mock_phys_object(void *arg) goto out; } +i915_gem_object_lock (obj,NULL );if (!i915_gem_object_has_struct_page (obj)) { +i915_gem_object_unlock (obj); err = -EINVAL ;pr_err ("shmem has no struct page\n" ); goto out_obj; } -i915_gem_object_lock (obj,NULL ); err =i915_gem_object_attach_phys (obj,PAGE_SIZE );i915_gem_object_unlock (obj);if (err) {
Signature · 6 lines
2.31.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v4 2/4 drm/i915/ttm: Adjust gem flags and caching settings after a move
In reply to Thomas HellströmAfter a TTM move or object init we need to update the i915 gem flags and caching settings to reflect the new placement. Currently caching settings are not changed during the lifetime of an object, although that might change moving forward if we run into performance issues or issues with WC system page allocations.
Also introduce gpu_binds_iomem() and cpu_maps_iomem() to clean up the various ways we previously used to detect this.
Finally, initialize the TTM object reserved to be able to update flags and caching before anyone else gets hold of the object.
---
v2:
- Style fixes (Reported by Matthew Auld)
v3:
- More style fixes. Clarify why we're updating caching settings after move. (Suggested by Matthew Auld)
--- drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 111 +++++++++++++++++++----- 1 file changed, 89 insertions(+), 22 deletions(-)
drivers/gpu/drm/i915/gem/i915_gem_ttm.c +89 -22
@@ -70,6 +70,17 @@ static struct ttm_placement i915_sys_placement = { .busy_placement = &lmem0_sys_placement_flags[1], }; +static bool gpu_binds_iomem (struct ttm_resource *mem) +{ +return mem->mem_type !=TTM_PL_SYSTEM ; +} + +static bool cpu_maps_iomem (struct ttm_resource *mem) +{ +/* Once / if we support GGTT, this is also false for cached ttm_tts */ +return mem->mem_type !=TTM_PL_SYSTEM ; +} +static void i915_ttm_adjust_lru (struct drm_i915_gem_object *obj); static struct ttm_tt *i915_ttm_tt_create(struct ttm_buffer_object *bo,
@@ -175,6 +186,40 @@ static void i915_ttm_free_cached_io_st(struct drm_i915_gem_object *obj) obj->ttm.cached_io_st =NULL ; } +static void +i915_ttm_adjust_domains_after_cpu_move (struct drm_i915_gem_object *obj) +{ +struct ttm_buffer_object *bo =i915_gem_to_ttm (obj); + +if (cpu_maps_iomem (bo->resource) || bo->ttm->caching != ttm_cached) { + obj->write_domain =I915_GEM_DOMAIN_WC ; + obj->read_domains =I915_GEM_DOMAIN_WC ; + }else { + obj->write_domain =I915_GEM_DOMAIN_CPU ; + obj->read_domains =I915_GEM_DOMAIN_CPU ; + } +} + +static void i915_ttm_adjust_gem_after_move (struct drm_i915_gem_object *obj) +{ +struct drm_i915_private *i915 =to_i915 (obj->base.dev); +struct ttm_buffer_object *bo =i915_gem_to_ttm (obj); +unsigned int cache_level; + + obj->mem_flags &= ~(I915_BO_FLAG_STRUCT_PAGE |I915_BO_FLAG_IOMEM ); + + obj->mem_flags |=cpu_maps_iomem (bo->resource) ?I915_BO_FLAG_IOMEM : +I915_BO_FLAG_STRUCT_PAGE ; + +if ((HAS_LLC (i915) ||HAS_SNOOP (i915)) && !gpu_binds_iomem (bo->resource) && + bo->ttm->caching == ttm_cached) + cache_level =I915_CACHE_LLC ; +else + cache_level =I915_CACHE_NONE ; + +i915_gem_object_set_cache_coherency (obj, cache_level); +} +static void i915_ttm_purge (struct drm_i915_gem_object *obj) {struct ttm_buffer_object *bo =i915_gem_to_ttm (obj);
@@ -190,8 +235,10 @@ static void i915_ttm_purge(struct drm_i915_gem_object *obj)/* TTM's purge interface. Note that we might be reentering. */ ret =ttm_bo_validate (bo, &place, &ctx); -if (!ret) { + obj->write_domain =0 ; + obj->read_domains =0 ; +i915_ttm_adjust_gem_after_move (obj);i915_ttm_free_cached_io_st (obj); obj->mm.madv = __I915_MADV_PURGED; }
@@ -273,12 +320,15 @@ i915_ttm_resource_get_st(struct drm_i915_gem_object *obj, struct ttm_resource *res) {struct ttm_buffer_object *bo =i915_gem_to_ttm (obj); -struct ttm_resource_manager *man = -ttm_manager_type (bo->bdev, res->mem_type); -if (man->use_tt) +if (!gpu_binds_iomem (res))return i915_ttm_tt_get_st (bo->ttm); +/* +* If CPU mapping differs, we need to add the ttm_tt pages to +* the resulting st. Might make sense for GGTT. +*/ +GEM_WARN_ON (!cpu_maps_iomem (res));return intel_region_ttm_node_to_st (obj->mm.region, res); }
@@ -290,8 +340,6 @@ static int i915_ttm_move(struct ttm_buffer_object *bo, bool evict,struct drm_i915_gem_object *obj =i915_ttm_to_gem (bo);struct ttm_resource_manager *dst_man =ttm_manager_type (bo->bdev, dst_mem->mem_type); -struct ttm_resource_manager *src_man = -ttm_manager_type (bo->bdev, bo->resource->mem_type);struct intel_memory_region *dst_reg, *src_reg;union {struct ttm_kmap_iter_tt tt;
@@ -332,34 +380,36 @@ static int i915_ttm_move(struct ttm_buffer_object *bo, bool evict,if (IS_ERR (dst_st))return PTR_ERR (dst_st); -/* If we start mapping GGTT, we can no longer use man::use_tt here. */ - dst_iter = dst_man->use_tt ? + dst_iter = !cpu_maps_iomem (dst_mem) ?ttm_kmap_iter_tt_init (&_dst_iter.tt, bo->ttm) :ttm_kmap_iter_iomap_init (&_dst_iter.io, &dst_reg->iomap, dst_st, dst_reg->region.start); - src_iter = src_man->use_tt ? + src_iter = !cpu_maps_iomem (bo->resource) ?ttm_kmap_iter_tt_init (&_src_iter.tt, bo->ttm) :ttm_kmap_iter_iomap_init (&_src_iter.io, &src_reg->iomap, obj->ttm.cached_io_st, src_reg->region.start);ttm_move_memcpy (bo, dst_mem->num_pages, dst_iter, src_iter); +/* Below dst_mem becomes bo->resource. */ ttm_bo_move_sync_cleanup (bo, dst_mem); +i915_ttm_adjust_domains_after_cpu_move (obj);i915_ttm_free_cached_io_st (obj); -if (!dst_man->use_tt) { +if (gpu_binds_iomem (dst_mem) ||cpu_maps_iomem (dst_mem)) { obj->ttm.cached_io_st = dst_st; obj->ttm.get_io_page.sg_pos = dst_st->sgl; obj->ttm.get_io_page.sg_idx =0 ; } +i915_ttm_adjust_gem_after_move (obj);return 0 ; }static int i915_ttm_io_mem_reserve (struct ttm_device *bdev,struct ttm_resource *mem) { -if (mem->mem_type <I915_PL_LMEM0 ) +if (!cpu_maps_iomem (mem))return 0 ; mem->bus.caching = ttm_write_combined;
@@ -421,6 +471,16 @@ static int i915_ttm_get_pages(struct drm_i915_gem_object *obj)if (ret)return ret == -ENOSPC ? -ENXIO : ret; +i915_ttm_adjust_lru (obj); +if (bo->ttm && !ttm_tt_is_populated (bo->ttm)) { + ret =ttm_tt_populate (bo->bdev, bo->ttm, &ctx); +if (ret) +return ret; + +i915_ttm_adjust_domains_after_cpu_move (obj); +i915_ttm_adjust_gem_after_move (obj); + } +/* Object either has a page vector or is an iomem object */ st = bo->ttm ?i915_ttm_tt_get_st (bo->ttm) : obj->ttm.cached_io_st;if (IS_ERR (st))
@@ -428,8 +488,6 @@ static int i915_ttm_get_pages(struct drm_i915_gem_object *obj)__i915_gem_object_set_pages (obj, st,i915_sg_dma_sizes (st->sgl)); -i915_ttm_adjust_lru (obj); -return ret; }
@@ -563,6 +621,7 @@ static u64 i915_ttm_mmap_offset(struct drm_i915_gem_object *obj)const struct drm_i915_gem_object_ops i915_gem_ttm_obj_ops = { .name ="i915_gem_object_ttm" , + .flags =I915_GEM_OBJECT_IS_SHRINKABLE , .get_pages = i915_ttm_get_pages, .put_pages = i915_ttm_put_pages,
@@ -599,6 +658,10 @@ int __i915_gem_ttm_object_init(struct intel_memory_region *mem, {static struct lock_class_key lock_class;struct drm_i915_private *i915 = mem->i915; +struct ttm_operation_ctx ctx = { + .interruptible = true, + .no_wait_gpu = false, + };enum ttm_bo_type bo_type;size_t alignment =0 ;int ret;
@@ -618,15 +681,14 @@ int __i915_gem_ttm_object_init(struct intel_memory_region *mem,i915_gem_object_init (obj, &i915_gem_ttm_obj_ops, &lock_class, flags);i915_gem_object_init_memory_region (obj, mem);i915_gem_object_make_unshrinkable (obj); - obj->read_domains =I915_GEM_DOMAIN_WC |I915_GEM_DOMAIN_GTT ; - obj->mem_flags |=I915_BO_FLAG_IOMEM ; -i915_gem_object_set_cache_coherency (obj,I915_CACHE_NONE );INIT_RADIX_TREE (&obj->ttm.get_io_page.radix,GFP_KERNEL | __GFP_NOWARN);mutex_init (&obj->ttm.get_io_page.lock); bo_type = (obj->flags &I915_BO_ALLOC_USER ) ? ttm_bo_type_device : ttm_bo_type_kernel; + obj->base.vma_node.driver_private =i915_gem_to_ttm (obj); +/* * If this function fails, it will call the destructor, but * our caller still owns the object. So no freeing in the
@@ -634,14 +696,19 @@ int __i915_gem_ttm_object_init(struct intel_memory_region *mem,* Similarly, in delayed_destroy, we can't call ttm_bo_put() * until successful initialization. */ - obj->base.vma_node.driver_private =i915_gem_to_ttm (obj); - ret =ttm_bo_init (&i915->bdev,i915_gem_to_ttm (obj), size, - bo_type, &i915_sys_placement, alignment, - true,NULL ,NULL , i915_ttm_bo_destroy); + ret =ttm_bo_init_reserved (&i915->bdev,i915_gem_to_ttm (obj), size, + bo_type, &i915_sys_placement, alignment, + &ctx,NULL ,NULL , i915_ttm_bo_destroy); + +if (ret) + goto out; -if (!ret) - obj->ttm.created = true; + obj->ttm.created = true; +i915_ttm_adjust_domains_after_cpu_move (obj); +i915_ttm_adjust_gem_after_move (obj); +i915_gem_object_unlock (obj); +out:/* i915 wants -ENXIO when out of memory region space. */ return (ret == -ENOSPC ) ? -ENXIO : ret; }
Signature · 6 lines
2.31.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH v4 2/4] drm/i915/ttm: Adjust gem flags and caching settings after a move
Quoted 241 lines · Thomas Hellström
After a TTM move or object init we need to update the i915 gem flags and caching settings to reflect the new placement. Currently caching settings are not changed during the lifetime of an object, although that might change moving forward if we run into performance issues or issues with WC system page allocations.
Also introducegpu_binds_iomem()andcpu_maps_iomem()to clean up the various ways we previously used to detect this.
Finally, initialize the TTM object reserved to be able to update flags and caching before anyone else gets hold of the object.Signed-off-by Thomas Hellström <[email protected]>---
v2:
- Style fixes (Reported by Matthew Auld)
v3:
- More style fixes. Clarify why we're updating caching settings after move. (Suggested by Matthew Auld)--- drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 111 +++++++++++++++++++----- 1 file changed, 89 insertions(+), 22 deletions(-)drivers/gpu/drm/i915/gem/i915_gem_ttm.c +81
-20@@ -70,6 +70,17 @@ static struct ttm_placement i915_sys_placement = { .busy_placement = &lmem0_sys_placement_flags[1], }; +static bool gpu_binds_iomem (struct ttm_resource *mem) +{ +return mem->mem_type !=TTM_PL_SYSTEM ; +} + +static bool cpu_maps_iomem (struct ttm_resource *mem) +{ +/* Once / if we support GGTT, this is also false for cached ttm_tts */ +return mem->mem_type !=TTM_PL_SYSTEM ; +} +static void i915_ttm_adjust_lru (struct drm_i915_gem_object *obj); static struct ttm_tt *i915_ttm_tt_create(struct ttm_buffer_object *bo,@@ -175,6 +186,40 @@ static void i915_ttm_free_cached_io_st(struct drm_i915_gem_object *obj) obj->ttm.cached_io_st =NULL ; } +static void +i915_ttm_adjust_domains_after_cpu_move (struct drm_i915_gem_object *obj) +{ +struct ttm_buffer_object *bo =i915_gem_to_ttm (obj); + +if (cpu_maps_iomem (bo->resource) || bo->ttm->caching != ttm_cached) { + obj->write_domain =I915_GEM_DOMAIN_WC ; + obj->read_domains =I915_GEM_DOMAIN_WC ; + }else { + obj->write_domain =I915_GEM_DOMAIN_CPU ; + obj->read_domains =I915_GEM_DOMAIN_CPU ; + } +} + +static void i915_ttm_adjust_gem_after_move (struct drm_i915_gem_object *obj) +{ +struct drm_i915_private *i915 =to_i915 (obj->base.dev); +struct ttm_buffer_object *bo =i915_gem_to_ttm (obj); +unsigned int cache_level; + + obj->mem_flags &= ~(I915_BO_FLAG_STRUCT_PAGE |I915_BO_FLAG_IOMEM ); + + obj->mem_flags |=cpu_maps_iomem (bo->resource) ?I915_BO_FLAG_IOMEM : +I915_BO_FLAG_STRUCT_PAGE ; + +if ((HAS_LLC (i915) ||HAS_SNOOP (i915)) && !gpu_binds_iomem (bo->resource) && + bo->ttm->caching == ttm_cached) + cache_level =I915_CACHE_LLC ; +else + cache_level =I915_CACHE_NONE ; + +i915_gem_object_set_cache_coherency (obj, cache_level); +} +static void i915_ttm_purge (struct drm_i915_gem_object *obj) {struct ttm_buffer_object *bo =i915_gem_to_ttm (obj);@@ -190,8 +235,10 @@ static void i915_ttm_purge(struct drm_i915_gem_object *obj)/* TTM's purge interface. Note that we might be reentering. */ ret =ttm_bo_validate (bo, &place, &ctx); -if (!ret) { + obj->write_domain =0 ; + obj->read_domains =0 ; +i915_ttm_adjust_gem_after_move (obj);i915_ttm_free_cached_io_st (obj); obj->mm.madv = __I915_MADV_PURGED; }@@ -273,12 +320,15 @@ i915_ttm_resource_get_st(struct drm_i915_gem_object *obj, struct ttm_resource *res) {struct ttm_buffer_object *bo =i915_gem_to_ttm (obj); -struct ttm_resource_manager *man = -ttm_manager_type (bo->bdev, res->mem_type); -if (man->use_tt) +if (!gpu_binds_iomem (res))return i915_ttm_tt_get_st (bo->ttm); +/* +* If CPU mapping differs, we need to add the ttm_tt pages to +* the resulting st. Might make sense for GGTT. +*/ +GEM_WARN_ON (!cpu_maps_iomem (res));return intel_region_ttm_node_to_st (obj->mm.region, res); }@@ -290,8 +340,6 @@ static int i915_ttm_move(struct ttm_buffer_object *bo, bool evict,struct drm_i915_gem_object *obj =i915_ttm_to_gem (bo);struct ttm_resource_manager *dst_man =ttm_manager_type (bo->bdev, dst_mem->mem_type); -struct ttm_resource_manager *src_man = -ttm_manager_type (bo->bdev, bo->resource->mem_type);struct intel_memory_region *dst_reg, *src_reg;union {struct ttm_kmap_iter_tt tt;@@ -332,34 +380,36 @@ static int i915_ttm_move(struct ttm_buffer_object *bo, bool evict,if (IS_ERR (dst_st))return PTR_ERR (dst_st); -/* If we start mapping GGTT, we can no longer use man::use_tt here. */ - dst_iter = dst_man->use_tt ? + dst_iter = !cpu_maps_iomem (dst_mem) ?ttm_kmap_iter_tt_init (&_dst_iter.tt, bo->ttm) :ttm_kmap_iter_iomap_init (&_dst_iter.io, &dst_reg->iomap, dst_st, dst_reg->region.start); - src_iter = src_man->use_tt ? + src_iter = !cpu_maps_iomem (bo->resource) ?ttm_kmap_iter_tt_init (&_src_iter.tt, bo->ttm) :ttm_kmap_iter_iomap_init (&_src_iter.io, &src_reg->iomap, obj->ttm.cached_io_st, src_reg->region.start);ttm_move_memcpy (bo, dst_mem->num_pages, dst_iter, src_iter); +/* Below dst_mem becomes bo->resource. */ ttm_bo_move_sync_cleanup (bo, dst_mem); +i915_ttm_adjust_domains_after_cpu_move (obj);i915_ttm_free_cached_io_st (obj); -if (!dst_man->use_tt) { +if (gpu_binds_iomem (dst_mem) ||cpu_maps_iomem (dst_mem)) { obj->ttm.cached_io_st = dst_st; obj->ttm.get_io_page.sg_pos = dst_st->sgl; obj->ttm.get_io_page.sg_idx =0 ; } +i915_ttm_adjust_gem_after_move (obj);return 0 ; }static int i915_ttm_io_mem_reserve (struct ttm_device *bdev,struct ttm_resource *mem) { -if (mem->mem_type <I915_PL_LMEM0 ) +if (!cpu_maps_iomem (mem))return 0 ; mem->bus.caching = ttm_write_combined;@@ -421,6 +471,16 @@ static int i915_ttm_get_pages(struct drm_i915_gem_object *obj)if (ret)return ret == -ENOSPC ? -ENXIO : ret; +i915_ttm_adjust_lru (obj); +if (bo->ttm && !ttm_tt_is_populated (bo->ttm)) { + ret =ttm_tt_populate (bo->bdev, bo->ttm, &ctx); +if (ret) +return ret; + +i915_ttm_adjust_domains_after_cpu_move (obj); +i915_ttm_adjust_gem_after_move (obj); + } +/* Object either has a page vector or is an iomem object */ st = bo->ttm ?i915_ttm_tt_get_st (bo->ttm) : obj->ttm.cached_io_st;if (IS_ERR (st))@@ -428,8 +488,6 @@ static int i915_ttm_get_pages(struct drm_i915_gem_object *obj)__i915_gem_object_set_pages (obj, st,i915_sg_dma_sizes (st->sgl)); -i915_ttm_adjust_lru (obj); -return ret; }@@ -563,6 +621,7 @@ static u64 i915_ttm_mmap_offset(struct drm_i915_gem_object *obj)const struct drm_i915_gem_object_ops i915_gem_ttm_obj_ops = { .name ="i915_gem_object_ttm" , + .flags =I915_GEM_OBJECT_IS_SHRINKABLE , .get_pages = i915_ttm_get_pages, .put_pages = i915_ttm_put_pages,@@ -599,6 +658,10 @@ int __i915_gem_ttm_object_init(struct intel_memory_region *mem, {static struct lock_class_key lock_class;struct drm_i915_private *i915 = mem->i915; +struct ttm_operation_ctx ctx = { + .interruptible = true, + .no_wait_gpu = false, + };enum ttm_bo_type bo_type;size_t alignment =0 ;int ret;@@ -618,15 +681,14 @@ int __i915_gem_ttm_object_init(struct intel_memory_region *mem,i915_gem_object_init (obj, &i915_gem_ttm_obj_ops, &lock_class, flags);i915_gem_object_init_memory_region (obj, mem);i915_gem_object_make_unshrinkable (obj); - obj->read_domains =I915_GEM_DOMAIN_WC |I915_GEM_DOMAIN_GTT ; - obj->mem_flags |=I915_BO_FLAG_IOMEM ; -i915_gem_object_set_cache_coherency (obj,I915_CACHE_NONE );INIT_RADIX_TREE (&obj->ttm.get_io_page.radix,GFP_KERNEL | __GFP_NOWARN);mutex_init (&obj->ttm.get_io_page.lock); bo_type = (obj->flags &I915_BO_ALLOC_USER ) ? ttm_bo_type_device : ttm_bo_type_kernel; + obj->base.vma_node.driver_private =i915_gem_to_ttm (obj); +/* * If this function fails, it will call the destructor, but * our caller still owns the object. So no freeing in the @@ -634,14 +696,19 @@ int __i915_gem_ttm_object_init(struct intel_memory_region *mem,* Similarly, in delayed_destroy, we can't call ttm_bo_put() * until successful initialization. */ - obj->base.vma_node.driver_private =i915_gem_to_ttm (obj); - ret =ttm_bo_init (&i915->bdev,i915_gem_to_ttm (obj), size, - bo_type, &i915_sys_placement, alignment, - true,NULL ,NULL , i915_ttm_bo_destroy); + ret =ttm_bo_init_reserved (&i915->bdev,i915_gem_to_ttm (obj), size, + bo_type, &i915_sys_placement, alignment, + &ctx,NULL ,NULL , i915_ttm_bo_destroy);
drivers/gpu/drm/i915/gem/i915_gem_ttm.c int __i915_gem_ttm_object_init(struct intel_memory_region *mem, · line 709
Quoted 10 lines
drivers/gpu/drm/i915/gem/i915_gem_ttm.c +7
-2+ +if (ret) + goto out; -if (!ret) - obj->ttm.created = true; + obj->ttm.created = true; +i915_ttm_adjust_domains_after_cpu_move (obj); +i915_ttm_adjust_gem_after_move (obj); +i915_gem_object_unlock (obj);
Looks like the is_shrinkable change was squashed in the next patch. Doesn't really matter,
Quoted 8 lines
drivers/gpu/drm/i915/gem/i915_gem_ttm.c +1
-1+out:/* i915 wants -ENXIO when out of memory region space. */ return (ret == -ENOSPC ) ? -ENXIO : ret; } --2.31.1
Quoted 4 lines
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH v4 2/4] drm/i915/ttm: Adjust gem flags and caching settings after a move
Quoted 254 lines · Matthew Auld
Quoted 240 lines · Thomas Hellström
After a TTM move or object init we need to update the i915 gem flags and caching settings to reflect the new placement. Currently caching settings are not changed during the lifetime of an object, although that might change moving forward if we run into performance issues or issues with WC system page allocations.
Also introducegpu_binds_iomem()andcpu_maps_iomem()to clean up the various ways we previously used to detect this.
Finally, initialize the TTM object reserved to be able to update flags and caching before anyone else gets hold of the object.Signed-off-by Thomas Hellström <[email protected]>---
v2:
- Style fixes (Reported by Matthew Auld)
v3:
- More style fixes. Clarify why we're updating caching settings after move. (Suggested by Matthew Auld)--- drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 111 +++++++++++++++++++----- 1 file changed, 89 insertions(+), 22 deletions(-)drivers/gpu/drm/i915/gem/i915_gem_ttm.c +81
-20@@ -70,6 +70,17 @@ static struct ttm_placement i915_sys_placement = { .busy_placement = &lmem0_sys_placement_flags[1], }; +static bool gpu_binds_iomem (struct ttm_resource *mem) +{ +return mem->mem_type !=TTM_PL_SYSTEM ; +} + +static bool cpu_maps_iomem (struct ttm_resource *mem) +{ +/* Once / if we support GGTT, this is also false for cached ttm_tts */ +return mem->mem_type !=TTM_PL_SYSTEM ; +} +static void i915_ttm_adjust_lru (struct drm_i915_gem_object *obj); static struct ttm_tt *i915_ttm_tt_create(struct ttm_buffer_object *bo,@@ -175,6 +186,40 @@ static void i915_ttm_free_cached_io_st(struct drm_i915_gem_object *obj) obj->ttm.cached_io_st =NULL ; } +static void +i915_ttm_adjust_domains_after_cpu_move (struct drm_i915_gem_object *obj) +{ +struct ttm_buffer_object *bo =i915_gem_to_ttm (obj); + +if (cpu_maps_iomem (bo->resource) || bo->ttm->caching != ttm_cached) { + obj->write_domain =I915_GEM_DOMAIN_WC ; + obj->read_domains =I915_GEM_DOMAIN_WC ; + }else { + obj->write_domain =I915_GEM_DOMAIN_CPU ; + obj->read_domains =I915_GEM_DOMAIN_CPU ; + } +} + +static void i915_ttm_adjust_gem_after_move (struct drm_i915_gem_object *obj) +{ +struct drm_i915_private *i915 =to_i915 (obj->base.dev); +struct ttm_buffer_object *bo =i915_gem_to_ttm (obj); +unsigned int cache_level; + + obj->mem_flags &= ~(I915_BO_FLAG_STRUCT_PAGE |I915_BO_FLAG_IOMEM ); + + obj->mem_flags |=cpu_maps_iomem (bo->resource) ?I915_BO_FLAG_IOMEM : +I915_BO_FLAG_STRUCT_PAGE ; + +if ((HAS_LLC (i915) ||HAS_SNOOP (i915)) && !gpu_binds_iomem (bo->resource) && + bo->ttm->caching == ttm_cached) + cache_level =I915_CACHE_LLC ; +else + cache_level =I915_CACHE_NONE ; + +i915_gem_object_set_cache_coherency (obj, cache_level); +} +static void i915_ttm_purge (struct drm_i915_gem_object *obj) {struct ttm_buffer_object *bo =i915_gem_to_ttm (obj);@@ -190,8 +235,10 @@ static void i915_ttm_purge(struct drm_i915_gem_object *obj)/* TTM's purge interface. Note that we might be reentering. */ ret =ttm_bo_validate (bo, &place, &ctx); -if (!ret) { + obj->write_domain =0 ; + obj->read_domains =0 ; +i915_ttm_adjust_gem_after_move (obj);i915_ttm_free_cached_io_st (obj); obj->mm.madv = __I915_MADV_PURGED; }@@ -273,12 +320,15 @@ i915_ttm_resource_get_st(struct drm_i915_gem_object *obj, struct ttm_resource *res) {struct ttm_buffer_object *bo =i915_gem_to_ttm (obj); -struct ttm_resource_manager *man = -ttm_manager_type (bo->bdev, res->mem_type); -if (man->use_tt) +if (!gpu_binds_iomem (res))return i915_ttm_tt_get_st (bo->ttm); +/* +* If CPU mapping differs, we need to add the ttm_tt pages to +* the resulting st. Might make sense for GGTT. +*/ +GEM_WARN_ON (!cpu_maps_iomem (res));return intel_region_ttm_node_to_st (obj->mm.region, res); }@@ -290,8 +340,6 @@ static int i915_ttm_move(struct ttm_buffer_object *bo, bool evict,struct drm_i915_gem_object *obj =i915_ttm_to_gem (bo);struct ttm_resource_manager *dst_man =ttm_manager_type (bo->bdev, dst_mem->mem_type); -struct ttm_resource_manager *src_man = -ttm_manager_type (bo->bdev, bo->resource->mem_type);struct intel_memory_region *dst_reg, *src_reg;union {struct ttm_kmap_iter_tt tt;@@ -332,34 +380,36 @@ static int i915_ttm_move(struct ttm_buffer_object *bo, bool evict,if (IS_ERR (dst_st))return PTR_ERR (dst_st); -/* If we start mapping GGTT, we can no longer use man::use_tt here. */ - dst_iter = dst_man->use_tt ? + dst_iter = !cpu_maps_iomem (dst_mem) ?ttm_kmap_iter_tt_init (&_dst_iter.tt, bo->ttm) :ttm_kmap_iter_iomap_init (&_dst_iter.io, &dst_reg->iomap, dst_st, dst_reg->region.start); - src_iter = src_man->use_tt ? + src_iter = !cpu_maps_iomem (bo->resource) ?ttm_kmap_iter_tt_init (&_src_iter.tt, bo->ttm) :ttm_kmap_iter_iomap_init (&_src_iter.io, &src_reg->iomap, obj->ttm.cached_io_st, src_reg->region.start);ttm_move_memcpy (bo, dst_mem->num_pages, dst_iter, src_iter); +/* Below dst_mem becomes bo->resource. */ ttm_bo_move_sync_cleanup (bo, dst_mem); +i915_ttm_adjust_domains_after_cpu_move (obj);i915_ttm_free_cached_io_st (obj); -if (!dst_man->use_tt) { +if (gpu_binds_iomem (dst_mem) ||cpu_maps_iomem (dst_mem)) { obj->ttm.cached_io_st = dst_st; obj->ttm.get_io_page.sg_pos = dst_st->sgl; obj->ttm.get_io_page.sg_idx =0 ; } +i915_ttm_adjust_gem_after_move (obj);return 0 ; }static int i915_ttm_io_mem_reserve (struct ttm_device *bdev,struct ttm_resource *mem) { -if (mem->mem_type <I915_PL_LMEM0 ) +if (!cpu_maps_iomem (mem))return 0 ; mem->bus.caching = ttm_write_combined;@@ -421,6 +471,16 @@ static int i915_ttm_get_pages(struct drm_i915_gem_object *obj)if (ret)return ret == -ENOSPC ? -ENXIO : ret; +i915_ttm_adjust_lru (obj); +if (bo->ttm && !ttm_tt_is_populated (bo->ttm)) { + ret =ttm_tt_populate (bo->bdev, bo->ttm, &ctx); +if (ret) +return ret; + +i915_ttm_adjust_domains_after_cpu_move (obj); +i915_ttm_adjust_gem_after_move (obj); + } +/* Object either has a page vector or is an iomem object */ st = bo->ttm ?i915_ttm_tt_get_st (bo->ttm) : obj->ttm.cached_io_st;if (IS_ERR (st))@@ -428,8 +488,6 @@ static int i915_ttm_get_pages(struct drm_i915_gem_object *obj)__i915_gem_object_set_pages (obj, st,i915_sg_dma_sizes (st->sgl)); -i915_ttm_adjust_lru (obj); -return ret; }@@ -563,6 +621,7 @@ static u64 i915_ttm_mmap_offset(struct drm_i915_gem_object *obj)const struct drm_i915_gem_object_ops i915_gem_ttm_obj_ops = { .name ="i915_gem_object_ttm" , + .flags =I915_GEM_OBJECT_IS_SHRINKABLE , .get_pages = i915_ttm_get_pages, .put_pages = i915_ttm_put_pages,@@ -599,6 +658,10 @@ int __i915_gem_ttm_object_init(struct intel_memory_region *mem, {static struct lock_class_key lock_class;struct drm_i915_private *i915 = mem->i915; +struct ttm_operation_ctx ctx = { + .interruptible = true, + .no_wait_gpu = false, + };enum ttm_bo_type bo_type;size_t alignment =0 ;int ret;@@ -618,15 +681,14 @@ int __i915_gem_ttm_object_init(struct intel_memory_region *mem,i915_gem_object_init (obj, &i915_gem_ttm_obj_ops, &lock_class, flags);i915_gem_object_init_memory_region (obj, mem);i915_gem_object_make_unshrinkable (obj); - obj->read_domains =I915_GEM_DOMAIN_WC |I915_GEM_DOMAIN_GTT ; - obj->mem_flags |=I915_BO_FLAG_IOMEM ; -i915_gem_object_set_cache_coherency (obj,I915_CACHE_NONE );INIT_RADIX_TREE (&obj->ttm.get_io_page.radix,GFP_KERNEL | __GFP_NOWARN);mutex_init (&obj->ttm.get_io_page.lock); bo_type = (obj->flags &I915_BO_ALLOC_USER ) ? ttm_bo_type_device : ttm_bo_type_kernel; + obj->base.vma_node.driver_private =i915_gem_to_ttm (obj); +/* * If this function fails, it will call the destructor, but * our caller still owns the object. So no freeing in the @@ -634,14 +696,19 @@ int __i915_gem_ttm_object_init(struct intel_memory_region *mem,* Similarly, in delayed_destroy, we can't call ttm_bo_put() * until successful initialization. */ - obj->base.vma_node.driver_private =i915_gem_to_ttm (obj); - ret =ttm_bo_init (&i915->bdev,i915_gem_to_ttm (obj), size, - bo_type, &i915_sys_placement, alignment, - true,NULL ,NULL , i915_ttm_bo_destroy); + ret =ttm_bo_init_reserved (&i915->bdev,i915_gem_to_ttm (obj), size, + bo_type, &i915_sys_placement, alignment, + &ctx,NULL ,NULL , i915_ttm_bo_destroy);drivers/gpu/drm/i915/gem/i915_gem_ttm.c int __i915_gem_ttm_object_init(struct intel_memory_region *mem, · line 709
Quoted 10 lines
drivers/gpu/drm/i915/gem/i915_gem_ttm.c +7
-2+ +if (ret) + goto out; -if (!ret) - obj->ttm.created = true; + obj->ttm.created = true; +i915_ttm_adjust_domains_after_cpu_move (obj); +i915_ttm_adjust_gem_after_move (obj); +i915_gem_object_unlock (obj);Looks like the
is_shrinkablechange was squashed in the next patch. Doesn't really matter,
Quoted 1 line
Reviewed-by Matthew Auld <[email protected]>
Ugh. I'll fix that up for a final version and attach your R-B.
Thanks,
Thomas
Quoted 8 lines
Quoted 8 lines
drivers/gpu/drm/i915/gem/i915_gem_ttm.c +1
-1+out:/* i915 wants -ENXIO when out of memory region space. */ return (ret == -ENOSPC ) ? -ENXIO : ret; } --2.31.1
Quoted 4 lines
Quoted 4 lines
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v4 3/4 drm/i915/ttm: Calculate the object placement at get_pages time
In reply to Thomas HellströmInstead of relying on a static placement, calculate at get_pages() time. This should work for LMEM regions and system for now. For stolen we need to take preallocated range into account. That will if needed be added later.
---
v2:
- Fixed a style issue (Reported by Matthew Auld)
v3:
- Make sure we don't add more placements to the stack-allocated vector than there is room for. (Reported by Matthew Auld)
v4:
- Remove confusion around shrinkable objects (Reported by Matthew Auld)
--- drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 95 ++++++++++++++++++------- drivers/gpu/drm/i915/intel_region_ttm.c | 8 ++- drivers/gpu/drm/i915/intel_region_ttm.h | 2 + 3 files changed, 77 insertions(+), 28 deletions(-)
drivers/gpu/drm/i915/gem/i915_gem_ttm.c +69 -26
@@ -24,6 +24,11 @@#define I915_TTM_PRIO_NO_PAGES 1#define I915_TTM_PRIO_HAS_PAGES 2 +/* +* Size of struct ttm_place vector in on-stack struct ttm_placement allocs +*/ +#define I915_TTM_MAX_PLACEMENTS INTEL_REGION_UNKNOWN +/** * struct i915_ttm_tt - TTM page vector with additional private information * @ttm: The base TTM page vector.
@@ -42,32 +47,18 @@ struct i915_ttm_tt {struct sg_table *cached_st; }; -static const struct ttm_place lmem0_sys_placement_flags[] = { - { - .fpfn =0 , - .lpfn =0 , - .mem_type =I915_PL_LMEM0 , - .flags =0 , - }, { - .fpfn =0 , - .lpfn =0 , - .mem_type =I915_PL_SYSTEM , - .flags =0 , - } -}; - -static struct ttm_placement i915_lmem0_placement = { - .num_placement =1 , - .placement = &lmem0_sys_placement_flags[0 ], - .num_busy_placement =1 , - .busy_placement = &lmem0_sys_placement_flags[0 ], +static const struct ttm_place sys_placement_flags = { + .fpfn =0 , + .lpfn =0 , + .mem_type =I915_PL_SYSTEM , + .flags =0 , };static struct ttm_placement i915_sys_placement = { .num_placement =1 , - .placement = &lmem0_sys_placement_flags[1 ], + .placement = &sys_placement_flags, .num_busy_placement =1 , - .busy_placement = &lmem0_sys_placement_flags[1 ], + .busy_placement = &sys_placement_flags, };static bool gpu_binds_iomem (struct ttm_resource *mem)
@@ -83,6 +74,55 @@ static bool cpu_maps_iomem(struct ttm_resource *mem)static void i915_ttm_adjust_lru (struct drm_i915_gem_object *obj); +static enum ttm_caching +i915_ttm_select_tt_caching (const struct drm_i915_gem_object *obj) +{ +/* +* Objects only allowed in system get cached cpu-mappings. +* Other objects get WC mapping for now. Even if in system. +*/ +if (obj->mm.region->type ==INTEL_MEMORY_SYSTEM && + obj->mm.n_placements <=1 ) +return ttm_cached; + +return ttm_write_combined; +} + +static void +i915_ttm_place_from_region (const struct intel_memory_region *mr, +struct ttm_place *place) +{ +memset (place,0 ,sizeof (*place)); + place->mem_type =intel_region_to_ttm_type (mr); +} + +static void +i915_ttm_placement_from_obj (const struct drm_i915_gem_object *obj, +struct ttm_place *requested, +struct ttm_place *busy, +struct ttm_placement *placement) +{ +unsigned int num_allowed = obj->mm.n_placements; +unsigned int i; + + placement->num_placement =1 ; +i915_ttm_place_from_region (num_allowed ? obj->mm.placements[0 ] : + obj->mm.region, requested); + +/* Cache this on object? */ + placement->num_busy_placement = num_allowed; +for (i =0 ; i < placement->num_busy_placement; ++i) +i915_ttm_place_from_region (obj->mm.placements[i], busy + i); + +if (num_allowed ==0 ) { + *busy = *requested; + placement->num_busy_placement =1 ; + } + + placement->placement = requested; + placement->busy_placement = busy; +} +static struct ttm_tt *i915_ttm_tt_create (struct ttm_buffer_object *bo,uint32_t page_flags) {
@@ -100,7 +140,8 @@ static struct ttm_tt *i915_ttm_tt_create(struct ttm_buffer_object *bo, man->use_tt) page_flags |=TTM_PAGE_FLAG_ZERO_ALLOC ; - ret =ttm_tt_init (&i915_tt->ttm, bo, page_flags, ttm_write_combined); + ret =ttm_tt_init (&i915_tt->ttm, bo, page_flags, +i915_ttm_select_tt_caching (obj));if (ret) {kfree (i915_tt);return NULL ;
@@ -464,10 +505,15 @@ static int i915_ttm_get_pages(struct drm_i915_gem_object *obj) .no_wait_gpu = false, };struct sg_table *st; +struct ttm_place requested, busy[I915_TTM_MAX_PLACEMENTS ]; +struct ttm_placement placement;int ret; +GEM_BUG_ON (obj->mm.n_placements >I915_TTM_MAX_PLACEMENTS ); +/* Move to the requested placement. */ - ret =ttm_bo_validate (bo, &i915_lmem0_placement, &ctx); +i915_ttm_placement_from_obj (obj, &requested, busy, &placement); + ret =ttm_bo_validate (bo, &placement, &ctx);if (ret)return ret == -ENOSPC ? -ENXIO : ret;
@@ -621,7 +667,6 @@ static u64 i915_ttm_mmap_offset(struct drm_i915_gem_object *obj)const struct drm_i915_gem_object_ops i915_gem_ttm_obj_ops = { .name ="i915_gem_object_ttm" , - .flags =I915_GEM_OBJECT_IS_SHRINKABLE , .get_pages = i915_ttm_get_pages, .put_pages = i915_ttm_put_pages,
@@ -683,7 +728,6 @@ int __i915_gem_ttm_object_init(struct intel_memory_region *mem,i915_gem_object_make_unshrinkable (obj);INIT_RADIX_TREE (&obj->ttm.get_io_page.radix,GFP_KERNEL | __GFP_NOWARN);mutex_init (&obj->ttm.get_io_page.lock); - bo_type = (obj->flags &I915_BO_ALLOC_USER ) ? ttm_bo_type_device : ttm_bo_type_kernel;
@@ -707,7 +751,6 @@ int __i915_gem_ttm_object_init(struct intel_memory_region *mem,i915_ttm_adjust_domains_after_cpu_move (obj);i915_ttm_adjust_gem_after_move (obj);i915_gem_object_unlock (obj); - out:/* i915 wants -ENXIO when out of memory region space. */ return (ret == -ENOSPC ) ? -ENXIO : ret;
drivers/gpu/drm/i915/intel_region_ttm.c +6 -2
@@ -50,12 +50,16 @@ void intel_region_ttm_device_fini(struct drm_i915_private *dev_priv)* driver-private types for now, reserving TTM_PL_VRAM for stolen * memory and TTM_PL_TT for GGTT use if decided to implement this. */ -static int intel_region_to_ttm_type (struct intel_memory_region *mem) +int intel_region_to_ttm_type (const struct intel_memory_region *mem) {int type;GEM_BUG_ON (mem->type !=INTEL_MEMORY_LOCAL && - mem->type !=INTEL_MEMORY_MOCK ); + mem->type !=INTEL_MEMORY_MOCK && + mem->type !=INTEL_MEMORY_SYSTEM ); + +if (mem->type ==INTEL_MEMORY_SYSTEM ) +return TTM_PL_SYSTEM ; type = mem->instance +TTM_PL_PRIV ;GEM_BUG_ON (type >=TTM_NUM_MEM_TYPES );
drivers/gpu/drm/i915/intel_region_ttm.h +2 -0
@@ -28,6 +28,8 @@ struct sg_table *intel_region_ttm_node_to_st(struct intel_memory_region *mem,void intel_region_ttm_node_free (struct intel_memory_region *mem,struct ttm_resource *node); +int intel_region_to_ttm_type (const struct intel_memory_region *mem); +struct ttm_device_funcs *i915_ttm_driver (void );#ifdef CONFIG_DRM_I915_SELFTEST
Signature · 6 lines
2.31.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v4 4/4 drm/i915/ttm: Use TTM for system memory
In reply to Thomas HellströmFor discrete, use TTM for both cached and WC system memory. That means we currently rely on the TTM memory accounting / shrinker. For cached system memory we should consider remaining shmem-backed, which can be implemented from our ttm_tt_populate callback. We can then also reuse our own very elaborate shrinker for that memory.
---
v2:
- Fix IS_ERR_OR_NULL() check to IS_ERR() (Reported by Matthew Auld) v3:
- Commit message typo fix
--- drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 22 ++++++++++++++++++++++ drivers/gpu/drm/i915/i915_drv.h | 3 --- drivers/gpu/drm/i915/intel_memory_region.c | 7 ++++++- drivers/gpu/drm/i915/intel_memory_region.h | 8 ++++++++ 4 files changed, 36 insertions(+), 4 deletions(-)
drivers/gpu/drm/i915/gem/i915_gem_ttm.c +22 -0
@@ -755,3 +755,25 @@ int __i915_gem_ttm_object_init(struct intel_memory_region *mem,/* i915 wants -ENXIO when out of memory region space. */ return (ret == -ENOSPC ) ? -ENXIO : ret; } + +static const struct intel_memory_region_ops ttm_system_region_ops = { + .init_object = __i915_gem_ttm_object_init, +}; + +struct intel_memory_region * +i915_gem_ttm_system_setup (struct drm_i915_private *i915, +u16 type,u16 instance) +{ +struct intel_memory_region *mr; + + mr =intel_memory_region_create (i915,0 , +totalram_pages () <<PAGE_SHIFT , +PAGE_SIZE ,0 , + type, instance, + &ttm_system_region_ops); +if (IS_ERR (mr)) +return mr; + +intel_memory_region_set_name (mr,"system-ttm" ); +return mr; +}
drivers/gpu/drm/i915/i915_drv.h +0 -3
@@ -1751,9 +1751,6 @@ void i915_gem_cleanup_userptr(struct drm_i915_private *dev_priv);void i915_gem_init_early (struct drm_i915_private *dev_priv);void i915_gem_cleanup_early (struct drm_i915_private *dev_priv); -struct intel_memory_region *i915_gem_shmem_setup (struct drm_i915_private *i915, -u16 type,u16 instance); -static inline void i915_gem_drain_freed_objects (struct drm_i915_private *i915) {/*
drivers/gpu/drm/i915/intel_memory_region.c +6 -1
@@ -220,7 +220,12 @@ int intel_memory_regions_hw_probe(struct drm_i915_private *i915) instance = intel_region_map[i].instance;switch (type) {case INTEL_MEMORY_SYSTEM : - mem =i915_gem_shmem_setup (i915, type, instance); +if (IS_DGFX (i915)) + mem =i915_gem_ttm_system_setup (i915, type, + instance); +else + mem =i915_gem_shmem_setup (i915, type, + instance);break ;case INTEL_MEMORY_STOLEN_LOCAL : mem =i915_gem_stolen_lmem_setup (i915, type, instance);
drivers/gpu/drm/i915/intel_memory_region.h +8 -0
@@ -143,4 +143,12 @@ void intel_memory_region_unreserve(struct intel_memory_region *mem);int intel_memory_region_reserve (struct intel_memory_region *mem,resource_size_t offset,resource_size_t size); + +struct intel_memory_region * +i915_gem_ttm_system_setup (struct drm_i915_private *i915, +u16 type,u16 instance); +struct intel_memory_region * +i915_gem_shmem_setup (struct drm_i915_private *i915, +u16 type,u16 instance); +#endif
Signature · 6 lines
2.31.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Move system memory to TTM for discrete (rev4)
In reply to Thomas Hellström== Series Details ==
== Series Details ==
Series: drm/i915: Move system memory to TTM for discrete (rev4)
URL : https://patchwork.freedesktop.org/series/90898/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +drivers/gpu/drm/i915/gem/i915_gem_ttm.c:668:38: warning: symbol 'i915_gem_ttm_obj_ops' was not declared. Should it be static? -O:drivers/gpu/drm/i915/gem/i915_gem_ttm.c:564:38: warning: symbol 'i915_gem_ttm_obj_ops' was not declared. Should it be static?
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Move system memory to TTM for discrete (rev4)
In reply to Thomas Hellström== Series Details ==
== Series Details ==
Series: drm/i915: Move system memory to TTM for discrete (rev4)
URL : https://patchwork.freedesktop.org/series/90898/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10219 -> Patchwork_20356
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20356/index.html
Known issues
------------
Here are the changes found in Patchwork_20356 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_basic@cs-gfx:
- fi-kbl-soraka: NOTRUN -> [SKIP][1] ([fdo#109271]) +4 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20356/fi-kbl-soraka/igt@amdgpu/[email protected]
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
Participating hosts (43 -> 39)
------------------------------
Missing (4): fi-ilk-m540 fi-bsw-cyan fi-bdw-samus fi-hsw-4200u
Build changes
-------------
* Linux: CI_DRM_10219 -> Patchwork_20356
CI-20190529: 20190529
CI_DRM_10219: 75a3dafbc374d49f0762a19e3aa83cc321ae0e62 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6104: f8f81bd3752f3126a47d9dbba2d0ab29f7c17a19 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_20356: 6588dbc5627d93c3a3ef472547869d7ae3b1aa85 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
6588dbc5627d drm/i915/ttm: Use TTM for system memory7152ccc78ad9 drm/i915/ttm: Calculate the object placement at get_pages time 144f95d403cd drm/i915/ttm: Adjust gem flags and caching settings after a move 31f04846b7f4 drm/i915: Update object placement flags to be mutable
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20356/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Move system memory to TTM for discrete (rev4)
In reply to Thomas Hellström== Series Details ==
== Series Details ==
Series: drm/i915: Move system memory to TTM for discrete (rev4)
URL : https://patchwork.freedesktop.org/series/90898/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10219_full -> Patchwork_20356_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_20356_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_persistence@many-contexts:
- shard-tglb: [PASS][1] -> [FAIL][2] ([i915#2410])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10219/shard-tglb2/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20356/shard-tglb2/igt@[email protected]
* igt@gem_ctx_persistence@smoketest:
- shard-snb: NOTRUN -> [SKIP][3] ([fdo#109271] / [i915#1099]) +5 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20356/shard-snb6/igt@[email protected]
* igt@gem_eio@unwedge-stress:
- shard-tglb: [PASS][4] -> [TIMEOUT][5] ([i915#2369] / [i915#3063])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10219/shard-tglb5/igt@[email protected]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20356/shard-tglb3/igt@[email protected]
* igt@gem_exec_fair@basic-deadline:
- shard-apl: NOTRUN -> [FAIL][6] ([i915#2846])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20356/shard-apl7/igt@[email protected]
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [PASS][7] -> [FAIL][8] ([i915#2842]) +1 similar issue
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10219/shard-glk6/igt@gem_exec_fair@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20356/shard-glk7/igt@gem_exec_fair@[email protected]
* igt@gem_exec_reloc@basic-wide-active@rcs0:
- shard-kbl: NOTRUN -> [FAIL][9] ([i915#2389]) +4 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20356/shard-kbl1/igt@gem_exec_reloc@[email protected]
* igt@gem_exec_reloc@basic-wide-active@vcs1:
- shard-iclb: NOTRUN -> [FAIL][10] ([i915#2389])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20356/shard-iclb2/igt@gem_exec_reloc@[email protected]
* igt@gem_exec_whisper@basic-contexts-forked:
- shard-glk: [PASS][11] -> [DMESG-WARN][12] ([i915#118] / [i915#95])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10219/shard-glk5/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20356/shard-glk2/igt@[email protected]
* igt@gem_mmap_gtt@big-copy-xy:
- shard-glk: [PASS][13] -> [FAIL][14] ([i915#307])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10219/shard-glk1/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20356/shard-glk2/igt@[email protected]
* igt@gem_mmap_gtt@cpuset-big-copy-xy:
- shard-iclb: [PASS][15] -> [FAIL][16] ([i915#2428])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10219/shard-iclb7/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20356/shard-iclb5/igt@[email protected]
* igt@gem_mmap_offset@clear:
- shard-iclb: [PASS][17] -> [FAIL][18] ([i915#3160])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10219/shard-iclb8/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20356/shard-iclb6/igt@[email protected]
* igt@gem_pread@exhaustion:
- shard-apl: NOTRUN -> [WARN][19] ([i915#2658]) +1 similar issue
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20356/shard-apl1/igt@[email protected]
- shard-snb: NOTRUN -> [WARN][20] ([i915#2658])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20356/shard-snb6/igt@[email protected]
* igt@i915_pm_dc@dc6-psr:
- shard-skl: [PASS][21] -> [FAIL][22] ([i915#454])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10219/shard-skl8/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20356/shard-skl9/igt@[email protected]
* igt@kms_ccs@pipe-c-random-ccs-data:
- shard-skl: NOTRUN -> [SKIP][23] ([fdo#109271] / [fdo#111304])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20356/shard-skl7/igt@[email protected]
* igt@kms_chamelium@hdmi-edid-change-during-suspend:
- shard-apl: NOTRUN -> [SKIP][24] ([fdo#109271] / [fdo#111827]) +20 similar issues
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20356/shard-apl8/igt@[email protected]
* igt@kms_color@pipe-a-ctm-0-75:
- shard-skl: [PASS][25] -> [DMESG-WARN][26] ([i915#1982])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10219/shard-skl6/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20356/shard-skl8/igt@[email protected]
* igt@kms_color@pipe-d-ctm-blue-to-red:
- shard-skl: NOTRUN -> [SKIP][27] ([fdo#109271]) +38 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20356/shard-skl7/igt@[email protected]
* igt@kms_color_chamelium@pipe-b-degamma:
- shard-kbl: NOTRUN -> [SKIP][28] ([fdo#109271] / [fdo#111827]) +1 similar issue
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20356/shard-kbl4/igt@[email protected]
* igt@kms_color_chamelium@pipe-d-ctm-green-to-red:
- shard-skl: NOTRUN -> [SKIP][29] ([fdo#109271] / [fdo#111827]) +1 similar issue
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20356/shard-skl7/igt@[email protected]
* igt@kms_color_chamelium@pipe-invalid-ctm-matrix-sizes:
- shard-snb: NOTRUN -> [SKIP][30] ([fdo#109271] / [fdo#111827]) +25 similar issues
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20356/shard-snb5/igt@[email protected]
* igt@kms_content_protection@lic:
- shard-apl: NOTRUN -> [TIMEOUT][31] ([i915#1319]) +1 similar issue
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20356/shard-apl8/igt@[email protected]
* igt@kms_content_protection@uevent:
- shard-apl: NOTRUN -> [FAIL][32] ([i915#2105])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20356/shard-apl7/igt@[email protected]
* igt@kms_cursor_crc@pipe-b-cursor-suspend:
- shard-kbl: NOTRUN -> [INCOMPLETE][33] ([i915#155] / [i915#2405])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20356/shard-kbl2/igt@[email protected]
* igt@kms_draw_crc@draw-method-rgb565-mmap-cpu-ytiled:
- shard-skl: [PASS][34] -> [FAIL][35] ([i915#3451])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10219/shard-skl7/igt@[email protected]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20356/shard-skl2/igt@[email protected]
* igt@kms_flip@flip-vs-suspend@b-edp1:
- shard-skl: [PASS][36] -> [INCOMPLETE][37] ([i915#146] / [i915#198])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10219/shard-skl6/igt@kms_flip@[email protected]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20356/shard-skl7/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-suspend@c-dp1:
- shard-apl: [PASS][38] -> [DMESG-WARN][39] ([i915#180])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10219/shard-apl7/igt@kms_flip@[email protected]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20356/shard-apl2/igt@kms_flip@[email protected]
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs:
- shard-apl: NOTRUN -> [SKIP][40] ([fdo#109271] / [i915#2672]) +1 similar issue
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20356/shard-apl8/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile:
- shard-apl: NOTRUN -> [SKIP][41] ([fdo#109271] / [i915#2642])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20356/shard-apl8/igt@[email protected]
* igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile:
- shard-snb: NOTRUN -> [SKIP][42] ([fdo#109271]) +473 similar issues
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20356/shard-snb7/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-blt:
- shard-kbl: NOTRUN -> [SKIP][43] ([fdo#109271]) +39 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20356/shard-kbl1/igt@[email protected]
* igt@kms_pipe_crc_basic@disable-crc-after-crtc-pipe-d:
- shard-apl: NOTRUN -> [SKIP][44] ([fdo#109271] / [i915#533]) +1 similar issue
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20356/shard-apl3/igt@[email protected]
- shard-skl: NOTRUN -> [SKIP][45] ([fdo#109271] / [i915#533])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20356/shard-skl7/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-a-alpha-transparent-fb:
- shard-kbl: NOTRUN -> [FAIL][46] ([i915#265])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20356/shard-kbl1/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: [PASS][47] -> [FAIL][48] ([fdo#108145] / [i915#265])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10219/shard-skl10/igt@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20356/shard-skl8/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-c-alpha-7efc:
- shard-skl: NOTRUN -> [FAIL][49] ([fdo#108145] / [i915#265])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20356/shard-skl7/igt@[email protected]
- shard-apl: NOTRUN -> [FAIL][50] ([fdo#108145] / [i915#265])
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20356/shard-apl3/igt@[email protected]
* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-5:
- shard-apl: NOTRUN -> [SKIP][51] ([fdo#109271] / [i915#658]) +3 similar issues
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20356/shard-apl3/igt@[email protected]
- shard-skl: NOTRUN -> [SKIP][52] ([fdo#109271] / [i915#658])
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20356/shard-skl7/igt@[email protected]
* igt@kms_psr@psr2_cursor_render:
- shard-iclb: [PASS][53] -> [SKIP][54] ([fdo#109441]) +3 similar issues
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10219/shard-iclb2/igt@kms_psr@psr2_cursor_render.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20356/shard-iclb3/igt@kms_psr@psr2_cursor_render.html
* igt@kms_writeback@writeback-pixel-formats:
- shard-apl: NOTRUN -> [SKIP][55] ([fdo#109271] / [i915#2437])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20356/shard-apl8/igt@[email protected]
* igt@perf@polling-parameterized:
- shard-skl: [PASS][56] -> [FAIL][57] ([i915#1542])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10219/shard-skl3/igt@[email protected]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20356/shard-skl1/igt@[email protected]
* igt@prime_nv_api@i915_nv_reimport_twice_check_flink_name:
- shard-apl: NOTRUN -> [SKIP][58] ([fdo#109271]) +205 similar issues
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20356/shard-apl8/igt@prime_nv_api@i915_nv_reimport_twice_check_flink_name.html
* igt@sysfs_clients@fair-7:
- shard-apl: NOTRUN -> [SKIP][59] ([fdo#109271] / [i915#2994]) +3 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20356/shard-apl8/igt@[email protected]
* igt@sysfs_clients@sema-10:
- shard-kbl: NOTRUN -> [SKIP][60] ([fdo#109271] / [i915#2994])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20356/shard-kbl1/igt@[email protected]
#### Possible fixes ####
* igt@drm_import_export@flink:
- shard-kbl: [INCOMPLETE][61] ([i915#2369]) -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10219/shard-kbl3/igt@[email protected]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20356/shard-kbl1/igt@[email protected]
* igt@gem_exec_fair@basic-none@rcs0:
- shard-glk: [FAIL][63] ([i915#2842]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10219/shard-glk4/igt@gem_exec_fair@[email protected]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20356/shard-glk1/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-none@vcs1:
- shard-kbl: [FAIL][65] ([i915#2842]) -> [PASS][66]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10219/shard-kbl1/igt@gem_exec_fair@[email protected]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20356/shard-kbl6/igt@gem_exec_fair@[email protected]
* igt@gem_mmap_gtt@big-copy-odd:
- shard-glk: [FAIL][67] ([i915#307]) -> [PASS][68]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10219/shard-glk9/igt@[email protected]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20356/shard-glk9/igt@[email protected]
* igt@gem_workarounds@suspend-resume:
- shard-apl: [DMESG-WARN][69] ([i915#180]) -> [PASS][70]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10219/shard-apl8/igt@[email protected]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20356/shard-apl1/igt@[email protected]
* igt@i915_selftest@live@execlists:
- shard-skl: [INCOMPLETE][71] ([i915#2782]) -> [PASS][72]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10219/shard-skl3/igt@i915_selftest@[email protected]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20356/shard-skl4/igt@i915_selftest@[email protected]
* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-kbl: [DMESG-WARN][73] ([i915#180]) -> [PASS][74] +3 similar issues
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10219/shard-kbl7/igt@[email protected]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20356/shard-kbl4/igt@[email protected]
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-skl: [FAIL][75] ([i915#2346]) -> [PASS][76]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10219/shard-skl10/igt@[email protected]
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20356/shard-skl4/igt@[email protected]
* igt@kms_cursor_legacy@flip-vs-cursor-toggle:
- shard-glk: [DMESG-FAIL][77] ([i915#118] / [i915#95]) -> [PASS][78]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10219/shard-glk7/igt@[email protected]
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20356/shard-glk3/igt@[email protected]
* igt@kms_flip@flip-vs-expired-vblank@c-hdmi-a2:
- shard-glk: [FAIL][79] ([i915#79]) -> [PASS][80]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10219/shard-glk9/igt@kms_flip@[email protected]
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20356/shard-glk6/igt@kms_flip@[email protected]
* igt@kms_flip@plain-flip-fb-recreate-interruptible@a-edp1:
- shard-skl: [FAIL][81] ([i915#2122]) -> [PASS][82]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10219/shard-skl6/igt@kms_flip@[email protected]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20356/shard-skl7/igt@kms_flip@[email protected]
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-pwrite:
- shard-skl: [FAIL][83] ([i915#49]) -> [PASS][84]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10219/shard-skl10/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-pwrite.html
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20356/shard-skl4/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-pwrite.html
* igt@kms_psr@psr2_sprite_plane_move:
- shard-iclb: [SKIP][85] ([fdo#109441]) -> [PASS][86] +4 similar issues
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10219/shard-iclb6/igt@kms_psr@psr2_sprite_plane_move.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20356/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html
* igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend:
- shard-kbl: [INCOMPLETE][87] ([i915#155]) -> [PASS][88]
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10219/shard-kbl4/igt@[email protected]
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20356/shard-kbl2/igt@[email protected]
* igt@sysfs_heartbeat_interval@mixed@rcs0:
- shard-skl: [FAIL][89] ([i915#1731]) -> [PASS][90]
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10219/shard-skl10/igt@sysfs_heartbeat_interval@[email protected]
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20356/shard-skl4/igt@sysfs_heartbeat_interval@[email protected]
#### Warnings ####
* igt@i915_pm_rc6_residency@rc6-fence:
- shard-iclb: [WARN][91] ([i915#1804] / [i915#2684]) -> [WARN][92] ([i915#2684])
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10219/shard-iclb6/igt@[email protected]
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20356/shard-iclb8/igt@[email protected]
* igt@i915_pm_rc6_residency@rc6-idle:
- shard-iclb: [WARN][93] ([i915#2684]) -> [WARN][94] ([i915#1804] / [i915#2684])
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10219/shard-iclb2/igt@[email protected]
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20356/shard-iclb3/igt@[email protected]
* igt@kms_draw_crc@draw-method-rgb565-pwrite-untiled:
- shard-glk: [DMESG-FAIL][95] ([i915#118] / [i915#95]) -> [FAIL][96] ([i915#3451])
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10219/shard-glk2/igt@[email protected]
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20356/shard-glk6/igt@[email protected]
* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-5:
- shard-iclb: [SKIP][97] ([i915#2920]) -> [SKIP][98] ([i915#658])
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10219/shard-iclb2/igt@[email protected]
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20356/shard-iclb3/igt@[email protected]
* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-5:
- shard-iclb: [SKIP][99] ([i915#658]) -> [SKIP][100] ([i915#2920]) +2 similar issues
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10219/shard-iclb6/igt@[email protected]
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20356/shard-iclb2/igt@[email protected]
* igt@runner@aborted:
- shard-kbl: ([FAIL][101], [FAIL][102], [FAIL][103], [FAIL][104], [FAIL][105], [FAIL][106]) ([i915#180] / [i915#1814] / [i915#2722] / [i915#3002] / [i915#3363]) -> ([FAIL][107], [FAIL][108], [FAIL][109]) ([i915#180] / [i915#3002] / [i915#3363])
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10219/shard-kbl2/igt@[email protected]
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10219/shard-kbl7/igt@[email protected]
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10219/shard-kbl4/igt@[email protected]
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10219/shard-kbl3/igt@[email protected]
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10219/shard-kbl3/igt@[email protected]
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10219/shard-kbl7/igt@[email protected]
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20356/shard-kbl3/igt@[email protected]
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20356/shard-kbl2/igt@[email protected]
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20356/shard-kbl3/igt@[email protected]
- shard-apl: ([FAIL][110], [FAIL][111], [FAIL][112]) ([fdo#109271] / [i915#180] / [i915#3002] / [i915#3363]) -> ([FAIL][113], [FAIL][114]) ([i915#180] / [i915#3002] / [i915#3363])
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10219/shard-apl8/igt@[email protected]
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10219/shard-apl2/igt@[email protected]
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10219/shard-apl2/igt@[email protected]
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20356/shard-apl8/igt@[email protected]
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20356/shard-apl2/igt@[email protected]
- shard-skl: ([FAIL][115], [FAIL][116]) ([i915#3002] / [i915#3363]) -> ([FAIL][117], [FAIL][118], [FAIL][119]) ([i915#1814] / [i915#2029] / [i915#3002] / [i915#3363])
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10219/shard-skl2/igt@[email protected]
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10219/shard-skl8/igt@[email protected]
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20356/shard-skl1/igt@[email protected]
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20356/shard-skl9/igt@[email protected]
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20356/shard-skl3/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#111304]: https://bugs.freedesktop.org/show_bug.cgi?id=111304
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1319]: https://gitlab.freedesktop.org/drm/intel/issues/1319
[i915#146]: https://gitlab.freedesktop.org/drm/intel/issues/146
[i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542
[i915#155]: https://gitlab.freedesktop.org/drm/intel/issues/155
[i915#1731]: https://gitlab.freedesktop.org/drm/intel/issues/1731
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1804]: https://gitlab.freedesktop.org/drm/intel/issues/1804
[i915#1814]: https://gitlab.freedesktop.org/drm/intel/issues/1814
[i915#198]: https://gitlab.freedesktop.org/drm/intel/issues/198
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2029]: https://gitlab.freedesktop.org/drm/intel/issues/2029
[i915#2105]: https://gitlab.freedesktop.org/drm/intel/issues/2105
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2369]: https://gitlab.freedesktop.org/drm/intel/issues/2369
[i915#2389]: https://gitlab.freedesktop.org/drm/intel/issues/2389
[i915#2405]: https://gitlab.freedesktop.org/drm/intel/issues/2405
[i915#2410]: https://gitlab.freedesktop.org/drm/intel/issues/2410
[i915#2428]: https://gitlab.freedesktop.org/drm/intel/issues/2428
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2642]: https://gitlab.freedesktop.org/drm/intel/issues/2642
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2684]: https://gitlab.freedesktop.org/drm/intel/issues/2684
[i915#2722]: https://gitlab.freedesktop.org/drm/intel/issues/2722
[i915#2782]: https://gitlab.freedesktop.org/drm/intel/issues/2782
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
[i915#3063]: https://gitlab.freedesktop.org/drm/intel/issues/3063
[i915#307]: https://gitlab.freedesktop.org/drm/intel/issues/307
[i915#3160]: https://gitlab.freedesktop.org/drm/intel/issues/3160
[i915#3363]: https://gitlab.freedesktop.org/drm/intel/issues/3363
[i915#3451]: https://gitlab.freedesktop.org/drm/intel/issues/3451
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#49]: https://gitlab.freedesktop.org/drm/intel/issues/49
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Build changes
-------------
* Linux: CI_DRM_10219 -> Patchwork_20356
CI-20190529: 20190529
CI_DRM_10219: 75a3dafbc374d49f0762a19e3aa83cc321ae0e62 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6104: f8f81bd3752f3126a47d9dbba2d0ab29f7c17a19 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_20356: 6588dbc5627d93c3a3ef472547869d7ae3b1aa85 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20356/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx