ice: remove unnecessary NULL checks before ptp_read_system_*
Subsystems (3)
PATCH 1/1 ice: remove unnecessary NULL checks before ptp_read_system_*
The ptp_read_system_prets and ptp_read_system_postts functions already check for the NULL value of the ptp_system_timestamp structure pointer. There is no need to check this manually in the ice driver code. Remove the checks.
Reported-by Jakub Kicinski <[email protected]>
Signed-off-by Jacob Keller <[email protected]>
--- drivers/net/ethernet/intel/ice/ice_ptp.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-)
drivers/net/ethernet/intel/ice/ice_ptp.c +4 -8
@@ -219,14 +219,12 @@ ice_ptp_read_src_clk_reg(struct ice_pf *pf, struct ptp_system_timestamp *sts) tmr_idx =ice_get_ptp_src_clock_index (hw);/* Read the system timestamp pre PHC read */ -if (sts) -ptp_read_system_prets (sts); +ptp_read_system_prets (sts); lo =rd32 (hw,GLTSYN_TIME_L (tmr_idx));/* Read the system timestamp post PHC read */ -if (sts) -ptp_read_system_postts (sts); +ptp_read_system_postts (sts); hi =rd32 (hw,GLTSYN_TIME_H (tmr_idx)); lo2 =rd32 (hw,GLTSYN_TIME_L (tmr_idx));
@@ -235,11 +233,9 @@ ice_ptp_read_src_clk_reg(struct ice_pf *pf, struct ptp_system_timestamp *sts)/* if TIME_L rolled over read TIME_L again and update * system timestamps */ -if (sts) -ptp_read_system_prets (sts); +ptp_read_system_prets (sts); lo =rd32 (hw,GLTSYN_TIME_L (tmr_idx)); -if (sts) -ptp_read_system_postts (sts); +ptp_read_system_postts (sts); hi =rd32 (hw,GLTSYN_TIME_H (tmr_idx)); }
base-commit: a212d9f33ed0b8399bd9829a779c4024068742a2
Signature · 1 line
2.31.1.331.gb0c09ab8796f