Skip to contentSkip to conversation

GitHub actions: add MSVC build

PATCH In review Lev Stipakov 2 participants 4 messages Jun 15, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 GitHub actions: add MSVC build

From: Lev Stipakov <[email protected]...>

---
 .github/workflows/build.yaml | 46 ++++++++++++++++++++++++++++++++++++
 1 file changed, 46 insertions(+)
.github/workflows/build.yaml +46 -0
index 410d6e1d..5d7dd37b 100644
@@ -181,3 +181,49 @@ jobs:
         run: make -j4
       - name: make check
         run: make check
+
+  msvc:
+      strategy:
+        matrix:
+          plat: [ARM64, Win32, x64]
+          include:
+            - plat: ARM64
+              triplet: arm64
+            - plat: Win32
+              triplet: x86
+            - plat: x64
+              triplet: x64
+
+      env:
+        BUILD_CONFIGURATION: Release
+        VCPKG_OVERLAY_PORTS: ${{ github.workspace }}/contrib/vcpkg-ports
+        VCPKG_OVERLAY_TRIPLETS: ${{ github.workspace }}/contrib/vcpkg-triplets
+
+      runs-on: windows-latest
+      steps:
+      - uses: actions/[email protected]...
+
+      - name: Add MSBuild to PATH
+        uses: microsoft/[email protected]...
+
+      - name: Restore artifacts, or run vcpkg, build and cache artifacts
+        uses: lukka/[email protected]...
+        with:
+          vcpkgArguments: 'openssl lz4 lzo pkcs11-helper tap-windows6'
+          vcpkgTriplet: '${{ matrix.triplet }}-windows-ovpn'
+          vcpkgGitCommitId: '7d472dd25830da92108eb76642c667aaa40512cb'
+          cleanAfterBuild: false
+
+      - name: Build
+        working-directory: ${{env.GITHUB_WORKSPACE}}
+        run: |
+          vcpkg integrate install
+          msbuild /m /p:Configuration=${{env.BUILD_CONFIGURATION}} /p:Platform="${{ matrix.plat }}" .
+
+      - name: Archive artifacts
+        uses: actions/[email protected]...
+        with:
+          name: artifacts-${{ matrix.plat }}
+          path: |
+            ${{ matrix.plat }}-Output/${{env.BUILD_CONFIGURATION}}/*.exe
+            ${{ matrix.plat }}-Output/${{env.BUILD_CONFIGURATION}}/*.dll
Signature · 1 line
2.23.0.windows.1
Acked-by on v1 1/1
#1 lore raw

Looks reasonable. Getting more test coverage on MSVC is good.

Will this put build artefacts somewhere where people can download and test MSVC builds? Or is it "just openvpn.exe", but not a complete installer? The file looks like "*.exe and *.dll" (but at least this).

Where does it report compile errors to?

Your patch has been applied to the master and release/2.5 branch.

commit e007cc260edb0f24ad8f8468fbe7daf9efde85dc (master) commit 1ca147bd716b4f756072c44fe7713f05f147bfc6 (release/2.5)

Author: Lev Stipakov
Date:   Tue Jun 15 15:56:16 2021 +0300
     GitHub actions: add MSVC build

     Signed-off-by: Lev Stipakov <[email protected]...>
     Acked-by: Gert Doering <[email protected]...>
     Message-Id: <[email protected]...>
     URL: https://www.mail-archive.com/[email protected]/msg22556.html
     Signed-off-by: Gert Doering <[email protected]...>

--
kind regards,

Gert Doering

#2 lore raw

Hi,

Quoted 3 lines

Will this put build artefacts somewhere where people can download and test MSVC builds? Or is it "just openvpn.exe", but not a complete installer? The file looks like "*.exe and *.dll" (but at least this).

One could download artifacts from https://github.com/OpenVPN/openvpn/actions,
for example https://github.com/OpenVPN/openvpn/actions/runs/939447024
(latest master).
At the moment it is .exe and .dll.

Building installer requires openvpn-build. I think this is something Samuli works on (related to buildbot).

Quoted 1 line

Where does it report compile errors to?

At the moment to GitHub Actions page
(https://github.com/OpenVPN/openvpn/actions). If needed we could look into email notifications (and maybe IRC?).

-Lev

#3 lore raw

Hi,

Quoted 5 lines · Lev Stipakov
Quoted 1 line

Where does it report compile errors to?

At the moment to GitHub Actions page
(https://github.com/OpenVPN/openvpn/actions). If needed we could look into email notifications (and maybe IRC?).

That would be cool indeed (e-mail and/or IRC :) ).

gert

Signature · 6 lines
"If was one thing all people took for granted, was conviction that if you 
 feed honest figures into a computer, honest figures come out. Never doubted 
 it myself till I met a computer with a sense of humor."
                             Robert A. Heinlein, The Moon is a Harsh Mistress

Gert Doering - Munich, Germany                             [email protected]...