Skip to contentSkip to conversation

usb: typec: tcpm: Ignore Vsafe0v in PR_SWAP_SNK_SRC_SOURCE_ON state

PATCH In review Kyle Tso 4 participants 4 messages Jun 15, 2021 – Jun 16, 2021

Subsystems (3)
lore
Share & tools
lore

Kyle Tso

author
#0 lore raw

PATCH 1/1 usb: typec: tcpm: Ignore Vsafe0v in PR_SWAP_SNK_SRC_SOURCE_ON state

In PR_SWAP_SNK_SRC_SOURCE_ON state, Vsafe0v is expected as well so do nothing here to avoid state machine going into SNK_UNATTACHED.

Fixes 28b43d3d746b ("usb: typec: tcpm: Introduce vsafe0v for vbus")
---
 drivers/usb/typec/tcpm/tcpm.c | 1 +
 1 file changed, 1 insertion(+)
drivers/usb/typec/tcpm/tcpm.c +1 -0
index 197556038ba4..e11e9227107d 100644
@@ -5212,6 +5212,7 @@ static void _tcpm_pd_vbus_vsafe0v(struct tcpm_port *port)
 		}
 		break;
 	case PR_SWAP_SNK_SRC_SINK_OFF:
+	case PR_SWAP_SNK_SRC_SOURCE_ON:
 		/* Do nothing, vsafe0v is expected during transition */
 		break;
 	default:
Signature · 1 line
2.32.0.272.g935e593368-goog
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 6 lines · Kyle Tso

In PR_SWAP_SNK_SRC_SOURCE_ON state, Vsafe0v is expected as well so do nothing here to avoid state machine going into SNK_UNATTACHED.

Fixes 28b43d3d746b ("usb: typec: tcpm: Introduce vsafe0v for vbus")
Quoted 19 lines
---
 drivers/usb/typec/tcpm/tcpm.c | 1 +
 1 file changed, 1 insertion(+)
drivers/usb/typec/tcpm/tcpm.c +1 -1
index 197556038ba4..e11e9227107d 100644
@@ -5212,6 +5212,7 @@ static void _tcpm_pd_vbus_vsafe0v(struct tcpm_port *port)
                }
                break;
        case PR_SWAP_SNK_SRC_SINK_OFF:
+       case PR_SWAP_SNK_SRC_SOURCE_ON:
                /* Do nothing, vsafe0v is expected during transition */
                break;
        default:
--

2.32.0.272.g935e593368-goog

Reviewed-by on v1 1/1
#2 lore raw
In reply to Kyle Tso
Quoted 5 lines · Kyle Tso

In PR_SWAP_SNK_SRC_SOURCE_ON state, Vsafe0v is expected as well so do nothing here to avoid state machine going into SNK_UNATTACHED.

Fixes 28b43d3d746b ("usb: typec: tcpm: Introduce vsafe0v for vbus")
Quoted 19 lines
---
 drivers/usb/typec/tcpm/tcpm.c | 1 +
 1 file changed, 1 insertion(+)
drivers/usb/typec/tcpm/tcpm.c +1 -0
index 197556038ba4..e11e9227107d 100644
@@ -5212,6 +5212,7 @@ static void _tcpm_pd_vbus_vsafe0v(struct tcpm_port *port)
 		}
 		break;
 	case PR_SWAP_SNK_SRC_SINK_OFF:
+	case PR_SWAP_SNK_SRC_SOURCE_ON:
 		/* Do nothing, vsafe0v is expected during transition */
 		break;
 	default:
Signature · 1 line
2.32.0.272.g935e593368-goog
maintainer Acked-by on v1 1/1
#3 lore raw
In reply to Kyle Tso
Quoted 5 lines · Kyle Tso

In PR_SWAP_SNK_SRC_SOURCE_ON state, Vsafe0v is expected as well so do nothing here to avoid state machine going into SNK_UNATTACHED.

Fixes 28b43d3d746b ("usb: typec: tcpm: Introduce vsafe0v for vbus")
Quoted 18 lines
---
 drivers/usb/typec/tcpm/tcpm.c | 1 +
 1 file changed, 1 insertion(+)
drivers/usb/typec/tcpm/tcpm.c +1 -0
index 197556038ba4..e11e9227107d 100644
@@ -5212,6 +5212,7 @@ static void _tcpm_pd_vbus_vsafe0v(struct tcpm_port *port)
 		}
 		break;
 	case PR_SWAP_SNK_SRC_SINK_OFF:
+	case PR_SWAP_SNK_SRC_SOURCE_ON:
 		/* Do nothing, vsafe0v is expected during transition */
 		break;
 	default:
Signature · 1 line
2.32.0.272.g935e593368-goog
Signature · 1 line
heikki