Skip to contentSkip to conversation

cobalt/thread: initialize sigarray in __xnthread_init

PATCH In review Hongzhan Chen 2 participants 2 messages Jun 16, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 cobalt/thread: initialize sigarray in __xnthread_init

Add missing sigarray initialization to avoid missing signal in __xnthread_signal.

kernel/cobalt/thread.c +2 -0
index d096a20d3..49913accc 100644
@@ -287,6 +287,8 @@ int __xnthread_init(struct xnthread *thread,
 	thread->cookie = NULL;
 	init_completion(&thread->exited);
 	memset(xnthread_archtcb(thread), 0, sizeof(struct xnarchtcb));
+	memset(thread->sigarray, 0, sizeof(thread->sigarray[0]) *
+				XNTHREAD_MAX_SIGNALS);
 
 	gravity = flags & XNUSER ? XNTIMER_UGRAVITY : XNTIMER_KGRAVITY;
 	xntimer_init(&thread->rtimer, &nkclock, timeout_handler,
Signature · 1 line
2.17.1
#1 lore raw
Quoted 11 lines · Hongzhan Chen via Xenomai

Add missing sigarray initialization to avoid missing signal in __xnthread_signal.

kernel/cobalt/thread.c +0 -0
index d096a20d3..49913accc 100644

kernel/cobalt/thread.c int __xnthread_init(struct xnthread *thread, · line 294

Quoted 8 lines
kernel/cobalt/thread.c +2 -0
@@ -287,6 +287,8 @@ int __xnthread_init(struct xnthread *thread,
 	thread->cookie = NULL;
 	init_completion(&thread->exited);
 	memset(xnthread_archtcb(thread), 0, sizeof(struct xnarchtcb));
+	memset(thread->sigarray, 0, sizeof(thread->sigarray[0]) *
+				XNTHREAD_MAX_SIGNALS);
 
 	gravity = flags & XNUSER ? XNTIMER_UGRAVITY : XNTIMER_KGRAVITY;
 	xntimer_init(&thread->rtimer, &nkclock, timeout_handler,

Good catch! Queued, though like this:

memset(thread->sigarray, 0, sizeof(thread->sigarray));

Thanks,
Jan

Signature · 2 lines
Siemens AG, T RDA IOT
Corporate Competence Center Embedded Linux