nvme: Correct the prps per page calculation method
PATCH 1/1 nvme: Correct the prps per page calculation method
From: wesleywesley <[email protected]>
Each prp is 8 bytes, calculate the number of prps
per page should just divide page size by 8
there is no need to minus 1
Signed-off-by wesleywesley <[email protected]>
--- drivers/nvme/nvme.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/nvme/nvme.c +1 -1
@@ -79,7 +79,7 @@ static int nvme_setup_prps(struct nvme_dev *dev, u64 *prp2,u64 *prp_pool;int length = total_len;int i, nprps; -u32 prps_per_page = (page_size >>3 ) -1 ; +u32 prps_per_page = page_size >>3 ;u32 num_pages; length -= (page_size - offset);
Signature · 1 line
2.25.1
Quoted 2 lines · Wesley Sheng
From: wesleywesley <[email protected]>
nits: are you sure this name is correct? Should it be "Wesley Sheng"?
Quoted 10 lines
Each prp is 8 bytes, calculate the number of prps
per page should just divide page size by 8
there is no need to minus 1Signed-off-by wesleywesley <[email protected]>--- drivers/nvme/nvme.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by Bin Meng <[email protected]>