Skip to contentSkip to conversation

bus/pci: fix leak for unbound devices

PATCH Applied David Marchand 1 participant 3 messages Jun 16, 2021 – Jul 6, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 bus/pci: fix leak for unbound devices

For devices not bound to any Linux kernel module, we leak a pci object since it is never added to the PCI bus device list.

Fixes c79a1c67465d ("bus/pci: optimize bus scan")
---
 drivers/bus/pci/linux/pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/bus/pci/linux/pci.c +1 -1
index 0dc99e9cb2..5ea76bc867 100644
@@ -331,7 +331,7 @@ pci_scan_one(const char *dirname, const struct rte_pci_addr *addr)
 		else
 			dev->kdrv = RTE_PCI_KDRV_UNKNOWN;
 	} else {
-		dev->kdrv = RTE_PCI_KDRV_NONE;
+		free(dev);
 		return 0;
 	}
 	/* device is valid, add in list (sorted) */
Signature · 1 line
2.23.0