Skip to contentSkip to conversation

riscv: dts: unleashed: Add gpio card detect to mmc-spi-slot

PATCH In review Bin Meng 2 participants 4 messages Jun 16, 2021 – Nov 24, 2021

Subsystems (4)
lore
Share & tools
lore

Bin Meng

author
#0 lore raw

PATCH 1/2 riscv: dts: unleashed: Add gpio card detect to mmc-spi-slot

From: Bin Meng <[email protected]>

Per HiFive Unleashed schematics, the card detect signal of the micro SD card is connected to gpio pin #11, which should be reflected in the DT via the <gpios> property, as described in Documentation/devicetree/bindings/mmc/mmc-spi-slot.txt.

[1] https://sifive.cdn.prismic.io/sifive/c52a8e32-05ce-4aaf-95c8-7bf8453f8698_hifive-unleashed-a00-schematics-1.pdf

---

 arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts | 1 +
 1 file changed, 1 insertion(+)
arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts +1 -0
index 60846e88ae4b..22f971e97161 100644
@@ -80,6 +80,7 @@ mmc@0 {
 		spi-max-frequency = <20000000>;
 		voltage-ranges = <3300 3300>;
 		disable-wp;
+		gpios = <&gpio 11 GPIO_ACTIVE_LOW>;
 	};
 };
 
Signature · 1 line
2.25.1
author
#1 lore raw

PATCH 2/2 riscv: dts: unmatched: Add gpio card detect to mmc-spi-slot

From: Bin Meng <[email protected]>

Per HiFive Unmatched schematics, the card detect signal of the micro SD card is connected to gpio pin #15, which should be reflected in the DT via the <gpios> property, as described in Documentation/devicetree/bindings/mmc/mmc-spi-slot.txt.

[1] https://sifive.cdn.prismic.io/sifive/6a06d6c0-6e66-49b5-8e9e-e68ce76f4192_hifive-unmatched-schematics-v3.pdf

---

 arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts | 2 ++
 1 file changed, 2 insertions(+)
arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts +2 -0
index b1c3c596578f..214794363c6a 100644
@@ -2,6 +2,7 @@
 /* Copyright (c) 2020 SiFive, Inc */
 
 #include "fu740-c000.dtsi"
+#include <dt-bindings/gpio/gpio.h>
 #include <dt-bindings/interrupt-controller/irq.h>
 
 /* Clock frequency (in Hz) of the PCB crystal for rtcclk */
@@ -228,6 +229,7 @@ mmc@0 {
 		spi-max-frequency = <20000000>;
 		voltage-ranges = <3300 3300>;
 		disable-wp;
+		gpios = <&gpio 15 GPIO_ACTIVE_LOW>;
 	};
 };
 
Signature · 7 lines
2.25.1


_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv
author
#2 lore raw
In reply to Bin Meng
Quoted 8 lines · Bin Meng

From: Bin Meng <[email protected]>

Per HiFive Unleashed schematics, the card detect signal of the micro SD card is connected to gpio pin #11, which should be reflected in the DT via the <gpios> property, as described in Documentation/devicetree/bindings/mmc/mmc-spi-slot.txt.

Quoted 8 lines

[1] https://sifive.cdn.prismic.io/sifive/c52a8e32-05ce-4aaf-95c8-7bf8453f8698_hifive-unleashed-a00-schematics-1.pdf

---

 arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts | 1 +
 1 file changed, 1 insertion(+)

Ping?

maintainer
#3 lore raw
Quoted 11 lines · On Thu, 08 Jul 2021 06:40:03 PDT (-0700), [email protected] wrote:
Quoted 10 lines · Bin Meng

From: Bin Meng <[email protected]>

Per HiFive Unleashed schematics, the card detect signal of the micro SD card is connected to gpio pin #11, which should be reflected in the DT via the <gpios> property, as described in Documentation/devicetree/bindings/mmc/mmc-spi-slot.txt.

[1] https://sifive.cdn.prismic.io/sifive/c52a8e32-05ce-4aaf-95c8-7bf8453f8698_hifive-unleashed-a00-schematics-1.pdf

Quoted 8 lines
Quoted 6 lines

---

 arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts | 1 +
 1 file changed, 1 insertion(+)

Ping?

Sorry I missed these, and thanks to David for pointing them out. They're on fixes.