drm/amdgpu: Set TTM_PAGE_FLAG_SG earlier for userprt BOs
Subsystems (2)
PATCH 1/1 drm/amdgpu: Set TTM_PAGE_FLAG_SG earlier for userprt BOs
Because TTM do page counting on userptr BOs which is actually not needed. To avoid that, lets set TTM_PAGE_FLAG_SG after tt_create and before tt_populate.
Signed-off-by xinhui pan <[email protected]>
--- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c +3 -3
@@ -1147,8 +1147,6 @@ static int amdgpu_ttm_tt_populate(struct ttm_device *bdev, ttm->sg =kzalloc (sizeof (struct sg_table ),GFP_KERNEL );if (!ttm->sg)return -ENOMEM ; - - ttm->page_flags |=TTM_PAGE_FLAG_SG ;return 0 ; }
@@ -1174,7 +1172,6 @@ static void amdgpu_ttm_tt_unpopulate(struct ttm_device *bdev,amdgpu_ttm_tt_set_user_pages (ttm,NULL );kfree (ttm->sg); ttm->sg =NULL ; - ttm->page_flags &= ~TTM_PAGE_FLAG_SG ;return ; }
@@ -1208,6 +1205,9 @@ int amdgpu_ttm_tt_set_userptr(struct ttm_buffer_object *bo,return -ENOMEM ; } +/* Set TTM_PAGE_FLAG_SG before populate but after create. */ + bo->ttm->page_flags |=TTM_PAGE_FLAG_SG ; + gtt = (void *)bo->ttm; gtt->userptr = addr; gtt->userflags = flags;
Signature · 6 lines
2.25.1 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Am 16.06.21 um 10:36 schrieb xinhui pan:
Quoted 5 lines
Because TTM do page counting on userptr BOs which is actually not needed. To avoid that, lets set
TTM_PAGE_FLAG_SGaftertt_createand beforett_populate.Signed-off-by xinhui pan <[email protected]>
Reviewed-by Christian König <[email protected]>
Quoted 26 lines
--- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c +0
-3@@ -1147,8 +1147,6 @@ static int amdgpu_ttm_tt_populate(struct ttm_device *bdev, ttm->sg =kzalloc (sizeof (struct sg_table ),GFP_KERNEL );if (!ttm->sg)return -ENOMEM ; - - ttm->page_flags |=TTM_PAGE_FLAG_SG ;return 0 ; }@@ -1174,7 +1172,6 @@ static void amdgpu_ttm_tt_unpopulate(struct ttm_device *bdev,amdgpu_ttm_tt_set_user_pages (ttm,NULL );kfree (ttm->sg); ttm->sg =NULL ; - ttm->page_flags &= ~TTM_PAGE_FLAG_SG ;return ; }
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c int amdgpu_ttm_tt_set_userptr(struct ttm_buffer_object *bo, · line 1213
Quoted 9 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c +3
-0@@ -1208,6 +1205,9 @@ int amdgpu_ttm_tt_set_userptr(struct ttm_buffer_object *bo,return -ENOMEM ; } +/* Set TTM_PAGE_FLAG_SG before populate but after create. */ + bo->ttm->page_flags |=TTM_PAGE_FLAG_SG ; + gtt = (void *)bo->ttm; gtt->userptr = addr; gtt->userflags = flags;
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx