Skip to contentSkip to conversation

bpf: fix libelf endian handling in resolv_btfids

PATCH Superseded Tony Ambardar 6 participants 12 messages Jun 16, 2021 – Jun 18, 2021

Subsystems (5)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 bpf: fix libelf endian handling in resolv_btfids

While patching the .BTF_ids section in vmlinux, resolve_btfids writes type ids using host-native endianness, and relies on libelf for any required translation when finally updating vmlinux. However, the default type of the .BTF_ids section content is ELF_T_BYTE (i.e. unsigned char), and undergoes no translation. This results in incorrect patched values if cross-compiling to non-native endianness, and can manifest as kernel Oops and test failures which are difficult to debug.

Explicitly set the type of patched data to ELF_T_WORD, allowing libelf to transparently handle the endian conversions.

Fixes fbbb68de80a4 ("bpf: Add resolve_btfids tool to resolve BTF IDs in ELF object")
Cc [email protected] # v5.10+
Cc Jiri Olsa <[email protected]>
Cc Yonghong Song <[email protected]>
---
 tools/bpf/resolve_btfids/main.c | 3 +++
 1 file changed, 3 insertions(+)
tools/bpf/resolve_btfids/main.c +3 -0
index d636643ddd35..f32c059fbfb4 100644
@@ -649,6 +649,9 @@ static int symbols_patch(struct object *obj)
 	if (sets_patch(obj))
 		return -1;
 
+	/* Set type to ensure endian translation occurs. */
+	obj->efile.idlist->d_type = ELF_T_WORD;
+
 	elf_flagdata(obj->efile.idlist, ELF_C_SET, ELF_F_DIRTY);
 
 	err = elf_update(obj->efile.elf, ELF_C_WRITE);
Signature · 1 line
2.25.1
#1 lore raw
Quoted 26 lines · Tony Ambardar

While patching the .BTF_ids section in vmlinux, resolve_btfids writes type ids using host-native endianness, and relies on libelf for any required translation when finally updating vmlinux. However, the default type of the .BTF_ids section content is ELF_T_BYTE (i.e. unsigned char), and undergoes no translation. This results in incorrect patched values if cross-compiling to non-native endianness, and can manifest as kernel Oops and test failures which are difficult to debug.

Explicitly set the type of patched data to ELF_T_WORD, allowing libelf to transparently handle the endian conversions.

Fixes fbbb68de80a4 ("bpf: Add resolve_btfids tool to resolve BTF IDs in ELF object")
Cc [email protected] # v5.10+
Cc Jiri Olsa <[email protected]>
Cc Yonghong Song <[email protected]>
---
  tools/bpf/resolve_btfids/main.c | 3 +++
  1 file changed, 3 insertions(+)
tools/bpf/resolve_btfids/main.c +0 -0
index d636643ddd35..f32c059fbfb4 100644

tools/bpf/resolve_btfids/main.c static int symbols_patch(struct object *obj) · line 653

Quoted 5 lines
tools/bpf/resolve_btfids/main.c +2 -0
@@ -649,6 +649,9 @@ static int symbols_patch(struct object *obj)
  	if (sets_patch(obj))
  		return -1;
 
+	/* Set type to ensure endian translation occurs. */
+	obj->efile.idlist->d_type = ELF_T_WORD;

The change makes sense to me as .BTF_ids contains just a list of u32's.

Jiri, could you double check on this?

Quoted 5 lines
tools/bpf/resolve_btfids/main.c +1 -0
+
  	elf_flagdata(obj->efile.idlist, ELF_C_SET, ELF_F_DIRTY);
 
  	err = elf_update(obj->efile.elf, ELF_C_WRITE);
#2 lore raw
Quoted 10 lines · Yonghong Song
Quoted 7 lines · Tony Ambardar

While patching the .BTF_ids section in vmlinux, resolve_btfids writes type ids using host-native endianness, and relies on libelf for any required translation when finally updating vmlinux. However, the default type of the .BTF_ids section content is ELF_T_BYTE (i.e. unsigned char), and undergoes no translation. This results in incorrect patched values if cross-compiling to non-native endianness, and can manifest as kernel Oops and test failures which are difficult to debug.

nice catch, great libelf can do that ;-)

Quoted 27 lines
Quoted 19 lines

Explicitly set the type of patched data to ELF_T_WORD, allowing libelf to transparently handle the endian conversions.

Fixes fbbb68de80a4 ("bpf: Add resolve_btfids tool to resolve BTF IDs in ELF object")
Cc [email protected] # v5.10+
Cc Jiri Olsa <[email protected]>
Cc Yonghong Song <[email protected]>
---
  tools/bpf/resolve_btfids/main.c | 3 +++
  1 file changed, 3 insertions(+)
tools/bpf/resolve_btfids/main.c +0 -0
index d636643ddd35..f32c059fbfb4 100644

tools/bpf/resolve_btfids/main.c static int symbols_patch(struct object *obj) · line 652

Quoted 4 lines
tools/bpf/resolve_btfids/main.c +2 -0
@@ -649,6 +649,9 @@ static int symbols_patch(struct object *obj)
  	if (sets_patch(obj))
  		return -1;
+	/* Set type to ensure endian translation occurs. */
+	obj->efile.idlist->d_type = ELF_T_WORD;

The change makes sense to me as .BTF_ids contains just a list of u32's.

Quoted 1 line

Jiri, could you double check on this?

the comment in ELF_T_WORD declaration suggests the size depends on elf's class?

ELF_T_WORD, /* Elf32_Word, Elf64_Word, ... */

data in .BTF_ids section are allways u32

I have no idea how is this handled in libelf (perhaps it's ok), but just that comment above suggests it could be also 64 bits, cc-ing Frank and Mark for more insight

thanks,
jirka

Quoted 6 lines
Quoted 5 lines
tools/bpf/resolve_btfids/main.c +1 -0
+
  	elf_flagdata(obj->efile.idlist, ELF_C_SET, ELF_F_DIRTY);
  	err = elf_update(obj->efile.elf, ELF_C_WRITE);
 
#3 lore raw
Quoted 12 lines · Jiri Olsa
Quoted 9 lines · Yonghong Song
Quoted 7 lines · Tony Ambardar

While patching the .BTF_ids section in vmlinux, resolve_btfids writes type ids using host-native endianness, and relies on libelf for any required translation when finally updating vmlinux. However, the default type of the .BTF_ids section content is ELF_T_BYTE (i.e. unsigned char), and undergoes no translation. This results in incorrect patched values if cross-compiling to non-native endianness, and can manifest as kernel Oops and test failures which are difficult to debug.

Quoted 1 line

nice catch, great libelf can do that ;-)

Funny, I'd actually assumed that was your intention, but I just couldn't find where the
data type was being set, so resorted to this "kludge". While there's a .BTF_ids section definition in include/linux/btf_ids.h, there's no means I can see to specify
the data type either (i.e. in the gcc asm .pushsection() options). That approach would be cleaner.

Quoted 28 lines
Quoted 28 lines
Quoted 20 lines

Explicitly set the type of patched data to ELF_T_WORD, allowing libelf to transparently handle the endian conversions.

Fixes fbbb68de80a4 ("bpf: Add resolve_btfids tool to resolve BTF IDs in ELF object")
Cc [email protected] # v5.10+
Cc Jiri Olsa <[email protected]>
Cc Yonghong Song <[email protected]>
---
  tools/bpf/resolve_btfids/main.c | 3 +++
  1 file changed, 3 insertions(+)
tools/bpf/resolve_btfids/main.c +0 -0
index d636643ddd35..f32c059fbfb4 100644

tools/bpf/resolve_btfids/main.c static int symbols_patch(struct object *obj) · line 652

Quoted 4 lines
tools/bpf/resolve_btfids/main.c +2 -0
@@ -649,6 +649,9 @@ static int symbols_patch(struct object *obj)
    if (sets_patch(obj))
            return -1;
+   /* Set type to ensure endian translation occurs. */
+   obj->efile.idlist->d_type = ELF_T_WORD;

The change makes sense to me as .BTF_ids contains just a list of u32's.

Quoted 9 lines
Quoted 1 line

Jiri, could you double check on this?

the comment in ELF_T_WORD declaration suggests the size depends on elf's class?

ELF_T_WORD, /* Elf32_Word, Elf64_Word, ... */

data in .BTF_ids section are allways u32

I believe the Elf32/Elf64 refer to the arch since some data structures vary between the two, but ELF_T_WORD is common to both, and valid as the data type of Elf_Data struct holding the .BTF_ids contents. See elf(5):

Basic types
The following types are used for N-bit architectures (N=32,64, ElfN stands for Elf32 or Elf64, uintN_t stands for uint32_t or uint64_t):
...
ElfN_Word uint32_t

Also see the code and comments in "elf.h":

    /* Types for signed and unsigned 32-bit quantities.  */
    typedef uint32_t Elf32_Word;
    typedef uint32_t Elf64_Word;
Quoted 4 lines

I have no idea how is this handled in libelf (perhaps it's ok), but just that comment above suggests it could be also 64 bits, cc-ing Frank and Mark for more insight

One other area I'd like to confirm is with section compression. Is it safe to ignore this for .BTF_ids? I've done so because include/linux/btf_ids.h appears to define the section with SHF_ALLOC flag set, which is incompatible with compression based on "libelf.h" comments.

Thanks for reviewing,
Tony

Quoted 10 lines

thanks,
jirka

Quoted 6 lines
Quoted 5 lines
tools/bpf/resolve_btfids/main.c +1 -0
+
    elf_flagdata(obj->efile.idlist, ELF_C_SET, ELF_F_DIRTY);
    err = elf_update(obj->efile.elf, ELF_C_WRITE);
 
#4 lore raw
Quoted 71 lines · Tony Ambardar
Quoted 12 lines · Jiri Olsa
Quoted 9 lines · Yonghong Song
Quoted 7 lines · Tony Ambardar

While patching the .BTF_ids section in vmlinux, resolve_btfids writes type ids using host-native endianness, and relies on libelf for any required translation when finally updating vmlinux. However, the default type of the .BTF_ids section content is ELF_T_BYTE (i.e. unsigned char), and undergoes no translation. This results in incorrect patched values if cross-compiling to non-native endianness, and can manifest as kernel Oops and test failures which are difficult to debug.

Quoted 1 line

nice catch, great libelf can do that ;-)

Funny, I'd actually assumed that was your intention, but I just couldn't find where the
data type was being set, so resorted to this "kludge". While there's a .BTF_ids section definition in include/linux/btf_ids.h, there's no means I can see to specify
the data type either (i.e. in the gcc asm .pushsection() options). That approach would be cleaner.

Quoted 28 lines
Quoted 28 lines
Quoted 20 lines

Explicitly set the type of patched data to ELF_T_WORD, allowing libelf to transparently handle the endian conversions.

Fixes fbbb68de80a4 ("bpf: Add resolve_btfids tool to resolve BTF IDs in ELF object")
Cc [email protected] # v5.10+
Cc Jiri Olsa <[email protected]>
Cc Yonghong Song <[email protected]>
---
  tools/bpf/resolve_btfids/main.c | 3 +++
  1 file changed, 3 insertions(+)
tools/bpf/resolve_btfids/main.c +0 -0
index d636643ddd35..f32c059fbfb4 100644

tools/bpf/resolve_btfids/main.c static int symbols_patch(struct object *obj) · line 652

Quoted 4 lines
tools/bpf/resolve_btfids/main.c +2 -0
@@ -649,6 +649,9 @@ static int symbols_patch(struct object *obj)
    if (sets_patch(obj))
            return -1;
+   /* Set type to ensure endian translation occurs. */
+   obj->efile.idlist->d_type = ELF_T_WORD;

The change makes sense to me as .BTF_ids contains just a list of u32's.

Quoted 9 lines
Quoted 1 line

Jiri, could you double check on this?

the comment in ELF_T_WORD declaration suggests the size depends on elf's class?

ELF_T_WORD, /* Elf32_Word, Elf64_Word, ... */

data in .BTF_ids section are allways u32

I believe the Elf32/Elf64 refer to the arch since some data structures vary between the two, but ELF_T_WORD is common to both, and valid as the data type of Elf_Data struct holding the .BTF_ids contents. See elf(5):

Basic types
The following types are used for N-bit architectures (N=32,64, ElfN stands for Elf32 or Elf64, uintN_t stands for uint32_t or uint64_t):
...
ElfN_Word uint32_t

Quoted 4 lines

Also see the code and comments in "elf.h":

    /* Types for signed and unsigned 32-bit quantities.  */
    typedef uint32_t Elf32_Word;
    typedef uint32_t Elf64_Word;

ok

Quoted 10 lines
Quoted 5 lines

I have no idea how is this handled in libelf (perhaps it's ok), but just that comment above suggests it could be also 64 bits, cc-ing Frank and Mark for more insight

One other area I'd like to confirm is with section compression. Is it safe to ignore this for .BTF_ids? I've done so because include/linux/btf_ids.h appears to define the section with SHF_ALLOC flag set, which is incompatible with compression based on "libelf.h" comments.

not sure what you mean.. where it wouldn't be safe? what workflow/processing

thanks,
jirka

#5 lore raw
Quoted 14 lines · Jiri Olsa
Quoted 6 lines · Tony Ambardar
Quoted 4 lines · Jiri Olsa

I have no idea how is this handled in libelf (perhaps it's ok), but just that comment above suggests it could be also 64 bits, cc-ing Frank and Mark for more insight

Quoted 6 lines

One other area I'd like to confirm is with section compression. Is it safe
to ignore this for .BTF_ids? I've done so because include/linux/btf_ids.h
appears to define the section with SHF_ALLOC flag set, which is incompatible with compression based on "libelf.h" comments.

Quoted 2 lines

not sure what you mean.. where it wouldn't be safe? what workflow/processing

I haven't looked at the code/patch, but Tony is correct that if a section has SHF_ALLOC set it cannot be a compressed section. SHF_COMPRESSED is incompatbile with SHF_ALLOC (or SHF_NOBITS) sections, because it would be unclear what a loader would need to do with them (uncompress the data first, then map it, or map the compressed data as is into memory).

So ignoring whether or not a section is compressed for SHF_ALLOC sections is fine.

Cheers,

Mark

#6 lore raw
In reply to Jiri Olsa

Hoi,

Quoted 18 lines · Jiri Olsa
Quoted 13 lines

tools/bpf/resolve_btfids/main.c static int symbols_patch(struct object *obj) · line 652

Quoted 9 lines
tools/bpf/resolve_btfids/main.c +2 -0
index d636643ddd35..f32c059fbfb4 100644
@@ -649,6 +649,9 @@ static int symbols_patch(struct object *obj)
  	if (sets_patch(obj))
  		return -1;
+	/* Set type to ensure endian translation occurs. */
+	obj->efile.idlist->d_type = ELF_T_WORD;

The change makes sense to me as .BTF_ids contains just a list of u32's.

Quoted 1 line

Jiri, could you double check on this?

the comment in ELF_T_WORD declaration suggests the size depends on elf's class?

Quoted 7 lines

ELF_T_WORD, /* Elf32_Word, Elf64_Word, ... */

data in .BTF_ids section are allways u32

I have no idea how is this handled in libelf (perhaps it's ok), but just that comment above suggests it could be also 64 bits, cc-ing Frank and Mark for more insight

It is correct to use ELF_T_WORD, which means a 32bit unsigned word.

The comment is meant to explain that, but is really confusing if you don't know that Elf32_Word and Elf64_Word are the same thing (a 32bit unsigned word). This comes from being "too consistent" in defining all data types for both 32bit and 64bit ELF, even if those types are the same in both formats...

Only Elf32_Addr/Elf64_Addr and Elf32_Off/Elf64_Off are different sizes. But Elf32/Elf_64_Half (16 bit), Elf32/Elf64_Word (32 bit), Elf32/Elf64_Xword (64 bit) and their Sword/Sxword (signed) variants are all identical data types in both the Elf32 and Elf64 formats.

I don't really know why. It seems the original ELF spec was 32bit only and when introducing the ELF64 format "they" simply duplicated all data types whether or not those data type were actually different between the 32 and 64 bit format.

Cheers,

Mark

Acked-by
#7 lore raw
Quoted 42 lines · Mark Wielaard

Hoi,

Quoted 18 lines · Jiri Olsa
Quoted 13 lines

tools/bpf/resolve_btfids/main.c static int symbols_patch(struct object *obj) · line 652

Quoted 9 lines
tools/bpf/resolve_btfids/main.c +2 -0
index d636643ddd35..f32c059fbfb4 100644
@@ -649,6 +649,9 @@ static int symbols_patch(struct object *obj)
  	if (sets_patch(obj))
  		return -1;
+	/* Set type to ensure endian translation occurs. */
+	obj->efile.idlist->d_type = ELF_T_WORD;

The change makes sense to me as .BTF_ids contains just a list of u32's.

Quoted 1 line

Jiri, could you double check on this?

the comment in ELF_T_WORD declaration suggests the size depends on elf's class?

Quoted 7 lines

ELF_T_WORD, /* Elf32_Word, Elf64_Word, ... */

data in .BTF_ids section are allways u32

I have no idea how is this handled in libelf (perhaps it's ok), but just that comment above suggests it could be also 64 bits, cc-ing Frank and Mark for more insight

It is correct to use ELF_T_WORD, which means a 32bit unsigned word.

The comment is meant to explain that, but is really confusing if you don't know that Elf32_Word and Elf64_Word are the same thing (a 32bit unsigned word). This comes from being "too consistent" in defining all data types for both 32bit and 64bit ELF, even if those types are the same in both formats...

Only Elf32_Addr/Elf64_Addr and Elf32_Off/Elf64_Off are different sizes. But Elf32/Elf_64_Half (16 bit), Elf32/Elf64_Word (32 bit), Elf32/Elf64_Xword (64 bit) and their Sword/Sxword (signed) variants are all identical data types in both the Elf32 and Elf64 formats.

Quoted 4 lines

I don't really know why. It seems the original ELF spec was 32bit only and when introducing the ELF64 format "they" simply duplicated all data types whether or not those data type were actually different between the 32 and 64 bit format.

nice, thanks for details

jirka

maintainer
#8 lore raw
Quoted 41 lines · Jiri Olsa
Quoted 40 lines · Mark Wielaard
Quoted 18 lines · Jiri Olsa
Quoted 13 lines

tools/bpf/resolve_btfids/main.c static int symbols_patch(struct object *obj) · line 652

Quoted 9 lines
tools/bpf/resolve_btfids/main.c +2 -0
index d636643ddd35..f32c059fbfb4 100644
@@ -649,6 +649,9 @@ static int symbols_patch(struct object *obj)
   	if (sets_patch(obj))
   		return -1;
+	/* Set type to ensure endian translation occurs. */
+	obj->efile.idlist->d_type = ELF_T_WORD;

The change makes sense to me as .BTF_ids contains just a list of u32's.

Quoted 1 line

Jiri, could you double check on this?

the comment in ELF_T_WORD declaration suggests the size depends on elf's class?

Quoted 7 lines
   ELF_T_WORD,                   /* Elf32_Word, Elf64_Word, ... */

data in .BTF_ids section are allways u32

I have no idea how is this handled in libelf (perhaps it's ok), but just that comment above suggests it could be also 64 bits, cc-ing Frank and Mark for more insight

It is correct to use ELF_T_WORD, which means a 32bit unsigned word.

The comment is meant to explain that, but is really confusing if you don't know that Elf32_Word and Elf64_Word are the same thing (a 32bit unsigned word). This comes from being "too consistent" in defining all data types for both 32bit and 64bit ELF, even if those types are the same in both formats...

Only Elf32_Addr/Elf64_Addr and Elf32_Off/Elf64_Off are different sizes. But Elf32/Elf_64_Half (16 bit), Elf32/Elf64_Word (32 bit), Elf32/Elf64_Xword (64 bit) and their Sword/Sxword (signed) variants are all identical data types in both the Elf32 and Elf64 formats.

Quoted 8 lines
Quoted 4 lines

I don't really know why. It seems the original ELF spec was 32bit only and when introducing the ELF64 format "they" simply duplicated all data types whether or not those data type were actually different between the 32 and 64 bit format.

nice, thanks for details

Tony, could you do a v2 and summarize the remainder of the discussion in here for the commit message? Would be good to explicitly document the assumptions made and why they work.

Thanks everyone,
Daniel

#9 lore raw
Quoted 48 lines · Daniel Borkmann
Quoted 46 lines · Jiri Olsa
Quoted 44 lines · Mark Wielaard
Quoted 18 lines · Jiri Olsa
Quoted 13 lines

tools/bpf/resolve_btfids/main.c static int symbols_patch(struct object *obj) · line 652

Quoted 9 lines
tools/bpf/resolve_btfids/main.c +2 -0
index d636643ddd35..f32c059fbfb4 100644
@@ -649,6 +649,9 @@ static int symbols_patch(struct object *obj)
          if (sets_patch(obj))
                  return -1;
+ /* Set type to ensure endian translation occurs. */
+ obj->efile.idlist->d_type = ELF_T_WORD;

The change makes sense to me as .BTF_ids contains just a list of u32's.

Quoted 1 line

Jiri, could you double check on this?

the comment in ELF_T_WORD declaration suggests the size depends on elf's class?

Quoted 7 lines
   ELF_T_WORD,                   /* Elf32_Word, Elf64_Word, ... */

data in .BTF_ids section are allways u32

I have no idea how is this handled in libelf (perhaps it's ok), but just that comment above suggests it could be also 64 bits, cc-ing Frank and Mark for more insight

It is correct to use ELF_T_WORD, which means a 32bit unsigned word.

The comment is meant to explain that, but is really confusing if you don't know that Elf32_Word and Elf64_Word are the same thing (a 32bit unsigned word). This comes from being "too consistent" in defining all data types for both 32bit and 64bit ELF, even if those types are the same in both formats...

Only Elf32_Addr/Elf64_Addr and Elf32_Off/Elf64_Off are different sizes. But Elf32/Elf_64_Half (16 bit), Elf32/Elf64_Word (32 bit), Elf32/Elf64_Xword (64 bit) and their Sword/Sxword (signed) variants are all identical data types in both the Elf32 and Elf64 formats.

I don't really know why. It seems the original ELF spec was 32bit only and when introducing the ELF64 format "they" simply duplicated all data types whether or not those data type were actually different between the 32 and 64 bit format.

Quoted 7 lines
Quoted 3 lines

nice, thanks for details

Tony, could you do a v2 and summarize the remainder of the discussion in here for the commit message? Would be good to explicitly document the assumptions made and why they work.

Sure, Daniel, I'll update the commit details and resend.

Thanks,
Tony

Quoted 2 lines

Thanks everyone,
Daniel

#10 lore raw

PATCH v2 1/1 bpf: fix libelf endian handling in resolv_btfids

In reply to Tony Ambardar

The vmlinux ".BTF_ids" ELF section is declared in btf_ids.h to hold a list of zero-filled BTF IDs, which is then patched at link-time with correct values by resolv_btfids. The section is flagged as "allocable" to preclude compression, but notably the section contents (BTF IDs) are untyped.

When patching the BTF IDs, resolve_btfids writes in host-native endianness and relies on libelf for any required translation on reading and updating vmlinux. However, since the type of the .BTF_ids section content defaults to ELF_T_BYTE (i.e. unsigned char), no translation occurs. This results in incorrect patched values when cross-compiling to non-native endianness, and can manifest as kernel Oops and test failures which are difficult to troubleshoot [1].

Explicitly set the type of patched data to ELF_T_WORD, the architecture- neutral ELF type corresponding to the u32 BTF IDs. This enables libelf to transparently perform any needed endian conversions.

Fixes fbbb68de80a4 ("bpf: Add resolve_btfids tool to resolve BTF IDs in ELF object")
Cc [email protected] # v5.10+
Cc Frank Eigler <[email protected]>
Cc Mark Wielaard <[email protected]>
Cc Jiri Olsa <[email protected]>
Cc Yonghong Song <[email protected]>

---
v1 -> v2:
* add context and elaborate on commit message per request
* include ACK from Jiri Olsa

---
 tools/bpf/resolve_btfids/main.c | 3 +++
 1 file changed, 3 insertions(+)
tools/bpf/resolve_btfids/main.c +3 -0
index d636643ddd35..f32c059fbfb4 100644
@@ -649,6 +649,9 @@ static int symbols_patch(struct object *obj)
 	if (sets_patch(obj))
 		return -1;
 
+	/* Set type to ensure endian translation occurs. */
+	obj->efile.idlist->d_type = ELF_T_WORD;
+
 	elf_flagdata(obj->efile.idlist, ELF_C_SET, ELF_F_DIRTY);
 
 	err = elf_update(obj->efile.elf, ELF_C_WRITE);
Signature · 1 line
2.25.1
#11 lore raw
This patch was applied to bpf/bpf.git (refs/heads/master):

Hello:

This patch was applied to bpf/bpf.git (refs/heads/master):

Quoted 13 lines · On Thu, 17 Jun 2021 23:14:04 -0700 you wrote:

The vmlinux ".BTF_ids" ELF section is declared in btf_ids.h to hold a list of zero-filled BTF IDs, which is then patched at link-time with correct values by resolv_btfids. The section is flagged as "allocable" to preclude compression, but notably the section contents (BTF IDs) are untyped.

When patching the BTF IDs, resolve_btfids writes in host-native endianness and relies on libelf for any required translation on reading and updating vmlinux. However, since the type of the .BTF_ids section content defaults to ELF_T_BYTE (i.e. unsigned char), no translation occurs. This results in incorrect patched values when cross-compiling to non-native endianness, and can manifest as kernel Oops and test failures which are difficult to troubleshoot [1].

Quoted 1 line

[...]

Here is the summary with links:
- [bpf,v2] bpf: fix libelf endian handling in resolv_btfids

    https://git.kernel.org/bpf/bpf/c/61e8aeda9398

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html