Skip to contentSkip to conversation

iio: hid-sensors: Update header includes

PATCH In review Jonathan Cameron 2 participants 3 messages Jun 8, 2021 – Jun 16, 2021

Subsystems (2)
lore
Share & tools
lore

Jonathan Cameron

author maintainer
#0 lore raw

PATCH 1/1 iio: hid-sensors: Update header includes

From: Jonathan Cameron <[email protected]>

General driver churn doesn't always include updates of header includes. Manual review of the output of the include-what-you-use checker lead to the following cleanup. Hopefuly this brings things back to a good state for the hid-sensor drivers.

Cc Jiri Kosina <[email protected]>
Cc Srinivas Pandruvada <[email protected]>
---
 drivers/iio/accel/hid-sensor-accel-3d.c                | 5 +----
 drivers/iio/common/hid-sensors/hid-sensor-attributes.c | 6 ------
 drivers/iio/common/hid-sensors/hid-sensor-trigger.c    | 5 +----
 drivers/iio/common/hid-sensors/hid-sensor-trigger.h    | 3 +++
 drivers/iio/gyro/hid-sensor-gyro-3d.c                  | 5 +----
 drivers/iio/humidity/hid-sensor-humidity.c             | 1 +
 drivers/iio/light/hid-sensor-als.c                     | 5 +----
 drivers/iio/light/hid-sensor-prox.c                    | 5 +----
 drivers/iio/magnetometer/hid-sensor-magn-3d.c          | 6 +-----
 drivers/iio/orientation/hid-sensor-incl-3d.c           | 5 +----
 drivers/iio/orientation/hid-sensor-rotation.c          | 4 +---
 drivers/iio/position/hid-sensor-custom-intel-hinge.c   | 2 ++
 drivers/iio/pressure/hid-sensor-press.c                | 5 +----
 drivers/iio/temperature/hid-sensor-temperature.c       | 1 +
 14 files changed, 16 insertions(+), 42 deletions(-)
drivers/iio/accel/hid-sensor-accel-3d.c +1 -4
index 27f47e1c251e..b4fa53dc447a 100644
@@ -6,13 +6,10 @@
 #include <linux/device.h>
 #include <linux/platform_device.h>
 #include <linux/module.h>
-#include <linux/interrupt.h>
-#include <linux/irq.h>
+#include <linux/mod_devicetable.h>
 #include <linux/slab.h>
-#include <linux/delay.h>
 #include <linux/hid-sensor-hub.h>
 #include <linux/iio/iio.h>
-#include <linux/iio/sysfs.h>
 #include <linux/iio/buffer.h>
 #include "../common/hid-sensors/hid-sensor-trigger.h"
 
drivers/iio/common/hid-sensors/hid-sensor-attributes.c +0 -6
index cb52b4fd6bf7..eb6a9012c899 100644
@@ -3,18 +3,12 @@
  * HID Sensors Driver
  * Copyright (c) 2012, Intel Corporation.
  */
-#include <linux/device.h>
-#include <linux/platform_device.h>
 #include <linux/module.h>
-#include <linux/interrupt.h>
-#include <linux/irq.h>
 #include <linux/kernel.h>
-#include <linux/slab.h>
 #include <linux/time.h>
 
 #include <linux/hid-sensor-hub.h>
 #include <linux/iio/iio.h>
-#include <linux/iio/sysfs.h>
 
 #define HZ_PER_MHZ	1000000L
 
drivers/iio/common/hid-sensors/hid-sensor-trigger.c +1 -4
index c06537e106e9..4918e2c8f6d5 100644
@@ -6,16 +6,13 @@
 #include <linux/device.h>
 #include <linux/platform_device.h>
 #include <linux/module.h>
-#include <linux/interrupt.h>
-#include <linux/irq.h>
-#include <linux/slab.h>
 #include <linux/delay.h>
 #include <linux/hid-sensor-hub.h>
+#include <linux/workqueue.h>
 #include <linux/iio/iio.h>
 #include <linux/iio/trigger.h>
 #include <linux/iio/triggered_buffer.h>
 #include <linux/iio/trigger_consumer.h>
-#include <linux/iio/buffer.h>
 #include <linux/iio/sysfs.h>
 #include "hid-sensor-trigger.h"
 
drivers/iio/common/hid-sensors/hid-sensor-trigger.h +3 -0
index bb45cc89e551..f94fca4f1edf 100644
@@ -9,6 +9,9 @@
 #include <linux/pm.h>
 #include <linux/pm_runtime.h>
 
+struct hid_sensor_common;
+struct iio_dev;
+
 extern const struct dev_pm_ops hid_sensor_pm_ops;
 
 int hid_sensor_setup_trigger(struct iio_dev *indio_dev, const char *name,
drivers/iio/gyro/hid-sensor-gyro-3d.c +1 -4
index dad26ee4fd1f..a8f59ed802f4 100644
@@ -6,13 +6,10 @@
 #include <linux/device.h>
 #include <linux/platform_device.h>
 #include <linux/module.h>
-#include <linux/interrupt.h>
-#include <linux/irq.h>
+#include <linux/mod_devicetable.h>
 #include <linux/slab.h>
-#include <linux/delay.h>
 #include <linux/hid-sensor-hub.h>
 #include <linux/iio/iio.h>
-#include <linux/iio/sysfs.h>
 #include <linux/iio/buffer.h>
 #include "../common/hid-sensors/hid-sensor-trigger.h"
 
drivers/iio/humidity/hid-sensor-humidity.c +1 -0
index 74383abc0d44..64fe6752ec16 100644
@@ -8,6 +8,7 @@
 #include <linux/iio/buffer.h>
 #include <linux/iio/iio.h>
 #include <linux/module.h>
+#include <linux/mod_devicetable.h>
 #include <linux/platform_device.h>
 
 #include "hid-sensor-trigger.h"
drivers/iio/light/hid-sensor-als.c +1 -4
index 85c8a05b73cb..cddd8d448372 100644
@@ -6,13 +6,10 @@
 #include <linux/device.h>
 #include <linux/platform_device.h>
 #include <linux/module.h>
-#include <linux/interrupt.h>
-#include <linux/irq.h>
+#include <linux/mod_devicetable.h>
 #include <linux/slab.h>
-#include <linux/delay.h>
 #include <linux/hid-sensor-hub.h>
 #include <linux/iio/iio.h>
-#include <linux/iio/sysfs.h>
 #include <linux/iio/buffer.h>
 #include "../common/hid-sensors/hid-sensor-trigger.h"
 
drivers/iio/light/hid-sensor-prox.c +1 -4
index 17d167c3d595..e02cc6cdf44a 100644
@@ -6,13 +6,10 @@
 #include <linux/device.h>
 #include <linux/platform_device.h>
 #include <linux/module.h>
-#include <linux/interrupt.h>
-#include <linux/irq.h>
+#include <linux/mod_devicetable.h>
 #include <linux/slab.h>
-#include <linux/delay.h>
 #include <linux/hid-sensor-hub.h>
 #include <linux/iio/iio.h>
-#include <linux/iio/sysfs.h>
 #include <linux/iio/buffer.h>
 #include "../common/hid-sensors/hid-sensor-trigger.h"
 
drivers/iio/magnetometer/hid-sensor-magn-3d.c +1 -5
index b78691523dd4..e42352c3221d 100644
@@ -6,13 +6,9 @@
 #include <linux/device.h>
 #include <linux/platform_device.h>
 #include <linux/module.h>
-#include <linux/interrupt.h>
-#include <linux/irq.h>
-#include <linux/slab.h>
-#include <linux/delay.h>
+#include <linux/mod_devicetable.h>
 #include <linux/hid-sensor-hub.h>
 #include <linux/iio/iio.h>
-#include <linux/iio/sysfs.h>
 #include <linux/iio/buffer.h>
 #include "../common/hid-sensors/hid-sensor-trigger.h"
 
drivers/iio/orientation/hid-sensor-incl-3d.c +1 -4
index 7af48d336285..9a7fa7e07522 100644
@@ -7,13 +7,10 @@
 #include <linux/device.h>
 #include <linux/platform_device.h>
 #include <linux/module.h>
-#include <linux/interrupt.h>
-#include <linux/irq.h>
+#include <linux/mod_devicetable.h>
 #include <linux/slab.h>
-#include <linux/delay.h>
 #include <linux/hid-sensor-hub.h>
 #include <linux/iio/iio.h>
-#include <linux/iio/sysfs.h>
 #include <linux/iio/buffer.h>
 #include "../common/hid-sensors/hid-sensor-trigger.h"
 
drivers/iio/orientation/hid-sensor-rotation.c +1 -3
index cf7f57a47681..8c1cb63c754c 100644
@@ -7,9 +7,7 @@
 #include <linux/device.h>
 #include <linux/platform_device.h>
 #include <linux/module.h>
-#include <linux/interrupt.h>
-#include <linux/irq.h>
-#include <linux/slab.h>
+#include <linux/mod_devicetable.h>
 #include <linux/hid-sensor-hub.h>
 #include <linux/iio/iio.h>
 #include <linux/iio/sysfs.h>
drivers/iio/position/hid-sensor-custom-intel-hinge.c +2 -0
index 738b5f4626ce..8d90637ec1b6 100644
@@ -7,6 +7,8 @@
 #include <linux/iio/buffer.h>
 #include <linux/iio/iio.h>
 #include <linux/platform_device.h>
+#include <linux/module.h>
+#include <linux/mod_devicetable.h>
 
 #include "../common/hid-sensors/hid-sensor-trigger.h"
 
drivers/iio/pressure/hid-sensor-press.c +1 -4
index c416d261e3e3..f30a26b8ab38 100644
@@ -6,13 +6,10 @@
 #include <linux/device.h>
 #include <linux/platform_device.h>
 #include <linux/module.h>
-#include <linux/interrupt.h>
-#include <linux/irq.h>
+#include <linux/mod_devicetable.h>
 #include <linux/slab.h>
-#include <linux/delay.h>
 #include <linux/hid-sensor-hub.h>
 #include <linux/iio/iio.h>
-#include <linux/iio/sysfs.h>
 #include <linux/iio/buffer.h>
 #include "../common/hid-sensors/hid-sensor-trigger.h"
 
drivers/iio/temperature/hid-sensor-temperature.c +1 -0
index dc534ed784c3..be102632c4ae 100644
@@ -8,6 +8,7 @@
 #include <linux/iio/buffer.h>
 #include <linux/iio/iio.h>
 #include <linux/module.h>
+#include <linux/mod_devicetable.h>
 #include <linux/platform_device.h>
 
 #include "../common/hid-sensors/hid-sensor-trigger.h"
Signature · 1 line
2.31.1
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 10 lines · Jonathan Cameron

From: Jonathan Cameron <[email protected]>

General driver churn doesn't always include updates of header includes.
Manual review of the output of the include-what-you-use checker lead to the
following cleanup. Hopefuly this brings things back to a good state for the
hid-sensor drivers.

Quoted 3 lines
Cc Jiri Kosina <[email protected]>
Cc Srinivas Pandruvada <[email protected]>
Quoted 276 lines
---
 drivers/iio/accel/hid-sensor-accel-3d.c                | 5 +----
 drivers/iio/common/hid-sensors/hid-sensor-attributes.c | 6 ------
 drivers/iio/common/hid-sensors/hid-sensor-trigger.c    | 5 +----
 drivers/iio/common/hid-sensors/hid-sensor-trigger.h    | 3 +++
 drivers/iio/gyro/hid-sensor-gyro-3d.c                  | 5 +----
 drivers/iio/humidity/hid-sensor-humidity.c             | 1 +
 drivers/iio/light/hid-sensor-als.c                     | 5 +----
 drivers/iio/light/hid-sensor-prox.c                    | 5 +----
 drivers/iio/magnetometer/hid-sensor-magn-3d.c          | 6 +-----
 drivers/iio/orientation/hid-sensor-incl-3d.c           | 5 +----
 drivers/iio/orientation/hid-sensor-rotation.c          | 4 +---
 drivers/iio/position/hid-sensor-custom-intel-hinge.c   | 2 ++
 drivers/iio/pressure/hid-sensor-press.c                | 5 +----
 drivers/iio/temperature/hid-sensor-temperature.c       | 1 +
 14 files changed, 16 insertions(+), 42 deletions(-)
drivers/iio/accel/hid-sensor-accel-3d.c +1 -4
index 27f47e1c251e..b4fa53dc447a 100644
@@ -6,13 +6,10 @@
 #include <linux/device.h>
 #include <linux/platform_device.h>
 #include <linux/module.h>
-#include <linux/interrupt.h>
-#include <linux/irq.h>
+#include <linux/mod_devicetable.h>
 #include <linux/slab.h>
-#include <linux/delay.h>
 #include <linux/hid-sensor-hub.h>
 #include <linux/iio/iio.h>
-#include <linux/iio/sysfs.h>
 #include <linux/iio/buffer.h>
 #include "../common/hid-sensors/hid-sensor-trigger.h"
 
drivers/iio/common/hid-sensors/hid-sensor-attributes.c +0 -6
index cb52b4fd6bf7..eb6a9012c899 100644
@@ -3,18 +3,12 @@
  * HID Sensors Driver
  * Copyright (c) 2012, Intel Corporation.
  */
-#include <linux/device.h>
-#include <linux/platform_device.h>
 #include <linux/module.h>
-#include <linux/interrupt.h>
-#include <linux/irq.h>
 #include <linux/kernel.h>
-#include <linux/slab.h>
 #include <linux/time.h>
 
 #include <linux/hid-sensor-hub.h>
 #include <linux/iio/iio.h>
-#include <linux/iio/sysfs.h>
 
 #define HZ_PER_MHZ	1000000L
 
drivers/iio/common/hid-sensors/hid-sensor-trigger.c +1 -4
index c06537e106e9..4918e2c8f6d5 100644
@@ -6,16 +6,13 @@
 #include <linux/device.h>
 #include <linux/platform_device.h>
 #include <linux/module.h>
-#include <linux/interrupt.h>
-#include <linux/irq.h>
-#include <linux/slab.h>
 #include <linux/delay.h>
 #include <linux/hid-sensor-hub.h>
+#include <linux/workqueue.h>
 #include <linux/iio/iio.h>
 #include <linux/iio/trigger.h>
 #include <linux/iio/triggered_buffer.h>
 #include <linux/iio/trigger_consumer.h>
-#include <linux/iio/buffer.h>
 #include <linux/iio/sysfs.h>
 #include "hid-sensor-trigger.h"
 
drivers/iio/common/hid-sensors/hid-sensor-trigger.h +3 -0
index bb45cc89e551..f94fca4f1edf 100644
@@ -9,6 +9,9 @@
 #include <linux/pm.h>
 #include <linux/pm_runtime.h>
 
+struct hid_sensor_common;
+struct iio_dev;
+
 extern const struct dev_pm_ops hid_sensor_pm_ops;
 
 int hid_sensor_setup_trigger(struct iio_dev *indio_dev, const char

*name,

drivers/iio/gyro/hid-sensor-gyro-3d.c +1 -4
index dad26ee4fd1f..a8f59ed802f4 100644
@@ -6,13 +6,10 @@
 #include <linux/device.h>
 #include <linux/platform_device.h>
 #include <linux/module.h>
-#include <linux/interrupt.h>
-#include <linux/irq.h>
+#include <linux/mod_devicetable.h>
 #include <linux/slab.h>
-#include <linux/delay.h>
 #include <linux/hid-sensor-hub.h>
 #include <linux/iio/iio.h>
-#include <linux/iio/sysfs.h>
 #include <linux/iio/buffer.h>
 #include "../common/hid-sensors/hid-sensor-trigger.h"
 
drivers/iio/humidity/hid-sensor-humidity.c +1 -0
index 74383abc0d44..64fe6752ec16 100644
@@ -8,6 +8,7 @@
 #include <linux/iio/buffer.h>
 #include <linux/iio/iio.h>
 #include <linux/module.h>
+#include <linux/mod_devicetable.h>
 #include <linux/platform_device.h>
 
 #include "hid-sensor-trigger.h"
drivers/iio/light/hid-sensor-als.c +1 -4
index 85c8a05b73cb..cddd8d448372 100644
@@ -6,13 +6,10 @@
 #include <linux/device.h>
 #include <linux/platform_device.h>
 #include <linux/module.h>
-#include <linux/interrupt.h>
-#include <linux/irq.h>
+#include <linux/mod_devicetable.h>
 #include <linux/slab.h>
-#include <linux/delay.h>
 #include <linux/hid-sensor-hub.h>
 #include <linux/iio/iio.h>
-#include <linux/iio/sysfs.h>
 #include <linux/iio/buffer.h>
 #include "../common/hid-sensors/hid-sensor-trigger.h"
 
drivers/iio/light/hid-sensor-prox.c +1 -4
index 17d167c3d595..e02cc6cdf44a 100644
@@ -6,13 +6,10 @@
 #include <linux/device.h>
 #include <linux/platform_device.h>
 #include <linux/module.h>
-#include <linux/interrupt.h>
-#include <linux/irq.h>
+#include <linux/mod_devicetable.h>
 #include <linux/slab.h>
-#include <linux/delay.h>
 #include <linux/hid-sensor-hub.h>
 #include <linux/iio/iio.h>
-#include <linux/iio/sysfs.h>
 #include <linux/iio/buffer.h>
 #include "../common/hid-sensors/hid-sensor-trigger.h"
 
drivers/iio/magnetometer/hid-sensor-magn-3d.c +1 -5
index b78691523dd4..e42352c3221d 100644
@@ -6,13 +6,9 @@
 #include <linux/device.h>
 #include <linux/platform_device.h>
 #include <linux/module.h>
-#include <linux/interrupt.h>
-#include <linux/irq.h>
-#include <linux/slab.h>
-#include <linux/delay.h>
+#include <linux/mod_devicetable.h>
 #include <linux/hid-sensor-hub.h>
 #include <linux/iio/iio.h>
-#include <linux/iio/sysfs.h>
 #include <linux/iio/buffer.h>
 #include "../common/hid-sensors/hid-sensor-trigger.h"
 
drivers/iio/orientation/hid-sensor-incl-3d.c +1 -4
index 7af48d336285..9a7fa7e07522 100644
@@ -7,13 +7,10 @@
 #include <linux/device.h>
 #include <linux/platform_device.h>
 #include <linux/module.h>
-#include <linux/interrupt.h>
-#include <linux/irq.h>
+#include <linux/mod_devicetable.h>
 #include <linux/slab.h>
-#include <linux/delay.h>
 #include <linux/hid-sensor-hub.h>
 #include <linux/iio/iio.h>
-#include <linux/iio/sysfs.h>
 #include <linux/iio/buffer.h>
 #include "../common/hid-sensors/hid-sensor-trigger.h"
 
drivers/iio/orientation/hid-sensor-rotation.c +1 -3
index cf7f57a47681..8c1cb63c754c 100644
@@ -7,9 +7,7 @@
 #include <linux/device.h>
 #include <linux/platform_device.h>
 #include <linux/module.h>
-#include <linux/interrupt.h>
-#include <linux/irq.h>
-#include <linux/slab.h>
+#include <linux/mod_devicetable.h>
 #include <linux/hid-sensor-hub.h>
 #include <linux/iio/iio.h>
 #include <linux/iio/sysfs.h>
drivers/iio/position/hid-sensor-custom-intel-hinge.c +2 -0
index 738b5f4626ce..8d90637ec1b6 100644
@@ -7,6 +7,8 @@
 #include <linux/iio/buffer.h>
 #include <linux/iio/iio.h>
 #include <linux/platform_device.h>
+#include <linux/module.h>
+#include <linux/mod_devicetable.h>
 
 #include "../common/hid-sensors/hid-sensor-trigger.h"
 
drivers/iio/pressure/hid-sensor-press.c +1 -4
index c416d261e3e3..f30a26b8ab38 100644
@@ -6,13 +6,10 @@
 #include <linux/device.h>
 #include <linux/platform_device.h>
 #include <linux/module.h>
-#include <linux/interrupt.h>
-#include <linux/irq.h>
+#include <linux/mod_devicetable.h>
 #include <linux/slab.h>
-#include <linux/delay.h>
 #include <linux/hid-sensor-hub.h>
 #include <linux/iio/iio.h>
-#include <linux/iio/sysfs.h>
 #include <linux/iio/buffer.h>
 #include "../common/hid-sensors/hid-sensor-trigger.h"
 
drivers/iio/temperature/hid-sensor-temperature.c +1 -0
index dc534ed784c3..be102632c4ae 100644
@@ -8,6 +8,7 @@
 #include <linux/iio/buffer.h>
 #include <linux/iio/iio.h>
 #include <linux/module.h>
+#include <linux/mod_devicetable.h>
 #include <linux/platform_device.h>
 
 #include "../common/hid-sensors/hid-sensor-trigger.h"
author maintainer Applied
#2 lore raw
Quoted 11 lines · On Tue, 15 Jun 2021 12:01:10 -0700 Srinivas Pandruvada…
Quoted 10 lines · Jonathan Cameron

From: Jonathan Cameron <[email protected]>

General driver churn doesn't always include updates of header includes.
Manual review of the output of the include-what-you-use checker lead to the
following cleanup. Hopefuly this brings things back to a good state for the
hid-sensor drivers.

Quoted 4 lines
Quoted 3 lines
Cc Jiri Kosina <[email protected]>
Cc Srinivas Pandruvada <[email protected]>

Applied,

As this one doesn't have the kernel.h include that Andy picked up on in the larger sets, the discussion about that doesn't apply and I can take this one now.

Thanks,

Jonathan

Quoted 278 lines
Quoted 277 lines
---
 drivers/iio/accel/hid-sensor-accel-3d.c                | 5 +----
 drivers/iio/common/hid-sensors/hid-sensor-attributes.c | 6 ------
 drivers/iio/common/hid-sensors/hid-sensor-trigger.c    | 5 +----
 drivers/iio/common/hid-sensors/hid-sensor-trigger.h    | 3 +++
 drivers/iio/gyro/hid-sensor-gyro-3d.c                  | 5 +----
 drivers/iio/humidity/hid-sensor-humidity.c             | 1 +
 drivers/iio/light/hid-sensor-als.c                     | 5 +----
 drivers/iio/light/hid-sensor-prox.c                    | 5 +----
 drivers/iio/magnetometer/hid-sensor-magn-3d.c          | 6 +-----
 drivers/iio/orientation/hid-sensor-incl-3d.c           | 5 +----
 drivers/iio/orientation/hid-sensor-rotation.c          | 4 +---
 drivers/iio/position/hid-sensor-custom-intel-hinge.c   | 2 ++
 drivers/iio/pressure/hid-sensor-press.c                | 5 +----
 drivers/iio/temperature/hid-sensor-temperature.c       | 1 +
 14 files changed, 16 insertions(+), 42 deletions(-)
drivers/iio/accel/hid-sensor-accel-3d.c +1 -4
index 27f47e1c251e..b4fa53dc447a 100644
@@ -6,13 +6,10 @@
 #include <linux/device.h>
 #include <linux/platform_device.h>
 #include <linux/module.h>
-#include <linux/interrupt.h>
-#include <linux/irq.h>
+#include <linux/mod_devicetable.h>
 #include <linux/slab.h>
-#include <linux/delay.h>
 #include <linux/hid-sensor-hub.h>
 #include <linux/iio/iio.h>
-#include <linux/iio/sysfs.h>
 #include <linux/iio/buffer.h>
 #include "../common/hid-sensors/hid-sensor-trigger.h"
 
drivers/iio/common/hid-sensors/hid-sensor-attributes.c +0 -6
index cb52b4fd6bf7..eb6a9012c899 100644
@@ -3,18 +3,12 @@
  * HID Sensors Driver
  * Copyright (c) 2012, Intel Corporation.
  */
-#include <linux/device.h>
-#include <linux/platform_device.h>
 #include <linux/module.h>
-#include <linux/interrupt.h>
-#include <linux/irq.h>
 #include <linux/kernel.h>
-#include <linux/slab.h>
 #include <linux/time.h>
 
 #include <linux/hid-sensor-hub.h>
 #include <linux/iio/iio.h>
-#include <linux/iio/sysfs.h>
 
 #define HZ_PER_MHZ	1000000L
 
drivers/iio/common/hid-sensors/hid-sensor-trigger.c +1 -4
index c06537e106e9..4918e2c8f6d5 100644
@@ -6,16 +6,13 @@
 #include <linux/device.h>
 #include <linux/platform_device.h>
 #include <linux/module.h>
-#include <linux/interrupt.h>
-#include <linux/irq.h>
-#include <linux/slab.h>
 #include <linux/delay.h>
 #include <linux/hid-sensor-hub.h>
+#include <linux/workqueue.h>
 #include <linux/iio/iio.h>
 #include <linux/iio/trigger.h>
 #include <linux/iio/triggered_buffer.h>
 #include <linux/iio/trigger_consumer.h>
-#include <linux/iio/buffer.h>
 #include <linux/iio/sysfs.h>
 #include "hid-sensor-trigger.h"
 
drivers/iio/common/hid-sensors/hid-sensor-trigger.h +3 -0
index bb45cc89e551..f94fca4f1edf 100644
@@ -9,6 +9,9 @@
 #include <linux/pm.h>
 #include <linux/pm_runtime.h>
 
+struct hid_sensor_common;
+struct iio_dev;
+
 extern const struct dev_pm_ops hid_sensor_pm_ops;
 
 int hid_sensor_setup_trigger(struct iio_dev *indio_dev, const char

*name,

drivers/iio/gyro/hid-sensor-gyro-3d.c +1 -4
index dad26ee4fd1f..a8f59ed802f4 100644
@@ -6,13 +6,10 @@
 #include <linux/device.h>
 #include <linux/platform_device.h>
 #include <linux/module.h>
-#include <linux/interrupt.h>
-#include <linux/irq.h>
+#include <linux/mod_devicetable.h>
 #include <linux/slab.h>
-#include <linux/delay.h>
 #include <linux/hid-sensor-hub.h>
 #include <linux/iio/iio.h>
-#include <linux/iio/sysfs.h>
 #include <linux/iio/buffer.h>
 #include "../common/hid-sensors/hid-sensor-trigger.h"
 
drivers/iio/humidity/hid-sensor-humidity.c +1 -0
index 74383abc0d44..64fe6752ec16 100644
@@ -8,6 +8,7 @@
 #include <linux/iio/buffer.h>
 #include <linux/iio/iio.h>
 #include <linux/module.h>
+#include <linux/mod_devicetable.h>
 #include <linux/platform_device.h>
 
 #include "hid-sensor-trigger.h"
drivers/iio/light/hid-sensor-als.c +1 -4
index 85c8a05b73cb..cddd8d448372 100644
@@ -6,13 +6,10 @@
 #include <linux/device.h>
 #include <linux/platform_device.h>
 #include <linux/module.h>
-#include <linux/interrupt.h>
-#include <linux/irq.h>
+#include <linux/mod_devicetable.h>
 #include <linux/slab.h>
-#include <linux/delay.h>
 #include <linux/hid-sensor-hub.h>
 #include <linux/iio/iio.h>
-#include <linux/iio/sysfs.h>
 #include <linux/iio/buffer.h>
 #include "../common/hid-sensors/hid-sensor-trigger.h"
 
drivers/iio/light/hid-sensor-prox.c +1 -4
index 17d167c3d595..e02cc6cdf44a 100644
@@ -6,13 +6,10 @@
 #include <linux/device.h>
 #include <linux/platform_device.h>
 #include <linux/module.h>
-#include <linux/interrupt.h>
-#include <linux/irq.h>
+#include <linux/mod_devicetable.h>
 #include <linux/slab.h>
-#include <linux/delay.h>
 #include <linux/hid-sensor-hub.h>
 #include <linux/iio/iio.h>
-#include <linux/iio/sysfs.h>
 #include <linux/iio/buffer.h>
 #include "../common/hid-sensors/hid-sensor-trigger.h"
 
drivers/iio/magnetometer/hid-sensor-magn-3d.c +1 -5
index b78691523dd4..e42352c3221d 100644
@@ -6,13 +6,9 @@
 #include <linux/device.h>
 #include <linux/platform_device.h>
 #include <linux/module.h>
-#include <linux/interrupt.h>
-#include <linux/irq.h>
-#include <linux/slab.h>
-#include <linux/delay.h>
+#include <linux/mod_devicetable.h>
 #include <linux/hid-sensor-hub.h>
 #include <linux/iio/iio.h>
-#include <linux/iio/sysfs.h>
 #include <linux/iio/buffer.h>
 #include "../common/hid-sensors/hid-sensor-trigger.h"
 
drivers/iio/orientation/hid-sensor-incl-3d.c +1 -4
index 7af48d336285..9a7fa7e07522 100644
@@ -7,13 +7,10 @@
 #include <linux/device.h>
 #include <linux/platform_device.h>
 #include <linux/module.h>
-#include <linux/interrupt.h>
-#include <linux/irq.h>
+#include <linux/mod_devicetable.h>
 #include <linux/slab.h>
-#include <linux/delay.h>
 #include <linux/hid-sensor-hub.h>
 #include <linux/iio/iio.h>
-#include <linux/iio/sysfs.h>
 #include <linux/iio/buffer.h>
 #include "../common/hid-sensors/hid-sensor-trigger.h"
 
drivers/iio/orientation/hid-sensor-rotation.c +1 -3
index cf7f57a47681..8c1cb63c754c 100644
@@ -7,9 +7,7 @@
 #include <linux/device.h>
 #include <linux/platform_device.h>
 #include <linux/module.h>
-#include <linux/interrupt.h>
-#include <linux/irq.h>
-#include <linux/slab.h>
+#include <linux/mod_devicetable.h>
 #include <linux/hid-sensor-hub.h>
 #include <linux/iio/iio.h>
 #include <linux/iio/sysfs.h>
drivers/iio/position/hid-sensor-custom-intel-hinge.c +2 -0
index 738b5f4626ce..8d90637ec1b6 100644
@@ -7,6 +7,8 @@
 #include <linux/iio/buffer.h>
 #include <linux/iio/iio.h>
 #include <linux/platform_device.h>
+#include <linux/module.h>
+#include <linux/mod_devicetable.h>
 
 #include "../common/hid-sensors/hid-sensor-trigger.h"
 
drivers/iio/pressure/hid-sensor-press.c +1 -4
index c416d261e3e3..f30a26b8ab38 100644
@@ -6,13 +6,10 @@
 #include <linux/device.h>
 #include <linux/platform_device.h>
 #include <linux/module.h>
-#include <linux/interrupt.h>
-#include <linux/irq.h>
+#include <linux/mod_devicetable.h>
 #include <linux/slab.h>
-#include <linux/delay.h>
 #include <linux/hid-sensor-hub.h>
 #include <linux/iio/iio.h>
-#include <linux/iio/sysfs.h>
 #include <linux/iio/buffer.h>
 #include "../common/hid-sensors/hid-sensor-trigger.h"
 
drivers/iio/temperature/hid-sensor-temperature.c +1 -0
index dc534ed784c3..be102632c4ae 100644
@@ -8,6 +8,7 @@
 #include <linux/iio/buffer.h>
 #include <linux/iio/iio.h>
 #include <linux/module.h>
+#include <linux/mod_devicetable.h>
 #include <linux/platform_device.h>
 
 #include "../common/hid-sensors/hid-sensor-trigger.h"