Skip to contentSkip to conversation

package/lvm2: default standard install to y

PATCH New Arnout Vandecappelle (Essensium/Mind) 3 participants 5 messages Jun 16, 2021 – Jun 21, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/lvm2: default standard install to y

Until commit 5c07dfcc1a52e2804011574a3e022523a20546c8 BR2_PACKAGE_LVM2_STANDARD_INSTALL would default to y. Indeed, the default read:

default y if !BR2_PACKAGE_LVM2_DMSETUP_ONLY # legacy 2013.11

Since the legacy symbol is normally not selected, this defaults to y.

Commit 5c07dfcc1a52e2804011574a3e022523a20546c8 inadvertedly removed the entire line instead of just the condition.

Fixes: https://bugs.busybox.net/show_bug.cgi?id=13846
For-stable: 2021.02, 2021.05

Cc dominique.tronche at atos.net
Cc Yann E. MORIN <[email protected]>
Cc Peter Korsgaard <[email protected]>

--
As an experiment, I added the For-stable tag (which I invented myself). Peter, is this useful? Should we propose this in the documentation?

---
 package/lvm2/Config.in | 1 +
 1 file changed, 1 insertion(+)
package/lvm2/Config.in +1 -0
index 317027929e..cc740dd40c 100644
@@ -26,6 +26,7 @@ if BR2_PACKAGE_LVM2
 
 config BR2_PACKAGE_LVM2_STANDARD_INSTALL
 	bool "standard install instead of only dmsetup"
+	default y
 	# http://lists.busybox.net/pipermail/buildroot/2016-August/170592.html
 	depends on !BR2_TOOLCHAIN_USES_MUSL
 	help
Signature · 1 line
2.31.1
#1 lore raw

PATCH 1/1 package/lvm2: default standard install to y

Arnout, All,

On 2021-06-16 19:33 +0200, Arnout Vandecappelle (Essensium/Mind) spake thusly:

Quoted 11 lines

Until commit 5c07dfcc1a52e2804011574a3e022523a20546c8 BR2_PACKAGE_LVM2_STANDARD_INSTALL would default to y. Indeed, the default read:

default y if !BR2_PACKAGE_LVM2_DMSETUP_ONLY # legacy 2013.11

Since the legacy symbol is normally not selected, this defaults to y.

Commit 5c07dfcc1a52e2804011574a3e022523a20546c8 inadvertedly removed the entire line instead of just the condition.

Quoted 6 lines

Fixes: https://bugs.busybox.net/show_bug.cgi?id=13846
For-stable: 2021.02, 2021.05

Cc dominique.tronche at atos.net
Cc Yann E. MORIN <[email protected]>
Cc Peter Korsgaard <[email protected]>

Applied to master, thanks.

Regards,
Yann E. MORIN.

Quoted 22 lines

--
As an experiment, I added the For-stable tag (which I invented myself). Peter, is this useful? Should we propose this in the documentation?

---
 package/lvm2/Config.in | 1 +
 1 file changed, 1 insertion(+)
package/lvm2/Config.in +1 -0
index 317027929e..cc740dd40c 100644
@@ -26,6 +26,7 @@ if BR2_PACKAGE_LVM2
 
 config BR2_PACKAGE_LVM2_STANDARD_INSTALL
 	bool "standard install instead of only dmsetup"
+	default y
 	# http://lists.busybox.net/pipermail/buildroot/2016-August/170592.html
 	depends on !BR2_TOOLCHAIN_USES_MUSL
 	help
Signature · 1 line
2.31.1
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#2 lore raw

PATCH 1/1 package/lvm2: default standard install to y

In reply to Arnout Vandecappelle (Essensium/Mind)
Quoted 15 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Arnout" == Arnout Vandecappelle (Essensium/Mind) <[email protected]> writes:

Until commit 5c07dfcc1a52e2804011574a3e022523a20546c8 BR2_PACKAGE_LVM2_STANDARD_INSTALL would default to y. Indeed, the default read:

default y if !BR2_PACKAGE_LVM2_DMSETUP_ONLY # legacy 2013.11

Since the legacy symbol is normally not selected, this defaults to y.

Commit 5c07dfcc1a52e2804011574a3e022523a20546c8 inadvertedly removed the entire line instead of just the condition.

Fixes: https://bugs.busybox.net/show_bug.cgi?id=13846
For-stable: 2021.02, 2021.05

Quoted 7 lines
Cc dominique.tronche at atos.net
Cc Yann E. MORIN <[email protected]>
Cc Peter Korsgaard <[email protected]>

--
As an experiment, I added the For-stable tag (which I invented myself). Peter, is this useful? Should we propose this in the documentation?

It could be. Typically just mentioning that this is a fix and/or CC me is enough, but it cannot hurt certainly.

Signature · 1 line
Bye, Peter Korsgaard
#3 lore raw

PATCH 1/1 package/lvm2: default standard install to y

Quoted 23 lines · Peter Korsgaard
Quoted 15 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Arnout" == Arnout Vandecappelle (Essensium/Mind) <[email protected]> writes:

Until commit 5c07dfcc1a52e2804011574a3e022523a20546c8 BR2_PACKAGE_LVM2_STANDARD_INSTALL would default to y. Indeed, the default read:

default y if !BR2_PACKAGE_LVM2_DMSETUP_ONLY # legacy 2013.11

Since the legacy symbol is normally not selected, this defaults to y.

Commit 5c07dfcc1a52e2804011574a3e022523a20546c8 inadvertedly removed the entire line instead of just the condition.

Fixes: https://bugs.busybox.net/show_bug.cgi?id=13846
For-stable: 2021.02, 2021.05

Quoted 7 lines
Cc dominique.tronche at atos.net
Cc Yann E. MORIN <[email protected]>
Cc Peter Korsgaard <[email protected]>

--
As an experiment, I added the For-stable tag (which I invented myself). Peter, is this useful? Should we propose this in the documentation?

Quoted 2 lines

It could be. Typically just mentioning that this is a fix and/or CC me is enough, but it cannot hurt certainly.

I'm mostly thinking about finding out to which stable branches it applies.
Currently, contributors rarely go through the effort of checking that. So the question is: is it worth your while to ask contributors to check to which stable branches a fix is applicable?

I've added "Fixes: <sha1>" tags a few times, but then I realized it doesn't
actually help a lot.

Regards,
Arnout

#4 lore raw

PATCH 1/1 package/lvm2: default standard install to y

In reply to Peter Korsgaard
Quoted 24 lines
Quoted 16 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

"Peter" == Peter Korsgaard <[email protected]> writes:

"Arnout" == Arnout Vandecappelle (Essensium/Mind) <[email protected]> writes:

Until commit 5c07dfcc1a52e2804011574a3e022523a20546c8 BR2_PACKAGE_LVM2_STANDARD_INSTALL would default to y. Indeed, the default read:

default y if !BR2_PACKAGE_LVM2_DMSETUP_ONLY # legacy 2013.11

Since the legacy symbol is normally not selected, this defaults to y.

Commit 5c07dfcc1a52e2804011574a3e022523a20546c8 inadvertedly removed the entire line instead of just the condition.

Fixes: https://bugs.busybox.net/show_bug.cgi?id=13846
For-stable: 2021.02, 2021.05

Quoted 7 lines
Cc dominique.tronche at atos.net
Cc Yann E. MORIN <[email protected]>
Cc Peter Korsgaard <[email protected]>

--
As an experiment, I added the For-stable tag (which I invented myself). Peter, is this useful? Should we propose this in the documentation?

Quoted 2 lines

It could be. Typically just mentioning that this is a fix and/or CC me is enough, but it cannot hurt certainly.

Committed to 2021.02.x and 2021.05.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard