drm/amd/display: Fix gcc unused variable warning
Subsystems (3)
PATCH 1/1 drm/amd/display: Fix gcc unused variable warning
GCC reports the following warning with W=1:
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c:3635:17:
warning:
variable ‘status’ set but not used [-Wunused-but-set-variable]
3635 | enum dc_status status = DC_ERROR_UNEXPECTED;
| ^~~~~~The variable should be used for error check, let's fix it.
--- drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 4 ++++ 1 file changed, 4 insertions(+)
drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c +4 -0
@@ -3681,6 +3681,10 @@ bool dp_retrieve_lttpr_cap(struct dc_link *link)DP_LT_TUNABLE_PHY_REPEATER_FIELD_DATA_STRUCTURE_REV , lttpr_dpcd_data, sizeof(lttpr_dpcd_data)); +if (status !=DC_OK ) { +dm_error ("%s: Read LTTPR caps data failed.\n" , __func__); +return false; + } link->dpcd_caps.lttpr_caps.revision.raw = lttpr_dpcd_data[DP_LT_TUNABLE_PHY_REPEATER_FIELD_DATA_STRUCTURE_REV -
Signature · 1 line
2.17.1
Quoted 11 lines · Pu Lehui
GCC reports the following warning with W=1:
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c:3635:17:
warning:
variable ‘status’ set but not used [-Wunused-but-set-variable]3635 | enum dc_status status = DC_ERROR_UNEXPECTED; | ^~~~~~The variable should be used for error check, let's fix it.
Signed-off-by Pu Lehui <[email protected]>
Harry
Quoted 10 lines
--- drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 4 ++++ 1 file changed, 4 insertions(+)drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c +0
-0
drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c bool dp_retrieve_lttpr_cap(struct dc_link *link) · line 3690
Quoted 10 lines
drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c +4
-0@@ -3681,6 +3681,10 @@ bool dp_retrieve_lttpr_cap(struct dc_link *link)DP_LT_TUNABLE_PHY_REPEATER_FIELD_DATA_STRUCTURE_REV , lttpr_dpcd_data, sizeof(lttpr_dpcd_data)); +if (status !=DC_OK ) { +dm_error ("%s: Read LTTPR caps data failed.\n" , __func__); +return false; + } link->dpcd_caps.lttpr_caps.revision.raw = lttpr_dpcd_data[DP_LT_TUNABLE_PHY_REPEATER_FIELD_DATA_STRUCTURE_REV -
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Alex Deucher
AppliedApplied. Thanks!
Alex
Quoted 43 lines · Harry Wentland
Quoted 11 lines · Pu Lehui
GCC reports the following warning with W=1:
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c:3635:17:
warning:
variable ‘status’ set but not used [-Wunused-but-set-variable]3635 | enum dc_status status = DC_ERROR_UNEXPECTED; | ^~~~~~The variable should be used for error check, let's fix it.
Signed-off-by Pu Lehui <[email protected]>Reviewed-by Harry Wentland <[email protected]>Harry
Quoted 10 lines
--- drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 4 ++++ 1 file changed, 4 insertions(+)drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c +0
-0drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c bool dp_retrieve_lttpr_cap(struct dc_link *link) · line 3690
Quoted 10 lines
drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c +4
-0@@ -3681,6 +3681,10 @@ bool dp_retrieve_lttpr_cap(struct dc_link *link)DP_LT_TUNABLE_PHY_REPEATER_FIELD_DATA_STRUCTURE_REV , lttpr_dpcd_data, sizeof(lttpr_dpcd_data)); +if (status !=DC_OK ) { +dm_error ("%s: Read LTTPR caps data failed.\n" , __func__); +return false; + } link->dpcd_caps.lttpr_caps.revision.raw = lttpr_dpcd_data[DP_LT_TUNABLE_PHY_REPEATER_FIELD_DATA_STRUCTURE_REV -_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx