generic/103: special left calculation for f2fs
PATCH v2 1/1 generic/103: special left calculation for f2fs
It failed on f2fs:
QA output created by 103
+fallocate: No space left on device
Silence is golden.
...
f2fs uses index(radix) tree as mapping metadata, its space overhead is about one thousandth of the data.
--- tests/generic/103 | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-)
tests/generic/103 +9 -1
@@ -40,10 +40,18 @@ rm -f $seqres.full _consume_freesp() { file=$1 + left=512 # consume nearly all available space (leave ~512kB) avail=`_get_available_space $SCRATCH_MNT` - filesizekb=$((avail / 1024 - 512)) + + # f2fs uses index(radix) tree as mapping metadata, its space overhead + # is about one thousandth of the data + if [ $FSTYP == "f2fs" ]; then + left=$((left + avail / 1024000)) + fi + + filesizekb=$((avail / 1024 - $left)) $XFS_IO_PROG -fc "falloc 0 ${filesizekb}k" $file }
Signature · 1 line
2.13.6
PATCH v2 1/1 generic/260: f2fs is also special
It fail on f2fs:
[+] Default length with start set (should succeed)
[+] Length beyond the end of fs (should succeed)
[+] Length beyond the end of fs with start set (should succeed)
+After the full fs discard 0 bytes were discarded however the file system is 12882804736 bytes long. +It seems that fs logic handling len argument overflows
The root cause is f2fs can tag a special flag TRIMMED_FLAG to indicate the whole filesystem is trimmed, so after mkfs/fstrim(), following fstrim() won't trim any block.
--- tests/generic/260 | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)
tests/generic/260 +8 -2
@@ -100,7 +100,10 @@ fi # It is because btrfs does not have not-yet-used parts of the device # mapped and since we got here right after the mkfs, there is not # enough free extents in the root tree. -if [ $bytes -le $(_math "$fssize*512") ] && [ $FSTYP != "btrfs" ]; then +# F2fs is also special. F2fs can tag a special flag TRIMMED_FLAG to +# indicate the whole filesystem is trimmed, so after mkfs/fstrim(), +# following fstrim() won't trim any block. +if [ $bytes -le $(_math "$fssize*512") ] && [ $FSTYP != "btrfs" ] && [ $FSTYP != "f2fs" ]; then status=1 echo "After the full fs discard $bytes bytes were discarded"\ "however the file system is $(_math "$fssize*1024") bytes long."
@@ -159,8 +162,11 @@ _scratch_mount # It is because btrfs does not have not-yet-used parts of the device # mapped and since we got here right after the mkfs, there is not # enough free extents in the root tree. +# F2fs is also special. F2fs can tag a special flag TRIMMED_FLAG to +# indicate the whole filesystem is trimmed, so after mkfs/fstrim(), +# following fstrim() won't trim any block. bytes=$($FSTRIM_PROG -v -l$len $SCRATCH_MNT | _filter_fstrim) -if [ $bytes -le $(_math "$fssize*512") ] && [ $FSTYP != "btrfs" ]; then +if [ $bytes -le $(_math "$fssize*512") ] && [ $FSTYP != "btrfs" ] && [ $FSTYP != "f2fs" ]; then status=1 echo "It seems that fs logic handling len argument overflows" fi
Signature · 1 line
2.13.6