Skip to contentSkip to conversation

raw/ioat: fix missing ring pointer reset

PATCH Applied Kevin Laatz 3 participants 3 messages Jun 17, 2021 – Jun 22, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 raw/ioat: fix missing ring pointer reset

In the event of a device reconfigure, "hdls_avail" is not being reset. This can lead to miscalculations in rte_ioat_completed_ops(), causing the function to report an incorrect amount of completed operations. This patch fixes the issue by resetting "hdls_avail" during the device configure.

Fixes 74464005a2af ("raw/ioat: rework SW ring layout")
---
 drivers/raw/ioat/ioat_common.c | 1 +
 1 file changed, 1 insertion(+)
drivers/raw/ioat/ioat_common.c +1 -0
index f4771745cc..60de41152a 100644
@@ -174,6 +174,7 @@ idxd_dev_configure(const struct rte_rawdev *dev,
 	}
 	rte_idxd->hdls_read = rte_idxd->batch_start = 0;
 	rte_idxd->batch_size = 0;
+	rte_idxd->hdls_avail = 0;
 
 	return 0;
 }
Signature · 1 line
2.25.1
Acked-by on v1 1/1
#1 lore raw
Quoted 9 lines · Kevin Laatz

In the event of a device reconfigure, "hdls_avail" is not being reset. This can lead to miscalculations in rte_ioat_completed_ops(), causing the function to report an incorrect amount of completed operations. This patch fixes the issue by resetting "hdls_avail" during the device configure.

Fixes 74464005a2af ("raw/ioat: rework SW ring layout")

---

To catch more of these reconfigure issues, we should look to add an appropriate unit test.

#2 lore raw

17/06/2021 16:21, Bruce Richardson:

Quoted 6 lines · Kevin Laatz
Quoted 5 lines

In the event of a device reconfigure, "hdls_avail" is not being reset. This can lead to miscalculations in rte_ioat_completed_ops(), causing the function to report an incorrect amount of completed operations. This patch fixes the issue by resetting "hdls_avail" during the device configure.

Quoted 8 lines
Quoted 4 lines
Fixes 74464005a2af ("raw/ioat: rework SW ring layout")

---

To catch more of these reconfigure issues, we should look to add an appropriate unit test.

Applied, thanks