Skip to contentSkip to conversation

o4-imx-nano: Fix dtc warnings

PATCH Applied Fabio Estevam 3 participants 3 messages Jun 17, 2021 – Jun 21, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 o4-imx-nano: Fix dtc warnings

Remove the LED unit addresses and reg properties to fix the following dtc build warnings:

arch/arm/dts/o4-imx-nano.dtb: Warning (reg_format): /leds/led@0:reg: property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1)
...
arch/arm/dts/o4-imx-nano.dtb: Warning (avoid_default_addr_size): /leds/led@0: Relying on default #address-cells value

---
 arch/arm/dts/o4-imx-nano.dts | 18 ++++++------------
 1 file changed, 6 insertions(+), 12 deletions(-)
arch/arm/dts/o4-imx-nano.dts +6 -12
index d1785b7dc702..54d32f9dd47b 100644
@@ -24,40 +24,34 @@
 	leds {
 		compatible = "gpio-leds";
 
-		led@0 {
+		led0 {
 			color = <LED_COLOR_ID_RED>;
 			gpios = <&pcf8574a 0 GPIO_ACTIVE_LOW>;
-			reg = <0>;
 		};
 
-		led@1 {
+		led1{
 			color = <LED_COLOR_ID_GREEN>;
 			gpios = <&pcf8574a 1 GPIO_ACTIVE_LOW>;
-			reg = <1>;
 		};
 
-		led@2 {
+		led2 {
 			gpios = <&pcf8574a 2 GPIO_ACTIVE_LOW>;
 			color = <LED_COLOR_ID_BLUE>;
-			reg = <2>;
 		};
 
-		led@3 {
+		led3 {
 			color = <LED_COLOR_ID_RED>;
 			gpios = <&pcf8574a 3 GPIO_ACTIVE_LOW>;
-			reg = <3>;
 		};
 
-		led@4 {
+		led4{
 			color = <LED_COLOR_ID_GREEN>;
 			gpios = <&pcf8574a 4 GPIO_ACTIVE_LOW>;
-			reg = <4>;
 		};
 
-		led@5 {
+		led5 {
 			color = <LED_COLOR_ID_BLUE>;
 			gpios = <&pcf8574a 5 GPIO_ACTIVE_LOW>;
-			reg = <5>;
 		};
 	};
 
Signature · 1 line
2.25.1
Reviewed-by on v1 1/1
#1 lore raw

17.06.21 18:57, Fabio Estevam пише:

Quoted 55 lines

Remove the LED unit addresses and reg properties to fix the following dtc build warnings:

arch/arm/dts/o4-imx-nano.dtb: Warning (reg_format): /leds/led@0:reg: property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1)
...
arch/arm/dts/o4-imx-nano.dtb: Warning (avoid_default_addr_size): /leds/led@0: Relying on default #address-cells value

---
 arch/arm/dts/o4-imx-nano.dts | 18 ++++++------------
 1 file changed, 6 insertions(+), 12 deletions(-)
arch/arm/dts/o4-imx-nano.dts +5 -10
index d1785b7dc702..54d32f9dd47b 100644
@@ -24,40 +24,34 @@
 	leds {
 		compatible = "gpio-leds";
 
-		led@0 {
+		led0 {
 			color = <LED_COLOR_ID_RED>;
 			gpios = <&pcf8574a 0 GPIO_ACTIVE_LOW>;
-			reg = <0>;
 		};
 
-		led@1 {
+		led1{
 			color = <LED_COLOR_ID_GREEN>;
 			gpios = <&pcf8574a 1 GPIO_ACTIVE_LOW>;
-			reg = <1>;
 		};
 
-		led@2 {
+		led2 {
 			gpios = <&pcf8574a 2 GPIO_ACTIVE_LOW>;
 			color = <LED_COLOR_ID_BLUE>;
-			reg = <2>;
 		};
 
-		led@3 {
+		led3 {
 			color = <LED_COLOR_ID_RED>;
 			gpios = <&pcf8574a 3 GPIO_ACTIVE_LOW>;
-			reg = <3>;
 		};
 
-		led@4 {
+		led4{
 			color = <LED_COLOR_ID_GREEN>;
 			gpios = <&pcf8574a 4 GPIO_ACTIVE_LOW>;
-			reg = <4>;

arch/arm/dts/o4-imx-nano.dts line 57

Quoted 10 lines
arch/arm/dts/o4-imx-nano.dts +1 -2
 		};
 
-		led@5 {
+		led5 {
 			color = <LED_COLOR_ID_BLUE>;
 			gpios = <&pcf8574a 5 GPIO_ACTIVE_LOW>;
-			reg = <5>;
 		};
 	};
 
#2 lore raw
In reply to Fabio Estevam
Quoted 10 lines · Fabio Estevam

Remove the LED unit addresses and reg properties to fix the following dtc build warnings:

arch/arm/dts/o4-imx-nano.dtb: Warning (reg_format): /leds/led@0:reg: property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1)
...
arch/arm/dts/o4-imx-nano.dtb: Warning (avoid_default_addr_size): /leds/led@0: Relying on default #address-cells value

---

Thanks, applied to -master.

Best regards,
Stefano

Quoted 55 lines
  arch/arm/dts/o4-imx-nano.dts | 18 ++++++------------
  1 file changed, 6 insertions(+), 12 deletions(-)
arch/arm/dts/o4-imx-nano.dts +6 -12
index d1785b7dc702..54d32f9dd47b 100644
@@ -24,40 +24,34 @@
  	leds {
  		compatible = "gpio-leds";
 
-		led@0 {
+		led0 {
  			color = <LED_COLOR_ID_RED>;
  			gpios = <&pcf8574a 0 GPIO_ACTIVE_LOW>;
-			reg = <0>;
  		};
 
-		led@1 {
+		led1{
  			color = <LED_COLOR_ID_GREEN>;
  			gpios = <&pcf8574a 1 GPIO_ACTIVE_LOW>;
-			reg = <1>;
  		};
 
-		led@2 {
+		led2 {
  			gpios = <&pcf8574a 2 GPIO_ACTIVE_LOW>;
  			color = <LED_COLOR_ID_BLUE>;
-			reg = <2>;
  		};
 
-		led@3 {
+		led3 {
  			color = <LED_COLOR_ID_RED>;
  			gpios = <&pcf8574a 3 GPIO_ACTIVE_LOW>;
-			reg = <3>;
  		};
 
-		led@4 {
+		led4{
  			color = <LED_COLOR_ID_GREEN>;
  			gpios = <&pcf8574a 4 GPIO_ACTIVE_LOW>;
-			reg = <4>;
  		};
 
-		led@5 {
+		led5 {
  			color = <LED_COLOR_ID_BLUE>;
  			gpios = <&pcf8574a 5 GPIO_ACTIVE_LOW>;
-			reg = <5>;
  		};
  	};
 
Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: [email protected]
=====================================================================