cxl/pci: Rename CXL REGLOC ID
PATCH 1/1 cxl/pci: Rename CXL REGLOC ID
The current naming is confusing and wrong. The Register Locator is identified by the DSVSEC identifier, not an offset.
Cc Dan Williams <[email protected]>
Signed-off-by Ben Widawsky <[email protected]>
--- drivers/cxl/pci.c | 2 +- drivers/cxl/pci.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/cxl/pci.c +1 -1
@@ -1086,7 +1086,7 @@ static int cxl_mem_setup_regs(struct cxl_mem *cxlm)LIST_HEAD (register_maps);int ret =0 ; - regloc =cxl_mem_dvsec (pdev,PCI_DVSEC_ID_CXL_REGLOC_OFFSET ); + regloc =cxl_mem_dvsec (pdev,PCI_DVSEC_ID_CXL_REGLOC_DVSEC_ID );if (!regloc) {dev_err (dev,"register location dvsec not found\n" );return -ENXIO ;
drivers/cxl/pci.h +1 -1
@@ -13,7 +13,7 @@#define PCI_DVSEC_VENDOR_ID_CXL 0x1E98#define PCI_DVSEC_ID_CXL 0x0 -#define PCI_DVSEC_ID_CXL_REGLOC_OFFSET 0x8 +#define PCI_DVSEC_ID_CXL_REGLOC_DVSEC_ID 0x8#define PCI_DVSEC_ID_CXL_REGLOC_BLOCK1_OFFSET 0xC/* BAR Indicator Register (BIR) */
Signature · 1 line
2.32.0
Quoted 6 lines · Ben Widawsky
The current naming is confusing and wrong. The Register Locator is identified by the DSVSEC identifier, not an offset.
Cc Dan Williams <[email protected]>Signed-off-by Ben Widawsky <[email protected]>
LGTM.
Jonathan Cameron
Reviewed-byQuoted 9 lines · On Thu, 17 Jun 2021 17:33:52 -0700 Dan Williams <[email protected]>…
Quoted 6 lines · Ben Widawsky
The current naming is confusing and wrong. The Register Locator is identified by the DSVSEC identifier, not an offset.
Cc Dan Williams <[email protected]>Signed-off-by Ben Widawsky <[email protected]>LGTM.
Likewise. oops ;)
Reviewed-by Jonathan Cameron <[email protected]>