Skip to contentSkip to conversation

cxl/pci: Rename CXL REGLOC ID

PATCH In review Ben Widawsky 3 participants 3 messages Jun 18, 2021 CXL

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 cxl/pci: Rename CXL REGLOC ID

The current naming is confusing and wrong. The Register Locator is identified by the DSVSEC identifier, not an offset.

---
 drivers/cxl/pci.c | 2 +-
 drivers/cxl/pci.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/cxl/pci.c +1 -1
index f8408e5f0754..4cf351a3cf99 100644
@@ -1086,7 +1086,7 @@ static int cxl_mem_setup_regs(struct cxl_mem *cxlm)
 	LIST_HEAD(register_maps);
 	int ret = 0;
 
-	regloc = cxl_mem_dvsec(pdev, PCI_DVSEC_ID_CXL_REGLOC_OFFSET);
+	regloc = cxl_mem_dvsec(pdev, PCI_DVSEC_ID_CXL_REGLOC_DVSEC_ID);
 	if (!regloc) {
 		dev_err(dev, "register location dvsec not found\n");
 		return -ENXIO;
drivers/cxl/pci.h +1 -1
index af3ec078cf6c..dad7a831f65f 100644
@@ -13,7 +13,7 @@
 #define PCI_DVSEC_VENDOR_ID_CXL		0x1E98
 #define PCI_DVSEC_ID_CXL		0x0
 
-#define PCI_DVSEC_ID_CXL_REGLOC_OFFSET		0x8
+#define PCI_DVSEC_ID_CXL_REGLOC_DVSEC_ID	0x8
 #define PCI_DVSEC_ID_CXL_REGLOC_BLOCK1_OFFSET	0xC
 
 /* BAR Indicator Register (BIR) */
Signature · 1 line
2.32.0