iavf: Fix init and watchdog state machines
v3 cover iavf: Fix init and watchdog state machines
Use single state machine for driver initialization and for service initialized driver. The init state machine implemented in init_task() is merged into the watchdog_task(). The init_task() function is removed.
---
v3: Added new file to patch series
v2: Splitted the patch into 2 to make them smaller
---
Jan Sokolowski (3):
iavf: Refactor iavf state machine tracking
iavf: Add __IAVF_INIT_FAILED state
iavf: Fix init and watchdog state machines
drivers/net/ethernet/intel/iavf/iavf.h | 12 +- drivers/net/ethernet/intel/iavf/iavf_main.c | 188 +++++++++--------- .../net/ethernet/intel/iavf/iavf_virtchnl.c | 2 +- 3 files changed, 103 insertions(+), 99 deletions(-)
Signature · 1 line
2.27.0
v3 cover iavf: Fix init and watchdog state machines
Quoted 5 lines · Mateusz Palczewski
Use single state machine for driver initialization and for service initialized driver. The init state machine implemented in
init_task()is merged into thewatchdog_task(). Theinit_task()function is removed.
Since this is code refactoring I think this should be applied via net-next.
Quoted 2 lines
---
v3: Added new file to patch series
Thanks for splitting the patches up!
Stefan
Quoted 21 lines
v2: Splitted the patch into 2 to make them smaller
---Jan Sokolowski (3):
iavf: Refactor iavf state machine tracking
iavf: Add__IAVF_INIT_FAILEDstate
iavf: Fix init and watchdog state machinesdrivers/net/ethernet/intel/iavf/iavf.h | 12 +- drivers/net/ethernet/intel/iavf/iavf_main.c | 188 +++++++++--------- .../net/ethernet/intel/iavf/iavf_virtchnl.c | 2 +- 3 files changed, 103 insertions(+), 99 deletions(-)Signature · 6 lines
2.27.0 _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan at osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
Nguyen
v3 cover iavf: Fix init and watchdog state machines
Quoted 9 lines · Stefan Assmann
Quoted 5 lines · Mateusz Palczewski
Use single state machine for driver initialization and for service initialized driver. The init state machine implemented in
init_task()is merged into thewatchdog_task(). Theinit_task()function is removed.Since this is code refactoring I think this should be applied via net-next.
I agree with Stefan. This seems like a better fit for net-next unless you have a specific bug/issue you are resolving. If so, please include that in the descriptions and put the fix in net patches with refactors in net-next patches.
Also, are you using the correct tree and branch? Rebasing before you send these? This does not apply to either tree (net-queue or next- queue).
Quoted 34 lines
Quoted 2 lines
---
v3: Added new file to patch seriesThanks for splitting the patches up!
Stefan
Quoted 8 lines
v2: Splitted the patch into 2 to make them smaller
---Jan Sokolowski (3):
iavf: Refactor iavf state machine tracking
iavf: Add__IAVF_INIT_FAILEDstate
iavf: Fix init and watchdog state machinesQuoted 14 lines
drivers/net/ethernet/intel/iavf/iavf.h | 12 +- drivers/net/ethernet/intel/iavf/iavf_main.c | 188 +++++++++----- ---- .../net/ethernet/intel/iavf/iavf_virtchnl.c | 2 +- 3 files changed, 103 insertions(+), 99 deletions(-)Signature · 6 lines
2.27.0 _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan at osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan at osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan