soc: qcom: geni: add support for gpi dma
Subsystems (2)
v2 cover soc: qcom: geni: add support for gpi dma
This is version 2 of the GPI dma series [1]
This series add the GPI DMA in qcom geni drivers. For this we first need to move GENI_IF_DISABLE_RO and struct geni_wrapper to common headers and then add support in the gpi dma in geni driver.
The SPI and I2C driver changes shall follow shortly
[1]: http://lore.kernel.org/r/[email protected]
Changes in v2:
- add r-b from Bjorn on patch 1
- add more details in log for patch 2
- Fix the comments from Doug and Bjorn for patch3, notable use read, modify update for irq registers, use geni_se_irq_clear() for irq, dont update single bit registers, add a bit more description for gpi dma etc
Vinod Koul (3):
soc: qcom: geni: move GENI_IF_DISABLE_RO to common header
soc: qcom: geni: move struct geni_wrapper to header
soc: qcom: geni: Add support for gpi dma
drivers/soc/qcom/qcom-geni-se.c | 47 ++++++++++++++++++++++----------- include/linux/qcom-geni-se.h | 23 ++++++++++++++-- 2 files changed, 52 insertions(+), 18 deletions(-)
Signature · 1 line
2.31.1
PATCH v2 1/3 soc: qcom: geni: move GENI_IF_DISABLE_RO to common header
GENI_IF_DISABLE_RO is used by geni spi driver as well to check the status if GENI, so move this to common header qcom-geni-se.h
Also, add FIFO_IF_DISABLE define.
--- drivers/soc/qcom/qcom-geni-se.c | 1 - include/linux/qcom-geni-se.h | 4 ++++ 2 files changed, 4 insertions(+), 1 deletion(-)
drivers/soc/qcom/qcom-geni-se.c +0 -1
@@ -104,7 +104,6 @@ static const char * const icc_path_names[] = {"qup-core", "qup-config",#define GENI_OUTPUT_CTRL 0x24#define GENI_CGC_CTRL 0x28#define GENI_CLK_CTRL_RO 0x60 -#define GENI_IF_DISABLE_RO 0x64#define GENI_FW_S_REVISION_RO 0x6c#define SE_GENI_BYTE_GRAN 0x254#define SE_GENI_TX_PACKING_CFG0 0x260
include/linux/qcom-geni-se.h +4 -0
@@ -63,6 +63,7 @@ struct geni_se {#define SE_GENI_STATUS 0x40#define GENI_SER_M_CLK_CFG 0x48#define GENI_SER_S_CLK_CFG 0x4c +#define GENI_IF_DISABLE_RO 0x64#define GENI_FW_REVISION_RO 0x68#define SE_GENI_CLK_SEL 0x7c#define SE_GENI_DMA_MODE_EN 0x258
@@ -105,6 +106,9 @@ struct geni_se {#define CLK_DIV_MSK GENMASK(15, 4)#define CLK_DIV_SHFT 4 +/* GENI_IF_DISABLE_RO fields */ +#define FIFO_IF_DISABLE (BIT(0)) +/* GENI_FW_REVISION_RO fields */ #define FW_REV_PROTOCOL_MSK GENMASK(15, 8)#define FW_REV_PROTOCOL_SHFT 8
Signature · 1 line
2.31.1
Re: [PATCH v2 1/3] soc: qcom: geni: move GENI_IF_DISABLE_RO to common header
Quoted 5 lines · Vinod Koul
GENI_IF_DISABLE_ROis used by geni spi driver as well to check the status if GENI, so move this to common headerqcom-geni-se.hAlso, add
FIFO_IF_DISABLEdefine.
Afaict these registers relates to the hardware block that is primarily owned by the individual engine-drivers, would it not make sense to move them all to the shared header file?
(The patch itself still looks ok, but needs the consuming patch to be merged)
Regards,
Bjorn
Quoted 44 lines
Reviewed-by Bjorn Andersson <[email protected]>Signed-off-by Vinod Koul <[email protected]>--- drivers/soc/qcom/qcom-geni-se.c | 1 - include/linux/qcom-geni-se.h | 4 ++++ 2 files changed, 4 insertions(+), 1 deletion(-)drivers/soc/qcom/qcom-geni-se.c +0
-1@@ -104,7 +104,6 @@ static const char * const icc_path_names[] = {"qup-core", "qup-config",#define GENI_OUTPUT_CTRL 0x24#define GENI_CGC_CTRL 0x28#define GENI_CLK_CTRL_RO 0x60 -#define GENI_IF_DISABLE_RO 0x64#define GENI_FW_S_REVISION_RO 0x6c#define SE_GENI_BYTE_GRAN 0x254#define SE_GENI_TX_PACKING_CFG0 0x260include/linux/qcom-geni-se.h +4
-0@@ -63,6 +63,7 @@ struct geni_se {#define SE_GENI_STATUS 0x40#define GENI_SER_M_CLK_CFG 0x48#define GENI_SER_S_CLK_CFG 0x4c +#define GENI_IF_DISABLE_RO 0x64#define GENI_FW_REVISION_RO 0x68#define SE_GENI_CLK_SEL 0x7c#define SE_GENI_DMA_MODE_EN 0x258@@ -105,6 +106,9 @@ struct geni_se {#define CLK_DIV_MSK GENMASK(15, 4)#define CLK_DIV_SHFT 4 +/* GENI_IF_DISABLE_RO fields */ +#define FIFO_IF_DISABLE (BIT(0)) +/* GENI_FW_REVISION_RO fields */ #define FW_REV_PROTOCOL_MSK GENMASK(15, 8)#define FW_REV_PROTOCOL_SHFT 8Signature · 1 line
2.31.1
Re: [PATCH v2 1/3] soc: qcom: geni: move GENI_IF_DISABLE_RO to common header
Quoted 11 lines · Bjorn Andersson
Quoted 5 lines · Vinod Koul
GENI_IF_DISABLE_ROis used by geni spi driver as well to check the status if GENI, so move this to common headerqcom-geni-se.hAlso, add
FIFO_IF_DISABLEdefine.Afaict these registers relates to the hardware block that is primarily owned by the individual engine-drivers, would it not make sense to move them all to the shared header file?
the GENI_IF_DISABLE_RO is used by SPI and I2C drivers, so we would create two copies. So better to be defined in geni header
Signature · 1 line
~Vinod
PATCH v2 2/3 soc: qcom: geni: move struct geni_wrapper to header
In reply to Vinod KoulSPI & I2C geni driver needs to access struct geni_wrapper, so move it to header. The drivers needs this header to find the geni device and use it in dma mapping.
Using this method works for both DT and ACPI systems
--- drivers/soc/qcom/qcom-geni-se.c | 14 -------------- include/linux/qcom-geni-se.h | 14 ++++++++++++++ 2 files changed, 14 insertions(+), 14 deletions(-)
drivers/soc/qcom/qcom-geni-se.c +0 -14
@@ -78,20 +78,6 @@*/ #define MAX_CLK_PERF_LEVEL 32 -#define NUM_AHB_CLKS 2 - -/** -* struct geni_wrapper - Data structure to represent the QUP Wrapper Core -* @dev: Device pointer of the QUP wrapper core -* @base: Base address of this instance of QUP wrapper core -* @ahb_clks: Handle to the primary & secondary AHB clocks -* @to_core: Core ICC path -*/ -struct geni_wrapper { -struct device *dev; -void __iomem *base; -struct clk_bulk_data ahb_clks[NUM_AHB_CLKS ]; -};static const char *const icc_path_names[] = {"qup-core" ,"qup-config" ,"qup-memory" };
include/linux/qcom-geni-se.h +14 -0
@@ -38,6 +38,20 @@ struct geni_icc_path {unsigned int avg_bw; }; +#define NUM_AHB_CLKS 2 + +/** +* @struct geni_wrapper - Data structure to represent the QUP Wrapper Core +* @dev: Device pointer of the QUP wrapper core +* @base: Base address of this instance of QUP wrapper core +* @ahb_clks: Handle to the primary & secondary AHB clocks +*/ +struct geni_wrapper { +struct device *dev; +void __iomem *base; +struct clk_bulk_data ahb_clks[NUM_AHB_CLKS ]; +}; +/** * struct geni_se - GENI Serial Engine * @base: Base Address of the Serial Engine's register block
Signature · 1 line
2.31.1
Re: [PATCH v2 2/3] soc: qcom: geni: move struct geni_wrapper to header
Quoted 4 lines · Vinod Koul
SPI & I2C geni driver needs to access struct
geni_wrapper, so move it to header. The drivers needs this header to find the geni device and use it in dma mapping.
How does this differ from engine->dev->parent?
Quoted 2 lines
Using this method works for both DT and ACPI systems
I was under the impression that the wrapper and engines are describe completely independently in ACPI, so we don't have a link between them.
If that's not the case, then I guess that answers the above question about ->parent.
Regards,
Bjorn
Quoted 59 lines
Signed-off-by Vinod Koul <[email protected]>--- drivers/soc/qcom/qcom-geni-se.c | 14 -------------- include/linux/qcom-geni-se.h | 14 ++++++++++++++ 2 files changed, 14 insertions(+), 14 deletions(-)drivers/soc/qcom/qcom-geni-se.c +0
-14@@ -78,20 +78,6 @@*/ #define MAX_CLK_PERF_LEVEL 32 -#define NUM_AHB_CLKS 2 - -/** -* struct geni_wrapper - Data structure to represent the QUP Wrapper Core -* @dev: Device pointer of the QUP wrapper core -* @base: Base address of this instance of QUP wrapper core -* @ahb_clks: Handle to the primary & secondary AHB clocks -* @to_core: Core ICC path -*/ -struct geni_wrapper { -struct device *dev; -void __iomem *base; -struct clk_bulk_data ahb_clks[NUM_AHB_CLKS ]; -};static const char *const icc_path_names[] = {"qup-core" ,"qup-config" ,"qup-memory" };include/linux/qcom-geni-se.h +14
-0@@ -38,6 +38,20 @@ struct geni_icc_path {unsigned int avg_bw; }; +#define NUM_AHB_CLKS 2 + +/** +* @struct geni_wrapper - Data structure to represent the QUP Wrapper Core +* @dev: Device pointer of the QUP wrapper core +* @base: Base address of this instance of QUP wrapper core +* @ahb_clks: Handle to the primary & secondary AHB clocks +*/ +struct geni_wrapper { +struct device *dev; +void __iomem *base; +struct clk_bulk_data ahb_clks[NUM_AHB_CLKS ]; +}; +/** * struct geni_se - GENI Serial Engine * @base: Base Address of the Serial Engine's register block Signature · 1 line
2.31.1
PATCH v2 3/3 soc: qcom: geni: Add support for gpi dma
In reply to Vinod KoulGPI DMA is one of the DMA modes supported on geni, this adds support to enable that mode
--- drivers/soc/qcom/qcom-geni-se.c | 32 +++++++++++++++++++++++++++++++- include/linux/qcom-geni-se.h | 5 +++-- 2 files changed, 34 insertions(+), 3 deletions(-)
drivers/soc/qcom/qcom-geni-se.c +31 -1
@@ -307,6 +307,32 @@ static void geni_se_select_dma_mode(struct geni_se *se)writel_relaxed (val, se->base +SE_GENI_DMA_MODE_EN ); } +static void geni_se_select_gpi_mode (struct geni_se *se) +{ +unsigned int gpi_event_en; +unsigned int m_irq_en; +unsigned int s_irq_en; + +geni_se_irq_clear (se); +writel (0 , se->base +SE_IRQ_EN ); + + s_irq_en =readl_relaxed (se->base +SE_GENI_S_IRQ_EN ); + s_irq_en &= ~S_CMD_DONE_EN ; +writel (s_irq_en, se->base +SE_GENI_S_IRQ_EN ); + + m_irq_en =readl (se->base +SE_GENI_M_IRQ_EN ); + m_irq_en &= ~(M_CMD_DONE_EN |M_TX_FIFO_WATERMARK_EN | +M_RX_FIFO_WATERMARK_EN |M_RX_FIFO_LAST_EN ); +writel (m_irq_en, se->base +SE_GENI_M_IRQ_EN ); + +writel (GENI_DMA_MODE_EN , se->base +SE_GENI_DMA_MODE_EN ); + + gpi_event_en =readl (se->base +SE_GSI_EVENT_EN ); + gpi_event_en |= (DMA_RX_EVENT_EN |DMA_TX_EVENT_EN | +GENI_M_EVENT_EN |GENI_S_EVENT_EN ); +writel (gpi_event_en, se->base +SE_GSI_EVENT_EN ); +} +/** * geni_se_select_mode() - Select the serial engine transfer mode * @se: Pointer to the concerned serial engine.
@@ -314,7 +340,8 @@ static void geni_se_select_dma_mode(struct geni_se *se)*/ void geni_se_select_mode (struct geni_se *se,enum geni_se_xfer_mode mode) { -WARN_ON (mode !=GENI_SE_FIFO && mode !=GENI_SE_DMA ); +WARN_ON (mode !=GENI_SE_FIFO && mode !=GENI_SE_DMA && + mode !=GENI_GPI_DMA );switch (mode) {case GENI_SE_FIFO :
@@ -323,6 +350,9 @@ void geni_se_select_mode(struct geni_se *se, enum geni_se_xfer_mode mode)case GENI_SE_DMA :geni_se_select_dma_mode (se);break ; +case GENI_GPI_DMA : +geni_se_select_gpi_mode (se); +break ;case GENI_SE_INVALID :default :break ;
include/linux/qcom-geni-se.h +3 -2
@@ -11,8 +11,9 @@/* Transfer mode supported by GENI Serial Engines */ enum geni_se_xfer_mode {GENI_SE_INVALID , -GENI_SE_FIFO , -GENI_SE_DMA , +GENI_SE_FIFO ,/* FIFO mode */ +GENI_GPI_DMA ,/* GSI aka GPI DMA mode */ +GENI_SE_DMA ,/* SE DMA mode */ };/* Protocols supported by GENI Serial Engines */
Signature · 1 line
2.31.1
Re: [PATCH v2 3/3] soc: qcom: geni: Add support for gpi dma
Quoted 2 lines · Vinod Koul
GPI DMA is one of the DMA modes supported on geni, this adds support to enable that mode
I think you're missing an opportunity to describe what GPI DMA is. Perhaps something like:
In GPI DMA mode the serial engine uses the DMA controller found in the associated wrapper to perform its transaction, add support for enabling this mode in the engine.
Quoted 12 lines
Signed-off-by Vinod Koul <[email protected]>--- drivers/soc/qcom/qcom-geni-se.c | 32 +++++++++++++++++++++++++++++++- include/linux/qcom-geni-se.h | 5 +++-- 2 files changed, 34 insertions(+), 3 deletions(-)drivers/soc/qcom/qcom-geni-se.c +0
-0
drivers/soc/qcom/qcom-geni-se.c static void geni_se_select_dma_mode(struct geni_se *se) · line 314
Quoted 8 lines
drivers/soc/qcom/qcom-geni-se.c +5
-0@@ -307,6 +307,32 @@ static void geni_se_select_dma_mode(struct geni_se *se)writel_relaxed (val, se->base +SE_GENI_DMA_MODE_EN ); } +static void geni_se_select_gpi_mode (struct geni_se *se) +{ +unsigned int gpi_event_en; +unsigned int m_irq_en; +unsigned int s_irq_en;
readl and writel operates on u32, so better to use that.
drivers/soc/qcom/qcom-geni-se.c static void geni_se_select_dma_mode(struct geni_se *se) · line 319
Quoted 5 lines
drivers/soc/qcom/qcom-geni-se.c +5
-0+ +geni_se_irq_clear (se); +writel (0 , se->base +SE_IRQ_EN ); + + s_irq_en =readl_relaxed (se->base +SE_GENI_S_IRQ_EN );
I don't mind this being _relaxed if done on purpose, but as it's the only one (and there's no comment) I get the feeling that it's a mistake.
drivers/soc/qcom/qcom-geni-se.c static void geni_se_select_dma_mode(struct geni_se *se) · line 321
Quoted 2 lines
drivers/soc/qcom/qcom-geni-se.c +2
-0+ s_irq_en &= ~S_CMD_DONE_EN ; +writel (s_irq_en, se->base +SE_GENI_S_IRQ_EN );
The use of 3 different variables (gpi_event_en, m_irq_en, s_irq_en) forced me to really look if the three sets of operations somehow reused previous results.
To clarify that this isn't the case I would suggest that you use a single variable ("val"?) instead.
Quoted 18 lines
drivers/soc/qcom/qcom-geni-se.c +14
-0+ + m_irq_en =readl (se->base +SE_GENI_M_IRQ_EN ); + m_irq_en &= ~(M_CMD_DONE_EN |M_TX_FIFO_WATERMARK_EN | +M_RX_FIFO_WATERMARK_EN |M_RX_FIFO_LAST_EN ); +writel (m_irq_en, se->base +SE_GENI_M_IRQ_EN ); + +writel (GENI_DMA_MODE_EN , se->base +SE_GENI_DMA_MODE_EN ); + + gpi_event_en =readl (se->base +SE_GSI_EVENT_EN ); + gpi_event_en |= (DMA_RX_EVENT_EN |DMA_TX_EVENT_EN | +GENI_M_EVENT_EN |GENI_S_EVENT_EN ); +writel (gpi_event_en, se->base +SE_GSI_EVENT_EN ); +} +/** * geni_se_select_mode() - Select the serial engine transfer mode * @se: Pointer to the concerned serial engine.
drivers/soc/qcom/qcom-geni-se.c static void geni_se_select_dma_mode(struct geni_se *se) · line 344
Quoted 6 lines
drivers/soc/qcom/qcom-geni-se.c +2
-1@@ -314,7 +340,8 @@ static void geni_se_select_dma_mode(struct geni_se *se)*/ void geni_se_select_mode (struct geni_se *se,enum geni_se_xfer_mode mode) { -WARN_ON (mode !=GENI_SE_FIFO && mode !=GENI_SE_DMA ); +WARN_ON (mode !=GENI_SE_FIFO && mode !=GENI_SE_DMA && + mode !=GENI_GPI_DMA );
This line can be left unbroken.
Quoted 18 lines
drivers/soc/qcom/qcom-geni-se.c +3
-0switch (mode) {case GENI_SE_FIFO :@@ -323,6 +350,9 @@ void geni_se_select_mode(struct geni_se *se, enum geni_se_xfer_mode mode)case GENI_SE_DMA :geni_se_select_dma_mode (se);break ; +case GENI_GPI_DMA : +geni_se_select_gpi_mode (se); +break ;case GENI_SE_INVALID :default :break ;include/linux/qcom-geni-se.h +0
-0
include/linux/qcom-geni-se.h line 15
Quoted 5 lines
include/linux/qcom-geni-se.h +0
-2@@ -11,8 +11,9 @@/* Transfer mode supported by GENI Serial Engines */ enum geni_se_xfer_mode {GENI_SE_INVALID , -GENI_SE_FIFO , -GENI_SE_DMA ,
Is the order significant? Is there a reason why SE_DMA ended up last?
include/linux/qcom-geni-se.h line 15
Quoted 2 lines
include/linux/qcom-geni-se.h +2
-0+GENI_SE_FIFO ,/* FIFO mode */ + GENI_GPI_DMA, /* GSI aka GPI DMA mode */
If the TLA soup is too soupy, then perhaps we should just document it as "external DMA" or "Use wrapper's DMA controller"?
And perhaps use kernel-doc instead?
Regards,
Bjorn
Quoted 7 lines
include/linux/qcom-geni-se.h +1
-0+ GENI_SE_DMA, /* SE DMA mode */ };/* Protocols supported by GENI Serial Engines */ Signature · 1 line
2.31.1
Re: [PATCH v2 3/3] soc: qcom: geni: Add support for gpi dma
Quoted 11 lines · Bjorn Andersson
Quoted 2 lines · Vinod Koul
GPI DMA is one of the DMA modes supported on geni, this adds support to enable that mode
I think you're missing an opportunity to describe what GPI DMA is. Perhaps something like:
In GPI DMA mode the serial engine uses the DMA controller found in the associated wrapper to perform its transaction, add support for enabling this mode in the engine.
Hmm looks like I did, I will update more kernel-doc style comments to explain more details
Quoted 16 lines
Quoted 16 lines
Signed-off-by Vinod Koul <[email protected]>--- drivers/soc/qcom/qcom-geni-se.c | 32 +++++++++++++++++++++++++++++++- include/linux/qcom-geni-se.h | 5 +++-- 2 files changed, 34 insertions(+), 3 deletions(-)drivers/soc/qcom/qcom-geni-se.c +0
-0@@ -307,6 +307,32 @@ static void geni_se_select_dma_mode(struct geni_se *se)writel_relaxed (val, se->base +SE_GENI_DMA_MODE_EN ); }
Quoted 7 lines
drivers/soc/qcom/qcom-geni-se.c static void geni_se_select_dma_mode(struct geni_se *se) · line 314
Quoted 5 lines
drivers/soc/qcom/qcom-geni-se.c +5
-0+static void geni_se_select_gpi_mode (struct geni_se *se) +{ +unsigned int gpi_event_en; +unsigned int m_irq_en; +unsigned int s_irq_en;readl and writel operates on u32, so better to use that.
Yes
Quoted 9 lines
drivers/soc/qcom/qcom-geni-se.c static void geni_se_select_dma_mode(struct geni_se *se) · line 319
Quoted 6 lines
drivers/soc/qcom/qcom-geni-se.c +5
-0+ +geni_se_irq_clear (se); +writel (0 , se->base +SE_IRQ_EN ); + + s_irq_en =readl_relaxed (se->base +SE_GENI_S_IRQ_EN );I don't mind this being
_relaxedif done on purpose, but as it's the only one (and there's no comment) I get the feeling that it's a mistake.
Yes it is a leftover, fixed now
Quoted 10 lines
drivers/soc/qcom/qcom-geni-se.c static void geni_se_select_dma_mode(struct geni_se *se) · line 321
Quoted 3 lines
drivers/soc/qcom/qcom-geni-se.c +2
-0+ s_irq_en &= ~S_CMD_DONE_EN ; +writel (s_irq_en, se->base +SE_GENI_S_IRQ_EN );The use of 3 different variables (
gpi_event_en,m_irq_en,s_irq_en) forced me to really look if the three sets of operations somehow reused previous results.To clarify that this isn't the case I would suggest that you use a single variable ("val"?) instead.
Yes updated
Quoted 19 lines
Quoted 19 lines
drivers/soc/qcom/qcom-geni-se.c +14
-0+ + m_irq_en =readl (se->base +SE_GENI_M_IRQ_EN ); + m_irq_en &= ~(M_CMD_DONE_EN |M_TX_FIFO_WATERMARK_EN | +M_RX_FIFO_WATERMARK_EN |M_RX_FIFO_LAST_EN ); +writel (m_irq_en, se->base +SE_GENI_M_IRQ_EN ); + +writel (GENI_DMA_MODE_EN , se->base +SE_GENI_DMA_MODE_EN ); + + gpi_event_en =readl (se->base +SE_GSI_EVENT_EN ); + gpi_event_en |= (DMA_RX_EVENT_EN |DMA_TX_EVENT_EN | +GENI_M_EVENT_EN |GENI_S_EVENT_EN ); +writel (gpi_event_en, se->base +SE_GSI_EVENT_EN ); +} +/** * geni_se_select_mode() - Select the serial engine transfer mode * @se: Pointer to the concerned serial engine. @@ -314,7 +340,8 @@ static void geni_se_select_dma_mode(struct geni_se *se)
Quoted 8 lines
drivers/soc/qcom/qcom-geni-se.c static void geni_se_select_dma_mode(struct geni_se *se) · line 344
Quoted 6 lines
drivers/soc/qcom/qcom-geni-se.c +2
-1*/ void geni_se_select_mode (struct geni_se *se,enum geni_se_xfer_mode mode) { -WARN_ON (mode !=GENI_SE_FIFO && mode !=GENI_SE_DMA ); +WARN_ON (mode !=GENI_SE_FIFO && mode !=GENI_SE_DMA && + mode !=GENI_GPI_DMA );This line can be left unbroken.
yaay 100 chars :-) will do
Quoted 18 lines
Quoted 18 lines
drivers/soc/qcom/qcom-geni-se.c +3
-0switch (mode) {case GENI_SE_FIFO :@@ -323,6 +350,9 @@ void geni_se_select_mode(struct geni_se *se, enum geni_se_xfer_mode mode)case GENI_SE_DMA :geni_se_select_dma_mode (se);break ; +case GENI_GPI_DMA : +geni_se_select_gpi_mode (se); +break ;case GENI_SE_INVALID :default :break ;include/linux/qcom-geni-se.h +0
-0
Quoted 8 lines
include/linux/qcom-geni-se.h line 15
Quoted 6 lines
include/linux/qcom-geni-se.h +0
-2@@ -11,8 +11,9 @@/* Transfer mode supported by GENI Serial Engines */ enum geni_se_xfer_mode {GENI_SE_INVALID , -GENI_SE_FIFO , -GENI_SE_DMA ,Is the order significant? Is there a reason why
SE_DMAended up last?
Nope not that I can tjing off.. I can add this as last!
Signature · 1 line
~Vinod
Quoted 8 lines · Vinod Koul
This is version 2 of the GPI dma series [1]
This series add the GPI DMA in qcom geni drivers. For this we first need to move
GENI_IF_DISABLE_ROand structgeni_wrapperto common headers and then add support in the gpi dma in geni driver.The SPI and I2C driver changes shall follow shortly
Given that the continuation of this series will have build time dependencies on these patches I think it would be good to see them all as one chunk (and practically I can create a immutable branch of the soc/qcom pieces and share with Wolfram and Mark).
Regards,
Bjorn
Quoted 21 lines
[1]: http://lore.kernel.org/r/[email protected]
Changes in v2:
- add r-b from Bjorn on patch 1
- add more details in log for patch 2
- Fix the comments from Doug and Bjorn for patch3, notable use read, modify update for irq registers, usegeni_se_irq_clear()for irq, dont update single bit registers, add a bit more description for gpi dma etcVinod Koul (3):
soc: qcom: geni: moveGENI_IF_DISABLE_ROto common header
soc: qcom: geni: move structgeni_wrapperto header
soc: qcom: geni: Add support for gpi dmadrivers/soc/qcom/qcom-geni-se.c | 47 ++++++++++++++++++++++----------- include/linux/qcom-geni-se.h | 23 ++++++++++++++-- 2 files changed, 52 insertions(+), 18 deletions(-)Signature · 1 line
2.31.1
Quoted 8 lines · Bjorn Andersson
Quoted 6 lines · Vinod Koul
This is version 2 of the GPI dma series [1]
This series add the GPI DMA in qcom geni drivers. For this we first need to move
GENI_IF_DISABLE_ROand structgeni_wrapperto common headers and then add support in the gpi dma in geni driver.
Quoted 7 lines
Quoted 2 lines
The SPI and I2C driver changes shall follow shortly
Given that the continuation of this series will have build time dependencies on these patches I think it would be good to see them all as one chunk (and practically I can create a immutable branch of the soc/qcom pieces and share with Wolfram and Mark).
Okay, let me post full series in few days
Quoted 25 lines
Regards,
BjornQuoted 21 lines
[1]: http://lore.kernel.org/r/[email protected]
Changes in v2:
- add r-b from Bjorn on patch 1
- add more details in log for patch 2
- Fix the comments from Doug and Bjorn for patch3, notable use read, modify update for irq registers, usegeni_se_irq_clear()for irq, dont update single bit registers, add a bit more description for gpi dma etcVinod Koul (3):
soc: qcom: geni: moveGENI_IF_DISABLE_ROto common header
soc: qcom: geni: move structgeni_wrapperto header
soc: qcom: geni: Add support for gpi dmadrivers/soc/qcom/qcom-geni-se.c | 47 ++++++++++++++++++++++----------- include/linux/qcom-geni-se.h | 23 ++++++++++++++-- 2 files changed, 52 insertions(+), 18 deletions(-)Signature · 1 line
2.31.1
Signature · 1 line
~Vinod