Skip to contentSkip to conversation

drm/amd/display: Fix edp_bootup_bl_level initialization issue

PATCH In review Bindu Ramamurthy 2 participants 2 messages Jun 18, 2021 – Jun 21, 2021

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 8/12 drm/amd/display: Fix edp_bootup_bl_level initialization issue

From: Logush Oliver <[email protected]>

[why]
Updating the file to fix the missing line

---
 drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c +1 -1
index 7d1c1b76d8d0..840d7aca17cf 100644
@@ -2140,7 +2140,7 @@ static enum bp_result get_integrated_info_v2_1(
 		info_v2_1->edp1_info.edp_pwr_down_bloff_to_vary_bloff;
 	info->edp1_info.edp_panel_bpc =
 		info_v2_1->edp1_info.edp_panel_bpc;
-	info->edp1_info.edp_bootup_bl_level =
+	info->edp1_info.edp_bootup_bl_level = info_v2_1->edp1_info.edp_bootup_bl_level;
 
 	info->edp2_info.edp_backlight_pwm_hz =
 	le16_to_cpu(info_v2_1->edp2_info.edp_backlight_pwm_hz);
Signature · 6 lines
2.25.1

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
maintainer
#1 lore raw
Quoted 17 lines · Bindu Ramamurthy

From: Logush Oliver <[email protected]>

[why]
Updating the file to fix the missing line

---
 drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c +0 -0
index 7d1c1b76d8d0..840d7aca17cf 100644

drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c static enum bp_result get_integrated_info_v2_1( · line 2144

Quoted 6 lines
drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c +1 -1
@@ -2140,7 +2140,7 @@ static enum bp_result get_integrated_info_v2_1(
 		info_v2_1->edp1_info.edp_pwr_down_bloff_to_vary_bloff;
 	info->edp1_info.edp_panel_bpc =
 		info_v2_1->edp1_info.edp_panel_bpc;
-	info->edp1_info.edp_bootup_bl_level =
+	info->edp1_info.edp_bootup_bl_level = info_v2_1->edp1_info.edp_bootup_bl_level;
 

This hints at a previous patch not building successfully. Please ensure all patches in the series are building. It can be easily checked with 'git rebase -i --exec make'.

Make sure this gets squashed with the faulty patch before merging.

Thanks,
Harry

drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c static enum bp_result get_integrated_info_v2_1( · line 2146

Quoted 3 lines
drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c +0 -0
 	info->edp2_info.edp_backlight_pwm_hz =
 	le16_to_cpu(info_v2_1->edp2_info.edp_backlight_pwm_hz);

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx