Skip to contentSkip to conversation

cpu: add conj 'than' to a defective sentence

PATCH In review Zhouyi Zhou 2 participants 3 messages Jun 18, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 cpu: add conj 'than' to a defective sentence

Hi Paul,

I guess '... represents a reasonably large system with no fewer 448 hardware threads' is a defective sentence, it needs a conj: 'than'.

Sorry for bothering you if I am wrong, because my English is not quite good :-)

Thanks
Zhouyi

---
 cpu/overheads.tex | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
cpu/overheads.tex +1 -1
index 4aeae6c..28462d4 100644
@@ -354,7 +354,7 @@ thousand clock cycles.
 	\cref{tab:cpu:CPU 0 View of Synchronization Mechanisms on 8-Socket System With Intel Xeon Platinum 8176 CPUs at 2.10GHz}
 	on
 	\cpageref{tab:cpu:CPU 0 View of Synchronization Mechanisms on 8-Socket System With Intel Xeon Platinum 8176 CPUs at 2.10GHz}
-	represents a reasonably large system with no fewer 448~hardware
+	represents a reasonably large system with no fewer than 448~hardware
 	threads.
 	Smaller systems often achieve better latency, as may be seen in
 	\cref{tab:cpu:Performance of Synchronization Mechanisms on 16-CPU 2.8GHz Intel X5550 (Nehalem) System},
Signature · 1 line
2.5.0
#1 lore raw
Quoted 5 lines · Zhouyi Zhou

Hi Paul,

I guess '... represents a reasonably large system with no fewer 448 hardware threads' is a defective sentence, it needs a conj: 'than'.

Quoted 7 lines

Sorry for bothering you if I am wrong, because my English is not quite good :-)

Thanks
Zhouyi

You are quite right, and thank you for spotting this and for sending the patch! I wordsmithed the commit log, in part to avoid the age-old debate as to whether a given use of "than" is a conjunction or a preposition. You probably had it right, but why take the chance? ;-)

Thanx, Paul

------------------------------------------------------------------------

commit 8fc0705251d3409591edfaf62a4373ffcec5794e

Author: Zhouyi Zhou <[email protected]>
Date:   Fri Jun 18 12:17:49 2021 +0800

cpu: Add 'than' to a defective sentence

The sentence '... represents a reasonably large system with no fewer 448 hardware threads' is missing a "than". This commit adds it.

cpu/overheads.tex +1 -1
index 4aeae6cd..28462d49 100644
@@ -354,7 +354,7 @@ thousand clock cycles.
 	\cref{tab:cpu:CPU 0 View of Synchronization Mechanisms on 8-Socket System With Intel Xeon Platinum 8176 CPUs at 2.10GHz}
 	on
 	\cpageref{tab:cpu:CPU 0 View of Synchronization Mechanisms on 8-Socket System With Intel Xeon Platinum 8176 CPUs at 2.10GHz}
-	represents a reasonably large system with no fewer 448~hardware
+	represents a reasonably large system with no fewer than 448~hardware
 	threads.
 	Smaller systems often achieve better latency, as may be seen in
 	\cref{tab:cpu:Performance of Synchronization Mechanisms on 16-CPU 2.8GHz Intel X5550 (Nehalem) System},
#2 lore raw

Thank you Paul,

Your encouragement is my driving force to go on. And thank you for adjusting the commit
log.

Cheers
Zhouyi

Quoted 2 lines · Paul E. McKenney

On Fri, Jun 18, 2021 at 12:17:49PM +0800, Zhouyi Zhou wrote: