Skip to contentSkip to conversation

drm: mxsfb: Disable overlay plane support for i.MX8MM/i.MX8MN

PATCH In review Marek Vasut 2 participants 3 messages Jun 20, 2021 – Jun 21, 2021

Subsystems (4)
lore
Share & tools
lore

Marek Vasut

author maintainer
#0 lore raw

PATCH 1/1 drm: mxsfb: Disable overlay plane support for i.MX8MM/i.MX8MN

The iMX8MM and iMX8MN do not support the overlay plane, so they are MXSFB V4. Add the compatible strings to reflect this. Note that iMX8MQ does support the overlay plane, so it is MXSFB V6.

Cc Daniel Abrecht <[email protected]>
Cc Emil Velikov <[email protected]>
Cc Laurent Pinchart <[email protected]>
Cc Lucas Stach <[email protected]>
Cc Stefan Agner <[email protected]>
---
 drivers/gpu/drm/mxsfb/mxsfb_drv.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/gpu/drm/mxsfb/mxsfb_drv.c +2 -0
index c277d3f61a5e..0ae4a3553304 100644
@@ -308,6 +308,8 @@ static const struct of_device_id mxsfb_dt_ids[] = {
 	{ .compatible = "fsl,imx23-lcdif", .data = &mxsfb_devdata[MXSFB_V3], },
 	{ .compatible = "fsl,imx28-lcdif", .data = &mxsfb_devdata[MXSFB_V4], },
 	{ .compatible = "fsl,imx6sx-lcdif", .data = &mxsfb_devdata[MXSFB_V6], },
+	{ .compatible = "fsl,imx8mm-lcdif", .data = &mxsfb_devdata[MXSFB_V4], },
+	{ .compatible = "fsl,imx8mn-lcdif", .data = &mxsfb_devdata[MXSFB_V4], },
 	{ /* sentinel */ }
 };
 MODULE_DEVICE_TABLE(of, mxsfb_dt_ids);
Signature · 1 line
2.30.2
#1 lore raw

Am Montag, dem 21.06.2021 um 00:48 +0200 schrieb Marek Vasut:

Quoted 3 lines

The iMX8MM and iMX8MN do not support the overlay plane, so they are MXSFB V4. Add the compatible strings to reflect this. Note that iMX8MQ does support the overlay plane, so it is MXSFB V6.

Do we need this compatible in the driver? If there are no other changes known at this time, shouldn't we be able to just specify "fsl,imx28- lcdif" as the fallback compatible in the DT, besides the imx8m* specific ones?

Regards,
Lucas

Quoted 24 lines
Cc Daniel Abrecht <[email protected]>
Cc Emil Velikov <[email protected]>
Cc Laurent Pinchart <[email protected]>
Cc Lucas Stach <[email protected]>
Cc Stefan Agner <[email protected]>
---
 drivers/gpu/drm/mxsfb/mxsfb_drv.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/gpu/drm/mxsfb/mxsfb_drv.c +2 -0
index c277d3f61a5e..0ae4a3553304 100644
@@ -308,6 +308,8 @@ static const struct of_device_id mxsfb_dt_ids[] = {
 	{ .compatible = "fsl,imx23-lcdif", .data = &mxsfb_devdata[MXSFB_V3], },
 	{ .compatible = "fsl,imx28-lcdif", .data = &mxsfb_devdata[MXSFB_V4], },
 	{ .compatible = "fsl,imx6sx-lcdif", .data = &mxsfb_devdata[MXSFB_V6], },
+	{ .compatible = "fsl,imx8mm-lcdif", .data = &mxsfb_devdata[MXSFB_V4], },
+	{ .compatible = "fsl,imx8mn-lcdif", .data = &mxsfb_devdata[MXSFB_V4], },
 	{ /* sentinel */ }
 };
 MODULE_DEVICE_TABLE(of, mxsfb_dt_ids);
author maintainer
#2 lore raw
Quoted 9 lines · Lucas Stach

Am Montag, dem 21.06.2021 um 00:48 +0200 schrieb Marek Vasut:

Quoted 3 lines

The iMX8MM and iMX8MN do not support the overlay plane, so they are MXSFB V4. Add the compatible strings to reflect this. Note that iMX8MQ does support the overlay plane, so it is MXSFB V6.

Do we need this compatible in the driver? If there are no other changes known at this time, shouldn't we be able to just specify "fsl,imx28- lcdif" as the fallback compatible in the DT, besides the imx8m* specific ones?

Yes, we should discard this patch and use the fallback compatible, although it is quite counter-intuitive.