ACPI: SPCR: Add new 16550-compatible Serial Port Subtype
Subsystems (2)
PATCH v3 1/1 ACPI: SPCR: Add new 16550-compatible Serial Port Subtype
The Microsoft Debug Port Table 2 (DBG2) specification revision May 31, 2017 adds support for 16550-compatible Serial Port Subtype with parameters defined in Generic Address Structure (GAS) [1]
Add its support in SPCR parsing routine.
[1] https://docs.microsoft.com/en-us/windows-hardware/drivers/bringup/acpi-debug-port-table
--- include/acpi/actbl1.h | 1 + drivers/acpi/spcr.c | 1 + 2 files changed, 2 insertions(+)
include/acpi/actbl1.h +1 -0
@@ -498,6 +498,7 @@ struct acpi_dbg2_device {#define ACPI_DBG2_ARM_SBSA_GENERIC 0x000E#define ACPI_DBG2_ARM_DCC 0x000F#define ACPI_DBG2_BCM2835 0x0010 +#define ACPI_DBG2_16550_WITH_GAS 0x0012#define ACPI_DBG2_1394_STANDARD 0x0000
drivers/acpi/spcr.c +1 -0
@@ -136,6 +136,7 @@ int __init acpi_parse_spcr(bool enable_earlycon, bool enable_console)break ;case ACPI_DBG2_16550_COMPATIBLE :case ACPI_DBG2_16550_SUBSET : +case ACPI_DBG2_16550_WITH_GAS : uart ="uart" ;break ;default :
Signature · 1 line
2.29.0
Apologies for the patch prefix, of course it's a first version and unrelated to the networking subsystem.
Best regards,
Marcin
pon., 21 cze 2021 o 22:05 Marcin Wojtas <[email protected]> napisał(a):
Quoted 42 lines
The Microsoft Debug Port Table 2 (DBG2) specification revision May 31, 2017 adds support for 16550-compatible Serial Port Subtype with parameters defined in Generic Address Structure (GAS) [1]
Add its support in SPCR parsing routine.
[1] https://docs.microsoft.com/en-us/windows-hardware/drivers/bringup/acpi-debug-port-table
Signed-off-by Marcin Wojtas <[email protected]>--- include/acpi/actbl1.h | 1 + drivers/acpi/spcr.c | 1 + 2 files changed, 2 insertions(+)include/acpi/actbl1.h +1
-0@@ -498,6 +498,7 @@ struct acpi_dbg2_device {#define ACPI_DBG2_ARM_SBSA_GENERIC 0x000E#define ACPI_DBG2_ARM_DCC 0x000F#define ACPI_DBG2_BCM2835 0x0010 +#define ACPI_DBG2_16550_WITH_GAS 0x0012#define ACPI_DBG2_1394_STANDARD 0x0000drivers/acpi/spcr.c +1
-1@@ -136,6 +136,7 @@ int __init acpi_parse_spcr(bool enable_earlycon, bool enable_console)break ;case ACPI_DBG2_16550_COMPATIBLE :case ACPI_DBG2_16550_SUBSET : +case ACPI_DBG2_16550_WITH_GAS : uart ="uart" ;break ;default : --2.29.0
Hi,
pon., 21 cze 2021 o 22:06 Marcin Wojtas <[email protected]> napisał(a):
Quoted 36 lines
Apologies for the patch prefix, of course it's a first version and unrelated to the networking subsystem.
Best regards,
Marcinpon., 21 cze 2021 o 22:05 Marcin Wojtas <[email protected]> napisał(a):
Quoted 27 lines
The Microsoft Debug Port Table 2 (DBG2) specification revision May 31, 2017 adds support for 16550-compatible Serial Port Subtype with parameters defined in Generic Address Structure (GAS) [1]
Add its support in SPCR parsing routine.
[1] https://docs.microsoft.com/en-us/windows-hardware/drivers/bringup/acpi-debug-port-table
Signed-off-by Marcin Wojtas <[email protected]>--- include/acpi/actbl1.h | 1 + drivers/acpi/spcr.c | 1 + 2 files changed, 2 insertions(+)include/acpi/actbl1.h +1
-0@@ -498,6 +498,7 @@ struct acpi_dbg2_device {#define ACPI_DBG2_ARM_SBSA_GENERIC 0x000E#define ACPI_DBG2_ARM_DCC 0x000F#define ACPI_DBG2_BCM2835 0x0010 +#define ACPI_DBG2_16550_WITH_GAS 0x0012#define ACPI_DBG2_1394_STANDARD 0x0000
Quoted 13 lines
drivers/acpi/spcr.c int __init acpi_parse_spcr(bool enable_earlycon, bool enable_console)
Quoted 13 lines
drivers/acpi/spcr.c +1
-1@@ -136,6 +136,7 @@ int __init acpi_parse_spcr(bool enable_earlycon, bool enable_console)break ;case ACPI_DBG2_16550_COMPATIBLE :case ACPI_DBG2_16550_SUBSET : +case ACPI_DBG2_16550_WITH_GAS : uart ="uart" ;break ;default : --
Do you have any comments / remarks to the patch?
Best regards,
Marcin
Rafael J. Wysocki
maintainerQuoted 40 lines · Marcin Wojtas
Hi,
pon., 21 cze 2021 o 22:06 Marcin Wojtas <mw(a)semihalf.com> napisał(a):
Quoted 36 lines
Apologies for the patch prefix, of course it's a first version and unrelated to the networking subsystem.
Best regards,
Marcinpon., 21 cze 2021 o 22:05 Marcin Wojtas <mw(a)semihalf.com> napisał(a):
Quoted 27 lines
The Microsoft Debug Port Table 2 (DBG2) specification revision May 31, 2017 adds support for 16550-compatible Serial Port Subtype with parameters defined in Generic Address Structure (GAS) [1]
Add its support in SPCR parsing routine.
[1] https://docs.microsoft.com/en-us/windows-hardware/drivers/bringup/acpi-debug-port-table
Signed-off-by Marcin Wojtas <mw(a)semihalf.com>--- include/acpi/actbl1.h | 1 + drivers/acpi/spcr.c | 1 + 2 files changed, 2 insertions(+)include/acpi/actbl1.h +1
-0@@ -498,6 +498,7 @@ struct acpi_dbg2_device {#define ACPI_DBG2_ARM_SBSA_GENERIC 0x000E#define ACPI_DBG2_ARM_DCC 0x000F#define ACPI_DBG2_BCM2835 0x0010 +#define ACPI_DBG2_16550_WITH_GAS 0x0012#define ACPI_DBG2_1394_STANDARD 0x0000
Quoted 15 lines
Quoted 5 lines
Quoted 5 lines
drivers/acpi/spcr.c +0
-0@@ -136,6 +136,7 @@ int __init acpi_parse_spcr(bool enable_earlycon, bool enable_console)Quoted 8 lines
drivers/acpi/spcr.c int __init acpi_parse_spcr(bool enable_earlycon, bool enable_console)
Quoted 8 lines
drivers/acpi/spcr.c +1
-1break ;case ACPI_DBG2_16550_COMPATIBLE :case ACPI_DBG2_16550_SUBSET : +case ACPI_DBG2_16550_WITH_GAS : uart ="uart" ;break ;default : --Do you have any comments / remarks to the patch?
Yes, I do, but I will get back to you next week.
Thanks!
pt., 25 cze 2021 o 19:20 Rafael J. Wysocki <[email protected]> napisał(a):
Quoted 58 lines · Marcin Wojtas
Quoted 40 lines
Hi,
pon., 21 cze 2021 o 22:06 Marcin Wojtas <[email protected]> napisał(a):
Quoted 36 lines
Apologies for the patch prefix, of course it's a first version and unrelated to the networking subsystem.
Best regards,
Marcinpon., 21 cze 2021 o 22:05 Marcin Wojtas <[email protected]> napisał(a):
Quoted 27 lines
The Microsoft Debug Port Table 2 (DBG2) specification revision May 31, 2017 adds support for 16550-compatible Serial Port Subtype with parameters defined in Generic Address Structure (GAS) [1]
Add its support in SPCR parsing routine.
[1] https://docs.microsoft.com/en-us/windows-hardware/drivers/bringup/acpi-debug-port-table
Signed-off-by Marcin Wojtas <[email protected]>--- include/acpi/actbl1.h | 1 + drivers/acpi/spcr.c | 1 + 2 files changed, 2 insertions(+)include/acpi/actbl1.h +1
-0@@ -498,6 +498,7 @@ struct acpi_dbg2_device {#define ACPI_DBG2_ARM_SBSA_GENERIC 0x000E#define ACPI_DBG2_ARM_DCC 0x000F#define ACPI_DBG2_BCM2835 0x0010 +#define ACPI_DBG2_16550_WITH_GAS 0x0012#define ACPI_DBG2_1394_STANDARD 0x0000Quoted 15 lines
Quoted 5 lines
Quoted 5 lines
drivers/acpi/spcr.c +0
-0@@ -136,6 +136,7 @@ int __init acpi_parse_spcr(bool enable_earlycon, bool enable_console)Quoted 8 lines
drivers/acpi/spcr.c int __init acpi_parse_spcr(bool enable_earlycon, bool enable_console)
Quoted 8 lines
drivers/acpi/spcr.c +1
-1break ;case ACPI_DBG2_16550_COMPATIBLE :case ACPI_DBG2_16550_SUBSET : +case ACPI_DBG2_16550_WITH_GAS : uart ="uart" ;break ;default : --Do you have any comments / remarks to the patch?
Quoted 2 lines
Yes, I do, but I will get back to you next week.
Great, thank you!
Marcin
Rafael J. Wysocki
maintainerSorry for the delay.
include/acpi/actbl1.h
Quoted 19 lines · Marcin Wojtas
The Microsoft Debug Port Table 2 (DBG2) specification revision May 31, 2017 adds support for 16550-compatible Serial Port Subtype with parameters defined in Generic Address Structure (GAS) [1]
Add its support in SPCR parsing routine.
[1] https://docs.microsoft.com/en-us/windows-hardware/drivers/bringup/acpi-debug-port-table
Signed-off-by Marcin Wojtas <mw(a)semihalf.com>--- include/acpi/actbl1.h | 1 + drivers/acpi/spcr.c | 1 + 2 files changed, 2 insertions(+)include/acpi/actbl1.h +0
-0
This is an ACPICA header, so the first part of the patch should go in via the ACPICA upstream repository.
Can you please resend this as two patches to make it easier to process it?
Quoted 23 lines
include/acpi/actbl1.h +1
-0@@ -498,6 +498,7 @@ struct acpi_dbg2_device {#define ACPI_DBG2_ARM_SBSA_GENERIC 0x000E#define ACPI_DBG2_ARM_DCC 0x000F#define ACPI_DBG2_BCM2835 0x0010 +#define ACPI_DBG2_16550_WITH_GAS 0x0012#define ACPI_DBG2_1394_STANDARD 0x0000drivers/acpi/spcr.c +1
-1@@ -136,6 +136,7 @@ int __init acpi_parse_spcr(bool enable_earlycon, bool enable_console)break ;case ACPI_DBG2_16550_COMPATIBLE :case ACPI_DBG2_16550_SUBSET : +case ACPI_DBG2_16550_WITH_GAS : uart ="uart" ;break ;default : --2.29.0
Hi Rafael,
śr., 14 lip 2021 o 14:27 Rafael J. Wysocki <[email protected]> napisał(a):
Quoted 27 lines
Sorry for the delay.
include/acpi/actbl1.h
Quoted 19 lines · Marcin Wojtas
The Microsoft Debug Port Table 2 (DBG2) specification revision May 31, 2017 adds support for 16550-compatible Serial Port Subtype with parameters defined in Generic Address Structure (GAS) [1]
Add its support in SPCR parsing routine.
[1] https://docs.microsoft.com/en-us/windows-hardware/drivers/bringup/acpi-debug-port-table
Signed-off-by Marcin Wojtas <[email protected]>--- include/acpi/actbl1.h | 1 + drivers/acpi/spcr.c | 1 + 2 files changed, 2 insertions(+)include/acpi/actbl1.h +0
-0This is an ACPICA header, so the first part of the patch should go in via the ACPICA upstream repository.
Quoted 2 lines
Can you please resend this as two patches to make it easier to process it?
I created a pull request to the ACPICA upstream with adding all the missing DBG2 subtypes:
https://github.com/acpica/acpica/pull/705
Once that is accepted and lands, I will import the header update to Linux along with the driver modification.
Best regards,
Marcin