Skip to contentSkip to conversation

checkpatch: Do not complain about positive return values starting with EPOLL

PATCH Applied Guenter Roeck 2 participants 2 messages Jun 22, 2021 Checkpatch

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 checkpatch: Do not complain about positive return values starting with EPOLL

checkpatch complains about positive return values of poll functions. Example:

WARNING: return of an errno should typically be negative (ie: return -EPOLLIN)
+ return EPOLLIN;

Poll functions return positive values. The defines for the return values of poll functions all start with EPOLL, resulting in a number of false positives. An often used workaround is to assign poll function return values to variables and returning that variable, but that is a less than perfect solution.

There is no error definition which starts with EPOLL, so it is safe to omit the warning for return values starting with EPOLL.

Cc Ricardo Ribalda <[email protected]>

---
v2: Replaced 'rindex($name, 'EPOLL', 0) != 0' with '$name !~ /^EPOLL/'

 scripts/checkpatch.pl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
scripts/checkpatch.pl +1 -1
index 23697a6b1eaa..9ab006df01fe 100755
@@ -5458,7 +5458,7 @@ sub process {
 # Return of what appears to be an errno should normally be negative
 		if ($sline =~ /\breturn(?:\s*\(+\s*|\s+)(E[A-Z]+)(?:\s*\)+\s*|\s*)[;:,]/) {
 			my $name = $1;
-			if ($name ne 'EOF' && $name ne 'ERROR') {
+			if ($name ne 'EOF' && $name ne 'ERROR' && $name !~ /^EPOLL/) {
 				WARN("USE_NEGATIVE_ERRNO",
 				     "return of an errno should typically be negative (ie: return -$1)\n" . $herecurr);
 			}
Signature · 1 line
2.25.1
maintainer Acked-by on v2 1/1
#1 lore raw
Quoted 12 lines · Guenter Roeck

checkpatch complains about positive return values of poll functions. Example:

WARNING: return of an errno should typically be negative (ie: return -EPOLLIN)

(quoted diff) +1 -0
+		return EPOLLIN;

Poll functions return positive values. The defines for the return values of poll functions all start with EPOLL, resulting in a number of false positives. An often used workaround is to assign poll function return values to variables and returning that variable, but that is a less than perfect solution.

Quoted 7 lines

There is no error definition which starts with EPOLL, so it is safe to omit the warning for return values starting with EPOLL.

Cc Ricardo Ribalda <[email protected]>

---
v2: Replaced 'rindex($name, 'EPOLL', 0) != 0' with '$name !~ /^EPOLL/'

Quoted 17 lines

 scripts/checkpatch.pl | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)
scripts/checkpatch.pl +1 -1
index 23697a6b1eaa..9ab006df01fe 100755
@@ -5458,7 +5458,7 @@ sub process {
  # Return of what appears to be an errno should normally be negative
  		if ($sline =~ /\breturn(?:\s*\(+\s*|\s+)(E[A-Z]+)(?:\s*\)+\s*|\s*)[;:,]/) {
  			my $name = $1;
-			if ($name ne 'EOF' && $name ne 'ERROR') {
+			if ($name ne 'EOF' && $name ne 'ERROR' && $name !~ /^EPOLL/) {
  				WARN("USE_NEGATIVE_ERRNO",
  				     "return of an errno should typically be negative (ie: return -$1)\n" . $herecurr);
  			}