monitor/hmp: command register support
cover monitor/hmp: command register support
Helps making qemu more modular,
see commit messages for details.
Depends on the "modules: add meta-data database" patch series.
Gerd Hoffmann (5):
monitor: allow register hmp commands
usb: drop usb_host_dev_is_scsi_storage hook monitor/usb: register 'info usbhost' dynamically
usb: build usb-host as module
monitor/tcg: move tcg hmp commands to accel/tcg, register them
dynamically
include/hw/usb.h | 7 +++++- include/monitor/monitor.h | 3 +++ accel/tcg/hmp.c | 29 +++++++++++++++++++++++ hw/ppc/spapr.c | 2 +- hw/usb/dev-storage-bot.c | 1 + hw/usb/dev-storage-classic.c | 1 + hw/usb/dev-uas.c | 1 + hw/usb/host-libusb.c | 38 ++++++++---------------------- hw/usb/host-stub.c | 45 ------------------------------------ monitor/hmp.c | 7 ++++++ monitor/misc.c | 33 ++++++++++++-------------- accel/tcg/meson.build | 1 + hmp-commands-info.hx | 3 --- hw/usb/meson.build | 10 ++++---- 14 files changed, 80 insertions(+), 101 deletions(-) create mode 100644 accel/tcg/hmp.c delete mode 100644 hw/usb/host-stub.c
Signature · 1 line
2.31.1
PATCH 1/5 monitor: allow register hmp commands
Allow commands having a NULL cmd pointer, add a function to set the pointer later. Use case: allow modules implement hmp commands.
--- include/monitor/monitor.h | 3 +++ monitor/hmp.c | 7 +++++++ monitor/misc.c | 15 +++++++++++++++ 3 files changed, 25 insertions(+)
include/monitor/monitor.h +3 -0
@@ -51,4 +51,7 @@ int monitor_fdset_dup_fd_add(int64_t fdset_id, int flags);void monitor_fdset_dup_fd_remove (int dup_fd);int64_t monitor_fdset_dup_fd_find (int dup_fd); +void monitor_register_hmp (const char *name,bool info, +void (*cmd)(Monitor *mon,const QDict *qdict)); +#endif /* MONITOR_H */
monitor/hmp.c +7 -0
@@ -1089,6 +1089,13 @@ void handle_hmp_command(MonitorHMP *mon, const char *cmdline)return ; } +if (!cmd->cmd) { +/* FIXME: is it useful to try autoload modules here ??? */ +monitor_printf (&mon->common,"Command \"%.*s\" is not available.\n" , + (int )(cmdline - cmd_start), cmd_start); +return ; + } + qdict =monitor_parse_arguments (&mon->common, &cmdline, cmd);if (!qdict) {while (cmdline > cmd_start &&qemu_isspace (cmdline[-1 ])) {
monitor/misc.c +15 -0
@@ -1974,6 +1974,21 @@ static void sortcmdlist(void) compare_mon_cmd); } +void monitor_register_hmp (const char *name,bool info, +void (*cmd)(Monitor *mon,const QDict *qdict)) +{ +HMPCommand *table = info ? hmp_info_cmds : hmp_cmds; + +while (table->name !=NULL ) { +if (strcmp (table->name, name) ==0 ) { + table->cmd = cmd; +return ; + } + table++; + } +g_assert_not_reached (); +} +void monitor_init_globals (void ) {monitor_init_globals_core ();
Signature · 1 line
2.31.1
Re: [PATCH 1/5] monitor: allow register hmp commands
Quoted 45 lines · On Tue, 22 Jun 2021 14:49:11 +0200 Gerd Hoffmann <[email protected]> wrote:
Allow commands having a NULL cmd pointer, add a function to set the pointer later. Use case: allow modules implement hmp commands.
Signed-off-by Gerd Hoffmann <[email protected]>--- include/monitor/monitor.h | 3 +++ monitor/hmp.c | 7 +++++++ monitor/misc.c | 15 +++++++++++++++ 3 files changed, 25 insertions(+)include/monitor/monitor.h +3
-0@@ -51,4 +51,7 @@ int monitor_fdset_dup_fd_add(int64_t fdset_id, int flags);void monitor_fdset_dup_fd_remove (int dup_fd);int64_t monitor_fdset_dup_fd_find (int dup_fd); +void monitor_register_hmp (const char *name,bool info, +void (*cmd)(Monitor *mon,const QDict *qdict)); +#endif /* MONITOR_H */ monitor/hmp.c +7
-0@@ -1089,6 +1089,13 @@ void handle_hmp_command(MonitorHMP *mon, const char *cmdline)return ; } +if (!cmd->cmd) { +/* FIXME: is it useful to try autoload modules here ??? */ +monitor_printf (&mon->common,"Command \"%.*s\" is not available.\n" , + (int )(cmdline - cmd_start), cmd_start); +return ; + } + qdict =monitor_parse_arguments (&mon->common, &cmdline, cmd);if (!qdict) {while (cmdline > cmd_start &&qemu_isspace (cmdline[-1 ])) {monitor/misc.c +0
-0
monitor/misc.c static void sortcmdlist(void) · line 1983
Quoted 10 lines
monitor/misc.c +7
-0@@ -1974,6 +1974,21 @@ static void sortcmdlist(void) compare_mon_cmd); } +void monitor_register_hmp (const char *name,bool info, +void (*cmd)(Monitor *mon,const QDict *qdict)) +{ +HMPCommand *table = info ? hmp_info_cmds : hmp_cmds; + +while (table->name !=NULL ) { +if (strcmp (table->name, name) ==0 ) {
Would it make sense to register the same command multiple times ? I guess it doesn't, so you may add an assert(table->cmd == NULL) here.
Quoted 11 lines
monitor/misc.c +8
-0+ table->cmd = cmd; +return ; + } + table++; + } +g_assert_not_reached (); +} +void monitor_init_globals (void ) {monitor_init_globals_core ();
PATCH 2/5 usb: drop usb_host_dev_is_scsi_storage hook
In reply to Gerd HoffmannIntroduce an usb device flag instead, set it when usb-host looks at the device descriptors anyway. Also set it for emulated storage devices, for consistency. Add an inline helper function to check the flag.
--- include/hw/usb.h | 7 ++++++- hw/ppc/spapr.c | 2 +- hw/usb/dev-storage-bot.c | 1 + hw/usb/dev-storage-classic.c | 1 + hw/usb/dev-uas.c | 1 + hw/usb/host-libusb.c | 36 +++++++----------------------------- hw/usb/host-stub.c | 5 ----- 7 files changed, 17 insertions(+), 36 deletions(-)
include/hw/usb.h +6 -1
@@ -219,6 +219,7 @@ enum USBDeviceFlags {USB_DEV_FLAG_IS_HOST ,USB_DEV_FLAG_MSOS_DESC_ENABLE ,USB_DEV_FLAG_MSOS_DESC_IN_USE , + USB_DEV_FLAG_IS_SCSI_STORAGE, };/* definition of a USB device */
@@ -465,7 +466,6 @@ void usb_generic_async_ctrl_complete(USBDevice *s, USBPacket *p);/* usb-linux.c */ void hmp_info_usbhost (Monitor *mon,const QDict *qdict); -bool usb_host_dev_is_scsi_storage (USBDevice *usbdev);/* usb ports of the VM */
@@ -561,6 +561,11 @@ const char *usb_device_get_product_desc(USBDevice *dev);const USBDesc *usb_device_get_usb_desc (USBDevice *dev); +static inline bool usb_device_is_scsi_storage (USBDevice *dev) +{ +return dev->flags & (1 <<USB_DEV_FLAG_IS_SCSI_STORAGE ); +} +/* quirks.c */ /* In bulk endpoints are streaming data sources (iow behave like isoc eps) */
hw/ppc/spapr.c +1 -1
@@ -3106,7 +3106,7 @@ static char *spapr_get_fw_dev_path(FWPathProvider *p, BusState *bus,*/ if (strcmp ("usb-host" ,qdev_fw_name (dev)) ==0 ) {USBDevice *usbdev =CAST (USBDevice, dev,TYPE_USB_DEVICE ); -if (usb_host_dev_is_scsi_storage (usbdev)) { +if (usb_device_is_scsi_storage (usbdev)) {return g_strdup_printf ("storage@%s/disk" , usbdev->port->path); } }
hw/usb/dev-storage-bot.c +1 -0
@@ -32,6 +32,7 @@ static void usb_msd_bot_realize(USBDevice *dev, Error **errp)usb_desc_create_serial (dev);usb_desc_init (dev); + dev->flags |= (1 <<USB_DEV_FLAG_IS_SCSI_STORAGE );if (d->hotplugged) { s->dev.auto_attach =0 ; }
hw/usb/dev-storage-classic.c +1 -0
@@ -64,6 +64,7 @@ static void usb_msd_storage_realize(USBDevice *dev, Error **errp)usb_desc_create_serial (dev);usb_desc_init (dev); + dev->flags |= (1 <<USB_DEV_FLAG_IS_SCSI_STORAGE );scsi_bus_new (&s->bus,sizeof (s->bus),DEVICE (dev), &usb_msd_scsi_info_storage,NULL ); scsi_dev = scsi_bus_legacy_add_drive(&s->bus, blk, 0, !!s->removable,
hw/usb/dev-uas.c +1 -0
@@ -926,6 +926,7 @@ static void usb_uas_realize(USBDevice *dev, Error **errp)QTAILQ_INIT (&uas->requests); uas->status_bh =qemu_bh_new (usb_uas_send_status_bh, uas); + dev->flags |= (1 <<USB_DEV_FLAG_IS_SCSI_STORAGE );scsi_bus_new (&uas->bus,sizeof (uas->bus),DEVICE (dev), &usb_uas_scsi_info,NULL ); }
hw/usb/host-libusb.c +7 -29
@@ -770,6 +770,13 @@ static void usb_host_speed_compat(USBHostDevice *s)for (i =0 ; i < conf->bNumInterfaces; i++) {for (a =0 ; a < conf->interface[i].num_altsetting; a++) { intf = &conf->interface[i].altsetting[a]; + +if (intf->bInterfaceClass ==LIBUSB_CLASS_MASS_STORAGE && + intf->bInterfaceSubClass ==6 ) {/* SCSI */ + udev->flags |= (1 <<USB_DEV_FLAG_IS_SCSI_STORAGE ); +break ; + } +for (e =0 ; e < intf->bNumEndpoints; e++) { endp = &intf->endpoint[e]; type = endp->bmAttributes &0x3 ;
@@ -1893,35 +1900,6 @@ static void usb_host_auto_check(void *unused)timer_mod (usb_auto_timer,qemu_clock_get_ms (QEMU_CLOCK_REALTIME ) +2000 ); } -/** -* Check whether USB host device has a USB mass storage SCSI interface -*/ -bool usb_host_dev_is_scsi_storage (USBDevice *ud) -{ -USBHostDevice *uhd =USB_HOST_DEVICE (ud); -struct libusb_config_descriptor *conf; -const struct libusb_interface_descriptor *intf; -bool is_scsi_storage = false; -int i; - -if (!uhd ||libusb_get_active_config_descriptor (uhd->dev, &conf) !=0 ) { -return false; - } - -for (i =0 ; i < conf->bNumInterfaces; i++) { - intf = &conf->interface[i].altsetting[ud->altsetting[i]]; -if (intf->bInterfaceClass ==LIBUSB_CLASS_MASS_STORAGE && - intf->bInterfaceSubClass ==6 ) {/* 6 means SCSI */ - is_scsi_storage = true; -break ; - } - } - -libusb_free_config_descriptor (conf); - -return is_scsi_storage; -} -void hmp_info_usbhost (Monitor *mon,const QDict *qdict) {libusb_device **devs =NULL ;
hw/usb/host-stub.c +0 -5
@@ -38,8 +38,3 @@ void hmp_info_usbhost(Monitor *mon, const QDict *qdict) {monitor_printf (mon,"USB host devices not supported\n" ); } - -bool usb_host_dev_is_scsi_storage (USBDevice *ud) -{ -return false; -}
Signature · 1 line
2.31.1
Re: [PATCH 2/5] usb: drop usb_host_dev_is_scsi_storage hook
Quoted 5 lines · Gerd Hoffmann
Introduce an usb device flag instead, set it when usb-host looks at the device descriptors anyway. Also set it for emulated storage devices, for consistency. Add an inline helper function to check the flag.
Signed-off-by Gerd Hoffmann <[email protected]>
ppc parts
Quoted 158 lines
--- include/hw/usb.h | 7 ++++++- hw/ppc/spapr.c | 2 +- hw/usb/dev-storage-bot.c | 1 + hw/usb/dev-storage-classic.c | 1 + hw/usb/dev-uas.c | 1 + hw/usb/host-libusb.c | 36 +++++++----------------------------- hw/usb/host-stub.c | 5 ----- 7 files changed, 17 insertions(+), 36 deletions(-)include/hw/usb.h +6
-1@@ -219,6 +219,7 @@ enum USBDeviceFlags {USB_DEV_FLAG_IS_HOST ,USB_DEV_FLAG_MSOS_DESC_ENABLE ,USB_DEV_FLAG_MSOS_DESC_IN_USE , + USB_DEV_FLAG_IS_SCSI_STORAGE, };/* definition of a USB device */ @@ -465,7 +466,6 @@ void usb_generic_async_ctrl_complete(USBDevice *s, USBPacket *p);/* usb-linux.c */ void hmp_info_usbhost (Monitor *mon,const QDict *qdict); -bool usb_host_dev_is_scsi_storage (USBDevice *usbdev);/* usb ports of the VM */ @@ -561,6 +561,11 @@ const char *usb_device_get_product_desc(USBDevice *dev);const USBDesc *usb_device_get_usb_desc (USBDevice *dev); +static inline bool usb_device_is_scsi_storage (USBDevice *dev) +{ +return dev->flags & (1 <<USB_DEV_FLAG_IS_SCSI_STORAGE ); +} +/* quirks.c */ /* In bulk endpoints are streaming data sources (iow behave like isoc eps) */ hw/ppc/spapr.c +1
-1@@ -3106,7 +3106,7 @@ static char *spapr_get_fw_dev_path(FWPathProvider *p, BusState *bus,*/ if (strcmp ("usb-host" ,qdev_fw_name (dev)) ==0 ) {USBDevice *usbdev =CAST (USBDevice, dev,TYPE_USB_DEVICE ); -if (usb_host_dev_is_scsi_storage (usbdev)) { +if (usb_device_is_scsi_storage (usbdev)) {return g_strdup_printf ("storage@%s/disk" , usbdev->port->path); } }hw/usb/dev-storage-bot.c +1
-0@@ -32,6 +32,7 @@ static void usb_msd_bot_realize(USBDevice *dev, Error **errp)usb_desc_create_serial (dev);usb_desc_init (dev); + dev->flags |= (1 <<USB_DEV_FLAG_IS_SCSI_STORAGE );if (d->hotplugged) { s->dev.auto_attach =0 ; }hw/usb/dev-storage-classic.c +1
-0@@ -64,6 +64,7 @@ static void usb_msd_storage_realize(USBDevice *dev, Error **errp)usb_desc_create_serial (dev);usb_desc_init (dev); + dev->flags |= (1 <<USB_DEV_FLAG_IS_SCSI_STORAGE );scsi_bus_new (&s->bus,sizeof (s->bus),DEVICE (dev), &usb_msd_scsi_info_storage,NULL ); scsi_dev = scsi_bus_legacy_add_drive(&s->bus, blk, 0, !!s->removable,hw/usb/dev-uas.c +1
-0@@ -926,6 +926,7 @@ static void usb_uas_realize(USBDevice *dev, Error **errp)QTAILQ_INIT (&uas->requests); uas->status_bh =qemu_bh_new (usb_uas_send_status_bh, uas); + dev->flags |= (1 <<USB_DEV_FLAG_IS_SCSI_STORAGE );scsi_bus_new (&uas->bus,sizeof (uas->bus),DEVICE (dev), &usb_uas_scsi_info,NULL ); }hw/usb/host-libusb.c +7
-29@@ -770,6 +770,13 @@ static void usb_host_speed_compat(USBHostDevice *s)for (i =0 ; i < conf->bNumInterfaces; i++) {for (a =0 ; a < conf->interface[i].num_altsetting; a++) { intf = &conf->interface[i].altsetting[a]; + +if (intf->bInterfaceClass ==LIBUSB_CLASS_MASS_STORAGE && + intf->bInterfaceSubClass ==6 ) {/* SCSI */ + udev->flags |= (1 <<USB_DEV_FLAG_IS_SCSI_STORAGE ); +break ; + } +for (e =0 ; e < intf->bNumEndpoints; e++) { endp = &intf->endpoint[e]; type = endp->bmAttributes &0x3 ;@@ -1893,35 +1900,6 @@ static void usb_host_auto_check(void *unused)timer_mod (usb_auto_timer,qemu_clock_get_ms (QEMU_CLOCK_REALTIME ) +2000 ); } -/** -* Check whether USB host device has a USB mass storage SCSI interface -*/ -bool usb_host_dev_is_scsi_storage (USBDevice *ud) -{ -USBHostDevice *uhd =USB_HOST_DEVICE (ud); -struct libusb_config_descriptor *conf; -const struct libusb_interface_descriptor *intf; -bool is_scsi_storage = false; -int i; - -if (!uhd ||libusb_get_active_config_descriptor (uhd->dev, &conf) !=0 ) { -return false; - } - -for (i =0 ; i < conf->bNumInterfaces; i++) { - intf = &conf->interface[i].altsetting[ud->altsetting[i]]; -if (intf->bInterfaceClass ==LIBUSB_CLASS_MASS_STORAGE && - intf->bInterfaceSubClass ==6 ) {/* 6 means SCSI */ - is_scsi_storage = true; -break ; - } - } - -libusb_free_config_descriptor (conf); - -return is_scsi_storage; -} -void hmp_info_usbhost (Monitor *mon,const QDict *qdict) {libusb_device **devs =NULL ;hw/usb/host-stub.c +0
-5@@ -38,8 +38,3 @@ void hmp_info_usbhost(Monitor *mon, const QDict *qdict) {monitor_printf (mon,"USB host devices not supported\n" ); } - -bool usb_host_dev_is_scsi_storage (USBDevice *ud) -{ -return false; -}
Signature · 4 lines
David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson
PATCH 3/5 monitor/usb: register 'info usbhost' dynamically
In reply to Gerd Hoffmann--- hw/usb/host-libusb.c | 1 + hw/usb/host-stub.c | 40 ---------------------------------------- hmp-commands-info.hx | 1 - hw/usb/meson.build | 4 +--- 4 files changed, 2 insertions(+), 44 deletions(-) delete mode 100644 hw/usb/host-stub.c
hw/usb/host-libusb.c +1 -0
@@ -1781,6 +1781,7 @@ static TypeInfo usb_host_dev_info = {static void usb_host_register_types (void ) {type_register_static (&usb_host_dev_info); +monitor_register_hmp ("usbhost" , true, hmp_info_usbhost); }type_init (usb_host_register_types)
hw/usb/host-stub.c deleted +0 -40
@@ -1,40 +0,0 @@ -/* -* Stub host USB redirector -* -* Copyright (c) 2005 Fabrice Bellard -* -* Copyright (c) 2008 Max Krasnyansky -* Support for host device auto connect & disconnect -* Major rewrite to support fully async operation -* -* Copyright 2008 TJ <[email protected]> -* Added flexible support for /dev/bus/usb /sys/bus/usb/devices in addition -* to the legacy /proc/bus/usb USB device discovery and handling -* -* Permission is hereby granted, free of charge, to any person obtaining a copy -* of this software and associated documentation files (the "Software"), to deal -* in the Software without restriction, including without limitation the rights -* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell -* copies of the Software, and to permit persons to whom the Software is -* furnished to do so, subject to the following conditions: -* -* The above copyright notice and this permission notice shall be included in -* all copies or substantial portions of the Software. -* -* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR -* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, -* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL -* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER -* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, -* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN -* THE SOFTWARE. -*/ - -#include "qemu/osdep.h" -#include "hw/usb.h" -#include "monitor/monitor.h" - -void hmp_info_usbhost (Monitor *mon,const QDict *qdict) -{ -monitor_printf (mon,"USB host devices not supported\n" ); -}
hmp-commands-info.hx +0 -1
@@ -368,7 +368,6 @@ ERST .args_type = "", .params = "", .help = "show host USB devices", - .cmd = hmp_info_usbhost, }, SRST
hw/usb/meson.build +1 -3
@@ -73,9 +73,7 @@ endif # usb pass-through softmmu_ss.add(when: ['CONFIG_USB', 'CONFIG_USB_LIBUSB', libusb], - if_true: files('host-libusb.c'), - if_false: files('host-stub.c')) -softmmu_ss.add(when: 'CONFIG_ALL', if_true: files('host-stub.c')) + if_true: files('host-libusb.c')) softmmu_ss.add(when: ['CONFIG_USB', 'CONFIG_XEN', libusb], if_true: files('xen-usb.c'))
Signature · 1 line
2.31.1
PATCH 4/5 usb: build usb-host as module
In reply to Gerd HoffmannDrop one more shared library dependency (libusb) from core qemu.
--- hw/usb/host-libusb.c | 1 + hw/usb/meson.build | 8 ++++++-- 2 files changed, 7 insertions(+), 2 deletions(-)
hw/usb/host-libusb.c +1 -0
@@ -1777,6 +1777,7 @@ static TypeInfo usb_host_dev_info = { .class_init = usb_host_class_initfn, .instance_init = usb_host_instance_init, }; +module_obj (TYPE_USB_HOST_DEVICE );static void usb_host_register_types (void ) {
hw/usb/meson.build +6 -2
@@ -72,8 +72,12 @@ if config_host.has_key('CONFIG_USB_REDIR') endif # usb pass-through -softmmu_ss.add(when: ['CONFIG_USB', 'CONFIG_USB_LIBUSB', libusb], - if_true: files('host-libusb.c')) +if config_host.has_key('CONFIG_USB_LIBUSB') + usbhost_ss = ss.source_set() + usbhost_ss.add(when: ['CONFIG_USB', libusb], + if_true: files('host-libusb.c')) + hw_usb_modules += {'host': usbhost_ss} +endif softmmu_ss.add(when: ['CONFIG_USB', 'CONFIG_XEN', libusb], if_true: files('xen-usb.c'))
Signature · 1 line
2.31.1
PATCH 5/5 monitor/tcg: move tcg hmp commands to accel/tcg, register them dynamically
In reply to Gerd HoffmannOne more little step towards modular tcg ...
--- accel/tcg/hmp.c | 29 +++++++++++++++++++++++++++++ monitor/misc.c | 18 ------------------ accel/tcg/meson.build | 1 + hmp-commands-info.hx | 2 -- 4 files changed, 30 insertions(+), 20 deletions(-) create mode 100644 accel/tcg/hmp.c
accel/tcg/hmp.c new file +29 -0
@@ -0,0 +1,29 @@ +#include "qemu/osdep.h" +#include "qemu/error-report.h" +#include "exec/exec-all.h" +#include "monitor/monitor.h" +#include "sysemu/tcg.h" + +static void hmp_info_jit (Monitor *mon,const QDict *qdict) +{ +if (!tcg_enabled ()) { +error_report ("JIT information is only available with accel=tcg" ); +return ; + } + +dump_exec_info (); +dump_drift_info (); +} + +static void hmp_info_opcount (Monitor *mon,const QDict *qdict) +{ +dump_opcount_info (); +} + +static void hmp_tcg_register (void ) +{ +monitor_register_hmp ("jit" , true, hmp_info_jit); +monitor_register_hmp ("opcount" , true, hmp_info_opcount); +} + +type_init (hmp_tcg_register);
monitor/misc.c +0 -18
@@ -320,24 +320,6 @@ static void hmp_info_registers(Monitor *mon, const QDict *qdict) } } -#ifdef CONFIG_TCG -static void hmp_info_jit (Monitor *mon,const QDict *qdict) -{ -if (!tcg_enabled ()) { -error_report ("JIT information is only available with accel=tcg" ); -return ; - } - -dump_exec_info (); -dump_drift_info (); -} - -static void hmp_info_opcount (Monitor *mon,const QDict *qdict) -{ -dump_opcount_info (); -} -#endif -static void hmp_info_sync_profile (Monitor *mon,const QDict *qdict) {int64_t max =qdict_get_try_int (qdict,"max" ,10 );
accel/tcg/meson.build +1 -0
@@ -15,6 +15,7 @@ specific_ss.add_all(when: 'CONFIG_TCG', if_true: tcg_ss) specific_ss.add(when: ['CONFIG_SOFTMMU', 'CONFIG_TCG'], if_true: files( 'cputlb.c', + 'hmp.c', )) tcg_module_ss.add(when: ['CONFIG_SOFTMMU', 'CONFIG_TCG'], if_true: files(
hmp-commands-info.hx +0 -2
@@ -274,7 +274,6 @@ ERST .args_type = "", .params = "", .help = "show dynamic compiler info", - .cmd = hmp_info_jit, }, #endif
@@ -289,7 +288,6 @@ ERST .args_type = "", .params = "", .help = "show dynamic compiler opcode counters", - .cmd = hmp_info_opcount, }, #endif
Signature · 1 line
2.31.1
Quoted 4 lines · Gerd Hoffmann
Helps making qemu more modular,
see commit messages for details.Depends on the "modules: add meta-data database" patch series.
This series is about HMP. Do we have equivalent functionality for QMP already?
I apologize for not looking at this sooner.
Quoted 9 lines · Markus Armbruster
Quoted 4 lines · Gerd Hoffmann
Helps making qemu more modular,
see commit messages for details.Depends on the "modules: add meta-data database" patch series.
This series is about HMP. Do we have equivalent functionality for QMP already?
Didn't check as the commands I've needed it this for are hmp-only. But, yes, when going forward with building more code modular we might need this for qmp too at some point ...
take care,
Gerd