Skip to contentSkip to conversation

cpuidle: moved EXPORT_SYMBOL so that it immediately followed its function/variable

PATCH In review Jinchao Wang 2 participants 2 messages Jun 23, 2021 – Jun 30, 2021 CPU idle time management framework

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 cpuidle: moved EXPORT_SYMBOL so that it immediately followed its function/variable

change made to resolve following checkpatch message:
WARNING: EXPORT_SYMBOL(foo); should immediately follow its
function/variable

---
 drivers/cpuidle/cpuidle.c | 6 ------
 1 file changed, 6 deletions(-)
drivers/cpuidle/cpuidle.c +0 -6
index ef2ea1b12cd8..ddd11236a0cc 100644
@@ -457,7 +457,6 @@ void cpuidle_pause_and_lock(void)
 	mutex_lock(&cpuidle_lock);
 	cpuidle_uninstall_idle_handler();
 }
-
 EXPORT_SYMBOL_GPL(cpuidle_pause_and_lock);
 
 /**
@@ -468,7 +467,6 @@ void cpuidle_resume_and_unlock(void)
 	cpuidle_install_idle_handler();
 	mutex_unlock(&cpuidle_lock);
 }
-
 EXPORT_SYMBOL_GPL(cpuidle_resume_and_unlock);
 
 /* Currently used in suspend/resume path to suspend cpuidle */
@@ -538,7 +536,6 @@ int cpuidle_enable_device(struct cpuidle_device *dev)
 
 	return ret;
 }
-
 EXPORT_SYMBOL_GPL(cpuidle_enable_device);
 
 /**
@@ -566,7 +563,6 @@ void cpuidle_disable_device(struct cpuidle_device *dev)
 	cpuidle_remove_device_sysfs(dev);
 	enabled_devices--;
 }
-
 EXPORT_SYMBOL_GPL(cpuidle_disable_device);
 
 static void __cpuidle_unregister_device(struct cpuidle_device *dev)
@@ -665,7 +661,6 @@ int cpuidle_register_device(struct cpuidle_device *dev)
 	__cpuidle_unregister_device(dev);
 	goto out_unlock;
 }
-
 EXPORT_SYMBOL_GPL(cpuidle_register_device);
 
 /**
@@ -689,7 +684,6 @@ void cpuidle_unregister_device(struct cpuidle_device *dev)
 
 	cpuidle_resume_and_unlock();
 }
-
 EXPORT_SYMBOL_GPL(cpuidle_unregister_device);
 
 /**
Signature · 1 line
2.31.1
#1 lore raw
Quoted 4 lines · Jinchao Wang

change made to resolve following checkpatch message:
WARNING: EXPORT_SYMBOL(foo); should immediately follow its
function/variable

checkpatch errors regarding the existing code base are not relevant as a rule.

Now, this patch removes unnecessary empty lines, so it is not meritless, but it should go under a different subject and with a changelog describing what's going on.

Something like

Subject: [PATCH] cpuidle: Remove unnecessary empty lines preceding EXPORT_SYMBOL_GPL()

In several places in cpuidle.c there are empty lines between the definition of a function and the following EXPORT_SYMBOL_GPL() which are not necessary, so remove them.

Quoted 62 lines
---
 drivers/cpuidle/cpuidle.c | 6 ------
 1 file changed, 6 deletions(-)
drivers/cpuidle/cpuidle.c +0 -7
index ef2ea1b12cd8..ddd11236a0cc 100644
@@ -457,7 +457,6 @@ void cpuidle_pause_and_lock(void)
        mutex_lock(&cpuidle_lock);
        cpuidle_uninstall_idle_handler();
 }
-
 EXPORT_SYMBOL_GPL(cpuidle_pause_and_lock);
 
 /**
@@ -468,7 +467,6 @@ void cpuidle_resume_and_unlock(void)
        cpuidle_install_idle_handler();
        mutex_unlock(&cpuidle_lock);
 }
-
 EXPORT_SYMBOL_GPL(cpuidle_resume_and_unlock);
 
 /* Currently used in suspend/resume path to suspend cpuidle */
@@ -538,7 +536,6 @@ int cpuidle_enable_device(struct cpuidle_device *dev)
 
        return ret;
 }
-
 EXPORT_SYMBOL_GPL(cpuidle_enable_device);
 
 /**
@@ -566,7 +563,6 @@ void cpuidle_disable_device(struct cpuidle_device *dev)
        cpuidle_remove_device_sysfs(dev);
        enabled_devices--;
 }
-
 EXPORT_SYMBOL_GPL(cpuidle_disable_device);
 
 static void __cpuidle_unregister_device(struct cpuidle_device *dev)
@@ -665,7 +661,6 @@ int cpuidle_register_device(struct cpuidle_device *dev)
        __cpuidle_unregister_device(dev);
        goto out_unlock;
 }
-
 EXPORT_SYMBOL_GPL(cpuidle_register_device);
 
 /**
@@ -689,7 +684,6 @@ void cpuidle_unregister_device(struct cpuidle_device *dev)
 
        cpuidle_resume_and_unlock();
 }
-
 EXPORT_SYMBOL_GPL(cpuidle_unregister_device);
 
 /**
--

2.31.1